From nobody Fri May 3 00:09:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559661293; cv=none; d=zoho.com; s=zohoarc; b=iN0HUzWsxD++8SE2DCPyAOuaWnliqt7C5hH2Hg4eaTvcR6QZooW04nY3OowzFkHQW2Yg2rQU9/9FS4PvnHuDXqpTwpHDhrHlmihzedmBOnxkmQUn8jYHIXP1C2YAQPUckebkMj5wZMPeDKybAVppehEgSCSy9d5hqt6Pcu7RJAo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559661293; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=GEjvQ8u4i2fJkzKqecXSb1CzHMz/WTpmPztYWbk58KA=; b=bH3fTcX69nfHorqMESN0lAdAIak8lXw/fCZ50cmiA0ostXK15v1GNN9ItCkY+X40EkemKUzAFcR4rIxKXDO6SXxB2bBatdedrkEZ3J61+XFm+vWdyXMPCJLv2389dyamaZsQYWY+x6D0fPrPwLoH+GIvmV79mhZjTKW9XgkEhsQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559661293219728.2232163008284; Tue, 4 Jun 2019 08:14:53 -0700 (PDT) Received: from localhost ([127.0.0.1]:53861 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYB9A-0000VO-6I for importer@patchew.org; Tue, 04 Jun 2019 11:14:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYB7W-00082Q-7s for qemu-devel@nongnu.org; Tue, 04 Jun 2019 11:13:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYB7V-0007Ap-2T for qemu-devel@nongnu.org; Tue, 04 Jun 2019 11:13:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57658) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYB7U-0007AF-TJ for qemu-devel@nongnu.org; Tue, 04 Jun 2019 11:13:01 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3DAC3C18B2E1 for ; Tue, 4 Jun 2019 15:12:55 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-148.ams2.redhat.com [10.36.116.148]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F7405B683; Tue, 4 Jun 2019 15:12:53 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id CF38D11386A3; Tue, 4 Jun 2019 17:12:51 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Tue, 4 Jun 2019 17:12:50 +0200 Message-Id: <20190604151251.9903-2-armbru@redhat.com> In-Reply-To: <20190604151251.9903-1-armbru@redhat.com> References: <20190604151251.9903-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 04 Jun 2019 15:12:55 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 1/2] vl: Fix -drive / -blockdev persistent reservation management X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, mprivozn@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" qemu-system-FOO's main() acts on command line arguments in its own idiosyncratic order. There's not much method to its madness. Whenever we find a case where one kind of command line argument needs to refer to something created for another kind later, we rejigger the order. Recent commit cda4aa9a5a "vl: Create block backends before setting machine properties" was such a rejigger. Block backends are now created before "delayed" objects. This broke persistent reservation management. Reproducer: $ qemu-system-x86_64 -object pr-manager-helper,id=3Dpr-helper0,path=3D/= tmp/pr-helper0.sock-drive -drive file=3D/dev/mapper/crypt,file.pr-manager= =3Dpr-helper0,format=3Draw,if=3Dnone,id=3Ddrive-scsi0-0-0-2 qemu-system-x86_64: -drive file=3D/dev/mapper/crypt,file.pr-manager=3Dp= r-helper0,format=3Draw,if=3Dnone,id=3Ddrive-scsi0-0-0-2: No persistent rese= rvation manager with id 'pr-helper0' The delayed pr-manager-helper object is created too late for use by -drive or -blockdev. Normal objects are still created in time. pr-manager-helper has always been a delayed object (commit 7c9e527659 "scsi, file-posix: add support for persistent reservation management"). Turns out there's no real reason for that. Make it a normal object. Fixes: cda4aa9a5a08777cf13e164c0543bd4888b8adce Signed-off-by: Markus Armbruster Reviewed-by: Michal Privoznik --- vl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/vl.c b/vl.c index f023a8ca73..cc6246d2af 100644 --- a/vl.c +++ b/vl.c @@ -2751,8 +2751,7 @@ static bool object_create_initial(const char *type, Q= emuOpts *opts) exit(0); } =20 - if (g_str_equal(type, "rng-egd") || - g_str_has_prefix(type, "pr-manager-")) { + if (g_str_equal(type, "rng-egd")) { return false; } =20 --=20 2.21.0 From nobody Fri May 3 00:09:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559661318; cv=none; d=zoho.com; s=zohoarc; b=BL8/yj77LbfQme6ZtjJJe498qprLC7tIVNEqSu4r9k4nebL2omQADDLdMEXyHUsUPYmHEIuEJn+fvtqMz0v0/5v3toqTfO5d4Xr/0OxNnJ+P5YM93sAlQiNOcegZIuh40vXlRSzZ1XKNem84wurQdet1OJ+hbeHenccQ6AXy3O0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559661318; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=3f4k+wUshpmxrqb3B6OAAVH1kaLj5leTXjgeRlQgww4=; b=dN6XFvIPkIjvA+oTyds2WSwfDsnC4noBF+o62ZzpNqxdsRg+f/O6Uh+s85qirmGu48XOtGwWyjC1KQBFNnwIndeBYEFPUWLwsxEWrPXjxDdwadVZx0ohUv1A7D69sJ2FMEanaRiKe+mqQyxttLXkscmSDDWOK/WWTmLWbd4WIgY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559661318542730.344576323097; Tue, 4 Jun 2019 08:15:18 -0700 (PDT) Received: from localhost ([127.0.0.1]:53857 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYB95-0000R8-9S for importer@patchew.org; Tue, 04 Jun 2019 11:14:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYB7V-00082L-IM for qemu-devel@nongnu.org; Tue, 04 Jun 2019 11:13:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYB7U-0007AX-NK for qemu-devel@nongnu.org; Tue, 04 Jun 2019 11:13:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59968) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYB7U-00079e-Fw for qemu-devel@nongnu.org; Tue, 04 Jun 2019 11:13:00 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 915A383F3F for ; Tue, 4 Jun 2019 15:12:54 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-148.ams2.redhat.com [10.36.116.148]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F65260BCC; Tue, 4 Jun 2019 15:12:53 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D262411386A6; Tue, 4 Jun 2019 17:12:51 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Tue, 4 Jun 2019 17:12:51 +0200 Message-Id: <20190604151251.9903-3-armbru@redhat.com> In-Reply-To: <20190604151251.9903-1-armbru@redhat.com> References: <20190604151251.9903-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 04 Jun 2019 15:12:54 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/2] vl: Document why objects are delayed X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, mprivozn@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Objects should not be "delayed" without a reason, as the previous commit demonstrates. The remaining ones have reasons. State them. and demand future ones come with such a statement. Signed-off-by: Markus Armbruster Reviewed-by: Michal Privoznik --- vl.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index cc6246d2af..cd1fbc4cdc 100644 --- a/vl.c +++ b/vl.c @@ -2751,19 +2751,25 @@ static bool object_create_initial(const char *type,= QemuOpts *opts) exit(0); } =20 + /* + * Objects should not be made "delayed" without a reason. If you + * add one, state the reason in a comment! + */ + + /* Reason: rng-egd property "chardev" */ if (g_str_equal(type, "rng-egd")) { return false; } =20 #if defined(CONFIG_VHOST_USER) && defined(CONFIG_LINUX) + /* Reason: cryptodev-vhost-user property "chardev" */ if (g_str_equal(type, "cryptodev-vhost-user")) { return false; } #endif =20 /* - * return false for concrete netfilters since - * they depend on netdevs already existing + * Reason: filter-* property "netdev" etc. */ if (g_str_equal(type, "filter-buffer") || g_str_equal(type, "filter-dump") || --=20 2.21.0