From nobody Tue Feb 10 23:54:33 2026 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1559474086; cv=none; d=zoho.com; s=zohoarc; b=GT6Vva4yBZVj1r0Ww/t2KI3lYIRFQHrz3jxzuHQDVJZYBWj+g1EfpB7NXJZY7BS/Ixfag9rl03B5KbW29oUZkhNMK0ZUbMgvbNa0QGTnHqIwEk0O8pM8g6k4mBrUY5QzPPy+ZYl8LbYImsgYiZNMzj78+wKic8nD9t46Aygxuf0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559474086; h=Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=BoD3dMI2k2Q0BiohK5P96LJFCEs9QM5yND88g0BySQY=; b=LkB9bzofiUfRDGEljfRPmStcckb3FT1HBZmOX+TW/i8oaLnrXb4eUghewxP3yQFmUsbphiJkh9CpF8PjKlL5P6oEUoMDRdSlg1xm2QFffyAnCj/jn1p/DBvj4JKw9A8A+BOPNIkFJ0Wzx9w7ZLLIIquFRDxq4UfF3wRgFcQHUeU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 155947408667981.22614633102023; Sun, 2 Jun 2019 04:14:46 -0700 (PDT) Received: from localhost ([127.0.0.1]:47675 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXORb-0004UM-Is for importer@patchew.org; Sun, 02 Jun 2019 07:14:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXOPc-0003LN-VE for qemu-devel@nongnu.org; Sun, 02 Jun 2019 07:12:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hXOPb-0003X4-SA for qemu-devel@nongnu.org; Sun, 02 Jun 2019 07:12:28 -0400 Received: from mail.ilande.co.uk ([46.43.2.167]:51382 helo=mail.default.ilande.uk0.bigv.io) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hXOPb-0002iF-M9; Sun, 02 Jun 2019 07:12:27 -0400 Received: from host81-158-188-206.range81-158.btcentralplus.com ([81.158.188.206] helo=kentang.home) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1hXOLb-0008A4-2A; Sun, 02 Jun 2019 12:08:20 +0100 From: Mark Cave-Ayland To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, rth@twiddle.net, gkurz@kaod.org Date: Sun, 2 Jun 2019 12:08:50 +0100 Message-Id: <20190602110903.3431-3-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190602110903.3431-1-mark.cave-ayland@ilande.co.uk> References: <20190602110903.3431-1-mark.cave-ayland@ilande.co.uk> X-SA-Exim-Connect-IP: 81.158.188.206 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 46.43.2.167 Subject: [Qemu-devel] [PATCH v2 02/15] target/ppc: remove getVSR()/putVSR() from mem_helper.c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Since commit 8a14d31b00 "target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order" functions getVSR() and putVSR() which u= sed to convert the VSR registers into host endian order are no longer required. Signed-off-by: Mark Cave-Ayland --- target/ppc/mem_helper.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c index 5b0f9ee50d..17a3c931a9 100644 --- a/target/ppc/mem_helper.c +++ b/target/ppc/mem_helper.c @@ -417,26 +417,27 @@ STVE(stvewx, cpu_stl_data_ra, bswap32, u32) void helper_##name(CPUPPCState *env, target_ulong addr, \ target_ulong xt_num, target_ulong rb) \ { \ - int i; \ - ppc_vsr_t xt; \ + ppc_vsr_t *xt =3D &env->vsr[xt_num]; \ + ppc_vsr_t t; \ uint64_t nb =3D GET_NB(rb); \ + int i; \ \ - xt.s128 =3D int128_zero(); \ + t.s128 =3D int128_zero(); \ if (nb) { \ nb =3D (nb >=3D 16) ? 16 : nb; = \ if (msr_le && !lj) { \ for (i =3D 16; i > 16 - nb; i--) { \ - xt.VsrB(i - 1) =3D cpu_ldub_data_ra(env, addr, GETPC()); \ + t.VsrB(i - 1) =3D cpu_ldub_data_ra(env, addr, GETPC()); \ addr =3D addr_add(env, addr, 1); \ } \ } else { \ for (i =3D 0; i < nb; i++) { \ - xt.VsrB(i) =3D cpu_ldub_data_ra(env, addr, GETPC()); \ + t.VsrB(i) =3D cpu_ldub_data_ra(env, addr, GETPC()); \ addr =3D addr_add(env, addr, 1); \ } \ } \ } \ - putVSR(xt_num, &xt, env); \ + *xt =3D t; \ } =20 VSX_LXVL(lxvl, 0) @@ -447,26 +448,28 @@ VSX_LXVL(lxvll, 1) void helper_##name(CPUPPCState *env, target_ulong addr, \ target_ulong xt_num, target_ulong rb) \ { \ - int i; \ - ppc_vsr_t xt; \ + ppc_vsr_t *xt =3D &env->vsr[xt_num]; \ + ppc_vsr_t t =3D *xt; \ target_ulong nb =3D GET_NB(rb); \ + int i; \ \ if (!nb) { \ return; \ } \ - getVSR(xt_num, &xt, env); \ + \ nb =3D (nb >=3D 16) ? 16 : nb; \ if (msr_le && !lj) { \ for (i =3D 16; i > 16 - nb; i--) { \ - cpu_stb_data_ra(env, addr, xt.VsrB(i - 1), GETPC()); \ + cpu_stb_data_ra(env, addr, t.VsrB(i - 1), GETPC()); \ addr =3D addr_add(env, addr, 1); \ } \ } else { \ for (i =3D 0; i < nb; i++) { \ - cpu_stb_data_ra(env, addr, xt.VsrB(i), GETPC()); \ + cpu_stb_data_ra(env, addr, t.VsrB(i), GETPC()) ; \ addr =3D addr_add(env, addr, 1); \ } \ } \ + *xt =3D t; \ } =20 VSX_STXVL(stxvl, 0) --=20 2.11.0