From nobody Sun May 5 02:44:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1559194867; cv=none; d=zoho.com; s=zohoarc; b=kTMJmSPMP/KiPud26rJuOfXbneqbldncVPaMUA193S6GIZfbj1wYE8hSY8kdwg5uNV4S3IVXTcpaOBscMu0+Lnm4Zqs9+IrJKyWL19tUP2oWFw50jAu7VpoWaYimrS+D3gwEC1eLY5QtxhjsYVDvQDWZ/ElEt4WZMeW/IwLDi00= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559194867; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=9MhK9PMGNzpiIGmS0061w5PWYr8o0fQ8u4Yhgqu8rXo=; b=XzsA3D/G7SpbmWmspG/abZerEeEI6EYisn/a8PCWnGs8v19eROAozeXAAkrKNSvTd1j9Ww2uonOVyCcAGLmmAjM5IK1IMgC6OMlk2YxpZNAah6DrDme195Tv5kVsktuXf7kEgZsfHJZ8RPGr6an6p6nMBxYz86wS9m3+ActRomE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 155919486581940.98390304737757; Wed, 29 May 2019 22:41:05 -0700 (PDT) Received: from localhost ([127.0.0.1]:52076 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWDo7-0007lm-19 for importer@patchew.org; Thu, 30 May 2019 01:40:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWDm0-0006Xu-TB for qemu-devel@nongnu.org; Thu, 30 May 2019 01:38:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWDlz-00048u-Db for qemu-devel@nongnu.org; Thu, 30 May 2019 01:38:44 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:50469) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWDly-00045I-Nd; Thu, 30 May 2019 01:38:43 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45DxFk6Y8gz9s00; Thu, 30 May 2019 15:38:34 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1559194714; bh=w/YEBfbeW/wU9g+yVcIls2ll9TuKhF9juZrK/MSyc1k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l0fvJd+r98167XZaygMvF5ctUsfrwVp3mKerReBuopZW8Pe4ushX9xPPZ9PZ/8C3q 2FcxqHbaZjF03odRISSrgBNUFJtPfMT6pnO+Wt+VAvp0FKhfaRvnweMJqu2yy563d1 woIDhOzHo45el3olc4fjEPCAR1E+bDtLBD02xYsY= From: David Gibson To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Date: Thu, 30 May 2019 15:38:24 +1000 Message-Id: <20190530053831.22115-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530053831.22115-1-david@gibson.dropbear.id.au> References: <20190530053831.22115-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PATCH v2 1/8] spapr: Clean up device node name generation for PCI devices X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.ibm.com, mst@redhat.com, groug@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" spapr_populate_pci_child_dt() adds a 'name' property to the device tree node for PCI devices. This is never necessary for a flattened device tree, it is implicit in the name added when the node is constructed. In fact anything we do add to a 'name' property will be overwritten with something derived from the structural name in the guest firmware (but in fact it is exactly the same bytes). So, remove that. In addition, pci_get_node_name() is very simple, so fold it into its (also simple) sole caller spapr_create_pci_child_dt(). While we're there rename pci_find_device_name() to the shorter and more accurate dt_name_from_class(). Signed-off-by: David Gibson Reviewed-by: Greg Kurz Acked-by: Michael S. Tsirkin --- hw/ppc/spapr_pci.c | 41 ++++++++++++++++------------------------- 1 file changed, 16 insertions(+), 25 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 97961b0128..3f86cf8620 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -1173,8 +1173,8 @@ static const PCIClass pci_classes[] =3D { { "data-processing-controller", spc_subclass }, }; =20 -static const char *pci_find_device_name(uint8_t class, uint8_t subclass, - uint8_t iface) +static const char *dt_name_from_class(uint8_t class, uint8_t subclass, + uint8_t iface) { const PCIClass *pclass; const PCISubClass *psubclass; @@ -1216,23 +1216,6 @@ static const char *pci_find_device_name(uint8_t clas= s, uint8_t subclass, return name; } =20 -static gchar *pci_get_node_name(PCIDevice *dev) -{ - int slot =3D PCI_SLOT(dev->devfn); - int func =3D PCI_FUNC(dev->devfn); - uint32_t ccode =3D pci_default_read_config(dev, PCI_CLASS_PROG, 3); - const char *name; - - name =3D pci_find_device_name((ccode >> 16) & 0xff, (ccode >> 8) & 0xf= f, - ccode & 0xff); - - if (func !=3D 0) { - return g_strdup_printf("%s@%x,%x", name, slot, func); - } else { - return g_strdup_printf("%s@%x", name, slot); - } -} - static uint32_t spapr_phb_get_pci_drc_index(SpaprPhbState *phb, PCIDevice *pdev); =20 @@ -1300,11 +1283,6 @@ static void spapr_populate_pci_child_dt(PCIDevice *d= ev, void *fdt, int offset, _FDT(fdt_setprop(fdt, offset, "udf-supported", NULL, 0)); } =20 - _FDT(fdt_setprop_string(fdt, offset, "name", - pci_find_device_name((ccode >> 16) & 0xff, - (ccode >> 8) & 0xff, - ccode & 0xff))); - buf =3D spapr_phb_get_loc_code(sphb, dev); _FDT(fdt_setprop_string(fdt, offset, "ibm,loc-code", buf)); g_free(buf); @@ -1348,10 +1326,23 @@ static int spapr_create_pci_child_dt(SpaprPhbState = *phb, PCIDevice *dev, void *fdt, int node_offset) { int offset; + const gchar *basename; gchar *nodename; + int slot =3D PCI_SLOT(dev->devfn); + int func =3D PCI_FUNC(dev->devfn); + uint32_t ccode =3D pci_default_read_config(dev, PCI_CLASS_PROG, 3); + + basename =3D dt_name_from_class((ccode >> 16) & 0xff, (ccode >> 8) & 0= xff, + ccode & 0xff); + + if (func !=3D 0) { + nodename =3D g_strdup_printf("%s@%x,%x", basename, slot, func); + } else { + nodename =3D g_strdup_printf("%s@%x", basename, slot); + } =20 - nodename =3D pci_get_node_name(dev); _FDT(offset =3D fdt_add_subnode(fdt, node_offset, nodename)); + g_free(nodename); =20 spapr_populate_pci_child_dt(dev, fdt, offset, phb); --=20 2.21.0 From nobody Sun May 5 02:44:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1559195048; cv=none; d=zoho.com; s=zohoarc; b=la2kcIDI9cQw9uPmkW/4IX/sQEIsTlDaqn/+XkPLJOzaPZpZGAL1q/Sda53VXI6ljRMO6s5go0GnqVP5mr2mwGLlV7Xou0EVs1yKlTmt3bjXYcugVYBQxNBzlDkgwlRcVCqc31MZB5zkm+wQ4ad57XAurVJqHUJR70ofZ84ZoVE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559195048; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Z+NYmIEnul8Vlv5rcL4hU8J/a2KuVpiP1VZxKkZzDwI=; b=DPx1uUjFZU/WKU6KwtaRTdehQNTpdKkcuDUCdq+ozcuyPOMTuoyjKMXDFTX4xh/ZYEoGWPSstyFo4dUxtEyUlrrAbs81QXfWfIZ7QJXRwTinAGAAV2Lyrs2Ek637Ads99d8KB4ikunCSyOJupG1BXFuDvLCezeiUKOWOd86OZHc= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559195048344806.8336133259095; Wed, 29 May 2019 22:44:08 -0700 (PDT) Received: from localhost ([127.0.0.1]:52852 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWDr7-00021j-6E for importer@patchew.org; Thu, 30 May 2019 01:44:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWDm0-0006Xv-TP for qemu-devel@nongnu.org; Thu, 30 May 2019 01:38:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWDlz-00048i-AW for qemu-devel@nongnu.org; Thu, 30 May 2019 01:38:44 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:46907 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWDlx-00044E-Oa; Thu, 30 May 2019 01:38:43 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45DxFl1qLGz9s7h; Thu, 30 May 2019 15:38:34 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1559194715; bh=5ILQQIiEPghTWvk+ulSQ8/gZdPIQtAnt1TeJ9Mgf1Kc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=THm6hSSilMoQGJCzTmxwpVCsAXKC/6PtKwB5vm2L+inpgWLze2GmQRwO4YZ/IhFU4 65WdD42cfkuRYMoTWJZdFA2TMLl41ouA0d1pdrfUk/oJQwOyKcmWKZq7E/VKGbLoA0 +kmJhrVsnLcjLaQWwOTzywg5Wsbs7NeI7JBupP7o= From: David Gibson To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Date: Thu, 30 May 2019 15:38:25 +1000 Message-Id: <20190530053831.22115-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530053831.22115-1-david@gibson.dropbear.id.au> References: <20190530053831.22115-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PATCH v2 2/8] spapr: Clean up device tree construction for PCI devices X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.ibm.com, mst@redhat.com, groug@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" spapr_create_pci_child_dt() is a trivial wrapper around spapr_populate_pci_child_dt(), but is the latter's only caller. So fold them together into spapr_dt_pci_device(), which closer matches our modern naming convention. While there, make a number of cleanups to the function itself. This is mostly using more temporary locals to avoid awkwardly long lines, and in some cases avoiding double reads of PCI config space variables. Signed-off-by: David Gibson Reviewed-by: Greg Kurz Acked-by: Michael S. Tsirkin --- hw/ppc/spapr_pci.c | 119 +++++++++++++++++++++------------------------ 1 file changed, 55 insertions(+), 64 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 3f86cf8620..5b038ef071 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -1219,57 +1219,75 @@ static const char *dt_name_from_class(uint8_t class= , uint8_t subclass, static uint32_t spapr_phb_get_pci_drc_index(SpaprPhbState *phb, PCIDevice *pdev); =20 -static void spapr_populate_pci_child_dt(PCIDevice *dev, void *fdt, int off= set, - SpaprPhbState *sphb) +/* create OF node for pci device and required OF DT properties */ +static int spapr_dt_pci_device(SpaprPhbState *sphb, PCIDevice *dev, + void *fdt, int parent_offset) { + int offset; + const gchar *basename; + gchar *nodename; + int slot =3D PCI_SLOT(dev->devfn); + int func =3D PCI_FUNC(dev->devfn); ResourceProps rp; - bool is_bridge =3D false; - int pci_status; - char *buf =3D NULL; uint32_t drc_index =3D spapr_phb_get_pci_drc_index(sphb, dev); + uint32_t header_type =3D pci_default_read_config(dev, PCI_HEADER_TYPE,= 1); + bool is_bridge =3D (header_type =3D=3D PCI_HEADER_TYPE_BRIDGE); + uint32_t vendor_id =3D pci_default_read_config(dev, PCI_VENDOR_ID, 2); + uint32_t device_id =3D pci_default_read_config(dev, PCI_DEVICE_ID, 2); + uint32_t revision_id =3D pci_default_read_config(dev, PCI_REVISION_ID,= 1); uint32_t ccode =3D pci_default_read_config(dev, PCI_CLASS_PROG, 3); - uint32_t max_msi, max_msix; + uint32_t irq_pin =3D pci_default_read_config(dev, PCI_INTERRUPT_PIN, 1= ); + uint32_t subsystem_id =3D pci_default_read_config(dev, PCI_SUBSYSTEM_I= D, 2); + uint32_t subsystem_vendor_id =3D + pci_default_read_config(dev, PCI_SUBSYSTEM_VENDOR_ID, 2); + uint32_t cache_line_size =3D + pci_default_read_config(dev, PCI_CACHE_LINE_SIZE, 1); + uint32_t pci_status =3D pci_default_read_config(dev, PCI_STATUS, 2); + gchar *loc_code; =20 - if (pci_default_read_config(dev, PCI_HEADER_TYPE, 1) =3D=3D - PCI_HEADER_TYPE_BRIDGE) { - is_bridge =3D true; + basename =3D dt_name_from_class((ccode >> 16) & 0xff, (ccode >> 8) & 0= xff, + ccode & 0xff); + + if (func !=3D 0) { + nodename =3D g_strdup_printf("%s@%x,%x", basename, slot, func); + } else { + nodename =3D g_strdup_printf("%s@%x", basename, slot); } =20 + _FDT(offset =3D fdt_add_subnode(fdt, parent_offset, nodename)); + + g_free(nodename); + /* in accordance with PAPR+ v2.7 13.6.3, Table 181 */ - _FDT(fdt_setprop_cell(fdt, offset, "vendor-id", - pci_default_read_config(dev, PCI_VENDOR_ID, 2))); - _FDT(fdt_setprop_cell(fdt, offset, "device-id", - pci_default_read_config(dev, PCI_DEVICE_ID, 2))); - _FDT(fdt_setprop_cell(fdt, offset, "revision-id", - pci_default_read_config(dev, PCI_REVISION_ID, 1)= )); + _FDT(fdt_setprop_cell(fdt, offset, "vendor-id", vendor_id)); + _FDT(fdt_setprop_cell(fdt, offset, "device-id", device_id)); + _FDT(fdt_setprop_cell(fdt, offset, "revision-id", revision_id)); + _FDT(fdt_setprop_cell(fdt, offset, "class-code", ccode)); - if (pci_default_read_config(dev, PCI_INTERRUPT_PIN, 1)) { - _FDT(fdt_setprop_cell(fdt, offset, "interrupts", - pci_default_read_config(dev, PCI_INTERRUPT_PIN, 1))); + if (irq_pin) { + _FDT(fdt_setprop_cell(fdt, offset, "interrupts", irq_pin)); } =20 if (!is_bridge) { - _FDT(fdt_setprop_cell(fdt, offset, "min-grant", - pci_default_read_config(dev, PCI_MIN_GNT, 1))); - _FDT(fdt_setprop_cell(fdt, offset, "max-latency", - pci_default_read_config(dev, PCI_MAX_LAT, 1))); + uint32_t min_grant =3D pci_default_read_config(dev, PCI_MIN_GNT, 1= ); + uint32_t max_latency =3D pci_default_read_config(dev, PCI_MAX_LAT,= 1); + _FDT(fdt_setprop_cell(fdt, offset, "min-grant", min_grant)); + _FDT(fdt_setprop_cell(fdt, offset, "max-latency", max_latency)); } =20 - if (pci_default_read_config(dev, PCI_SUBSYSTEM_ID, 2)) { - _FDT(fdt_setprop_cell(fdt, offset, "subsystem-id", - pci_default_read_config(dev, PCI_SUBSYSTEM_ID, 2))); + if (subsystem_id) { + _FDT(fdt_setprop_cell(fdt, offset, "subsystem-id", subsystem_id)); } =20 - if (pci_default_read_config(dev, PCI_SUBSYSTEM_VENDOR_ID, 2)) { + if (subsystem_vendor_id) { _FDT(fdt_setprop_cell(fdt, offset, "subsystem-vendor-id", - pci_default_read_config(dev, PCI_SUBSYSTEM_VENDOR_ID, 2))= ); + subsystem_vendor_id)); } =20 - _FDT(fdt_setprop_cell(fdt, offset, "cache-line-size", - pci_default_read_config(dev, PCI_CACHE_LINE_SIZE, 1))); + _FDT(fdt_setprop_cell(fdt, offset, "cache-line-size", cache_line_size)= ); + =20 /* the following fdt cells are masked off the pci status register */ - pci_status =3D pci_default_read_config(dev, PCI_STATUS, 2); _FDT(fdt_setprop_cell(fdt, offset, "devsel-speed", PCI_STATUS_DEVSEL_MASK & pci_status)); =20 @@ -1283,9 +1301,9 @@ static void spapr_populate_pci_child_dt(PCIDevice *de= v, void *fdt, int offset, _FDT(fdt_setprop(fdt, offset, "udf-supported", NULL, 0)); } =20 - buf =3D spapr_phb_get_loc_code(sphb, dev); - _FDT(fdt_setprop_string(fdt, offset, "ibm,loc-code", buf)); - g_free(buf); + loc_code =3D spapr_phb_get_loc_code(sphb, dev); + _FDT(fdt_setprop_string(fdt, offset, "ibm,loc-code", loc_code)); + g_free(loc_code); =20 if (drc_index) { _FDT(fdt_setprop_cell(fdt, offset, "ibm,my-drc-index", drc_index)); @@ -1297,13 +1315,13 @@ static void spapr_populate_pci_child_dt(PCIDevice *= dev, void *fdt, int offset, RESOURCE_CELLS_SIZE)); =20 if (msi_present(dev)) { - max_msi =3D msi_nr_vectors_allocated(dev); + uint32_t max_msi =3D msi_nr_vectors_allocated(dev); if (max_msi) { _FDT(fdt_setprop_cell(fdt, offset, "ibm,req#msi", max_msi)); } } if (msix_present(dev)) { - max_msix =3D dev->msix_entries_nr; + uint32_t max_msix =3D dev->msix_entries_nr; if (max_msix) { _FDT(fdt_setprop_cell(fdt, offset, "ibm,req#msi-x", max_msix)); } @@ -1319,33 +1337,6 @@ static void spapr_populate_pci_child_dt(PCIDevice *d= ev, void *fdt, int offset, } =20 spapr_phb_nvgpu_populate_pcidev_dt(dev, fdt, offset, sphb); -} - -/* create OF node for pci device and required OF DT properties */ -static int spapr_create_pci_child_dt(SpaprPhbState *phb, PCIDevice *dev, - void *fdt, int node_offset) -{ - int offset; - const gchar *basename; - gchar *nodename; - int slot =3D PCI_SLOT(dev->devfn); - int func =3D PCI_FUNC(dev->devfn); - uint32_t ccode =3D pci_default_read_config(dev, PCI_CLASS_PROG, 3); - - basename =3D dt_name_from_class((ccode >> 16) & 0xff, (ccode >> 8) & 0= xff, - ccode & 0xff); - - if (func !=3D 0) { - nodename =3D g_strdup_printf("%s@%x,%x", basename, slot, func); - } else { - nodename =3D g_strdup_printf("%s@%x", basename, slot); - } - - _FDT(offset =3D fdt_add_subnode(fdt, node_offset, nodename)); - - g_free(nodename); - - spapr_populate_pci_child_dt(dev, fdt, offset, phb); =20 return offset; } @@ -1393,7 +1384,7 @@ int spapr_pci_dt_populate(SpaprDrc *drc, SpaprMachine= State *spapr, SpaprPhbState *sphb =3D SPAPR_PCI_HOST_BRIDGE(plug_handler); PCIDevice *pdev =3D PCI_DEVICE(drc->dev); =20 - *fdt_start_offset =3D spapr_create_pci_child_dt(sphb, pdev, fdt, 0); + *fdt_start_offset =3D spapr_dt_pci_device(sphb, pdev, fdt, 0); return 0; } =20 @@ -2086,7 +2077,7 @@ static void spapr_populate_pci_devices_dt(PCIBus *bus= , PCIDevice *pdev, int offset; SpaprFdt s_fdt; =20 - offset =3D spapr_create_pci_child_dt(p->sphb, pdev, p->fdt, p->node_of= f); + offset =3D spapr_dt_pci_device(p->sphb, pdev, p->fdt, p->node_off); if (!offset) { error_report("Failed to create pci child device tree node"); return; --=20 2.21.0 From nobody Sun May 5 02:44:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1559195085; cv=none; d=zoho.com; s=zohoarc; b=Lil0HxcywyB+MXqa6hpMtyPGOCdhjeMVYryT2ZGnxePm9XFEoGtcS54+qKUucyNRpIXyLCEDlAWJMmlbYat1d4GrwS7mcKL9I29boL1DdVNFgQGHv298kQyTi7gWDi+gEt6xU62dvu3x7i67i1wH9hWoeRul62FsjfWS0hSeeTo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559195085; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=H8W2Rcv2GYxDEErMjSb4QK96K7ZTHmZ3cEVKkVAHT3w=; b=ZpgvlmIJ0nRVqkwPP9yJyTvHTC/s3zyYo1SNKjf1McqlEVAIQxvEaentkkdcc0BmI0CY/8VQtcUrDQpF4GZzif37IWBz0Ikx94M9rcwUgcOElC0Dpf4gsPZE/Msm5VE/CjYymxe4uSjax2VCtL5+EPyCgAmcw25gBbLvXXwzvjA= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559195085200957.6475334147718; Wed, 29 May 2019 22:44:45 -0700 (PDT) Received: from localhost ([127.0.0.1]:53016 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWDri-0002YL-4v for importer@patchew.org; Thu, 30 May 2019 01:44:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWDm4-0006ZO-0V for qemu-devel@nongnu.org; Thu, 30 May 2019 01:38:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWDm2-0004Cy-2y for qemu-devel@nongnu.org; Thu, 30 May 2019 01:38:47 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:44695 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWDm1-00049R-Cl; Thu, 30 May 2019 01:38:45 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45DxFl2XM1z9s55; Thu, 30 May 2019 15:38:34 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1559194715; bh=29Ur1mf8+UUu/Axw20Lqdiw0uSSn3vVcIa6cT6ezreI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I6B611hUbFjYHSEXZExcpdovfzlRxkLNll87902llt3yMZH0/3d2p606tFqdoJbHh tpN4QfsDqoHQjttW/ExvGUU4IpIeu0h45sV59iMP40M8exk7bCJtsmrqAnzkcrUyqh P+3I6Bm91ija5eeZTsyI/KzBtQJAwzgFPCvccU9c= From: David Gibson To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Date: Thu, 30 May 2019 15:38:26 +1000 Message-Id: <20190530053831.22115-4-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530053831.22115-1-david@gibson.dropbear.id.au> References: <20190530053831.22115-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PATCH v2 3/8] spapr: Clean up dt creation for PCI buses X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.ibm.com, mst@redhat.com, groug@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Device nodes for PCI bridges (both host and P2P) describe both the bridge device itself and the bus hanging off it, handling of this is a bit of a mess. spapr_dt_pci_device() has a few things it only adds for non-bridges, but always adds #address-cells and #size-cells which should only appear for bridges. But the walking down the subordinate PCI bus is done in one of its callers spapr_populate_pci_devices_dt(). The PHB dt creation in spapr_populate_pci_dt() open codes some similar logic to the bridge case. This patch consolidates things in a bunch of ways: * Bus specific dt info is now created in spapr_dt_pci_bus() used for both P2P bridges and the host bridge. This includes walking subordinate devices * spapr_dt_pci_device() now calls spapr_dt_pci_bus() when called on a P2P bridge * We do detection of bridges with the is_bridge field of the device class, rather than checking PCI config space directly, for consistency with qemu's core PCI code. * Several things are renamed for brevity and clarity Signed-off-by: David Gibson Acked-by: Michael S. Tsirkin --- hw/ppc/spapr.c | 7 +- hw/ppc/spapr_pci.c | 140 +++++++++++++++++++----------------- include/hw/pci-host/spapr.h | 4 +- 3 files changed, 79 insertions(+), 72 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index e2b33e5890..44573adce7 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1309,8 +1309,7 @@ static void *spapr_build_fdt(SpaprMachineState *spapr) } =20 QLIST_FOREACH(phb, &spapr->phbs, list) { - ret =3D spapr_populate_pci_dt(phb, PHANDLE_INTC, fdt, - spapr->irq->nr_msis, NULL); + ret =3D spapr_dt_phb(phb, PHANDLE_INTC, fdt, spapr->irq->nr_msis, = NULL); if (ret < 0) { error_report("couldn't setup PCI devices in fdt"); exit(1); @@ -3917,8 +3916,8 @@ int spapr_phb_dt_populate(SpaprDrc *drc, SpaprMachine= State *spapr, return -1; } =20 - if (spapr_populate_pci_dt(sphb, intc_phandle, fdt, spapr->irq->nr_msis, - fdt_start_offset)) { + if (spapr_dt_phb(sphb, intc_phandle, fdt, spapr->irq->nr_msis, + fdt_start_offset)) { error_setg(errp, "unable to create FDT node for PHB %d", sphb->ind= ex); return -1; } diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 5b038ef071..08537c8c85 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -1219,6 +1219,60 @@ static const char *dt_name_from_class(uint8_t class,= uint8_t subclass, static uint32_t spapr_phb_get_pci_drc_index(SpaprPhbState *phb, PCIDevice *pdev); =20 +typedef struct PciWalkFdt { + void *fdt; + int offset; + SpaprPhbState *sphb; + int err; +} PciWalkFdt; + +static int spapr_dt_pci_device(SpaprPhbState *sphb, PCIDevice *dev, + void *fdt, int parent_offset); + +static void spapr_dt_pci_device_cb(PCIBus *bus, PCIDevice *pdev, + void *opaque) +{ + PciWalkFdt *p =3D opaque; + int err; + + if (p->err) { + /* Something's already broken, don't keep going */ + return; + } + + err =3D spapr_dt_pci_device(p->sphb, pdev, p->fdt, p->offset); + if (err < 0) { + p->err =3D err; + } +} + +/* Augment PCI device node with bridge specific information */ +static int spapr_dt_pci_bus(SpaprPhbState *sphb, PCIBus *bus, + void *fdt, int offset) +{ + PciWalkFdt cbinfo =3D { + .fdt =3D fdt, + .offset =3D offset, + .sphb =3D sphb, + .err =3D 0, + }; + + _FDT(fdt_setprop_cell(fdt, offset, "#address-cells", + RESOURCE_CELLS_ADDRESS)); + _FDT(fdt_setprop_cell(fdt, offset, "#size-cells", + RESOURCE_CELLS_SIZE)); + + if (bus) { + pci_for_each_device_reverse(bus, pci_bus_num(bus), + spapr_dt_pci_device_cb, &cbinfo); + if (cbinfo.err) { + return cbinfo.err; + } + } + + return offset; +} + /* create OF node for pci device and required OF DT properties */ static int spapr_dt_pci_device(SpaprPhbState *sphb, PCIDevice *dev, void *fdt, int parent_offset) @@ -1228,10 +1282,9 @@ static int spapr_dt_pci_device(SpaprPhbState *sphb, = PCIDevice *dev, gchar *nodename; int slot =3D PCI_SLOT(dev->devfn); int func =3D PCI_FUNC(dev->devfn); + PCIDeviceClass *pc =3D PCI_DEVICE_GET_CLASS(dev); ResourceProps rp; uint32_t drc_index =3D spapr_phb_get_pci_drc_index(sphb, dev); - uint32_t header_type =3D pci_default_read_config(dev, PCI_HEADER_TYPE,= 1); - bool is_bridge =3D (header_type =3D=3D PCI_HEADER_TYPE_BRIDGE); uint32_t vendor_id =3D pci_default_read_config(dev, PCI_VENDOR_ID, 2); uint32_t device_id =3D pci_default_read_config(dev, PCI_DEVICE_ID, 2); uint32_t revision_id =3D pci_default_read_config(dev, PCI_REVISION_ID,= 1); @@ -1268,13 +1321,6 @@ static int spapr_dt_pci_device(SpaprPhbState *sphb, = PCIDevice *dev, _FDT(fdt_setprop_cell(fdt, offset, "interrupts", irq_pin)); } =20 - if (!is_bridge) { - uint32_t min_grant =3D pci_default_read_config(dev, PCI_MIN_GNT, 1= ); - uint32_t max_latency =3D pci_default_read_config(dev, PCI_MAX_LAT,= 1); - _FDT(fdt_setprop_cell(fdt, offset, "min-grant", min_grant)); - _FDT(fdt_setprop_cell(fdt, offset, "max-latency", max_latency)); - } - if (subsystem_id) { _FDT(fdt_setprop_cell(fdt, offset, "subsystem-id", subsystem_id)); } @@ -1309,11 +1355,6 @@ static int spapr_dt_pci_device(SpaprPhbState *sphb, = PCIDevice *dev, _FDT(fdt_setprop_cell(fdt, offset, "ibm,my-drc-index", drc_index)); } =20 - _FDT(fdt_setprop_cell(fdt, offset, "#address-cells", - RESOURCE_CELLS_ADDRESS)); - _FDT(fdt_setprop_cell(fdt, offset, "#size-cells", - RESOURCE_CELLS_SIZE)); - if (msi_present(dev)) { uint32_t max_msi =3D msi_nr_vectors_allocated(dev); if (max_msi) { @@ -1338,7 +1379,18 @@ static int spapr_dt_pci_device(SpaprPhbState *sphb, = PCIDevice *dev, =20 spapr_phb_nvgpu_populate_pcidev_dt(dev, fdt, offset, sphb); =20 - return offset; + if (!pc->is_bridge) { + /* Properties only for non-bridges */ + uint32_t min_grant =3D pci_default_read_config(dev, PCI_MIN_GNT, 1= ); + uint32_t max_latency =3D pci_default_read_config(dev, PCI_MAX_LAT,= 1); + _FDT(fdt_setprop_cell(fdt, offset, "min-grant", min_grant)); + _FDT(fdt_setprop_cell(fdt, offset, "max-latency", max_latency)); + return offset; + } else { + PCIBus *sec_bus =3D pci_bridge_get_sec_bus(PCI_BRIDGE(dev)); + + return spapr_dt_pci_bus(sphb, sec_bus, fdt, offset); + } } =20 /* Callback to be called during DRC release. */ @@ -2063,44 +2115,6 @@ static const TypeInfo spapr_phb_info =3D { } }; =20 -typedef struct SpaprFdt { - void *fdt; - int node_off; - SpaprPhbState *sphb; -} SpaprFdt; - -static void spapr_populate_pci_devices_dt(PCIBus *bus, PCIDevice *pdev, - void *opaque) -{ - PCIBus *sec_bus; - SpaprFdt *p =3D opaque; - int offset; - SpaprFdt s_fdt; - - offset =3D spapr_dt_pci_device(p->sphb, pdev, p->fdt, p->node_off); - if (!offset) { - error_report("Failed to create pci child device tree node"); - return; - } - - if ((pci_default_read_config(pdev, PCI_HEADER_TYPE, 1) !=3D - PCI_HEADER_TYPE_BRIDGE)) { - return; - } - - sec_bus =3D pci_bridge_get_sec_bus(PCI_BRIDGE(pdev)); - if (!sec_bus) { - return; - } - - s_fdt.fdt =3D p->fdt; - s_fdt.node_off =3D offset; - s_fdt.sphb =3D p->sphb; - pci_for_each_device_reverse(sec_bus, pci_bus_num(sec_bus), - spapr_populate_pci_devices_dt, - &s_fdt); -} - static void spapr_phb_pci_enumerate_bridge(PCIBus *bus, PCIDevice *pdev, void *opaque) { @@ -2138,8 +2152,8 @@ static void spapr_phb_pci_enumerate(SpaprPhbState *ph= b) =20 } =20 -int spapr_populate_pci_dt(SpaprPhbState *phb, uint32_t intc_phandle, void = *fdt, - uint32_t nr_msis, int *node_offset) +int spapr_dt_phb(SpaprPhbState *phb, uint32_t intc_phandle, void *fdt, + uint32_t nr_msis, int *node_offset) { int bus_off, i, j, ret; uint32_t bus_range[] =3D { cpu_to_be32(0), cpu_to_be32(0xff) }; @@ -2186,8 +2200,6 @@ int spapr_populate_pci_dt(SpaprPhbState *phb, uint32_= t intc_phandle, void *fdt, cpu_to_be32(0x0), cpu_to_be32(phb->numa_node)}; SpaprTceTable *tcet; - PCIBus *bus =3D PCI_HOST_BRIDGE(phb)->bus; - SpaprFdt s_fdt; SpaprDrc *drc; Error *errp =3D NULL; =20 @@ -2200,8 +2212,6 @@ int spapr_populate_pci_dt(SpaprPhbState *phb, uint32_= t intc_phandle, void *fdt, /* Write PHB properties */ _FDT(fdt_setprop_string(fdt, bus_off, "device_type", "pci")); _FDT(fdt_setprop_string(fdt, bus_off, "compatible", "IBM,Logical_PHB")= ); - _FDT(fdt_setprop_cell(fdt, bus_off, "#address-cells", 0x3)); - _FDT(fdt_setprop_cell(fdt, bus_off, "#size-cells", 0x2)); _FDT(fdt_setprop_cell(fdt, bus_off, "#interrupt-cells", 0x1)); _FDT(fdt_setprop(fdt, bus_off, "used-by-rtas", NULL, 0)); _FDT(fdt_setprop(fdt, bus_off, "bus-range", &bus_range, sizeof(bus_ran= ge))); @@ -2266,13 +2276,11 @@ int spapr_populate_pci_dt(SpaprPhbState *phb, uint3= 2_t intc_phandle, void *fdt, spapr_phb_pci_enumerate(phb); _FDT(fdt_setprop_cell(fdt, bus_off, "qemu,phb-enumerated", 0x1)); =20 - /* Populate tree nodes with PCI devices attached */ - s_fdt.fdt =3D fdt; - s_fdt.node_off =3D bus_off; - s_fdt.sphb =3D phb; - pci_for_each_device_reverse(bus, pci_bus_num(bus), - spapr_populate_pci_devices_dt, - &s_fdt); + /* Walk the bridge and subordinate buses */ + ret =3D spapr_dt_pci_bus(phb, PCI_HOST_BRIDGE(phb)->bus, fdt, bus_off); + if (ret) { + return ret; + } =20 ret =3D spapr_drc_populate_dt(fdt, bus_off, OBJECT(phb), SPAPR_DR_CONNECTOR_TYPE_PCI); diff --git a/include/hw/pci-host/spapr.h b/include/hw/pci-host/spapr.h index 53519c835e..1b61162f91 100644 --- a/include/hw/pci-host/spapr.h +++ b/include/hw/pci-host/spapr.h @@ -131,8 +131,8 @@ static inline qemu_irq spapr_phb_lsi_qirq(struct SpaprP= hbState *phb, int pin) return spapr_qirq(spapr, phb->lsi_table[pin].irq); } =20 -int spapr_populate_pci_dt(SpaprPhbState *phb, uint32_t intc_phandle, void = *fdt, - uint32_t nr_msis, int *node_offset); +int spapr_dt_phb(SpaprPhbState *phb, uint32_t intc_phandle, void *fdt, + uint32_t nr_msis, int *node_offset); =20 void spapr_pci_rtas_init(void); =20 --=20 2.21.0 From nobody Sun May 5 02:44:01 2024 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1559194869; cv=none; d=zoho.com; s=zohoarc; b=iQdZ3MD5nhXX46V0lE08pqHxaNiBVyh9zXlvRnYer6Uu7yhBPQNxRZy1IsApquYGNvISTQ6ZE0/mhIGnIZhG4xx4jFP9+bUbU84dRQfCyScLrQSuQdKo3HbacN6cwbCz1BVKh/KsC6WLM2266TVBO0l+l2u2ebjHJD3LF4RjVLE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559194869; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=7j4g+0ZlIk8ga71D4T0M7ZSLsmcHx7QNEtRi5OaJ51k=; b=MGcKdwXeCZUjwzfA3UME70HeinFx4eBEeScO9221Nm66qhSrRQR/uZhjBqsO1SgQc/mihM6SOt1yT8r9vdjg6llA2yIPvbjYmnxe3VwS2uSBzSHRIO5X5gNtIspdrhvl3Uv66SXyhhGswZDumvZbdqfjXS/ySfadXIQMX4YI5Uo= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 155919486838023.270101030234514; Wed, 29 May 2019 22:41:08 -0700 (PDT) Received: from localhost ([127.0.0.1]:52067 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWDo4-0007kQ-On for importer@patchew.org; Thu, 30 May 2019 01:40:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWDm0-0006Xs-ID for qemu-devel@nongnu.org; Thu, 30 May 2019 01:38:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWDlz-00048O-7U for qemu-devel@nongnu.org; Thu, 30 May 2019 01:38:44 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:51071 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWDlx-00045a-Ty; Thu, 30 May 2019 01:38:43 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45DxFl0yCcz9s3l; Thu, 30 May 2019 15:38:35 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1559194715; bh=+lxQTtJygEMrOo4K8QMnuAxyUk7C/17tEDaXNevlNmI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JawBejaSCsRiqVyIWPwPsuTB3/QGgxkY1dVN/P2SsFNpLwyZL1iOnQ6miGRJHnZ/g 9gmE5wN8EK6Ebhk9vHNMcM6976R5UoboUOIN6lr++0+uCzkFsYDslFvreJHK9fwTM6 xOqz8U/8NccuuOg2PwTHwgsNlJacpc1YcoK9KDAk= From: David Gibson To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Date: Thu, 30 May 2019 15:38:27 +1000 Message-Id: <20190530053831.22115-5-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530053831.22115-1-david@gibson.dropbear.id.au> References: <20190530053831.22115-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PATCH v2 4/8] spapr: Clean up spapr_drc_populate_dt() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.ibm.com, mst@redhat.com, groug@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This makes some minor cleanups to spapr_drc_populate_dt(), renaming it to the shorter and more idiomatic spapr_dt_drc() along the way. Signed-off-by: David Gibson Reviewed-by: Greg Kurz Acked-by: Michael S. Tsirkin --- hw/ppc/spapr.c | 7 +++---- hw/ppc/spapr_drc.c | 13 ++++++------- hw/ppc/spapr_pci.c | 3 +-- include/hw/ppc/spapr_drc.h | 3 +-- 4 files changed, 11 insertions(+), 15 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 44573adce7..507fd50dd5 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1320,13 +1320,12 @@ static void *spapr_build_fdt(SpaprMachineState *spa= pr) spapr_populate_cpus_dt_node(fdt, spapr); =20 if (smc->dr_lmb_enabled) { - _FDT(spapr_drc_populate_dt(fdt, 0, NULL, SPAPR_DR_CONNECTOR_TYPE_L= MB)); + _FDT(spapr_dt_drc(fdt, 0, NULL, SPAPR_DR_CONNECTOR_TYPE_LMB)); } =20 if (mc->has_hotpluggable_cpus) { int offset =3D fdt_path_offset(fdt, "/cpus"); - ret =3D spapr_drc_populate_dt(fdt, offset, NULL, - SPAPR_DR_CONNECTOR_TYPE_CPU); + ret =3D spapr_dt_drc(fdt, offset, NULL, SPAPR_DR_CONNECTOR_TYPE_CP= U); if (ret < 0) { error_report("Couldn't set up CPU DR device tree properties"); exit(1); @@ -1363,7 +1362,7 @@ static void *spapr_build_fdt(SpaprMachineState *spapr) } =20 if (smc->dr_phb_enabled) { - ret =3D spapr_drc_populate_dt(fdt, 0, NULL, SPAPR_DR_CONNECTOR_TYP= E_PHB); + ret =3D spapr_dt_drc(fdt, 0, NULL, SPAPR_DR_CONNECTOR_TYPE_PHB); if (ret < 0) { error_report("Couldn't set up PHB DR device tree properties"); exit(1); diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index 597f236b9c..bacadfcac5 100644 --- a/hw/ppc/spapr_drc.c +++ b/hw/ppc/spapr_drc.c @@ -781,7 +781,7 @@ SpaprDrc *spapr_drc_by_id(const char *type, uint32_t id) } =20 /** - * spapr_drc_populate_dt + * spapr_dt_drc * * @fdt: libfdt device tree * @path: path in the DT to generate properties @@ -794,8 +794,7 @@ SpaprDrc *spapr_drc_by_id(const char *type, uint32_t id) * * as documented in PAPR+ v2.1, 13.5.2 */ -int spapr_drc_populate_dt(void *fdt, int fdt_offset, Object *owner, - uint32_t drc_type_mask) +int spapr_dt_drc(void *fdt, int offset, Object *owner, uint32_t drc_type_m= ask) { Object *root_container; ObjectProperty *prop; @@ -873,7 +872,7 @@ int spapr_drc_populate_dt(void *fdt, int fdt_offset, Ob= ject *owner, *(uint32_t *)drc_names->str =3D cpu_to_be32(drc_count); *(uint32_t *)drc_types->str =3D cpu_to_be32(drc_count); =20 - ret =3D fdt_setprop(fdt, fdt_offset, "ibm,drc-indexes", + ret =3D fdt_setprop(fdt, offset, "ibm,drc-indexes", drc_indexes->data, drc_indexes->len * sizeof(uint32_t)); if (ret) { @@ -881,7 +880,7 @@ int spapr_drc_populate_dt(void *fdt, int fdt_offset, Ob= ject *owner, goto out; } =20 - ret =3D fdt_setprop(fdt, fdt_offset, "ibm,drc-power-domains", + ret =3D fdt_setprop(fdt, offset, "ibm,drc-power-domains", drc_power_domains->data, drc_power_domains->len * sizeof(uint32_t)); if (ret) { @@ -889,14 +888,14 @@ int spapr_drc_populate_dt(void *fdt, int fdt_offset, = Object *owner, goto out; } =20 - ret =3D fdt_setprop(fdt, fdt_offset, "ibm,drc-names", + ret =3D fdt_setprop(fdt, offset, "ibm,drc-names", drc_names->str, drc_names->len); if (ret) { error_report("Couldn't finalize ibm,drc-names property"); goto out; } =20 - ret =3D fdt_setprop(fdt, fdt_offset, "ibm,drc-types", + ret =3D fdt_setprop(fdt, offset, "ibm,drc-types", drc_types->str, drc_types->len); if (ret) { error_report("Couldn't finalize ibm,drc-types property"); diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 08537c8c85..efbbe705c7 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -2282,8 +2282,7 @@ int spapr_dt_phb(SpaprPhbState *phb, uint32_t intc_ph= andle, void *fdt, return ret; } =20 - ret =3D spapr_drc_populate_dt(fdt, bus_off, OBJECT(phb), - SPAPR_DR_CONNECTOR_TYPE_PCI); + ret =3D spapr_dt_drc(fdt, bus_off, OBJECT(phb), SPAPR_DR_CONNECTOR_TYP= E_PCI); if (ret) { return ret; } diff --git a/include/hw/ppc/spapr_drc.h b/include/hw/ppc/spapr_drc.h index fad0a887f9..c2c543a591 100644 --- a/include/hw/ppc/spapr_drc.h +++ b/include/hw/ppc/spapr_drc.h @@ -266,8 +266,7 @@ SpaprDrc *spapr_dr_connector_new(Object *owner, const c= har *type, uint32_t id); SpaprDrc *spapr_drc_by_index(uint32_t index); SpaprDrc *spapr_drc_by_id(const char *type, uint32_t id); -int spapr_drc_populate_dt(void *fdt, int fdt_offset, Object *owner, - uint32_t drc_type_mask); +int spapr_dt_drc(void *fdt, int offset, Object *owner, uint32_t drc_type_m= ask); =20 void spapr_drc_attach(SpaprDrc *drc, DeviceState *d, Error **errp); void spapr_drc_detach(SpaprDrc *drc); --=20 2.21.0 From nobody Sun May 5 02:44:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1559194889; cv=none; d=zoho.com; s=zohoarc; b=TiP7EgbgJKhlW4yAl12vHRg03Sb/0CuZjQ1/CqXL238I55nD8TJGzZvneq3Ws/Leau45XoOF3Bk+obOaXZXrZ8m+NAQnxklY3M0/vL3/jCfX6me687yVgDs3BKWBRSvgEsS7V7SbE3u+PnnktqJZ1pcUNxb8n3JMyEJm8TXOngY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559194889; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=+5iADL1D8OCpkkS9tTvcvSYGsJkb48tGctCTYNMzW+s=; b=F1LHjX9cWGY4uZpmrQ07d0m7FGp1vGAd1ADQck33HCDny2mmENEmGaTSrPT0kaBrZqr07tq0o/30MvBIDTp1SW5Lx7GFUHlZqsLyaKukfdXEfv+iTcnkXyTMs5RYSyaPVPmCDKvtXQ1nKi4bFghrp7SNARKeRnpRm6spmeqN6MA= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 155919488962511.613992577225872; Wed, 29 May 2019 22:41:29 -0700 (PDT) Received: from localhost ([127.0.0.1]:52173 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWDoV-0008Aq-M2 for importer@patchew.org; Thu, 30 May 2019 01:41:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWDm3-0006Yn-KH for qemu-devel@nongnu.org; Thu, 30 May 2019 01:38:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWDm2-0004Ct-2h for qemu-devel@nongnu.org; Thu, 30 May 2019 01:38:47 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:33853 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWDm1-00049X-E7; Thu, 30 May 2019 01:38:45 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45DxFl4NR4z9s9T; Thu, 30 May 2019 15:38:35 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1559194715; bh=fySpbhLIuV1xbHwCRwtBsMPg3+9Tjljv7iTKkbMSW14=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ockaxCpIW4CK2PIFp58fSboSIBdGQUgVs2sgVO//nRSRhPJf85S/80cqvJ6fmcAMI RoXpHkcqEYOLN4YmOzdR4bwgcJz9osflRc6VHt+Nq5dzatNSUXzCleVQRawZOf8hUM DZE72NIHrw7riKdT2O340DSaFXSUWCYTiQHPUufI= From: David Gibson To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Date: Thu, 30 May 2019 15:38:28 +1000 Message-Id: <20190530053831.22115-6-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530053831.22115-1-david@gibson.dropbear.id.au> References: <20190530053831.22115-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PATCH v2 5/8] spapr: Clean up DRC index construction X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.ibm.com, mst@redhat.com, groug@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" spapr_pci.c currently has several confusingly similarly named functions for various conversions between representations of DRCs. Make things clearer by renaming things in a more consistent XXX_from_YYY() manner and remove some called-only-once variants in favour of open coding. While we're at it, move this code together in the file to avoid some extra forward references, and split out construction and removal of DRCs for the host bridge into helper functions. Signed-off-by: David Gibson Acked-by: Michael S. Tsirkin --- hw/ppc/spapr_pci.c | 124 +++++++++++++++++++++++++-------------------- 1 file changed, 68 insertions(+), 56 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index efbbe705c7..9dd64bd0bd 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -1216,8 +1216,60 @@ static const char *dt_name_from_class(uint8_t class,= uint8_t subclass, return name; } =20 -static uint32_t spapr_phb_get_pci_drc_index(SpaprPhbState *phb, - PCIDevice *pdev); +/* + * DRC helper functions + */ + +static uint32_t drc_id_from_devfn(SpaprPhbState *phb, + uint32_t busnr, + int32_t devfn) +{ + return (phb->index << 16) | (busnr << 8) | devfn; +} + +static SpaprDrc *drc_from_devfn(SpaprPhbState *phb, + uint32_t busnr, int32_t devfn) +{ + return spapr_drc_by_id(TYPE_SPAPR_DRC_PCI, + drc_id_from_devfn(phb, busnr, devfn)); +} + +static SpaprDrc *drc_from_dev(SpaprPhbState *phb, PCIDevice *dev) +{ + uint32_t busnr =3D pci_bus_num(PCI_BUS(qdev_get_parent_bus(DEVICE(dev)= ))); + return drc_from_devfn(phb, busnr, dev->devfn); +} + +static void add_drcs(SpaprPhbState *phb) +{ + int i; + + if (!phb->dr_enabled) { + return; + } + + for (i =3D 0; i < PCI_SLOT_MAX * PCI_FUNC_MAX; i++) { + spapr_dr_connector_new(OBJECT(phb), TYPE_SPAPR_DRC_PCI, + drc_id_from_devfn(phb, 0, i)); + } +} + +static void remove_drcs(SpaprPhbState *phb) +{ + int i; + + if (!phb->dr_enabled) { + return; + } + + for (i =3D PCI_SLOT_MAX * PCI_FUNC_MAX - 1; i >=3D 0; i--) { + SpaprDrc *drc =3D drc_from_devfn(phb, 0, i); + + if (drc) { + object_unparent(OBJECT(drc)); + } + } +} =20 typedef struct PciWalkFdt { void *fdt; @@ -1284,7 +1336,7 @@ static int spapr_dt_pci_device(SpaprPhbState *sphb, P= CIDevice *dev, int func =3D PCI_FUNC(dev->devfn); PCIDeviceClass *pc =3D PCI_DEVICE_GET_CLASS(dev); ResourceProps rp; - uint32_t drc_index =3D spapr_phb_get_pci_drc_index(sphb, dev); + SpaprDrc *drc =3D drc_from_dev(sphb, dev); uint32_t vendor_id =3D pci_default_read_config(dev, PCI_VENDOR_ID, 2); uint32_t device_id =3D pci_default_read_config(dev, PCI_DEVICE_ID, 2); uint32_t revision_id =3D pci_default_read_config(dev, PCI_REVISION_ID,= 1); @@ -1351,8 +1403,9 @@ static int spapr_dt_pci_device(SpaprPhbState *sphb, P= CIDevice *dev, _FDT(fdt_setprop_string(fdt, offset, "ibm,loc-code", loc_code)); g_free(loc_code); =20 - if (drc_index) { - _FDT(fdt_setprop_cell(fdt, offset, "ibm,my-drc-index", drc_index)); + if (drc) { + _FDT(fdt_setprop_cell(fdt, offset, "ibm,my-drc-index", + spapr_drc_index(drc))); } =20 if (msi_present(dev)) { @@ -1402,33 +1455,6 @@ void spapr_phb_remove_pci_device_cb(DeviceState *dev) object_unparent(OBJECT(dev)); } =20 -static SpaprDrc *spapr_phb_get_pci_func_drc(SpaprPhbState *phb, - uint32_t busnr, - int32_t devfn) -{ - return spapr_drc_by_id(TYPE_SPAPR_DRC_PCI, - (phb->index << 16) | (busnr << 8) | devfn); -} - -static SpaprDrc *spapr_phb_get_pci_drc(SpaprPhbState *phb, - PCIDevice *pdev) -{ - uint32_t busnr =3D pci_bus_num(PCI_BUS(qdev_get_parent_bus(DEVICE(pdev= )))); - return spapr_phb_get_pci_func_drc(phb, busnr, pdev->devfn); -} - -static uint32_t spapr_phb_get_pci_drc_index(SpaprPhbState *phb, - PCIDevice *pdev) -{ - SpaprDrc *drc =3D spapr_phb_get_pci_drc(phb, pdev); - - if (!drc) { - return 0; - } - - return spapr_drc_index(drc); -} - int spapr_pci_dt_populate(SpaprDrc *drc, SpaprMachineState *spapr, void *fdt, int *fdt_start_offset, Error **errp) { @@ -1445,7 +1471,7 @@ static void spapr_pci_plug(HotplugHandler *plug_handl= er, { SpaprPhbState *phb =3D SPAPR_PCI_HOST_BRIDGE(DEVICE(plug_handler)); PCIDevice *pdev =3D PCI_DEVICE(plugged_dev); - SpaprDrc *drc =3D spapr_phb_get_pci_drc(phb, pdev); + SpaprDrc *drc =3D drc_from_dev(phb, pdev); Error *local_err =3D NULL; PCIBus *bus =3D PCI_BUS(qdev_get_parent_bus(DEVICE(pdev))); uint32_t slotnr =3D PCI_SLOT(pdev->devfn); @@ -1496,8 +1522,8 @@ static void spapr_pci_plug(HotplugHandler *plug_handl= er, SpaprDrcClass *func_drck; SpaprDREntitySense state; =20 - func_drc =3D spapr_phb_get_pci_func_drc(phb, pci_bus_num(bus), - PCI_DEVFN(slotnr, i)); + func_drc =3D drc_from_devfn(phb, pci_bus_num(bus), + PCI_DEVFN(slotnr, i)); func_drck =3D SPAPR_DR_CONNECTOR_GET_CLASS(func_drc); state =3D func_drck->dr_entity_sense(func_drc); =20 @@ -1533,7 +1559,7 @@ static void spapr_pci_unplug_request(HotplugHandler *= plug_handler, { SpaprPhbState *phb =3D SPAPR_PCI_HOST_BRIDGE(DEVICE(plug_handler)); PCIDevice *pdev =3D PCI_DEVICE(plugged_dev); - SpaprDrc *drc =3D spapr_phb_get_pci_drc(phb, pdev); + SpaprDrc *drc =3D drc_from_dev(phb, pdev); =20 if (!phb->dr_enabled) { error_setg(errp, QERR_BUS_NO_HOTPLUG, @@ -1555,8 +1581,8 @@ static void spapr_pci_unplug_request(HotplugHandler *= plug_handler, /* ensure any other present functions are pending unplug */ if (PCI_FUNC(pdev->devfn) =3D=3D 0) { for (i =3D 1; i < 8; i++) { - func_drc =3D spapr_phb_get_pci_func_drc(phb, pci_bus_num(b= us), - PCI_DEVFN(slotnr, i)= ); + func_drc =3D drc_from_devfn(phb, pci_bus_num(bus), + PCI_DEVFN(slotnr, i)); func_drck =3D SPAPR_DR_CONNECTOR_GET_CLASS(func_drc); state =3D func_drck->dr_entity_sense(func_drc); if (state =3D=3D SPAPR_DR_ENTITY_SENSE_PRESENT @@ -1577,8 +1603,8 @@ static void spapr_pci_unplug_request(HotplugHandler *= plug_handler, */ if (PCI_FUNC(pdev->devfn) =3D=3D 0) { for (i =3D 7; i >=3D 0; i--) { - func_drc =3D spapr_phb_get_pci_func_drc(phb, pci_bus_num(b= us), - PCI_DEVFN(slotnr, i)= ); + func_drc =3D drc_from_devfn(phb, pci_bus_num(bus), + PCI_DEVFN(slotnr, i)); func_drck =3D SPAPR_DR_CONNECTOR_GET_CLASS(func_drc); state =3D func_drck->dr_entity_sense(func_drc); if (state =3D=3D SPAPR_DR_ENTITY_SENSE_PRESENT) { @@ -1626,16 +1652,7 @@ static void spapr_phb_unrealize(DeviceState *dev, Er= ror **errp) } } =20 - if (sphb->dr_enabled) { - for (i =3D PCI_SLOT_MAX * 8 - 1; i >=3D 0; i--) { - SpaprDrc *drc =3D spapr_drc_by_id(TYPE_SPAPR_DRC_PCI, - (sphb->index << 16) | = i); - - if (drc) { - object_unparent(OBJECT(drc)); - } - } - } + remove_drcs(sphb); =20 for (i =3D PCI_NUM_PINS - 1; i >=3D 0; i--) { if (sphb->lsi_table[i].irq) { @@ -1861,12 +1878,7 @@ static void spapr_phb_realize(DeviceState *dev, Erro= r **errp) } =20 /* allocate connectors for child PCI devices */ - if (sphb->dr_enabled) { - for (i =3D 0; i < PCI_SLOT_MAX * 8; i++) { - spapr_dr_connector_new(OBJECT(phb), TYPE_SPAPR_DRC_PCI, - (sphb->index << 16) | i); - } - } + add_drcs(sphb); =20 /* DMA setup */ for (i =3D 0; i < windows_supported; ++i) { --=20 2.21.0 From nobody Sun May 5 02:44:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1559195063; cv=none; d=zoho.com; s=zohoarc; b=NHq8pagLoWuyMKac9zNHaSxkkZMAlezHZ/ryYKjetqJnz0ZCg6gjLauwmlMSERBIugmUGFiH9kzQQjQAFmd8o/cOAAh75joQesh4kn0wTJGTaqA6VIs2qIOdk+6u4ZTZh/qGT09ptVovTW1tXboJi0ZKsgzd+lAcvQQVESJOzGE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559195063; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=ufEC12x5eVXIJ+17YSHZeCk73yhZKG9kWtOmTQl5ZSo=; b=QRPMpk+c+DQgHKQqJR7mYjBe70+GDNf3ygiXLx0PxhivNRp0gKuSmyoRc81kigiYDmK8PagTG9SZEUElUw+70J9rdEusW4wH/LNFfGjyW/KmLtxuqjCpuSfYQUhHbkCOtuvxIGu+AiQZjl90XvpTyiqi12wF46/NUfSvocUzOic= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559195063901349.77397227862514; Wed, 29 May 2019 22:44:23 -0700 (PDT) Received: from localhost ([127.0.0.1]:52912 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWDrM-0002FM-QM for importer@patchew.org; Thu, 30 May 2019 01:44:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWDm3-0006Yh-GH for qemu-devel@nongnu.org; Thu, 30 May 2019 01:38:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWDm2-0004DD-5F for qemu-devel@nongnu.org; Thu, 30 May 2019 01:38:47 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:53397 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWDm1-00049Y-Gb; Thu, 30 May 2019 01:38:46 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45DxFl3nTDz9sB3; Thu, 30 May 2019 15:38:35 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1559194715; bh=ul4JdYiwnI1q/3YRoDI9Ph10fCjLHAG9+CKFUBhvsec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VjuS5p4c3+Xzn+KvmeGtinh9jHBz5vvWHi38vmqu9V2BH9mbMTmHrscHm+kkryYwO URgiOj4th5uzNvu4gblDhDADN9bYLLhdgo6ZdL3tozwn5ihcAQoC4g9NqOa0xbkWX+ nMGz2UDtVTBNQZGIBMuDO4z5WhxvvkGehwYo6I0Q= From: David Gibson To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Date: Thu, 30 May 2019 15:38:29 +1000 Message-Id: <20190530053831.22115-7-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530053831.22115-1-david@gibson.dropbear.id.au> References: <20190530053831.22115-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PATCH v2 6/8] spapr: Don't use bus number for building DRC ids X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.ibm.com, mst@redhat.com, groug@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" DRC ids are more or less arbitrary, as long as they're consistent. For PCI, we notionally build them from the phb's index along with PCI bus number, slot and function number. Using bus number is broken, however, because it can change if the guest re-enumerates the PCI topology for whatever reason (e.g. due to hotplug of a bridge, which we don't support yet but want to). Fortunately, there's an alternative. Bridges are required to have a unique non-zero "chassis number" that we can use instead. Adjust the code to use that instead. This looks like it would introduce a guest visible breaking change, but in fact it does not because we don't yet ever use non-zero bus numbers. Both chassis and bus number are always 0 for the root bus, so there's no change for the existing cases. Signed-off-by: David Gibson Acked-by: Michael S. Tsirkin --- hw/ppc/spapr_pci.c | 54 ++++++++++++++++++++++++++++++++++------------ 1 file changed, 40 insertions(+), 14 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 9dd64bd0bd..513b70f9ad 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -1221,23 +1221,40 @@ static const char *dt_name_from_class(uint8_t class= , uint8_t subclass, */ =20 static uint32_t drc_id_from_devfn(SpaprPhbState *phb, - uint32_t busnr, - int32_t devfn) + uint8_t chassis, int32_t devfn) { - return (phb->index << 16) | (busnr << 8) | devfn; + return (phb->index << 16) | (chassis << 8) | devfn; } =20 static SpaprDrc *drc_from_devfn(SpaprPhbState *phb, - uint32_t busnr, int32_t devfn) + uint8_t chassis, int32_t devfn) { return spapr_drc_by_id(TYPE_SPAPR_DRC_PCI, - drc_id_from_devfn(phb, busnr, devfn)); + drc_id_from_devfn(phb, chassis, devfn)); +} + +static uint8_t chassis_from_bus(PCIBus *bus, Error **errp) +{ + if (pci_bus_is_root(bus)) { + return 0; + } else { + PCIDevice *bridge =3D pci_bridge_get_device(bus); + + return object_property_get_uint(OBJECT(bridge), "chassis_nr", errp= ); + } } =20 static SpaprDrc *drc_from_dev(SpaprPhbState *phb, PCIDevice *dev) { - uint32_t busnr =3D pci_bus_num(PCI_BUS(qdev_get_parent_bus(DEVICE(dev)= ))); - return drc_from_devfn(phb, busnr, dev->devfn); + Error *local_err =3D NULL; + uint8_t chassis =3D chassis_from_bus(pci_get_bus(dev), &local_err); + + if (local_err) { + error_report_err(local_err); + return NULL; + } + + return drc_from_devfn(phb, chassis, dev->devfn); } =20 static void add_drcs(SpaprPhbState *phb) @@ -1516,14 +1533,19 @@ static void spapr_pci_plug(HotplugHandler *plug_han= dler, spapr_drc_reset(drc); } else if (PCI_FUNC(pdev->devfn) =3D=3D 0) { int i; + uint8_t chassis =3D chassis_from_bus(pci_get_bus(pdev), &local_err= ); + + if (local_err) { + error_propagate(errp, local_err); + return; + } =20 for (i =3D 0; i < 8; i++) { SpaprDrc *func_drc; SpaprDrcClass *func_drck; SpaprDREntitySense state; =20 - func_drc =3D drc_from_devfn(phb, pci_bus_num(bus), - PCI_DEVFN(slotnr, i)); + func_drc =3D drc_from_devfn(phb, chassis, PCI_DEVFN(slotnr, i)= ); func_drck =3D SPAPR_DR_CONNECTOR_GET_CLASS(func_drc); state =3D func_drck->dr_entity_sense(func_drc); =20 @@ -1571,18 +1593,23 @@ static void spapr_pci_unplug_request(HotplugHandler= *plug_handler, g_assert(drc->dev =3D=3D plugged_dev); =20 if (!spapr_drc_unplug_requested(drc)) { - PCIBus *bus =3D PCI_BUS(qdev_get_parent_bus(DEVICE(pdev))); uint32_t slotnr =3D PCI_SLOT(pdev->devfn); SpaprDrc *func_drc; SpaprDrcClass *func_drck; SpaprDREntitySense state; int i; + Error *local_err =3D NULL; + uint8_t chassis =3D chassis_from_bus(pci_get_bus(pdev), &local_err= ); + + if (local_err) { + error_propagate(errp, local_err); + return; + } =20 /* ensure any other present functions are pending unplug */ if (PCI_FUNC(pdev->devfn) =3D=3D 0) { for (i =3D 1; i < 8; i++) { - func_drc =3D drc_from_devfn(phb, pci_bus_num(bus), - PCI_DEVFN(slotnr, i)); + func_drc =3D drc_from_devfn(phb, chassis, PCI_DEVFN(slotnr= , i)); func_drck =3D SPAPR_DR_CONNECTOR_GET_CLASS(func_drc); state =3D func_drck->dr_entity_sense(func_drc); if (state =3D=3D SPAPR_DR_ENTITY_SENSE_PRESENT @@ -1603,8 +1630,7 @@ static void spapr_pci_unplug_request(HotplugHandler *= plug_handler, */ if (PCI_FUNC(pdev->devfn) =3D=3D 0) { for (i =3D 7; i >=3D 0; i--) { - func_drc =3D drc_from_devfn(phb, pci_bus_num(bus), - PCI_DEVFN(slotnr, i)); + func_drc =3D drc_from_devfn(phb, chassis, PCI_DEVFN(slotnr= , i)); func_drck =3D SPAPR_DR_CONNECTOR_GET_CLASS(func_drc); state =3D func_drck->dr_entity_sense(func_drc); if (state =3D=3D SPAPR_DR_ENTITY_SENSE_PRESENT) { --=20 2.21.0 From nobody Sun May 5 02:44:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1559195340; cv=none; d=zoho.com; s=zohoarc; b=EpH18BQxomg/UFjUOueYwmJnFu8MWMgusmjHfFWIyokFZzkEQiNl+/rt28QhZULGFnmLXdk7RRW9OT1wfAFMWuOqpwB3Gt4Swku5hbH6G9u0AYDr5PUsAeKXwDvSE6fn/nX4j5xmVMinrF9fmWMNmtf0RADpD/r73MEr28wgUOA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559195340; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=sViPYoQ5PiG9kRkEIkY0uffco6+oD7s+FCOfRnBon1Y=; b=RxZViRDT7QbCbleSV1vvqQ659WyKAdw6QZgKKoBonnkAgqNaTL8gFRe0aZd/QSHEg2lhuBk7JEbut6l55W3QdUEZexCBNlEnNVSdalTc2XlEEIbVzHf4BaNyeU5Z5y6fDGv/JHKF1jt4Z+N298wrsvGbd+FwSXYwG3Hd7/5SYFM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559195340524770.6520106331858; Wed, 29 May 2019 22:49:00 -0700 (PDT) Received: from localhost ([127.0.0.1]:54088 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWDvp-0005mp-L2 for importer@patchew.org; Thu, 30 May 2019 01:48:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWDm3-0006Z6-QT for qemu-devel@nongnu.org; Thu, 30 May 2019 01:38:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWDm2-0004EK-TP for qemu-devel@nongnu.org; Thu, 30 May 2019 01:38:47 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:50151) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWDm2-00049q-HF; Thu, 30 May 2019 01:38:46 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45DxFl5GqGz9s9N; Thu, 30 May 2019 15:38:35 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1559194715; bh=Dc4e87KbcUk5ty+IGSWNE2GcGV1SyAd7CLeN6PnTLas=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bp4Omv7xoDFa6FwoOEWmlCBt5y2lBUpGX8G35NnccmBbN1aJJ61lGUVW94P2xVryh D6/sux+9Ce7Am99LHSDwKWb9jx5FlJwVkuQkPiWnox/aJSmHX96HT5dd8H5CNfJAwN mRH2OQandfD9X15HmiatmtPNzh78CFU5/XDDHB2I= From: David Gibson To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Date: Thu, 30 May 2019 15:38:30 +1000 Message-Id: <20190530053831.22115-8-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530053831.22115-1-david@gibson.dropbear.id.au> References: <20190530053831.22115-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PATCH v2 7/8] spapr: Direct all PCI hotplug to host bridge, rather than P2P bridge X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.ibm.com, mst@redhat.com, groug@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" A P2P bridge will attempt to handle the hotplug with SHPC, which doesn't work in the PAPR environment. Instead we want to direct all PCI hotplug actions to the PAPR specific host bridge which will use the PAPR hotplug mechanism. Signed-off-by: David Gibson Acked-by: Michael S. Tsirkin --- hw/ppc/spapr.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 507fd50dd5..6dd8aaac33 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -4094,6 +4094,17 @@ static HotplugHandler *spapr_get_hotplug_handler(Mac= hineState *machine, object_dynamic_cast(OBJECT(dev), TYPE_SPAPR_PCI_HOST_BRIDGE)) { return HOTPLUG_HANDLER(machine); } + if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) { + PCIDevice *pcidev =3D PCI_DEVICE(dev); + PCIBus *root =3D pci_device_root_bus(pcidev); + SpaprPhbState *phb =3D + (SpaprPhbState *)object_dynamic_cast(OBJECT(BUS(root)->parent), + TYPE_SPAPR_PCI_HOST_BRIDG= E); + + if (phb) { + return HOTPLUG_HANDLER(phb); + } + } return NULL; } =20 --=20 2.21.0 From nobody Sun May 5 02:44:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1559195067; cv=none; d=zoho.com; s=zohoarc; b=FABwxp1sdZzg9JRyDgHUP/OS9zgCOaOXrDSIhnrQzxi4NTgAlkV4SLfA7UN8B4isgljL8nv4ILCrZK5QFgMM6lELSME2rtgji99+Qh98mlOMQfkAUtmCF+2r74Cvf7MpFBK6MbIb5wYZ+9cgGBjjxXJjsLqtNh87JfBHGTJG2Os= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559195067; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=VIASF0qMrd/LFZw0TxIOpZ8XIyEds9eaejWeOsfKb5s=; b=BHrXJ2Pc6+vds3xB3ZKlLfiktyp7V7I4jj2Skzu4ggLhyA5eq9IEeKBYqT8m8HJ1p4geFLREnuqrphRA5+c+hWwf8XoVI5wbn6ley5L3Ygfv3zUuVLVO8SkSRNLRMVmWErRzWy01M/3tAIvnvti+6fvph2McUlj2F6bm6CKrRjs= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559195067769922.3714623381089; Wed, 29 May 2019 22:44:27 -0700 (PDT) Received: from localhost ([127.0.0.1]:52951 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWDrT-0002Ly-JP for importer@patchew.org; Thu, 30 May 2019 01:44:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWDm4-0006aR-Sk for qemu-devel@nongnu.org; Thu, 30 May 2019 01:38:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWDm3-0004Eh-4F for qemu-devel@nongnu.org; Thu, 30 May 2019 01:38:48 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:41845) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWDm2-00049V-CQ; Thu, 30 May 2019 01:38:47 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45DxFl37ZVz9s5c; Thu, 30 May 2019 15:38:35 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1559194715; bh=K+qpaPDVKkyoD7dmzN0Wck6b3Q2/EqsKLIv2A7XbRJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PlyT+irrLTqACg9mCFPXsQx4lG3/37l7stplOaroMNpBzRGaSLsIAwCYTQ39yvQMZ eEhXafItlhMLMs9rqFbZooENjj4o3PradnDQcGg0ll7njqJfku2BSwI0GlZczDKGq8 4gUFn5ZOcFMt4QZLOWnLFE5ELXNGs7kFAyGlobi0= From: David Gibson To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Date: Thu, 30 May 2019 15:38:31 +1000 Message-Id: <20190530053831.22115-9-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530053831.22115-1-david@gibson.dropbear.id.au> References: <20190530053831.22115-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PATCH v2 8/8] spapr: Allow hot plug/unplug of PCI bridges and devices under PCI bridges X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.ibm.com, mst@redhat.com, groug@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The pseries machine type already allows PCI hotplug and unplug via the PAPR mechanism, but only on the root bus of each PHB. This patch extends this to allow PCI to PCI bridges to be hotplugged, and devices to be hotplugged or unplugged under P2P bridges. For now we disallow hot unplugging P2P bridges. I tried doing that, but haven't managed to get it working, I think due to some guest side problems that need further investigation. To do this we dynamically construct DRCs when bridges are hot (or cold) added, which can in turn be used to hotplug devices under the bridge. Signed-off-by: David Gibson Acked-by: Michael S. Tsirkin --- hw/ppc/spapr_pci.c | 115 ++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 102 insertions(+), 13 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 513b70f9ad..ab2a21db35 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -1257,30 +1257,53 @@ static SpaprDrc *drc_from_dev(SpaprPhbState *phb, P= CIDevice *dev) return drc_from_devfn(phb, chassis, dev->devfn); } =20 -static void add_drcs(SpaprPhbState *phb) +static void add_drcs(SpaprPhbState *phb, PCIBus *bus, Error **errp) { + Object *owner; int i; + uint8_t chassis; + Error *local_err =3D NULL; =20 if (!phb->dr_enabled) { return; } =20 + chassis =3D chassis_from_bus(bus, &local_err); + if (local_err) { + error_propagate(errp, local_err); + return; + } + + if (pci_bus_is_root(bus)) { + owner =3D OBJECT(phb); + } else { + owner =3D OBJECT(pci_bridge_get_device(bus)); + } + for (i =3D 0; i < PCI_SLOT_MAX * PCI_FUNC_MAX; i++) { - spapr_dr_connector_new(OBJECT(phb), TYPE_SPAPR_DRC_PCI, - drc_id_from_devfn(phb, 0, i)); + spapr_dr_connector_new(owner, TYPE_SPAPR_DRC_PCI, + drc_id_from_devfn(phb, chassis, i)); } } =20 -static void remove_drcs(SpaprPhbState *phb) +static void remove_drcs(SpaprPhbState *phb, PCIBus *bus, Error **errp) { int i; + uint8_t chassis; + Error *local_err =3D NULL; =20 if (!phb->dr_enabled) { return; } =20 + chassis =3D chassis_from_bus(bus, &local_err); + if (local_err) { + error_propagate(errp, local_err); + return; + } + for (i =3D PCI_SLOT_MAX * PCI_FUNC_MAX - 1; i >=3D 0; i--) { - SpaprDrc *drc =3D drc_from_devfn(phb, 0, i); + SpaprDrc *drc =3D drc_from_devfn(phb, chassis, i); =20 if (drc) { object_unparent(OBJECT(drc)); @@ -1325,6 +1348,7 @@ static int spapr_dt_pci_bus(SpaprPhbState *sphb, PCIB= us *bus, .sphb =3D sphb, .err =3D 0, }; + int ret; =20 _FDT(fdt_setprop_cell(fdt, offset, "#address-cells", RESOURCE_CELLS_ADDRESS)); @@ -1339,6 +1363,12 @@ static int spapr_dt_pci_bus(SpaprPhbState *sphb, PCI= Bus *bus, } } =20 + ret =3D spapr_dt_drc(fdt, offset, OBJECT(bus->parent_dev), + SPAPR_DR_CONNECTOR_TYPE_PCI); + if (ret) { + return ret; + } + return offset; } =20 @@ -1483,11 +1513,26 @@ int spapr_pci_dt_populate(SpaprDrc *drc, SpaprMachi= neState *spapr, return 0; } =20 +static void spapr_pci_bridge_plug(SpaprPhbState *phb, + PCIBridge *bridge, + Error **errp) +{ + Error *local_err =3D NULL; + PCIBus *bus =3D pci_bridge_get_sec_bus(bridge); + + add_drcs(phb, bus, &local_err); + if (local_err) { + error_propagate(errp, local_err); + return; + } +} + static void spapr_pci_plug(HotplugHandler *plug_handler, DeviceState *plugged_dev, Error **errp) { SpaprPhbState *phb =3D SPAPR_PCI_HOST_BRIDGE(DEVICE(plug_handler)); PCIDevice *pdev =3D PCI_DEVICE(plugged_dev); + PCIDeviceClass *pc =3D PCI_DEVICE_GET_CLASS(plugged_dev); SpaprDrc *drc =3D drc_from_dev(phb, pdev); Error *local_err =3D NULL; PCIBus *bus =3D PCI_BUS(qdev_get_parent_bus(DEVICE(pdev))); @@ -1509,6 +1554,14 @@ static void spapr_pci_plug(HotplugHandler *plug_hand= ler, =20 g_assert(drc); =20 + if (pc->is_bridge) { + spapr_pci_bridge_plug(phb, PCI_BRIDGE(plugged_dev), &local_err); + if (local_err) { + error_propagate(errp, local_err); + return; + } + } + /* Following the QEMU convention used for PCIe multifunction * hotplug, we do not allow functions to be hotplugged to a * slot that already has function 0 present @@ -1559,9 +1612,26 @@ out: error_propagate(errp, local_err); } =20 +static void spapr_pci_bridge_unplug(SpaprPhbState *phb, + PCIBridge *bridge, + Error **errp) +{ + Error *local_err =3D NULL; + PCIBus *bus =3D pci_bridge_get_sec_bus(bridge); + + remove_drcs(phb, bus, &local_err); + if (local_err) { + error_propagate(errp, local_err); + return; + } +} + static void spapr_pci_unplug(HotplugHandler *plug_handler, DeviceState *plugged_dev, Error **errp) { + PCIDeviceClass *pc =3D PCI_DEVICE_GET_CLASS(plugged_dev); + SpaprPhbState *phb =3D SPAPR_PCI_HOST_BRIDGE(DEVICE(plug_handler)); + /* some version guests do not wait for completion of a device * cleanup (generally done asynchronously by the kernel) before * signaling to QEMU that the device is safe, but instead sleep @@ -1573,6 +1643,16 @@ static void spapr_pci_unplug(HotplugHandler *plug_ha= ndler, * an 'idle' state, as the device cleanup code expects. */ pci_device_reset(PCI_DEVICE(plugged_dev)); + + if (pc->is_bridge) { + Error *local_err =3D NULL; + spapr_pci_bridge_unplug(phb, PCI_BRIDGE(plugged_dev), &local_err); + if (local_err) { + error_propagate(errp, local_err); + } + return; + } + object_property_set_bool(OBJECT(plugged_dev), false, "realized", NULL); } =20 @@ -1593,6 +1673,7 @@ static void spapr_pci_unplug_request(HotplugHandler *= plug_handler, g_assert(drc->dev =3D=3D plugged_dev); =20 if (!spapr_drc_unplug_requested(drc)) { + PCIDeviceClass *pc =3D PCI_DEVICE_GET_CLASS(plugged_dev); uint32_t slotnr =3D PCI_SLOT(pdev->devfn); SpaprDrc *func_drc; SpaprDrcClass *func_drck; @@ -1606,6 +1687,10 @@ static void spapr_pci_unplug_request(HotplugHandler = *plug_handler, return; } =20 + if (pc->is_bridge) { + error_setg(errp, "PCI: Hot unplug of PCI bridges not supported= "); + } + /* ensure any other present functions are pending unplug */ if (PCI_FUNC(pdev->devfn) =3D=3D 0) { for (i =3D 1; i < 8; i++) { @@ -1658,6 +1743,7 @@ static void spapr_phb_unrealize(DeviceState *dev, Err= or **errp) SpaprTceTable *tcet; int i; const unsigned windows_supported =3D spapr_phb_windows_supported(sphb); + Error *local_err =3D NULL; =20 spapr_phb_nvgpu_free(sphb); =20 @@ -1678,7 +1764,11 @@ static void spapr_phb_unrealize(DeviceState *dev, Er= ror **errp) } } =20 - remove_drcs(sphb); + remove_drcs(sphb, phb->bus, &local_err); + if (local_err) { + error_propagate(errp, local_err); + return; + } =20 for (i =3D PCI_NUM_PINS - 1; i >=3D 0; i--) { if (sphb->lsi_table[i].irq) { @@ -1743,6 +1833,7 @@ static void spapr_phb_realize(DeviceState *dev, Error= **errp) uint64_t msi_window_size =3D 4096; SpaprTceTable *tcet; const unsigned windows_supported =3D spapr_phb_windows_supported(sphb); + Error *local_err =3D NULL; =20 if (!spapr) { error_setg(errp, TYPE_SPAPR_PCI_HOST_BRIDGE " needs a pseries mach= ine"); @@ -1879,7 +1970,6 @@ static void spapr_phb_realize(DeviceState *dev, Error= **errp) /* Initialize the LSI table */ for (i =3D 0; i < PCI_NUM_PINS; i++) { uint32_t irq =3D SPAPR_IRQ_PCI_LSI + sphb->index * PCI_NUM_PINS + = i; - Error *local_err =3D NULL; =20 if (smc->legacy_irq_allocation) { irq =3D spapr_irq_findone(spapr, &local_err); @@ -1904,7 +1994,11 @@ static void spapr_phb_realize(DeviceState *dev, Erro= r **errp) } =20 /* allocate connectors for child PCI devices */ - add_drcs(sphb); + add_drcs(sphb, phb->bus, &local_err); + if (local_err) { + error_propagate(errp, local_err); + goto unrealize; + } =20 /* DMA setup */ for (i =3D 0; i < windows_supported; ++i) { @@ -2320,11 +2414,6 @@ int spapr_dt_phb(SpaprPhbState *phb, uint32_t intc_p= handle, void *fdt, return ret; } =20 - ret =3D spapr_dt_drc(fdt, bus_off, OBJECT(phb), SPAPR_DR_CONNECTOR_TYP= E_PCI); - if (ret) { - return ret; - } - spapr_phb_nvgpu_populate_dt(phb, fdt, bus_off, &errp); if (errp) { error_report_err(errp); --=20 2.21.0