From nobody Wed May 8 01:52:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559146172; cv=none; d=zoho.com; s=zohoarc; b=S7QmnKL5gbbV+7vGrrA5lk+dLSPAOz4lYfODA/DRagbeiUlWgumL7pE8QJzzMgJ3jRgHLb8vLA7Dg5l58w68p9IotTRznMQeJ1ixm6q8QWZ+2aCRiQD5Ihih8G3YnIYotbN1sKnlwyXzZVQg9DhJ9yP8e921KEHLO5GfI1EclMc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559146172; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=oZq08cQExjLD+NcLNNaPK5sAr4cwlMIldabQsXw0u2o=; b=mjUFnyN0HX2dGyJpOj6/3h+wB/Fz6Z4zkdUoc6Hfo2vZ7srzxe/3ZAgyz2qUKkLfcGeiindQMDRvoZ4Mhu5OPJ0vKwvPz+5VVRrx3TSAt8KtLEzPtCHYDwGtgBvpaJluf0cM69Hx5IS/A9WyebmNNmu63czugBtGbfzO0lWu7qo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559146172730838.1876902893164; Wed, 29 May 2019 09:09:32 -0700 (PDT) Received: from localhost ([127.0.0.1]:57411 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hW18k-0002AD-GK for importer@patchew.org; Wed, 29 May 2019 12:09:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hW17g-0001il-EE for qemu-devel@nongnu.org; Wed, 29 May 2019 12:08:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hW17f-00023H-90 for qemu-devel@nongnu.org; Wed, 29 May 2019 12:08:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46570) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hW17V-0001zV-2t; Wed, 29 May 2019 12:08:06 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6969B307D97F; Wed, 29 May 2019 16:07:58 +0000 (UTC) Received: from thinkpad.redhat.com (ovpn-204-181.brq.redhat.com [10.40.204.181]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0F5521001DD8; Wed, 29 May 2019 16:07:53 +0000 (UTC) From: Laurent Vivier To: qemu-devel@nongnu.org Date: Wed, 29 May 2019 18:07:47 +0200 Message-Id: <20190529160747.778-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Wed, 29 May 2019 16:08:03 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v4] numa: improve cpu hotplug error message with a wrong node-id X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Igor Mammedov , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" On pseries, core-ids are strongly binded to a node-id by the command line option. If an user tries to add a CPU to the wrong node, he has an error but it is not really helpful: qemu-system-ppc64 ... -smp 1,maxcpus=3D64,cores=3D1,threads=3D1,sockets= =3D1 \ -numa node,nodeid=3D0 -numa node,nodeid=3D1 ... (qemu) device_add power9_v2.0-spapr-cpu-core,core-id=3D30,node-id=3D1 Error: node-id=3D1 must match numa node specified with -numa option This patch improves this error message by giving to the user the good node-id to use with the core-id he's providing Error: invalid node-id, must be 0 Signed-off-by: Laurent Vivier Reviewed-by: Igor Mammedov --- Notes: v4: simplify the message =20 v3: only add the topology to the existing message As suggested by Igor replace Error: core-id 30 can only be plugged into node-id 0 by Error: node-id=3D1 must match numa node specified with -numa opti= on 'node-id 0' =20 v2: display full topology in the error message numa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/numa.c b/numa.c index 3875e1efda3a..955ec0c830db 100644 --- a/numa.c +++ b/numa.c @@ -470,8 +470,8 @@ void numa_cpu_pre_plug(const CPUArchId *slot, DeviceSta= te *dev, Error **errp) "node-id", errp); } } else if (node_id !=3D slot->props.node_id) { - error_setg(errp, "node-id=3D%d must match numa node specified " - "with -numa option", node_id); + error_setg(errp, "invalid node-id, must be %"PRId64, + slot->props.node_id); } } =20 --=20 2.20.1