From nobody Mon Feb 9 09:00:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559140522; cv=none; d=zoho.com; s=zohoarc; b=iztuooGzlbEqJNPN5zwsv+/AKHmDIH6n122yK1Ys56Z0VPSAsW07SQ6WoFDrAUsmy2cecslMT196jIOWHP5JzJBEdEBYNDXQsbnfy2aTVjTFNtbVxnqNocD8UA5TPPKE1UtNURjxhSxJYQyaPAmrlh2HiXxjKhXSqcknsfqAGFs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559140522; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=XaWCdEmFf//78EmJ7t69x3cgI/x2tpHYENNOpuEVeq0=; b=hhoqPrAlDBp5TnVWfREfWh5ORRB76/piTJ6kUFru5EPDIS4SCiauxE/joKT0oWRseRdI51pS5OJi9IxYzgJ/fNfl/GHAbHOSNF9/EMSn+3tktPne4ulToW/fbSwATsPG0ILTI/k5Rpi73MLZyy047IU4NgfRf/iQrW1pL0Md+Z8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559140522653221.95551522732364; Wed, 29 May 2019 07:35:22 -0700 (PDT) Received: from localhost ([127.0.0.1]:55458 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVzf8-0004Nd-CU for importer@patchew.org; Wed, 29 May 2019 10:34:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVzcE-0002bo-Qi for qemu-devel@nongnu.org; Wed, 29 May 2019 10:31:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVzcC-0004Xt-QO for qemu-devel@nongnu.org; Wed, 29 May 2019 10:31:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45018) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVzcC-0004Wc-KX for qemu-devel@nongnu.org; Wed, 29 May 2019 10:31:40 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 84BDCC0528B3; Wed, 29 May 2019 14:31:34 +0000 (UTC) Received: from thinkpad.redhat.com (ovpn-204-181.brq.redhat.com [10.40.204.181]) by smtp.corp.redhat.com (Postfix) with ESMTP id CEA45611AD; Wed, 29 May 2019 14:31:29 +0000 (UTC) From: Laurent Vivier To: qemu-devel@nongnu.org Date: Wed, 29 May 2019 16:31:06 +0200 Message-Id: <20190529143106.11789-5-lvivier@redhat.com> In-Reply-To: <20190529143106.11789-1-lvivier@redhat.com> References: <20190529143106.11789-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 29 May 2019 14:31:39 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v7 4/4] virtio-rng: change default backend to rng-builtin X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Kashyap Chamarthy , Amit Shah , Richard Henderson , "Richard W . M . Jones" , Markus Armbruster , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Reviewed-by: Markus Armbruster Signed-off-by: Laurent Vivier --- backends/rng-builtin.c | 1 - hw/virtio/virtio-rng.c | 3 +-- include/sysemu/rng.h | 2 ++ qemu-options.hx | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/backends/rng-builtin.c b/backends/rng-builtin.c index 3381d47174df..ba1b8d66b83e 100644 --- a/backends/rng-builtin.c +++ b/backends/rng-builtin.c @@ -10,7 +10,6 @@ #include "qemu/main-loop.h" #include "qemu/guest-random.h" =20 -#define TYPE_RNG_BUILTIN "rng-builtin" #define RNG_BUILTIN(obj) OBJECT_CHECK(RngBuiltin, (obj), TYPE_RNG_BUILTIN) =20 typedef struct RngBuiltin { diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c index 73ffb476e030..55745f75a1c9 100644 --- a/hw/virtio/virtio-rng.c +++ b/hw/virtio/virtio-rng.c @@ -16,7 +16,6 @@ #include "hw/virtio/virtio.h" #include "hw/virtio/virtio-rng.h" #include "sysemu/rng.h" -#include "sysemu/rng-random.h" #include "qom/object_interfaces.h" #include "trace.h" =20 @@ -190,7 +189,7 @@ static void virtio_rng_device_realize(DeviceState *dev,= Error **errp) } =20 if (vrng->conf.rng =3D=3D NULL) { - Object *default_backend =3D object_new(TYPE_RNG_RANDOM); + Object *default_backend =3D object_new(TYPE_RNG_BUILTIN); =20 user_creatable_complete(USER_CREATABLE(default_backend), &local_err); diff --git a/include/sysemu/rng.h b/include/sysemu/rng.h index 27b37da05d2e..9dc5e0e90100 100644 --- a/include/sysemu/rng.h +++ b/include/sysemu/rng.h @@ -24,6 +24,8 @@ #define RNG_BACKEND_CLASS(klass) \ OBJECT_CLASS_CHECK(RngBackendClass, (klass), TYPE_RNG_BACKEND) =20 +#define TYPE_RNG_BUILTIN "rng-builtin" + typedef struct RngRequest RngRequest; typedef struct RngBackendClass RngBackendClass; typedef struct RngBackend RngBackend; diff --git a/qemu-options.hx b/qemu-options.hx index 4e6a6828d7ce..7746fe9bed6a 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4327,7 +4327,7 @@ The @option{share} boolean option is @var{on} by defa= ult with memfd. Creates a random number generator backend which obtains entropy from QEMU builtin functions. The @option{id} parameter is a unique ID that will be used to reference this entropy backend from the @option{virtio-rng} -device. +device. By default, the @option{virtio-rng} device uses this RNG backend. =20 @item -object rng-random,id=3D@var{id},filename=3D@var{/dev/random} =20 --=20 2.20.1