From nobody Mon Feb 9 21:11:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1559113368; cv=none; d=zoho.com; s=zohoarc; b=OVYPU1oCCpSrUBBnIqw6E1fL96cJP789hQpOlrNZDBaSq4OMmo6uW/gaqwhYLmrf86f4E54t12bBc4/RhRu4rO2Yc/EMcNjlqcZKoZua4cP0Woo1Ljkb1Ur+fcIrvd1z87MkbeT13OOzcuzUQRFn7YoYE8RD6egieFMHt/1bvuA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559113368; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=IjLlfE9YD0fCN+SuapDp7zBBdaWcEQLlf0u0JMfXek0=; b=eDKWKflSY+P/lMMEhvWy63wSh7pG+Bssb510Y23U/mdL/YKodd/y0AFXBAX6WVlahwMA6xa/WV+JT/ptrD4xUVgI9HbSTywjYKsu4Az13VGc9aPtdFtbVaVBFtNVOBMiO0cpZRmSQ/fb8mhJczIu+CpdqeAAnBoPAdslcMN+rqk= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559113368969506.945907270221; Wed, 29 May 2019 00:02:48 -0700 (PDT) Received: from localhost ([127.0.0.1]:48529 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVsbl-0001g3-25 for importer@patchew.org; Wed, 29 May 2019 03:02:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVsQ3-0008HQ-G6 for qemu-devel@nongnu.org; Wed, 29 May 2019 02:50:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVsQ2-0002c2-BY for qemu-devel@nongnu.org; Wed, 29 May 2019 02:50:39 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:55855 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVsQ1-0002Ya-VJ; Wed, 29 May 2019 02:50:38 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45DLv32rgyz9sNk; Wed, 29 May 2019 16:50:22 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1559112623; bh=Pt2V6H9UxjB0VJr6x7Imcec9CnShuswntyMOw5mqCy0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fS8xcg4nRf1Q3oCD7DbnMmuJvImGT49muIYI1Yth0ladTmkygJy90By//RU4pG2BQ SFF/8Xb/yIoo6N/9pqKfqS9+KWK0G+EA4bl/kpmSklNUyyQwWXIGBkgf5h6FpIhbQG EVtKvRwkeaB9AfCvLHHxrGlmp7g4qvDRsz4TQPlA= From: David Gibson To: peter.maydell@linaro.org Date: Wed, 29 May 2019 16:49:45 +1000 Message-Id: <20190529065017.15149-13-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190529065017.15149-1-david@gibson.dropbear.id.au> References: <20190529065017.15149-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 12/44] target/ppc: Fix vsum2sws X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson , Anton Blanchard , rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Anton Blanchard A recent cleanup changed the pre zeroing of the result from 64 bit to 32 bit operations: - result.u64[i] =3D 0; + result.VsrW(i) =3D 0; This corrupts the result. Fixes: 60594fea298d ("target/ppc: remove various HOST_WORDS_BIGENDIAN hacks= in int_helper.c") Signed-off-by: Anton Blanchard Message-Id: <20190507004811.29968-9-anton@ozlabs.org> Signed-off-by: David Gibson --- target/ppc/int_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c index 2bad2d5620..093ef74b59 100644 --- a/target/ppc/int_helper.c +++ b/target/ppc/int_helper.c @@ -2053,7 +2053,7 @@ void helper_vsum2sws(CPUPPCState *env, ppc_avr_t *r, = ppc_avr_t *a, ppc_avr_t *b) for (i =3D 0; i < ARRAY_SIZE(r->u64); i++) { int64_t t =3D (int64_t)b->VsrSW(upper + i * 2); =20 - result.VsrW(i) =3D 0; + result.VsrD(i) =3D 0; for (j =3D 0; j < ARRAY_SIZE(r->u64); j++) { t +=3D a->VsrSW(2 * i + j); } --=20 2.21.0