From nobody Mon Feb 9 04:59:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559062113; cv=none; d=zoho.com; s=zohoarc; b=lHFqmVAW2jQDYCFFvgWDy7KSEx6t1xrUyCyzWWnMiY1rsVxTczooxBlmv8e+APqeqEObRp7YYem6YmEBRTC5/kskqS5CmgRn08EvDBZCfCw4ulkJL3iZJyt4PDa1YVZDZBmMtXriKgzWSigBRvWKPBAviLFGC7GVYdyeaxbaboA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559062113; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=qAeWewqalVs/SLS9ILxTCKkdy9lG+wEhn8+BRBeExSY=; b=f0n+4YYiSQVAEfLrZeHKFojgUhdhJrsPhHh6xSXJ78s3nxvkUigPcXkucDYlOrWO16tt71RyWtIY3RPq/6CzIGN8CJNkoJkn5wd7lyt6MwBGaEDK9AFTEopNwbvO32fmvFUBA6BP3KerkI5iUoQ4gyDgUTVxVUFvSgevj3Q1A9Y= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559062113211241.07593946243662; Tue, 28 May 2019 09:48:33 -0700 (PDT) Received: from localhost ([127.0.0.1]:39471 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVfH0-00060V-59 for importer@patchew.org; Tue, 28 May 2019 12:48:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVfCE-0002RX-NN for qemu-devel@nongnu.org; Tue, 28 May 2019 12:43:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVfC4-0001W9-Ca for qemu-devel@nongnu.org; Tue, 28 May 2019 12:43:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35124) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVfC4-00013B-4e; Tue, 28 May 2019 12:43:20 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF82F300BEA9; Tue, 28 May 2019 16:42:30 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.206.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7732160BDF; Tue, 28 May 2019 16:42:22 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, qemu-trivial@nongnu.org Date: Tue, 28 May 2019 18:40:18 +0200 Message-Id: <20190528164020.32250-9-philmd@redhat.com> In-Reply-To: <20190528164020.32250-1-philmd@redhat.com> References: <20190528164020.32250-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 28 May 2019 16:42:31 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 08/10] hw/usb-storage: Use the QOM DEVICE() macro to access DeviceState.qdev X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Dmitry Fleytman , Aleksandar Markovic , "Michael S. Tsirkin" , Aleksandar Rikalo , Markus Armbruster , David Hildenbrand , Alex Williamson , qemu-s390x@nongnu.org, Halil Pasic , Christian Borntraeger , Michael Walle , Gerd Hoffmann , Cornelia Huck , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Rather than looking inside the definition of a DeviceState with "s->qdev", use the QOM prefered style: "DEVICE(s)". This patch was generated using the following Coccinelle script: // Use DEVICE() macros to access DeviceState.qdev @use_device_macro_to_access_qdev@ expression obj; identifier dev; @@ -&obj->dev.qdev +DEVICE(obj) Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Gerd Hoffmann --- hw/usb/dev-storage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index cd5551d94f..0e4e93ef16 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -616,7 +616,7 @@ static void usb_msd_storage_realize(USBDevice *dev, Err= or **errp) * The hack is probably a bad idea. */ blk_ref(blk); - blk_detach_dev(blk, &s->dev.qdev); + blk_detach_dev(blk, DEVICE(s)); s->conf.blk =3D NULL; =20 usb_desc_create_serial(dev); --=20 2.20.1