From nobody Tue Apr 30 06:41:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1558857651; cv=none; d=zoho.com; s=zohoarc; b=eklpQcPRwmyzJrJd5TCH9P/sbXujSnHDVUcGY0mG7VVOBV62Vv8gpTyFWEcRGKkAlcw0qZuIEo/E1j2hZNz86IhML+/+5snGvrlbjBD2vKhy72cxX6UjhtPsKM77D/nvxFi8Y7X8n/hORtFpw17nzc/mzDyfUq2djj7PZhw1C6Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558857651; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=UpAF+Bp0rIUtVnXVOisU6bkLam7XumHi/1u+zXHbgc8=; b=IeykitE5VdSJLNJPhJCU2IZ7m0ixPLYTSpYbOD00SB7ED3yXWx96vnmwaXPREio5ysgCj2LXm4/Ezc9QTnlSQwieDsbPBTg4JxbcKgPp8aTKFhp5IqsuY2sgSBoN+zgNLbGA/JWPp2CvSw5n4j1Qp2CffHHBkv4GUoquRZmQB7k= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558857651563764.0544814331761; Sun, 26 May 2019 01:00:51 -0700 (PDT) Received: from localhost ([127.0.0.1]:52122 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUo5F-0000Pq-5X for importer@patchew.org; Sun, 26 May 2019 04:00:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUo3k-0008LP-9n for qemu-devel@nongnu.org; Sun, 26 May 2019 03:59:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hUnxp-0000MJ-Vv for qemu-devel@nongnu.org; Sun, 26 May 2019 03:53:06 -0400 Received: from sonic306-46.consmr.mail.sg3.yahoo.com ([106.10.241.166]:42840) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hUnxp-0000Jr-HG for qemu-devel@nongnu.org; Sun, 26 May 2019 03:53:05 -0400 Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.sg3.yahoo.com with HTTP; Sun, 26 May 2019 07:53:02 +0000 Received: from pl35138.ag1212.nttpc.ne.jp (EHLO localhost.localdomain) ([133.232.247.66]) by smtp403.mail.sg3.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID c6670c1054cd47402857e31956aff826; Sun, 26 May 2019 07:51:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1558857182; bh=UpAF+Bp0rIUtVnXVOisU6bkLam7XumHi/1u+zXHbgc8=; h=From:To:Cc:Subject:Date:From:Subject; b=t7S8wtJxYsx9Mnixx5mnr5zFR50ObV6YfCZt3GM+J5NSteproudFe6IZq+i8ZQb4Ti3aiSkcN7QqWvYgM5bKwMg+Cudxnmg2QOc5AXMVfzJensLo8fIMl7NdFoT+YqY9i8U5FwCkYAUQt6606doO7qEi/PvZlR9AxhUdnAQFod3VzNw1dRUCocujY/g7w3BAaLxRnVPt51ds+n2aeJeTxp+g8zluNr9QAXcMkDMmbNIkKXSFt/a347Pj2pLYSsYg3eHj75kSBfEDKrmBwMM5kS1PKNFcpv68x6maVdf9WWlBw+07Nd5ZgjY9VIgMMblpDx+y4Uokbk0oLjC41AdZaA== X-YMail-OSG: 3HBsUhYVM1nIbH4P_qDpmfF8N62Ur6rbcGnwPRr6180ynbbH0KHiTdamVQiUKr4 AVOJY6281u4Gj03hByxF9c13VjuJEQY4pZROk3FyGyAmBk_yvX0XzecvbimRYQhzj3n0bXhcFbNv oWEMS8xiZWiawlyjppxgDQaJ9fH6Ci.oNeP2enO5pexMN.45xrMVHZcu3GERB7sL1_FGLT49_ryn taCdaIC8dgtBZtDUjFQMxsOaLC.WfV2kf.7xI6QbgjEhFwJcs294lTep7Eb6zIzYhthoLzNmX4lm xolFZpggmfhhSOQb5A8mA9keR1LMAeeTzVVfyChHCDfyjGdodnLXIgVmBfmYsaOA5IOogaPHxt1W _6_tUoUO1j.0WvpAMB1JkBPFiEzECnvmX2Pxi7yUvgHXn8vlErVLd9OFWSKz3akJ50.sqmt8PTa. HFdS79F5W5CTAOU_Peu48cnnK5t3XosmnPvoodc5vJaohZMQNTvXA1nrH5er22emBz8C1x3fTxlo jCD1ST1NMRa8FwE_kAv27SW7vNM7JhRQxWLzCgOC0DYC_akFj7ws2GakFnp0D7D2gPhEWGUc83Or wTZqy8Pdn8eya.lvN7SO_l3AgobTqj5vClYtoCoVF_T2mIM7Sy2mU1ObIAx93owUJAo9e3od4i1a sZJs8PRNE1dIiuX9h7p.0KvNR6Mx7LmcOA4EJVP1poha9jD_CLRVshI9pMIe0rOIya9ceU1xbes7 DQf7MZ3hZwsjgSqWwg3ICvTAO7UJmfPuUz8Q9.1NCPTdZnUZ76UEbnjd0ZE1yU8vT86xmF.m412m HekECmP.T0qSFQuqGdBd_QAcJX.VxzM42Sl6rj7EBWODPC7S37wGBdA.VK5T742zaVAWwnjiM2vG mkUCIyDQ3qq9G.9zPY.Rgw1wk2iZ6YL29Qrs3SthavxJHgil_aVxWpDKcwik_sHa8w_2E4dT7z9k UHD159PmPA7F9koRNu44B2.pW_YuNFkj1Sbl8fT6.wKCY14DgDh3m.ByWzgY4ws95DVkB9RmptnG UZsrUDR6jAg.2v8.L_Yuvwkj2TyVM_hGnlQEbpvOEL7mfzJjHPo87qeESjgnh9EIFdsTahZv47I9 M9loILmPYQB.ZZsELXp3cjwvG5yzpEnB4.1HlGPYf7qajO_N36ojDxVdEf4337vafiQpO7P7Oi8u RauH8pzlVTf_JZRW25FG8CP4S.2ZIgXOWRZtS0DO0_tJ5m5lHB3KvnIHhM7KstuwkfxDvER71jGI d3LL.taKm.yw3nw2mcKEwbhPhMNEVIX5w_tgXlg.K1nHBdjUH9KMMtQVxqHjnfG90psyJ_GfvH5I - To: qemu-devel@nongnu.org Date: Sun, 26 May 2019 16:50:56 +0900 Message-Id: <20190526075056.33865-1-lucienmp_antispam@yahoo.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 106.10.241.166 Subject: [Qemu-devel] [PATCH] Regression for m68k causing Single-Step via GDB/RSP to not single step X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lucien Murray-Pitts via Qemu-devel Reply-To: Lucien Murray-Pitts Cc: Thomas Huth , Richard Henderson , Laurent Vivier , "Emilio G . Cota" , lucienmp_antispam@yahoo.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Luc Michel Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" A regression that was introduced, with the refactor to TranslatorOps, drops two lines that update the PC when single-stepping is being performed. ( short commit 11ab74b ) This patch resolves that issue. Signed-off-by: Lucien Murray-Pitts Reviewed-by: Laurent Vivier --- target/m68k/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index f0534a4ba0..2922ea79c3 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -6130,6 +6130,8 @@ static void m68k_tr_tb_stop(DisasContextBase *dcbase,= CPUState *cpu) return; } if (dc->base.singlestep_enabled) { + update_cc_op(dc); + tcg_gen_movi_i32(QREG_PC, dc->pc); gen_helper_raise_exception(cpu_env, tcg_const_i32(EXCP_DEBUG)); return; } --=20 2.21.0