From nobody Mon Feb 9 05:40:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1558713916; cv=none; d=zoho.com; s=zohoarc; b=S2je2CHxhssTp7v/7lxqC9IbkhKAMePpbE9wtYU8ixP40GP3q2HJtk1SVYGbeeZ4T7c5iriDrukGuIn5LAsCG5mJnoARZx+UBftE7cFk/PYrDkP0vvVSSzvuvzN0ebzoK+fisbbV8VP9RLLEQtV/4/v4YNn6ScDYXn8NNoOHMcM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558713916; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=CctE0zTJnEU25JB3cn3PPMbvqOEdGic49XPgJHQGWnY=; b=a1D2iF5SvLgUTTVAoZj1D0h+PyrmPfmhp0PkLNXTvadcI1LmFNfrBs76+II8WAzBEUFSGTEA9+Jv/WPFykAGUFgSP+M6g/H48vlikT8ImTHji52NYgcZVF/tjOGib3LuYnhoHZx9IIHiy7jv/AC7TUCwiXh9F7VXu9c7dxzNChQ= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 155871391600653.18955772424465; Fri, 24 May 2019 09:05:16 -0700 (PDT) Received: from localhost ([127.0.0.1]:56841 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUCgo-0006A5-43 for importer@patchew.org; Fri, 24 May 2019 12:05:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUCdf-00044E-F3 for qemu-devel@nongnu.org; Fri, 24 May 2019 12:01:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hUCdd-00023u-Bj for qemu-devel@nongnu.org; Fri, 24 May 2019 12:01:47 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:41121) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hUCdZ-0001zT-F9 for qemu-devel@nongnu.org; Fri, 24 May 2019 12:01:43 -0400 Received: by mail-wr1-x442.google.com with SMTP id u16so6658527wrn.8 for ; Fri, 24 May 2019 09:01:40 -0700 (PDT) Received: from jondnuc.lan ([176.230.64.37]) by smtp.gmail.com with ESMTPSA id s11sm370863wro.17.2019.05.24.09.01.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 May 2019 09:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CctE0zTJnEU25JB3cn3PPMbvqOEdGic49XPgJHQGWnY=; b=WCQSpA636wewpDaVqr6fC68Sek+DcX+4tdbx+1F6rhf0wCXBRHljhLm6nPjFEprxlW ZBB1NesnDBXmvcW8LOrLROetpLD2Tc3ml38Bz+379F7ys1PzYbxJowEJV6sTCwECVojU cKmZzGDj+VWBK2VRbvvk2x2i4hKcHHcgcOmQLOZmb59OSRvPLVcrBasbtCsZQNDGCtlc Fld4GXgaax0iy03brfJlcak5TSRNWyF7uHDquREUIez6jRUeCCDW6XUfbTxfDJ5DyWbj pq+kWoh8MQBw4I0S20ypq5EHVUa0i29Dy/wYA3J++JyDZ1A6dbudNyXaT7zogzKrq27U QOEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CctE0zTJnEU25JB3cn3PPMbvqOEdGic49XPgJHQGWnY=; b=aUkoegmUq7UOR+OEkHvcPxoUf32RXqydUM742DfMy5K5G6wEuH8nnEl7PtFLOI8ZQi saSmBY8ZrF/rwVkxfpB2Ci38jsaVcClAFMrBuFan35TWH234FVXYiGKC3wn0XA3IvWdU oUQA3ZQBbKROY+YzoI3uO1BKum1T7g3/5xcZgj9SDY+zfiIoa2hkzqghwl8TA9rFQkl9 Vu0E/EsUyfX7Lc3fI5YWWMTyjnQOBXfpxcVVbgVqs4AsWjx2pk86Gt4TDecyV+5MxYT9 QSpHcypLxb0sVLetF7YiMDT33DFaleSGvL6c0jhwXcTdGkzCuaEX4388of+qzFE+dVsD boug== X-Gm-Message-State: APjAAAUNZVzf7wGXnXHhwmR4T5g97OcDmvyzxNlBoLhR+RKjtHjZRn9S lWnVuaJPdl91GxBNXv6HdlBCSoZ2 X-Google-Smtp-Source: APXvYqxVVEJT0EaZL4U1sNZEtsyrEn4n4U05CSkrZQIht6RVo7NxZrtfC1b1qk1NxLZb2bv/hZhRtQ== X-Received: by 2002:adf:e352:: with SMTP id n18mr7841515wrj.82.1558713699713; Fri, 24 May 2019 09:01:39 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Fri, 24 May 2019 19:01:06 +0300 Message-Id: <20190524160118.31134-9-arilou@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190524160118.31134-1-arilou@gmail.com> References: <20190524160118.31134-1-arilou@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH v11 08/20] gdbstub: Implement set register (P pkt) with new infra X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, Jon Doron Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Jon Doron --- gdbstub.c | 39 ++++++++++++++++++++++++++++++--------- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index c59a6765cd..1c210d671a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1637,6 +1637,27 @@ static void handle_remove_bp(GdbCmdContext *gdb_ctx,= void *user_ctx) put_packet(gdb_ctx->s, "E22"); } =20 +static void handle_set_reg(GdbCmdContext *gdb_ctx, void *user_ctx) +{ + int reg_size; + + if (!gdb_has_xml) { + put_packet(gdb_ctx->s, "E00"); + return; + } + + if (gdb_ctx->num_params !=3D 2) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + reg_size =3D strlen(gdb_ctx->params[1].data) / 2; + hextomem(gdb_ctx->mem_buf, gdb_ctx->params[1].data, reg_size); + gdb_write_register(gdb_ctx->s->g_cpu, gdb_ctx->mem_buf, + gdb_ctx->params[0].val_ull); + put_packet(gdb_ctx->s, "OK"); +} + static int gdb_handle_packet(GDBState *s, const char *line_buf) { CPUState *cpu; @@ -1881,15 +1902,15 @@ static int gdb_handle_packet(GDBState *s, const cha= r *line_buf) } break; case 'P': - if (!gdb_has_xml) - goto unknown_command; - addr =3D strtoull(p, (char **)&p, 16); - if (*p =3D=3D '=3D') - p++; - reg_size =3D strlen(p) / 2; - hextomem(mem_buf, p, reg_size); - gdb_write_register(s->g_cpu, mem_buf, addr); - put_packet(s, "OK"); + { + static const GdbCmdParseEntry set_reg_cmd_desc =3D { + .handler =3D handle_set_reg, + .cmd =3D "P", + .cmd_startswith =3D 1, + .schema =3D "L?s0" + }; + cmd_parser =3D &set_reg_cmd_desc; + } break; case 'Z': { --=20 2.21.0