From nobody Tue Feb 10 13:37:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1558704148; cv=none; d=zoho.com; s=zohoarc; b=SHbAIOtlbaZ8sXaO83qiCBA01/eWfx67JL4rdWgOFnEVKZGm43iMUS6opZ412tMyptmII3nviY+qXK02WCrEvMIkKFv8eYDO7UbbUJV9MoI89lblrFnKqOcTmYfHsHN25uA2IwcunuwesI/SJKdKDbnbhT5IueLr+zzwAaMS5mc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558704148; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=VCAtceY/SslT1MNQ6D6R1zd3LhA+n1anvK27Pgtzq9E=; b=JBRot6wK4chuNn1FzI+HagCcMYrX1di6rnZW/LRPkG4qIANveTZylnQpeGRGzaSMEDgYbDgfP93zfy1bVKRjtuU4pwbt+a0h+Gf9nidpx/U7V92XsNiqx6jnbGwrKnwh7AzoEzPeDevWCVZu+4Lxb3xFjTAuFuW/sOjkQHfYecA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558704148507267.5014684398568; Fri, 24 May 2019 06:22:28 -0700 (PDT) Received: from localhost ([127.0.0.1]:54575 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUA9N-0005t9-J1 for importer@patchew.org; Fri, 24 May 2019 09:22:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUA18-0007aL-T1 for qemu-devel@nongnu.org; Fri, 24 May 2019 09:13:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hU9yQ-0001bG-30 for qemu-devel@nongnu.org; Fri, 24 May 2019 09:11:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27858) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hU9yP-0001ax-Tj for qemu-devel@nongnu.org; Fri, 24 May 2019 09:11:02 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3133E59450 for ; Fri, 24 May 2019 13:10:56 +0000 (UTC) Received: from localhost (ovpn-112-23.ams2.redhat.com [10.36.112.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC9C07848B; Fri, 24 May 2019 13:10:55 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Fri, 24 May 2019 15:09:43 +0200 Message-Id: <20190524130946.31736-7-marcandre.lureau@redhat.com> In-Reply-To: <20190524130946.31736-1-marcandre.lureau@redhat.com> References: <20190524130946.31736-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 24 May 2019 13:10:56 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v9 6/9] spice-app: fix running when !CONFIG_OPENGL X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Gerd Hoffmann , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Do not set 'gl' parameter, fixes: qemu-system-x86_64: Invalid parameter 'gl' Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/spice-app.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/spice-app.c b/ui/spice-app.c index 925b27b708..30541b1022 100644 --- a/ui/spice-app.c +++ b/ui/spice-app.c @@ -157,9 +157,10 @@ static void spice_app_display_early_init(DisplayOption= s *opts) qemu_opt_set(qopts, "addr", sock_path, &error_abort); qemu_opt_set(qopts, "image-compression", "off", &error_abort); qemu_opt_set(qopts, "streaming-video", "off", &error_abort); +#ifdef CONFIG_OPENGL qemu_opt_set(qopts, "gl", opts->has_gl ? "on" : "off", &error_abort); display_opengl =3D opts->has_gl; - +#endif be->u.spiceport.data->fqdn =3D g_strdup("org.qemu.monitor.qmp.0"); qemu_chardev_new("org.qemu.monitor.qmp", TYPE_CHARDEV_SPICEPORT, be, NULL, &error_abort); --=20 2.22.0.rc1.1.g079e7d2849.dirty