From nobody Tue Feb 10 07:23:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1558564763; cv=none; d=zoho.com; s=zohoarc; b=Ee9JR656TKsPbJbSRxkwJ++3+NqwINZ6IbjQdM8Bopk9U20tex/w0nd37r9gPKc1LjynGidMFn8fW5xGpRQ9T0l55H1feJCkwi0iGGY7UUjoP6DukCnOw1PdPObDRLFzxrvGJR+6q29moxoz1FcBqN/X+ELESkkFbxscE9x6lik= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558564763; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=OLftcOa71o3SDWkHEvzuYmmBM81jvFAhtQKjy7MXc3g=; b=KuIP0ETSkAiWcGg3rGXsVIfiVLfF54qZbSG7HpNP3RoqK+U2AafwPlti4OH0SHQklobnZdGLUPV9RO7VyUKC02ctFkQ7sqrnyl6LyyVDlwY4agRWtV9ESn2g0ovRO0WyUW5M6BLLWGIrdO2FQNjAVQyp3zTBfA+0WziNAxKYfmw= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558564763768308.5624601874225; Wed, 22 May 2019 15:39:23 -0700 (PDT) Received: from localhost ([127.0.0.1]:52631 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTZtE-0002Ok-PJ for importer@patchew.org; Wed, 22 May 2019 18:39:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTZj4-00039v-J4 for qemu-devel@nongnu.org; Wed, 22 May 2019 18:28:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTZj3-0007RF-FV for qemu-devel@nongnu.org; Wed, 22 May 2019 18:28:46 -0400 Received: from mail-yw1-xc43.google.com ([2607:f8b0:4864:20::c43]:41249) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hTZiz-0007Mp-Np for qemu-devel@nongnu.org; Wed, 22 May 2019 18:28:43 -0400 Received: by mail-yw1-xc43.google.com with SMTP id o65so1483056ywd.8 for ; Wed, 22 May 2019 15:28:35 -0700 (PDT) Received: from localhost.localdomain ([71.46.56.17]) by smtp.gmail.com with ESMTPSA id q11sm2276453ywg.7.2019.05.22.15.28.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 May 2019 15:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OLftcOa71o3SDWkHEvzuYmmBM81jvFAhtQKjy7MXc3g=; b=uUBBJxmvsqRHbMy8XSdo6r5vF5HvwD48/t4WfqRF0g2PV7vA2RF2BKGARd+3PLeRAD 4JzeUXHypr+jbcec2ca4yxa9VNCu5NrZJSk2IVbYNLTCPi++5yE3D4//d+BrlaSM312+ UhdqRWPIH1Rwa1T1OkhEO9t6NLetYVY592p5CCgJPGnnO4hJIXdPXK2SUvM4DwvXLarz fOo8dNksT6NFut81D5N066dGNKvIX0C7XtZrzcjMPj+0/2WcYDb6QLKZUJ+mBKHKjqE/ xpSdFH4i9YjNep2b6ZBLIcvaOr4ObusdfgLDPraa3rJiHAKJd3DXrZtgCpRR4Ukfhitc fR2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=OLftcOa71o3SDWkHEvzuYmmBM81jvFAhtQKjy7MXc3g=; b=a0aYa6NUUGd0R3UFPkL96JlYEeiyFB3WD/RftvXgX5aD1zj+AMiDBvLtYpikhWmwL9 L0RcWWi8UeQ3Tmu1KOx+ixhLGDqwOYaZPJljmgj/1cR7al8aCTDRc/MSTWTmzdZeruli rWCT9NcYKRex5nrii/opib1oGnHbuGhG5yCKl3ei5YgyUzJrNzL/otQ8IBR+I4t8DADn 58mL6WtCtX8XBTEgZ8eVP3QZ88bUnCSkqbM/27yrUHrx1V60ROfeHRCxahUzwXN23mzY mfAc5JzSCtqNe2+2YhiHfT6URD4bqO4Z0TTFi+8MGsdRPb0t8/fVJpHF9JSSobLXkWWe hAww== X-Gm-Message-State: APjAAAW6la42w027q2Fb1rRNs0/IZITvWh8P6ljNyOGaJxfl1mW3+yWe Dd15Wg7rBbKUkt9+JrKXEg3O5AO0JH4= X-Google-Smtp-Source: APXvYqwnVFFk/LIWzXbUfC7yy1mlo6A/35o/Gp3RT3FWqk39mZGfGHgAToBjGJJ09PBp8fJrcpFw6g== X-Received: by 2002:a0d:ea4c:: with SMTP id t73mr42896537ywe.472.1558564114807; Wed, 22 May 2019 15:28:34 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 22 May 2019 18:28:15 -0400 Message-Id: <20190522222821.23850-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190522222821.23850-1-richard.henderson@linaro.org> References: <20190522222821.23850-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::c43 Subject: [Qemu-devel] [PULL 10/16] tcg/i386: Use umin/umax in expanding unsigned compare X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Using umin(a, b) =3D=3D a as an expansion for TCG_COND_LEU is a better alternative to (a - INT_MIN) <=3D (b - INT_MIN). Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 80 +++++++++++++++++++++++++++++---------- 1 file changed, 61 insertions(+), 19 deletions(-) diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c index 569a2c2120..6ec5e60448 100644 --- a/tcg/i386/tcg-target.inc.c +++ b/tcg/i386/tcg-target.inc.c @@ -3468,28 +3468,61 @@ static bool expand_vec_cmp_noinv(TCGType type, unsi= gned vece, TCGv_vec v0, TCGv_vec v1, TCGv_vec v2, TCGCond cond) { enum { - NEED_SWAP =3D 1, - NEED_INV =3D 2, - NEED_BIAS =3D 4 - }; - static const uint8_t fixups[16] =3D { - [0 ... 15] =3D -1, - [TCG_COND_EQ] =3D 0, - [TCG_COND_NE] =3D NEED_INV, - [TCG_COND_GT] =3D 0, - [TCG_COND_LT] =3D NEED_SWAP, - [TCG_COND_LE] =3D NEED_INV, - [TCG_COND_GE] =3D NEED_SWAP | NEED_INV, - [TCG_COND_GTU] =3D NEED_BIAS, - [TCG_COND_LTU] =3D NEED_BIAS | NEED_SWAP, - [TCG_COND_LEU] =3D NEED_BIAS | NEED_INV, - [TCG_COND_GEU] =3D NEED_BIAS | NEED_SWAP | NEED_INV, + NEED_INV =3D 1, + NEED_SWAP =3D 2, + NEED_BIAS =3D 4, + NEED_UMIN =3D 8, + NEED_UMAX =3D 16, }; TCGv_vec t1, t2; uint8_t fixup; =20 - fixup =3D fixups[cond & 15]; - tcg_debug_assert(fixup !=3D 0xff); + switch (cond) { + case TCG_COND_EQ: + case TCG_COND_GT: + fixup =3D 0; + break; + case TCG_COND_NE: + case TCG_COND_LE: + fixup =3D NEED_INV; + break; + case TCG_COND_LT: + fixup =3D NEED_SWAP; + break; + case TCG_COND_GE: + fixup =3D NEED_SWAP | NEED_INV; + break; + case TCG_COND_LEU: + if (vece <=3D MO_32) { + fixup =3D NEED_UMIN; + } else { + fixup =3D NEED_BIAS | NEED_INV; + } + break; + case TCG_COND_GTU: + if (vece <=3D MO_32) { + fixup =3D NEED_UMIN | NEED_INV; + } else { + fixup =3D NEED_BIAS; + } + break; + case TCG_COND_GEU: + if (vece <=3D MO_32) { + fixup =3D NEED_UMAX; + } else { + fixup =3D NEED_BIAS | NEED_SWAP | NEED_INV; + } + break; + case TCG_COND_LTU: + if (vece <=3D MO_32) { + fixup =3D NEED_UMAX | NEED_INV; + } else { + fixup =3D NEED_BIAS | NEED_SWAP; + } + break; + default: + g_assert_not_reached(); + } =20 if (fixup & NEED_INV) { cond =3D tcg_invert_cond(cond); @@ -3500,7 +3533,16 @@ static bool expand_vec_cmp_noinv(TCGType type, unsig= ned vece, TCGv_vec v0, } =20 t1 =3D t2 =3D NULL; - if (fixup & NEED_BIAS) { + if (fixup & (NEED_UMIN | NEED_UMAX)) { + t1 =3D tcg_temp_new_vec(type); + if (fixup & NEED_UMIN) { + tcg_gen_umin_vec(vece, t1, v1, v2); + } else { + tcg_gen_umax_vec(vece, t1, v1, v2); + } + v2 =3D t1; + cond =3D TCG_COND_EQ; + } else if (fixup & NEED_BIAS) { t1 =3D tcg_temp_new_vec(type); t2 =3D tcg_temp_new_vec(type); tcg_gen_dupi_vec(vece, t2, 1ull << ((8 << vece) - 1)); --=20 2.17.1