From nobody Mon Feb 9 19:04:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1558533007; cv=none; d=zoho.com; s=zohoarc; b=Bv0OB3Z4bz/Z9ASPOnqIimNCyrMN5ZPOrbTCw7jby+lAz3cARNnuAQLjFJI1hKinc+husrPe4iTYcG2LeHVAXfD6pzIYuUZ4uKPkzoCs8H68EvKerrLM5W6Wxb8aftKd6P1Iu70WOM+wpQACebisuxeukhltjrvEso4DNJWWee0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558533007; h=Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Q2asl/GDbj3gJM8BuLxosEuUPigjqoT4uH7tXW6tnNE=; b=OceUnR2xA4732RvDAKoAalK+020MxO7KzKtykrw9aqwQjRI7n0MvuSxuKJLzsGGLN4ImhVngLr+Hm3lKNzHvhmxauyu27YIPQG6pR3cF2qUBmI08SS2EurS4ayVfOnGlqnIY2HpjABSkFVARXD9Yu2TRtlJQxi60lGeuhDL2NQQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558533007832456.2190381033282; Wed, 22 May 2019 06:50:07 -0700 (PDT) Received: from localhost ([127.0.0.1]:43656 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTRcx-00084g-OB for importer@patchew.org; Wed, 22 May 2019 09:49:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTRac-0006sR-PY for qemu-devel@nongnu.org; Wed, 22 May 2019 09:47:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTRab-0002bG-RQ for qemu-devel@nongnu.org; Wed, 22 May 2019 09:47:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49510) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTRab-0002aI-MI for qemu-devel@nongnu.org; Wed, 22 May 2019 09:47:29 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5C807C0528B3 for ; Wed, 22 May 2019 13:47:28 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-28.ams2.redhat.com [10.36.116.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2C7627839C for ; Wed, 22 May 2019 13:47:28 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id CF0FC1132BB6; Wed, 22 May 2019 15:47:26 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Wed, 22 May 2019 15:47:22 +0200 Message-Id: <20190522134726.19225-2-armbru@redhat.com> In-Reply-To: <20190522134726.19225-1-armbru@redhat.com> References: <20190522134726.19225-1-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 22 May 2019 13:47:28 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 1/5] qemu-bridge-helper: Fix misuse of isspace() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" parse_acl_file() passes char values to isspace(). Undefined behavior when the value is negative. Not a security issue, because the characters come from trusted $prefix/etc/qemu/bridge.conf and the files it includes. Furthermore, isspace()'s locale-dependence means qemu-bridge-helper uses the user's locale for parsing $prefix/etc/bridge.conf. Feels wrong. Use g_ascii_isspace() instead. This fixes the undefined behavior, and makes parsing of $prefix/etc/bridge.conf locale-independent. Signed-off-by: Markus Armbruster Message-Id: <20190514180311.16028-2-armbru@redhat.com> --- qemu-bridge-helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c index 5396fbfbb6..f9940deefd 100644 --- a/qemu-bridge-helper.c +++ b/qemu-bridge-helper.c @@ -75,7 +75,7 @@ static int parse_acl_file(const char *filename, ACLList *= acl_list) char *ptr =3D line; char *cmd, *arg, *argend; =20 - while (isspace(*ptr)) { + while (g_ascii_isspace(*ptr)) { ptr++; } =20 @@ -99,12 +99,12 @@ static int parse_acl_file(const char *filename, ACLList= *acl_list) =20 *arg =3D 0; arg++; - while (isspace(*arg)) { + while (g_ascii_isspace(*arg)) { arg++; } =20 argend =3D arg + strlen(arg); - while (arg !=3D argend && isspace(*(argend - 1))) { + while (arg !=3D argend && g_ascii_isspace(*(argend - 1))) { argend--; } *argend =3D 0; --=20 2.17.2