From nobody Tue Feb 10 10:54:44 2026 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1558502042; cv=none; d=zoho.com; s=zohoarc; b=DfrG8qkj+IJP2m4f0/oBcquXQqaoYAHQ7aacU8VT11qXwyU3EOeibyxTMLcq2MlV3GCzu3Pr177ZEc1WNBZWdI6UPcijntPhrmELb44UjZofJyQkS58XhiHd2NuoQXVFCHjuQgTmkeCfgoSlXQZ4shVNJjWXgje/r8/wSQEKPmc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558502042; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=TxEG/FX3+V3w/K94VMSiZYmrruvxb62vbpep1FzZZEc=; b=Ypu6JMjX5ELP+/15Q3SE5s4obI+k/ju4kLhS5/eRSmcmoHCcu0+9Vnd735gdPvH66b5g585NABR4dCI5tb9VSkUZdcW+Uek6RFTD0GRUF9jLl2eCbjUD7f7o92T3getgYc/klnDz0cRFFbUpgfOt7VDwpbhRZJV3chZuCHvy9FM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558502042537663.1744990557132; Tue, 21 May 2019 22:14:02 -0700 (PDT) Received: from localhost ([127.0.0.1]:36138 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTJZT-0001m3-DF for importer@patchew.org; Wed, 22 May 2019 01:13:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTJ9G-0003h0-Vc for qemu-devel@nongnu.org; Wed, 22 May 2019 00:46:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTJ9F-0006u0-Vq for qemu-devel@nongnu.org; Wed, 22 May 2019 00:46:42 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:49525 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTJ9F-0006fC-Jf; Wed, 22 May 2019 00:46:41 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4580Sx1Mmhz9sPH; Wed, 22 May 2019 14:46:06 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1558500369; bh=ytv6+2Za7txhjhng8BTf4vmasxIQT6D/X9uDYVn1uXM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d9w2HkJ81urKY9BOVoUcAekuipanQDJF5DkXGX6ng4DLlvRS788c/zWBS4QwQdniQ SnypYaHFmE1F3D+fcPANNpD5/4ai+vnAD/zKN79aE00bEsVnxWTOJL3u/VZ1Tu+fx4 MEDbxMx8NE+LGZEDMxpFkOTjHd79x0fjK2xkzARU= From: David Gibson To: peter.maydell@linaro.org Date: Wed, 22 May 2019 14:45:35 +1000 Message-Id: <20190522044600.16534-14-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190522044600.16534-1-david@gibson.dropbear.id.au> References: <20190522044600.16534-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 13/38] spapr/xive: EQ page should be naturally aligned X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: C=C3=A9dric Le Goater When the OS configures the EQ page in which to receive event notifications from the XIVE interrupt controller, the page should be naturally aligned. Add this check. Signed-off-by: C=C3=A9dric Le Goater Message-Id: <20190508171946.657-2-clg@kaod.org> Reviewed-by: Greg Kurz [dwg: Minor change for printf warning on some platforms] Signed-off-by: David Gibson --- hw/intc/spapr_xive.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/intc/spapr_xive.c b/hw/intc/spapr_xive.c index 097f88d460..33da1a52c6 100644 --- a/hw/intc/spapr_xive.c +++ b/hw/intc/spapr_xive.c @@ -993,6 +993,12 @@ static target_ulong h_int_set_queue_config(PowerPCCPU = *cpu, case 16: case 21: case 24: + if (!QEMU_IS_ALIGNED(qpage, 1ul << qsize)) { + qemu_log_mask(LOG_GUEST_ERROR, "XIVE: EQ @0x%" HWADDR_PRIx + " is not naturally aligned with %" HWADDR_PRIx "= \n", + qpage, (hwaddr)1 << qsize); + return H_P4; + } end.w2 =3D cpu_to_be32((qpage >> 32) & 0x0fffffff); end.w3 =3D cpu_to_be32(qpage & 0xffffffff); end.w0 |=3D cpu_to_be32(END_W0_ENQUEUE); --=20 2.21.0