From nobody Tue Feb 10 10:54:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1558501266; cv=none; d=zoho.com; s=zohoarc; b=Qfsq1UTYJC4ws02hXbzwOl9t2J9gavxumiwbg83WQsGZb5gD2kRZ29bLMpGgohdwuPETZfnXQA5hE7pqjuDgKLWQ0Mrk+f8hutu+IfWMLREkuWuo8ks7KGCFbiN0y4WY58I7+WetDUzwVCqCYQBIk2tEvcd7XaWWlzE0MN2txGM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558501266; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=bY4AL42/Ctl9m7ycvESHYbA1KkBxcf0GBeZjoDpRVGs=; b=UoAtZ5BZnATCMtZlRt1J4Nk2nFv9VE+MhUN/oxv4EEbQ8PP3DNUG4dk4+S0Nync0WiT0rfW01PwOg/A1q6idMFxsc6CrUGPB6UW56aFVLtpmC2j68kR9DnQopL8s42dxUVE0B+B4tuV8tN8HPT4A5Su9I4sT0LxafXUJE3elT5g= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558501266047197.80249114424055; Tue, 21 May 2019 22:01:06 -0700 (PDT) Received: from localhost ([127.0.0.1]:35938 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTJN0-0007Zs-3f for importer@patchew.org; Wed, 22 May 2019 01:00:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTJ8t-0003Mb-8A for qemu-devel@nongnu.org; Wed, 22 May 2019 00:46:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTJ8r-0006eg-PH for qemu-devel@nongnu.org; Wed, 22 May 2019 00:46:19 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:33713 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hTJ8r-0006b5-AX; Wed, 22 May 2019 00:46:17 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4580St52wRz9sNp; Wed, 22 May 2019 14:46:06 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1558500366; bh=ixFuCpsnBZYHkeYrLQ26Rb+EWQNCUX6wDdO2BVyDFVs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h2WSU0hRoMbUi8RCeZ9pUoGJeEGc5ONGGZo3oghFDgqvJnHEKJYSm94AUsBHjkSxK j5bugBMiDl1n9DOk+Ec/Qv1LUFZy7LeA/h2ny3eZdFRTXXnnnp7AtlFsLuSa4qVBvk BJyldFC3tnWfyz9Cz+zy9OeYNl+a6w9zNXmPo42A= From: David Gibson To: peter.maydell@linaro.org Date: Wed, 22 May 2019 14:45:32 +1000 Message-Id: <20190522044600.16534-11-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190522044600.16534-1-david@gibson.dropbear.id.au> References: <20190522044600.16534-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 10/38] target/ppc: Fix vslv and vsrv X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, Anton Blanchard , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Anton Blanchard vslv and vsrv are broken on little endian, we append 00 to the high byte not the low byte. Fix it by using the VsrB() accessor. Signed-off-by: Anton Blanchard Message-Id: <20190507004811.29968-6-anton@ozlabs.org> Signed-off-by: David Gibson --- target/ppc/int_helper.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c index f6a088ac08..fd715b4076 100644 --- a/target/ppc/int_helper.c +++ b/target/ppc/int_helper.c @@ -1800,10 +1800,10 @@ void helper_vslv(ppc_avr_t *r, ppc_avr_t *a, ppc_av= r_t *b) =20 size =3D ARRAY_SIZE(r->u8); for (i =3D 0; i < size; i++) { - shift =3D b->u8[i] & 0x7; /* extract shift value */ - bytes =3D (a->u8[i] << 8) + /* extract adjacent bytes = */ - (((i + 1) < size) ? a->u8[i + 1] : 0); - r->u8[i] =3D (bytes << shift) >> 8; /* shift and store result */ + shift =3D b->VsrB(i) & 0x7; /* extract shift value */ + bytes =3D (a->VsrB(i) << 8) + /* extract adjacent bytes = */ + (((i + 1) < size) ? a->VsrB(i + 1) : 0); + r->VsrB(i) =3D (bytes << shift) >> 8; /* shift and store result = */ } } =20 @@ -1818,10 +1818,10 @@ void helper_vsrv(ppc_avr_t *r, ppc_avr_t *a, ppc_av= r_t *b) * order will guarantee that computed result is not fed back. */ for (i =3D ARRAY_SIZE(r->u8) - 1; i >=3D 0; i--) { - shift =3D b->u8[i] & 0x7; /* extract shift value */ - bytes =3D ((i ? a->u8[i - 1] : 0) << 8) + a->u8[i]; + shift =3D b->VsrB(i) & 0x7; /* extract shift value */ + bytes =3D ((i ? a->VsrB(i - 1) : 0) << 8) + a->VsrB(i); /* extract adjacent bytes = */ - r->u8[i] =3D (bytes >> shift) & 0xFF; /* shift and store resul= t */ + r->VsrB(i) =3D (bytes >> shift) & 0xFF; /* shift and store resul= t */ } } =20 --=20 2.21.0