From nobody Mon Feb 9 14:05:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1558366332; cv=none; d=zoho.com; s=zohoarc; b=MyQaLf9YNKE0YKoJEib0dL2+GATGeMrxaBWHFxymqQk87FpCjSaIXd6Wr8q761B3GevDG26fm2T87BAJJllvTvyu9lV6zXUe5z2nD0migREt0iBuyFU/BddkRpbEDvbJiLiO+gEh2VpVo3Od58lXW3HqVVbEWcLw05brSfy5lVs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558366332; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=C++gch5+PTKE4I/wDsrfL7X6jGFa+HevsnMQ/RPYofM=; b=EIGvl5Nf3ljELtC+JWJ8cUvpu+DFopAsXlqEKXE8XIPiljRRnqiy70WsjWiGpMe5HQje6KQl89lEupRzLoVJIWJnkwBbTE+KDAJQm2BFZk0/B1/eKmQgkgK45g58eRerAkvqg04HF3/GD0JmNpM6HkbA1zwMighoZiwweWpc39o= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558366332254157.40236857712944; Mon, 20 May 2019 08:32:12 -0700 (PDT) Received: from localhost ([127.0.0.1]:37259 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSkGb-0002MB-9x for importer@patchew.org; Mon, 20 May 2019 11:31:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSkEJ-0000rT-Td for qemu-devel@nongnu.org; Mon, 20 May 2019 11:29:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSkEH-0004XT-Sk for qemu-devel@nongnu.org; Mon, 20 May 2019 11:29:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43586) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hSkEF-0004Uw-Ki; Mon, 20 May 2019 11:29:31 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 480375D61E; Mon, 20 May 2019 15:29:25 +0000 (UTC) Received: from thinkpad.redhat.com (unknown [10.40.205.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id CA42219C68; Mon, 20 May 2019 15:29:22 +0000 (UTC) From: Laurent Vivier To: qemu-devel@nongnu.org Date: Mon, 20 May 2019 17:29:21 +0200 Message-Id: <20190520152921.15959-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 20 May 2019 15:29:25 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] numa: improve cpu hotplug error message with a wrong node-id X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Igor Mammedov , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" On pseries, core-ids are strongly binded to a node-id by the command line option. If a user tries to add a CPU to the wrong node, he has an error but it is not really helpful: qemu-system-ppc64 ... -smp 1,maxcpus=3D64,cores=3D1,threads=3D1,sockets= =3D1 \ -numa node,nodeid=3D0 -numa node,nodeid=3D1 ... (qemu) device_add power9_v2.0-spapr-cpu-core,core-id=3D30,node-id=3D1 Error: node-id=3D1 must match numa node specified with -numa option This patch improves this error message by giving to the user the good node-id to use with the core-id he's providing: Error: core-id 30 can only be plugged into node-id 0 Signed-off-by: Laurent Vivier --- numa.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/numa.c b/numa.c index 3875e1efda3a..c419c5b5b8ee 100644 --- a/numa.c +++ b/numa.c @@ -470,8 +470,9 @@ void numa_cpu_pre_plug(const CPUArchId *slot, DeviceSta= te *dev, Error **errp) "node-id", errp); } } else if (node_id !=3D slot->props.node_id) { - error_setg(errp, "node-id=3D%d must match numa node specified " - "with -numa option", node_id); + error_setg(errp, + "core-id %"PRId64" can only be plugged into node-id %"P= RId64, + slot->props.core_id, slot->props.node_id); } } =20 --=20 2.20.1