From nobody Mon Nov 10 19:09:08 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1558322383; cv=none; d=zoho.com; s=zohoarc; b=g24jyT8jGdaOhzGtaF+KKrIhTsnuNuo7CuXcTS3/eCGx++VKwg9W/RKA1/6WrQE8RkTRLQeMXGcjhqlD7KpGnmf8Hgs+q6RM8Tqqjigc/7b9NZsXdCqNDc++IAr4xJelEgtWZQASHsZiEGUkqJOFa6w3iH7HIwiIUudjoOLOIi4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558322383; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=og20E3wdbANUmZCjUQ92SPPWgafJrnViwGppUA3nhJU=; b=dCh8vDGKBtwJemVUUnS2hAYaJidTef14tmL8A6Px6JlD0KouwT3pXV//e09N1vfu6EfCsHgorTIYjTkf+p2HIfGem4kNuQcEsa4sGOU1yZtAtpQD3jtOHRCFImPejqXV4gWUUr/AvMwhErxnRfoZb+lVoJSYNxu1I9N69ULR6/U= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558322383613697.8674329468882; Sun, 19 May 2019 20:19:43 -0700 (PDT) Received: from localhost ([127.0.0.1]:57101 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSYpt-0001iH-FY for importer@patchew.org; Sun, 19 May 2019 23:19:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSYfr-00026C-6W for qemu-devel@nongnu.org; Sun, 19 May 2019 23:09:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSYfq-0001jj-8k for qemu-devel@nongnu.org; Sun, 19 May 2019 23:09:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36718) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hSYfq-0001iw-10 for qemu-devel@nongnu.org; Sun, 19 May 2019 23:09:14 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5BE288667D for ; Mon, 20 May 2019 03:09:13 +0000 (UTC) Received: from xz-x1.nay.redhat.com (dhcp-15-205.nay.redhat.com [10.66.15.205]) by smtp.corp.redhat.com (Postfix) with ESMTP id 42EB41001E73; Mon, 20 May 2019 03:09:11 +0000 (UTC) From: Peter Xu To: qemu-devel@nongnu.org Date: Mon, 20 May 2019 11:08:33 +0800 Message-Id: <20190520030839.6795-10-peterx@redhat.com> In-Reply-To: <20190520030839.6795-1-peterx@redhat.com> References: <20190520030839.6795-1-peterx@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 20 May 2019 03:09:13 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 09/15] kvm: Update comments for sync_dirty_bitmap X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Paolo Bonzini , "Dr . David Alan Gilbert" , peterx@redhat.com, Juan Quintela Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" It's obviously obsolete. Do some update. Signed-off-by: Peter Xu --- accel/kvm/kvm-all.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 524c4ddfbd..b686531586 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -473,13 +473,13 @@ static int kvm_get_dirty_pages_log_range(MemoryRegion= Section *section, #define ALIGN(x, y) (((x)+(y)-1) & ~((y)-1)) =20 /** - * kvm_physical_sync_dirty_bitmap - Grab dirty bitmap from kernel space - * This function updates qemu's dirty bitmap using - * memory_region_set_dirty(). This means all bits are set - * to dirty. + * kvm_physical_sync_dirty_bitmap - Sync dirty bitmap from kernel space * - * @start_add: start of logged region. - * @end_addr: end of logged region. + * This function will first try to fetch dirty bitmap from the kernel, + * and then updates qemu's dirty bitmap. + * + * @kml: the KVM memory listener object + * @section: the memory section to sync the dirty bitmap with */ static int kvm_physical_sync_dirty_bitmap(KVMMemoryListener *kml, MemoryRegionSection *section) --=20 2.17.1