From nobody Mon Nov 10 19:47:08 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1558206757; cv=none; d=zoho.com; s=zohoarc; b=nOyqpzoOSHt63cNol1BIXrCLeZzh9wDhMI8WSprIs/oJzG5LuxqQkjKLWlJcwo2vW/ZXMcRugZHsdiE8SMpD4UI/x4WSwMGIq5XU+IfJ6ryR1QVpayujmHCbQOXoZhlmHybg1z6GezCtkvNgQ03eIEFrtYXaqH2nhArgcZqAp3A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558206757; h=Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=OLftcOa71o3SDWkHEvzuYmmBM81jvFAhtQKjy7MXc3g=; b=CWwn/Okvfep8bMFVMPKHA/P/jz2WdmQIOXpS7BMLNdp3lNOhkAuVVTTWvGKqFp0+jR4/VN5BppQUZNpdIlnDg1k7UTL5mJigOsvvP63FsBXfnLhyT7qiPB2XDuQj/HgwD7ZrqgyI42R6TVgsJe87kBY1H6/LWF4tXAro6mM5r6U= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558206757606745.0261438081325; Sat, 18 May 2019 12:12:37 -0700 (PDT) Received: from localhost ([127.0.0.1]:37679 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hS4kf-0000qe-Lu for importer@patchew.org; Sat, 18 May 2019 15:12:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hS4dP-0002lS-9E for qemu-devel@nongnu.org; Sat, 18 May 2019 15:04:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hS4b1-0002i6-JQ for qemu-devel@nongnu.org; Sat, 18 May 2019 15:02:17 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:34613) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hS4b0-0002hS-Bm for qemu-devel@nongnu.org; Sat, 18 May 2019 15:02:14 -0400 Received: by mail-pf1-x443.google.com with SMTP id n19so5269639pfa.1 for ; Sat, 18 May 2019 12:02:14 -0700 (PDT) Received: from localhost.localdomain (97-113-13-231.tukw.qwest.net. [97.113.13.231]) by smtp.gmail.com with ESMTPSA id m9sm2751274pgd.23.2019.05.18.12.02.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 May 2019 12:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=OLftcOa71o3SDWkHEvzuYmmBM81jvFAhtQKjy7MXc3g=; b=p/RQnUV5OvLoa08tg1eiYyRAFDHUcJ9wsisxXqmYbKQxz3Ro3VtXEpwq92DYEnyjFa 0jC1GTaD8xdDI4CHDwDqhPLwjBQsNtoHF7DLz8vQYRmIBbw7j9zTTCZnJODd/rOnc+Ea 0DPub1POc9Ie7g4+FC2130BiQU3skP845wCYJjxxlrP+ZuvMYQ01U2iFfTpVw4xuaX+8 pHOJXgW87ZF/vzTu5utNFA13disk+Y9Pg5ZCZ9UnTzJgnKkVyG+O/trZW/CmIiQVGBKs yr8FdfbDo5teXICWo4PzsgP+sOzco3YmWzFl8mQQvcKDxdQtFjkT2IpZ6+7kdJyVGNeU t1bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=OLftcOa71o3SDWkHEvzuYmmBM81jvFAhtQKjy7MXc3g=; b=RaYm79eS00mTizjqjJ3Ppz8Yl2pKLbluum6jGsSyS2B5dJN/yr59zXw85x3cBnN8/I gqBVdoYr+qglHD5pt7chAVrA6hfo6SfKpe/5RyggBQCiU7ZsNFKe8yHlACTGxVBAjmG9 uko3ExSx4B0KZBuylj0TqjO9pSaqfZATB4/Ih8qIdWq9qjscIs3IQuzKkClfFEkJ7Uh8 C5Kptd6dnurFsYDtqs2A0s8rfAe3bpYiwHeqA4Z/f3qSmN/7SIaEFYMyiIl7MIYuJEa7 yqn5m9mz3t2sjrhu3heDMWUPXmFQJeGWTmGNbB1K44j4umgz8Wkx4kGST5nEPvynF5PT XtAQ== X-Gm-Message-State: APjAAAUj1cNrLKfNq1oYg2BC87/2GFqjC/WT8csLIPn0IZFLiHgMD5Tv P8SmFVHUdalvPEcf7tDSOYeJGOIf1HE= X-Google-Smtp-Source: APXvYqwN2HnM/CD1gHQM9OWHU6RDZyAGSTuy6UVEcbbghCyN1Nxj8Ifoh2wcL000x8fq6M3344P26g== X-Received: by 2002:a63:1c4:: with SMTP id 187mr38120757pgb.317.1558206133167; Sat, 18 May 2019 12:02:13 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sat, 18 May 2019 12:01:51 -0700 Message-Id: <20190518190157.21255-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190518190157.21255-1-richard.henderson@linaro.org> References: <20190518190157.21255-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::443 Subject: [Qemu-devel] [PATCH 10/16] tcg/i386: Use umin/umax in expanding unsigned compare X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Using umin(a, b) =3D=3D a as an expansion for TCG_COND_LEU is a better alternative to (a - INT_MIN) <=3D (b - INT_MIN). Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 80 +++++++++++++++++++++++++++++---------- 1 file changed, 61 insertions(+), 19 deletions(-) diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c index 569a2c2120..6ec5e60448 100644 --- a/tcg/i386/tcg-target.inc.c +++ b/tcg/i386/tcg-target.inc.c @@ -3468,28 +3468,61 @@ static bool expand_vec_cmp_noinv(TCGType type, unsi= gned vece, TCGv_vec v0, TCGv_vec v1, TCGv_vec v2, TCGCond cond) { enum { - NEED_SWAP =3D 1, - NEED_INV =3D 2, - NEED_BIAS =3D 4 - }; - static const uint8_t fixups[16] =3D { - [0 ... 15] =3D -1, - [TCG_COND_EQ] =3D 0, - [TCG_COND_NE] =3D NEED_INV, - [TCG_COND_GT] =3D 0, - [TCG_COND_LT] =3D NEED_SWAP, - [TCG_COND_LE] =3D NEED_INV, - [TCG_COND_GE] =3D NEED_SWAP | NEED_INV, - [TCG_COND_GTU] =3D NEED_BIAS, - [TCG_COND_LTU] =3D NEED_BIAS | NEED_SWAP, - [TCG_COND_LEU] =3D NEED_BIAS | NEED_INV, - [TCG_COND_GEU] =3D NEED_BIAS | NEED_SWAP | NEED_INV, + NEED_INV =3D 1, + NEED_SWAP =3D 2, + NEED_BIAS =3D 4, + NEED_UMIN =3D 8, + NEED_UMAX =3D 16, }; TCGv_vec t1, t2; uint8_t fixup; =20 - fixup =3D fixups[cond & 15]; - tcg_debug_assert(fixup !=3D 0xff); + switch (cond) { + case TCG_COND_EQ: + case TCG_COND_GT: + fixup =3D 0; + break; + case TCG_COND_NE: + case TCG_COND_LE: + fixup =3D NEED_INV; + break; + case TCG_COND_LT: + fixup =3D NEED_SWAP; + break; + case TCG_COND_GE: + fixup =3D NEED_SWAP | NEED_INV; + break; + case TCG_COND_LEU: + if (vece <=3D MO_32) { + fixup =3D NEED_UMIN; + } else { + fixup =3D NEED_BIAS | NEED_INV; + } + break; + case TCG_COND_GTU: + if (vece <=3D MO_32) { + fixup =3D NEED_UMIN | NEED_INV; + } else { + fixup =3D NEED_BIAS; + } + break; + case TCG_COND_GEU: + if (vece <=3D MO_32) { + fixup =3D NEED_UMAX; + } else { + fixup =3D NEED_BIAS | NEED_SWAP | NEED_INV; + } + break; + case TCG_COND_LTU: + if (vece <=3D MO_32) { + fixup =3D NEED_UMAX | NEED_INV; + } else { + fixup =3D NEED_BIAS | NEED_SWAP; + } + break; + default: + g_assert_not_reached(); + } =20 if (fixup & NEED_INV) { cond =3D tcg_invert_cond(cond); @@ -3500,7 +3533,16 @@ static bool expand_vec_cmp_noinv(TCGType type, unsig= ned vece, TCGv_vec v0, } =20 t1 =3D t2 =3D NULL; - if (fixup & NEED_BIAS) { + if (fixup & (NEED_UMIN | NEED_UMAX)) { + t1 =3D tcg_temp_new_vec(type); + if (fixup & NEED_UMIN) { + tcg_gen_umin_vec(vece, t1, v1, v2); + } else { + tcg_gen_umax_vec(vece, t1, v1, v2); + } + v2 =3D t1; + cond =3D TCG_COND_EQ; + } else if (fixup & NEED_BIAS) { t1 =3D tcg_temp_new_vec(type); t2 =3D tcg_temp_new_vec(type); tcg_gen_dupi_vec(vece, t2, 1ull << ((8 << vece) - 1)); --=20 2.17.1