From nobody Mon Nov 10 17:59:13 2025 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1558165226; cv=none; d=zoho.com; s=zohoarc; b=h0NpGLgDGLjN0qsrYFkOcyOs6VlF/kZr2wZRfFtCl1QgxyHtc3bDx+YpxhQsfekti8V3J0yF3DanPpbp3okCGv8NH+R/46Opxf+2aTjFXm4CXHD7PC8XkyVP0v5WKIhMa0MErs4JROzPy65HyWPj6uDGc7/i2GSsQIFvFUl9UcA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558165226; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=IExzVhFlgcwx/L7n7YK9q810tdTEzcxUPC5nHbRvzW4=; b=Tvfzg/KSuavMYQLxlwWQ8cw+uerNBfpgqIaLQmAIlRwkN/PHZTWOfKSQxuyO2YFEERWB983r7AU90k+zhOo7U9MNUxjrccmpnDUQi6Yvh5pc7PunxSUAHZSBdIxj5ZgZw0d6FepltwLyGQC+yHCEk6GvKx+1Q/Njz/5ygV06/s4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558165226001393.1507306465487; Sat, 18 May 2019 00:40:26 -0700 (PDT) Received: from localhost ([127.0.0.1]:58895 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRtww-0004HI-Qj for importer@patchew.org; Sat, 18 May 2019 03:40:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRtw2-0003xQ-Nw for qemu-devel@nongnu.org; Sat, 18 May 2019 03:39:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRtw1-0005ST-UR for qemu-devel@nongnu.org; Sat, 18 May 2019 03:39:14 -0400 Received: from charlie.dont.surf ([128.199.63.193]:43036) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRtvz-0005PC-Lj; Sat, 18 May 2019 03:39:11 -0400 Received: from apples.localdomain (ip-5-186-120-196.cgn.fibianet.dk [5.186.120.196]) by charlie.dont.surf (Postfix) with ESMTPSA id A7E38BF659; Sat, 18 May 2019 07:39:10 +0000 (UTC) From: Klaus Birkelund Jensen To: qemu-block@nongnu.org Date: Sat, 18 May 2019 09:39:05 +0200 Message-Id: <20190518073905.17178-1-klaus@birkelund.eu> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 128.199.63.193 Subject: [Qemu-devel] [PATCH] nvme: fix copy direction in DMA reads going to CMB X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Kevin Wolf , "Heitke, Kenneth" , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" `nvme_dma_read_prp` erronously used `qemu_iovec_*to*_buf` instead of `qemu_iovec_*from*_buf` when the request involved the controller memory buffer. Signed-off-by: Klaus Birkelund Jensen Reviewed-by: Kenneth Heitke --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 7caf92532a09..63a5b58849fb 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -238,7 +238,7 @@ static uint16_t nvme_dma_read_prp(NvmeCtrl *n, uint8_t = *ptr, uint32_t len, } qemu_sglist_destroy(&qsg); } else { - if (unlikely(qemu_iovec_to_buf(&iov, 0, ptr, len) !=3D len)) { + if (unlikely(qemu_iovec_from_buf(&iov, 0, ptr, len) !=3D len)) { trace_nvme_err_invalid_dma(); status =3D NVME_INVALID_FIELD | NVME_DNR; } --=20 2.21.0