From nobody Mon Feb 9 18:04:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1558118294; cv=none; d=zoho.com; s=zohoarc; b=k2UKMCZ2+B3Suap/Q1O7GYafwWy0FqxG2rUFUzDB+gnXURFZt1rKHGB4WpvtihxY0WHkV/BrlYgWBRGDy1OIaqdAU/MjJ66mlbRrSC8Ew/YLUuANQHL7+qPTPa+qFpK6Mr1yFU1a183UOKj9D9FFW2UPPJoJ0SWKQj0gx26JU3A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558118294; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=zqF3fUNY8zwKpff7f854HJ1G/nB7KIq48Nmnds9egto=; b=lyfgcZEpze7QuiDj/U/bRE963A0tmE7QiNhttM0wQVLkw0I4u/iu2IHeDrMXZJYKdjHNvlpfw+e+S8Fc6ZHEXmWHe7wNP6E2t53NJsW/nrG7J35yyrc/0dS47INNnSUQTjnZ/Tydn+QU/2u28P/P/sHwrWTgzD5epzXvuJ9iqGs= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558118294451825.4315998752672; Fri, 17 May 2019 11:38:14 -0700 (PDT) Received: from localhost ([127.0.0.1]:52347 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRhk2-0007kS-Bk for importer@patchew.org; Fri, 17 May 2019 14:38:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRhfE-00046S-DP for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRhfD-0006Hc-F1 for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:04 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58922) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRhfD-0006FV-3c for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:03 -0400 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4HIMOih070291 for ; Fri, 17 May 2019 14:33:01 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2sj0wbkaqn-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 17 May 2019 14:33:00 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 17 May 2019 19:32:58 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 17 May 2019 19:32:56 +0100 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x4HIWt5c33292444 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 May 2019 18:32:55 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 71DB7A4060; Fri, 17 May 2019 18:32:55 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5F97DA405F; Fri, 17 May 2019 18:32:55 +0000 (GMT) Received: from smtp.lab.toulouse-stg.fr.ibm.com (unknown [9.101.4.1]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 17 May 2019 18:32:55 +0000 (GMT) Received: from bahia.ibmuc.com (sig-9-145-156-103.de.ibm.com [9.145.156.103]) by smtp.lab.toulouse-stg.fr.ibm.com (Postfix) with ESMTP id D6C0722019A; Fri, 17 May 2019 20:32:54 +0200 (CEST) From: Greg Kurz To: qemu-devel@nongnu.org Date: Fri, 17 May 2019 20:32:35 +0200 X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190517183240.689188-1-groug@kaod.org> References: <20190517183240.689188-1-groug@kaod.org> X-TM-AS-GCONF: 00 x-cbid: 19051718-0028-0000-0000-0000036ED4A4 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19051718-0029-0000-0000-0000242E74D3 Message-Id: <20190517183240.689188-2-groug@kaod.org> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-17_11:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=4 phishscore=0 bulkscore=0 spamscore=0 clxscore=1034 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=792 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905170108 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 148.163.156.1 Subject: [Qemu-devel] [PULL 1/6] fsdev: Drop unused extern declaration X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Greg Kurz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This is a leftover of the handle backend, removed in QEMU 4.0. Signed-off-by: Greg Kurz Reviewed-by: Thomas Huth --- fsdev/qemu-fsdev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fsdev/qemu-fsdev.h b/fsdev/qemu-fsdev.h index d9716b414492..844159d1e1ff 100644 --- a/fsdev/qemu-fsdev.h +++ b/fsdev/qemu-fsdev.h @@ -41,7 +41,6 @@ typedef struct FsDriverListEntry { int qemu_fsdev_add(QemuOpts *opts, Error **errp); FsDriverEntry *get_fsdev_fsentry(char *id); extern FileOperations local_ops; -extern FileOperations handle_ops; extern FileOperations synth_ops; extern FileOperations proxy_ops; #endif --=20 2.17.2 From nobody Mon Feb 9 18:04:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1558118274; cv=none; d=zoho.com; s=zohoarc; b=k1fHvtFpnSLYVe+RO1LbfKBwG2yyH+cLShjVKr+bI/oULOG34T2SN+wT3s/1B9puq8ujjrqLjTNEeC/5KzaMidiZdQ7j5VtVxqwMwwShPzZdeWfyOS9Pmhre3QKUQnNs0+M559aRWC3oAe10JFxSmtkmCoNKUQmiEaFR+lnNBd8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558118274; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=1AmPuB7uI+u2KzmZk9sTTdPr39qkA5wrrEaWu0neAII=; b=jzy50P3x70Ip3uKS28RjL/Zi3R3GpJ/M5h3dZGfLDiIY0XjocZyLVBg47Ha8IdzZv5bG7iln48/aQrcCCDN4/Bh91qLmueJCRrBxWiC4xjtfroEoiexfm+XzRrWCYhbtliKdalGYa31Bbhg1FwcP/XEU0AEb/32Bzk+JYMGrJes= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558118274746342.2247527979656; Fri, 17 May 2019 11:37:54 -0700 (PDT) Received: from localhost ([127.0.0.1]:52345 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRhjl-0007YX-M2 for importer@patchew.org; Fri, 17 May 2019 14:37:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRhfE-00047G-JX for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRhfD-0006I4-Ju for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:04 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:42682) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRhfD-0006Fz-8Z for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:03 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4HINGCV078685 for ; Fri, 17 May 2019 14:33:01 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2sj1xq0u4k-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 17 May 2019 14:33:01 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 17 May 2019 19:32:59 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 17 May 2019 19:32:57 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x4HIWu8U47513742 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 May 2019 18:32:56 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E45E611C04C; Fri, 17 May 2019 18:32:55 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D1D6D11C04A; Fri, 17 May 2019 18:32:55 +0000 (GMT) Received: from smtp.lab.toulouse-stg.fr.ibm.com (unknown [9.101.4.1]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 17 May 2019 18:32:55 +0000 (GMT) Received: from bahia.ibmuc.com (sig-9-145-156-103.de.ibm.com [9.145.156.103]) by smtp.lab.toulouse-stg.fr.ibm.com (Postfix) with ESMTP id 581732203F3; Fri, 17 May 2019 20:32:55 +0200 (CEST) From: Greg Kurz To: qemu-devel@nongnu.org Date: Fri, 17 May 2019 20:32:36 +0200 X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190517183240.689188-1-groug@kaod.org> References: <20190517183240.689188-1-groug@kaod.org> X-TM-AS-GCONF: 00 x-cbid: 19051718-4275-0000-0000-00000335EB44 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19051718-4276-0000-0000-0000384577DA Message-Id: <20190517183240.689188-3-groug@kaod.org> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-17_11:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=4 phishscore=0 bulkscore=0 spamscore=0 clxscore=1034 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=661 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905170108 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 148.163.156.1 Subject: [Qemu-devel] [PULL 2/6] fsdev: Drop unused opaque field X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Greg Kurz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This was introduced along with -fsdev but it never got used. Signed-off-by: Greg Kurz Reviewed-by: Thomas Huth --- fsdev/file-op-9p.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h index 3fa062b39f1b..c757c8099f54 100644 --- a/fsdev/file-op-9p.h +++ b/fsdev/file-op-9p.h @@ -147,7 +147,6 @@ struct FileOperations int (*renameat)(FsContext *ctx, V9fsPath *olddir, const char *old_name, V9fsPath *newdir, const char *new_name); int (*unlinkat)(FsContext *ctx, V9fsPath *dir, const char *name, int f= lags); - void *opaque; }; =20 #endif --=20 2.17.2 From nobody Mon Feb 9 18:04:23 2026 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1558118251; cv=none; d=zoho.com; s=zohoarc; b=cBWw5euUHQ0o2SzDSTYhcxzpPkI7qeVdCoz3/CvPAK9e5uPfVEQe8iN3pQKP5GXpMHU3lFZ1a1cB+PxG967ohtYrQxtgA2FJXXmoU3QDVv5jRKD+7jV4rr3FU1cPUXbW/2DnQmN71fiqCn0/n72eyIOhj/RBQECQgmbkbSbl9dM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558118251; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=+dqXT4Oh90Ns0+bpA9ypPmD7RELIl5xExFOOtIAymCo=; b=TZxyYZQhmhfwqPmJUesvHw7c0nr284jMmDKLT71UMLKsFldknWzmYTv3xlSGRraR60O8CCQYBSHSRAMV/iW04STT+n5RaEOSMYuIwvEcPyYXIPoAysfMy88MUcxrkH7jLXNJ8ATo3m1q2VgBY42dQYpQkY/ROc+wME6e2iYrlS4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558118251153514.8716890451014; Fri, 17 May 2019 11:37:31 -0700 (PDT) Received: from localhost ([127.0.0.1]:52343 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRhjH-0007B0-ST for importer@patchew.org; Fri, 17 May 2019 14:37:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRhfE-00047U-Lh for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRhfD-0006Hk-GH for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:04 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38062 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRhfD-0006GH-B0 for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:03 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4HINq76073046 for ; Fri, 17 May 2019 14:33:01 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2shyuswkfs-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 17 May 2019 14:33:01 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 17 May 2019 19:32:59 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 17 May 2019 19:32:57 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x4HIWuw310223722 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 May 2019 18:32:56 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5A3AE4C044; Fri, 17 May 2019 18:32:56 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 47E8D4C052; Fri, 17 May 2019 18:32:56 +0000 (GMT) Received: from smtp.lab.toulouse-stg.fr.ibm.com (unknown [9.101.4.1]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 17 May 2019 18:32:56 +0000 (GMT) Received: from bahia.ibmuc.com (sig-9-145-156-103.de.ibm.com [9.145.156.103]) by smtp.lab.toulouse-stg.fr.ibm.com (Postfix) with ESMTP id CA06522019A; Fri, 17 May 2019 20:32:55 +0200 (CEST) From: Greg Kurz To: qemu-devel@nongnu.org Date: Fri, 17 May 2019 20:32:37 +0200 X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190517183240.689188-1-groug@kaod.org> References: <20190517183240.689188-1-groug@kaod.org> X-TM-AS-GCONF: 00 x-cbid: 19051718-4275-0000-0000-00000335EB46 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19051718-4276-0000-0000-0000384577DB Message-Id: <20190517183240.689188-4-groug@kaod.org> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-17_11:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=4 phishscore=0 bulkscore=0 spamscore=0 clxscore=1034 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905170108 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 148.163.158.5 Subject: [Qemu-devel] [PULL 3/6] fsdev: Move some types definition to qemu-fsdev.c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Greg Kurz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" It would make sense for these types to be defined in a header file if we had an API for fsdrivers to register themselves. In practice, we only have three of them and it is very unlikely we add new ones since the future of file sharing between host and guest is the upcoming virtio-fs. Move the types to qemu-fsdev.c instead since they are only used there. Signed-off-by: Greg Kurz Reviewed-by: Thomas Huth --- fsdev/qemu-fsdev.c | 23 +++++++++++++++++++++++ fsdev/qemu-fsdev.h | 24 ------------------------ 2 files changed, 23 insertions(+), 24 deletions(-) diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c index 54cb36a2124b..e972bd698cf5 100644 --- a/fsdev/qemu-fsdev.c +++ b/fsdev/qemu-fsdev.c @@ -18,6 +18,29 @@ #include "qemu/error-report.h" #include "qemu/option.h" =20 +/* + * A table to store the various file systems and their callback operations. + * ----------------- + * fstype | ops + * ----------------- + * local | local_ops + * . | + * . | + * . | + * . | + * ----------------- + * etc + */ +typedef struct FsDriverTable { + const char *name; + FileOperations *ops; +} FsDriverTable; + +typedef struct FsDriverListEntry { + FsDriverEntry fse; + QTAILQ_ENTRY(FsDriverListEntry) next; +} FsDriverListEntry; + static QTAILQ_HEAD(, FsDriverListEntry) fsdriver_entries =3D QTAILQ_HEAD_INITIALIZER(fsdriver_entries); =20 diff --git a/fsdev/qemu-fsdev.h b/fsdev/qemu-fsdev.h index 844159d1e1ff..52a53977701a 100644 --- a/fsdev/qemu-fsdev.h +++ b/fsdev/qemu-fsdev.h @@ -14,30 +14,6 @@ #define QEMU_FSDEV_H #include "file-op-9p.h" =20 - -/* - * A table to store the various file systems and their callback operations. - * ----------------- - * fstype | ops - * ----------------- - * local | local_ops - * . | - * . | - * . | - * . | - * ----------------- - * etc - */ -typedef struct FsDriverTable { - const char *name; - FileOperations *ops; -} FsDriverTable; - -typedef struct FsDriverListEntry { - FsDriverEntry fse; - QTAILQ_ENTRY(FsDriverListEntry) next; -} FsDriverListEntry; - int qemu_fsdev_add(QemuOpts *opts, Error **errp); FsDriverEntry *get_fsdev_fsentry(char *id); extern FileOperations local_ops; --=20 2.17.2 From nobody Mon Feb 9 18:04:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1558118419; cv=none; d=zoho.com; s=zohoarc; b=gvQUEogMTjG0wiibQYCBkV8AYI63vMvJUpJyUOYFczSOAZBSIIGF4wKhtHjkRE8ucb8gBoh0i/S8aKYsTDD7Y/9Zt4zCfgth8u4tzsgrQ4KD1D0ojXXjXWZgdyhAC9klytaggaGA5OS0Ns4W7V0uOOE8ICP+PpFTXbjYSrv6/k4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558118419; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=kSP09rXvK5idVzDCV4IYtHZSDd3Rz+oSDfaQVwSOI+Y=; b=Ro+M41Zw1U2kKJdKKw8j9JeyokfY7//oiA5h+DvVzPAW5utfZbW0nM3AN6iKleLi6PPxfZiK+teAdefr++Jn1TW23KhjCZ6oCgZtNhzecGHTmdE3aTeONf7mxXGDR1XFyV72hoXM0w734SZwsVBKvZNApubt+r9pBqwTdMaYUgM= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558118419340575.3860523716393; Fri, 17 May 2019 11:40:19 -0700 (PDT) Received: from localhost ([127.0.0.1]:52365 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRhm3-0000sq-5Z for importer@patchew.org; Fri, 17 May 2019 14:40:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRhfE-00046X-E3 for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRhfD-0006H9-8O for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:04 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38060 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRhfD-0006GG-3V for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:03 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4HINoG9072969 for ; Fri, 17 May 2019 14:33:01 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2shyuswkfk-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 17 May 2019 14:33:00 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 17 May 2019 19:32:59 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 17 May 2019 19:32:57 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x4HIWunC49676306 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 May 2019 18:32:56 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C96F052065; Fri, 17 May 2019 18:32:56 +0000 (GMT) Received: from smtp.lab.toulouse-stg.fr.ibm.com (unknown [9.101.4.1]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id A5E8452050; Fri, 17 May 2019 18:32:56 +0000 (GMT) Received: from bahia.ibmuc.com (sig-9-145-156-103.de.ibm.com [9.145.156.103]) by smtp.lab.toulouse-stg.fr.ibm.com (Postfix) with ESMTP id 3F3BD2203F3; Fri, 17 May 2019 20:32:56 +0200 (CEST) From: Greg Kurz To: qemu-devel@nongnu.org Date: Fri, 17 May 2019 20:32:38 +0200 X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190517183240.689188-1-groug@kaod.org> References: <20190517183240.689188-1-groug@kaod.org> X-TM-AS-GCONF: 00 x-cbid: 19051718-4275-0000-0000-00000335EB45 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19051718-4276-0000-0000-0000384577DC Message-Id: <20190517183240.689188-5-groug@kaod.org> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-17_11:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=4 phishscore=0 bulkscore=0 spamscore=0 clxscore=1034 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905170108 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 148.163.158.5 Subject: [Qemu-devel] [PULL 4/6] fsdev: Error out when unsupported option is passed X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Greg Kurz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Each fsdriver only supports a subset of the options that can be passed to -fsdev. Unsupported options are simply ignored. This could cause the user to erroneously think QEMU has a bug. Enforce strict checking of supported options for all fsdrivers. This shouldn't impact libvirt, since it doesn't know about the synth and proxy fsdrivers. Signed-off-by: Greg Kurz Reviewed-by: Eric Blake --- fsdev/qemu-fsdev.c | 74 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 71 insertions(+), 3 deletions(-) diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c index e972bd698cf5..077a8c4e2bca 100644 --- a/fsdev/qemu-fsdev.c +++ b/fsdev/qemu-fsdev.c @@ -34,6 +34,7 @@ typedef struct FsDriverTable { const char *name; FileOperations *ops; + const char **opts; } FsDriverTable; =20 typedef struct FsDriverListEntry { @@ -44,12 +45,75 @@ typedef struct FsDriverListEntry { static QTAILQ_HEAD(, FsDriverListEntry) fsdriver_entries =3D QTAILQ_HEAD_INITIALIZER(fsdriver_entries); =20 +#define COMMON_FS_DRIVER_OPTIONS "id", "fsdriver", "readonly" + static FsDriverTable FsDrivers[] =3D { - { .name =3D "local", .ops =3D &local_ops}, - { .name =3D "synth", .ops =3D &synth_ops}, - { .name =3D "proxy", .ops =3D &proxy_ops}, + { + .name =3D "local", + .ops =3D &local_ops, + .opts =3D (const char * []) { + COMMON_FS_DRIVER_OPTIONS, + "security_model", + "path", + "writeout", + "fmode", + "dmode", + "throttling.bps-total", + "throttling.bps-read", + "throttling.bps-write", + "throttling.iops-total", + "throttling.iops-read", + "throttling.iops-write", + "throttling.bps-total-max", + "throttling.bps-read-max", + "throttling.bps-write-max", + "throttling.iops-total-max", + "throttling.iops-read-max", + "throttling.iops-write-max", + "throttling.bps-total-max-length", + "throttling.bps-read-max-length", + "throttling.bps-write-max-length", + "throttling.iops-total-max-length", + "throttling.iops-read-max-length", + "throttling.iops-write-max-length", + "throttling.iops-size", + }, + }, + { + .name =3D "synth", + .ops =3D &synth_ops, + .opts =3D (const char * []) { + COMMON_FS_DRIVER_OPTIONS, + }, + }, + { + .name =3D "proxy", + .ops =3D &proxy_ops, + .opts =3D (const char * []) { + COMMON_FS_DRIVER_OPTIONS, + "socket", + "sock_fd", + "writeout", + }, + }, }; =20 +static int validate_opt(void *opaque, const char *name, const char *value, + Error **errp) +{ + FsDriverTable *drv =3D opaque; + const char **opt; + + for (opt =3D drv->opts; *opt; opt++) { + if (!strcmp(*opt, name)) { + return 0; + } + } + + error_setg(errp, "'%s' is invalid for fsdriver '%s'", name, drv->name); + return -1; +} + int qemu_fsdev_add(QemuOpts *opts, Error **errp) { int i; @@ -80,6 +144,10 @@ int qemu_fsdev_add(QemuOpts *opts, Error **errp) return -1; } =20 + if (qemu_opt_foreach(opts, validate_opt, &FsDrivers[i], errp)) { + return -1; + } + fsle =3D g_malloc0(sizeof(*fsle)); fsle->fse.fsdev_id =3D g_strdup(fsdev_id); fsle->fse.ops =3D FsDrivers[i].ops; --=20 2.17.2 From nobody Mon Feb 9 18:04:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1558118431; cv=none; d=zoho.com; s=zohoarc; b=j5ij6zCqSC7w4oAjDhPeLTdh/q3uuKnUy+BvjINYDJrAWtfP3tCO6MI1DeYQO7HsIPqetq2pEqCzOQBrwP6fANGF97ZIpZtEPSFAsjrEQlnyxizHqq0jnvsAIXq4mVCW6+T+SiXTAJ3uiMgMTVvv/sFKb3xuFdAgJyvLuF/F/Rs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558118431; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=mOy1yrNMYlcvHDUp1Svg5V9MiHBfS/IY1iaNSJEyIgo=; b=mtreBO+W9gY7+okD/ToGMrn9zp7t5JhriVk8OpYSpdUV528IGgoRIs6nEHwyPTw43Cebp0UWgKSZQkF7RfrUH+4oLGc2GP/eADofVj6ljG3hFetROdDAgK5TI8bOcsXUfqhlFIC4oMCiad779ZBLMjEpFD7J/028EF7uty+NUO8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558118431986440.5545164326893; Fri, 17 May 2019 11:40:31 -0700 (PDT) Received: from localhost ([127.0.0.1]:52367 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRhmM-00015z-0i for importer@patchew.org; Fri, 17 May 2019 14:40:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRhfG-0004Ad-CE for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRhfF-0006LW-CF for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:06 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:44966 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRhfF-0006Kn-5w for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:05 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4HIWEl7008212 for ; Fri, 17 May 2019 14:33:03 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2sj2au80wj-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 17 May 2019 14:33:03 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 17 May 2019 19:33:01 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 17 May 2019 19:32:58 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x4HIWvE643647100 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 May 2019 18:32:57 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2DCD34C066; Fri, 17 May 2019 18:32:57 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 257D64C058; Fri, 17 May 2019 18:32:57 +0000 (GMT) Received: from smtp.lab.toulouse-stg.fr.ibm.com (unknown [9.101.4.1]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 17 May 2019 18:32:57 +0000 (GMT) Received: from bahia.ibmuc.com (sig-9-145-156-103.de.ibm.com [9.145.156.103]) by smtp.lab.toulouse-stg.fr.ibm.com (Postfix) with ESMTP id A86AD22019A; Fri, 17 May 2019 20:32:56 +0200 (CEST) From: Greg Kurz To: qemu-devel@nongnu.org Date: Fri, 17 May 2019 20:32:39 +0200 X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190517183240.689188-1-groug@kaod.org> References: <20190517183240.689188-1-groug@kaod.org> X-TM-AS-GCONF: 00 x-cbid: 19051718-0016-0000-0000-0000027CD883 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19051718-0017-0000-0000-000032D9B6B1 Message-Id: <20190517183240.689188-6-groug@kaod.org> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-17_11:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=4 phishscore=0 bulkscore=0 spamscore=0 clxscore=1034 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905170108 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 148.163.158.5 Subject: [Qemu-devel] [PULL 5/6] vl: Deprecate -virtfs_synth X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Greg Kurz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The synth fsdriver never got used for anything else but the QTest testcase for VirtIO 9P. And even there, QTest uses -fsdev synth and -device virtio-9p-... directly. Signed-off-by: Greg Kurz Reviewed-by: Thomas Huth --- qemu-deprecated.texi | 5 +++++ qemu-options.hx | 3 ++- vl.c | 4 ++++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 842e71b11dcc..1a821b68f435 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -72,6 +72,11 @@ backend settings instead of environment variables. To e= ase migration to the new format, the ``-audiodev-help'' option can be used to convert the current values of the environment variables to ``-audiodev'' options. =20 +@subsection -virtfs_synth (since 4.1) + +The ``-virtfs_synth'' argument is now deprecated. Please use ``-fsdev synt= h'' +and ``-device virtio-9p-...'' instead. + @section QEMU Machine Protocol (QMP) commands =20 @subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0) diff --git a/qemu-options.hx b/qemu-options.hx index 3faa93592991..e54c56593b25 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1368,7 +1368,8 @@ DEF("virtfs_synth", 0, QEMU_OPTION_virtfs_synth, STEXI @item -virtfs_synth @findex -virtfs_synth -Create synthetic file system image +Create synthetic file system image. Note that this option is now deprecate= d. +Please use @code{-fsdev synth} and @code{-device virtio-9p-...} instead. ETEXI =20 DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi, diff --git a/vl.c b/vl.c index b6709514c1bb..8456f006edbd 100644 --- a/vl.c +++ b/vl.c @@ -3535,6 +3535,10 @@ int main(int argc, char **argv, char **envp) QemuOpts *fsdev; QemuOpts *device; =20 + warn_report("'-virtfs_synth' is deprecated, please use " + "'-fsdev synth' and '-device virtio-9p-...' " + "instead"); + fsdev =3D qemu_opts_create(qemu_find_opts("fsdev"), "v_syn= th", 1, NULL); if (!fsdev) { --=20 2.17.2 From nobody Mon Feb 9 18:04:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1558118384; cv=none; d=zoho.com; s=zohoarc; b=Uki243Du1IIsSKa7mO4jYJXIVKNAC0j40WET4E4KAxFCYhk1meVXGUy0HXihDy7UMm/pSmYe5vpAZk8s8KdFpHNZ//4cJASTVgF0rGFoTrSb2OrMWu2FcqFVxgYrxKQXJ8IZXoSltgWyhXZyrRKX/mfmfAjEntmL104l3KVoMfM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558118384; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=3OEF2AlABoNU0OgZ+vlFvYOO4gFsvTzZmeHk8aZ1o70=; b=EqqvWrxQwvOcSx4hMVsttyEAcgZb+0eDNy28hxeu6sCd6kqTSTXdZnS4pIm1oPjd1mvrwugcTvwhzM8XvqtfMFegAYAujqFJac1thea7ATDVy7xuACDCKYufVnXYqO/IVJ4xCO4klhCJnvaBNrTqmgCRhPaVgM5Tkr1fj46LZQ8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558118384093103.4411296678577; Fri, 17 May 2019 11:39:44 -0700 (PDT) Received: from localhost ([127.0.0.1]:52363 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRhla-0000Wz-1L for importer@patchew.org; Fri, 17 May 2019 14:39:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRhfH-0004Ah-Fq for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRhfF-0006Lc-CT for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:07 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:52328 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRhfF-0006Ko-5h for qemu-devel@nongnu.org; Fri, 17 May 2019 14:33:05 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4HINeis130605 for ; Fri, 17 May 2019 14:33:02 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0b-001b2d01.pphosted.com with ESMTP id 2sj0n3ky8f-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 17 May 2019 14:33:02 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 17 May 2019 19:33:00 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 17 May 2019 19:32:58 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x4HIWvIJ53674102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 May 2019 18:32:57 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A163411C04C; Fri, 17 May 2019 18:32:57 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8EF6711C06E; Fri, 17 May 2019 18:32:57 +0000 (GMT) Received: from smtp.lab.toulouse-stg.fr.ibm.com (unknown [9.101.4.1]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 17 May 2019 18:32:57 +0000 (GMT) Received: from bahia.ibmuc.com (sig-9-145-156-103.de.ibm.com [9.145.156.103]) by smtp.lab.toulouse-stg.fr.ibm.com (Postfix) with ESMTP id 1D2232203F3; Fri, 17 May 2019 20:32:57 +0200 (CEST) From: Greg Kurz To: qemu-devel@nongnu.org Date: Fri, 17 May 2019 20:32:40 +0200 X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190517183240.689188-1-groug@kaod.org> References: <20190517183240.689188-1-groug@kaod.org> X-TM-AS-GCONF: 00 x-cbid: 19051718-4275-0000-0000-00000335EB48 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19051718-4276-0000-0000-0000384577DD Message-Id: <20190517183240.689188-7-groug@kaod.org> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-17_11:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1034 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905170108 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 148.163.158.5 Subject: [Qemu-devel] [PULL 6/6] virtfs: Fix documentation of -fsdev and -virtfs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Greg Kurz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This fixes several things: - add "id" description to -virtfs documentation - split the description into several lines in both usage and documentation for accurateness and clarity - add documentation and usage of the synth fsdriver - add "throttling.*" description to -fsdev local - add some missing periods - add proper reference to the virtfs-proxy-helper(1) manual page - document that the virtio device may be either virtio-9p-pci, virtio-9p-ccw or virtio-9p-device, depending on the machine type Buglink: https://bugs.launchpad.net/qemu/+bug/1581976 Signed-off-by: Greg Kurz Acked-by: Thomas Huth --- qemu-options.hx | 93 +++++++++++++++++++++++++++++++++++-------------- 1 file changed, 66 insertions(+), 27 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index e54c56593b25..5daa5a8fb0a8 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1232,26 +1232,35 @@ the write back by pressing @key{C-a s} (@pxref{disk= _images}). ETEXI =20 DEF("fsdev", HAS_ARG, QEMU_OPTION_fsdev, - "-fsdev fsdriver,id=3Did[,path=3Dpath,][security_model=3D{mapped-xattr= |mapped-file|passthrough|none}]\n" - " [,writeout=3Dimmediate][,readonly][,socket=3Dsocket|sock_fd=3Dsock_f= d][,fmode=3Dfmode][,dmode=3Ddmode]\n" + "-fsdev local,id=3Did,path=3Dpath,security_model=3Dmapped-xattr|mapped= -file|passthrough|none\n" + " [,writeout=3Dimmediate][,readonly][,fmode=3Dfmode][,dmode=3Ddmode]\n" " [[,throttling.bps-total=3Db]|[[,throttling.bps-read=3Dr][,throttling= .bps-write=3Dw]]]\n" " [[,throttling.iops-total=3Di]|[[,throttling.iops-read=3Dr][,throttli= ng.iops-write=3Dw]]]\n" " [[,throttling.bps-total-max=3Dbm]|[[,throttling.bps-read-max=3Drm][,= throttling.bps-write-max=3Dwm]]]\n" " [[,throttling.iops-total-max=3Dim]|[[,throttling.iops-read-max=3Dirm= ][,throttling.iops-write-max=3Diwm]]]\n" - " [[,throttling.iops-size=3Dis]]\n", + " [[,throttling.iops-size=3Dis]]\n" + "-fsdev proxy,id=3Did,socket=3Dsocket[,writeout=3Dimmediate][,readonly= ]\n" + "-fsdev proxy,id=3Did,sock_fd=3Dsock_fd[,writeout=3Dimmediate][,readon= ly]\n" + "-fsdev synth,id=3Did\n", QEMU_ARCH_ALL) =20 STEXI =20 -@item -fsdev @var{fsdriver},id=3D@var{id},path=3D@var{path},[security_mode= l=3D@var{security_model}][,writeout=3D@var{writeout}][,readonly][,socket=3D= @var{socket}|sock_fd=3D@var{sock_fd}][,fmode=3D@var{fmode}][,dmode=3D@var{d= mode}] +@item -fsdev local,id=3D@var{id},path=3D@var{path},security_model=3D@var{s= ecurity_model} [,writeout=3D@var{writeout}][,readonly][,fmode=3D@var{fmode}= ][,dmode=3D@var{dmode}] [,throttling.@var{option}=3D@var{value}[,throttling= .@var{option}=3D@var{value}[,...]]] +@itemx -fsdev proxy,id=3D@var{id},socket=3D@var{socket}[,writeout=3D@var{w= riteout}][,readonly] +@itemx -fsdev proxy,id=3D@var{id},sock_fd=3D@var{sock_fd}[,writeout=3D@var= {writeout}][,readonly] +@itemx -fsdev synth,id=3D@var{id}[,readonly] @findex -fsdev Define a new file system device. Valid options are: @table @option -@item @var{fsdriver} -This option specifies the fs driver backend to use. -Currently "local" and "proxy" file system drivers are supported. +@item local +Accesses to the filesystem are done by QEMU. +@item proxy +Accesses to the filesystem are done by virtfs-proxy-helper(1). +@item synth +Synthetic filesystem, only used by QTests. @item id=3D@var{id} -Specifies identifier for this device +Specifies identifier for this device. @item path=3D@var{path} Specifies the export path for the file system device. Files under this path will be available to the 9p client on the guest. @@ -1279,48 +1288,76 @@ Enables exporting 9p share as a readonly mount for = guests. By default read-write access is given. @item socket=3D@var{socket} Enables proxy filesystem driver to use passed socket file for communicating -with virtfs-proxy-helper +with virtfs-proxy-helper(1). @item sock_fd=3D@var{sock_fd} Enables proxy filesystem driver to use passed socket descriptor for -communicating with virtfs-proxy-helper. Usually a helper like libvirt -will create socketpair and pass one of the fds as sock_fd +communicating with virtfs-proxy-helper(1). Usually a helper like libvirt +will create socketpair and pass one of the fds as sock_fd. @item fmode=3D@var{fmode} Specifies the default mode for newly created files on the host. Works only with security models "mapped-xattr" and "mapped-file". @item dmode=3D@var{dmode} Specifies the default mode for newly created directories on the host. Works only with security models "mapped-xattr" and "mapped-file". +@item throttling.bps-total=3D@var{b},throttling.bps-read=3D@var{r},throttl= ing.bps-write=3D@var{w} +Specify bandwidth throttling limits in bytes per second, either for all re= quest +types or for reads or writes only. +@item throttling.bps-total-max=3D@var{bm},bps-read-max=3D@var{rm},bps-writ= e-max=3D@var{wm} +Specify bursts in bytes per second, either for all request types or for re= ads +or writes only. Bursts allow the guest I/O to spike above the limit +temporarily. +@item throttling.iops-total=3D@var{i},throttling.iops-read=3D@var{r}, thro= ttling.iops-write=3D@var{w} +Specify request rate limits in requests per second, either for all request +types or for reads or writes only. +@item throttling.iops-total-max=3D@var{im},throttling.iops-read-max=3D@var= {irm}, throttling.iops-write-max=3D@var{iwm} +Specify bursts in requests per second, either for all request types or for= reads +or writes only. Bursts allow the guest I/O to spike above the limit tempo= rarily. +@item throttling.iops-size=3D@var{is} +Let every @var{is} bytes of a request count as a new request for iops +throttling purposes. @end table =20 --fsdev option is used along with -device driver "virtio-9p-pci". -@item -device virtio-9p-pci,fsdev=3D@var{id},mount_tag=3D@var{mount_tag} -Options for virtio-9p-pci driver are: +-fsdev option is used along with -device driver "virtio-9p-...". +@item -device virtio-9p-@var{type},fsdev=3D@var{id},mount_tag=3D@var{mount= _tag} +Options for virtio-9p-... driver are: @table @option +@item @var{type} +Specifies the variant to be used. Supported values are "pci", "ccw" or "de= vice", +depending on the machine type. @item fsdev=3D@var{id} -Specifies the id value specified along with -fsdev option +Specifies the id value specified along with -fsdev option. @item mount_tag=3D@var{mount_tag} -Specifies the tag name to be used by the guest to mount this export point +Specifies the tag name to be used by the guest to mount this export point. @end table =20 ETEXI =20 DEF("virtfs", HAS_ARG, QEMU_OPTION_virtfs, - "-virtfs local,path=3Dpath,mount_tag=3Dtag,security_model=3D[mapped-xa= ttr|mapped-file|passthrough|none]\n" - " [,id=3Did][,writeout=3Dimmediate][,readonly][,socket=3Dsocket= |sock_fd=3Dsock_fd][,fmode=3Dfmode][,dmode=3Ddmode]\n", + "-virtfs local,path=3Dpath,mount_tag=3Dtag,security_model=3Dmapped-xat= tr|mapped-file|passthrough|none\n" + " [,id=3Did][,writeout=3Dimmediate][,readonly][,fmode=3Dfmode][= ,dmode=3Ddmode]\n" + "-virtfs proxy,mount_tag=3Dtag,socket=3Dsocket[,id=3Did][,writeout=3Di= mmediate][,readonly]\n" + "-virtfs proxy,mount_tag=3Dtag,sock_fd=3Dsock_fd[,id=3Did][,writeout= =3Dimmediate][,readonly]\n" + "-virtfs synth,mount_tag=3Dtag[,id=3Did][,readonly]\n", QEMU_ARCH_ALL) =20 STEXI =20 -@item -virtfs @var{fsdriver}[,path=3D@var{path}],mount_tag=3D@var{mount_ta= g}[,security_model=3D@var{security_model}][,writeout=3D@var{writeout}][,rea= donly][,socket=3D@var{socket}|sock_fd=3D@var{sock_fd}][,fmode=3D@var{fmode}= ][,dmode=3D@var{dmode}] +@item -virtfs local,path=3D@var{path},mount_tag=3D@var{mount_tag} ,securit= y_model=3D@var{security_model}[,writeout=3D@var{writeout}][,readonly] [,fmo= de=3D@var{fmode}][,dmode=3D@var{dmode}] +@itemx -virtfs proxy,socket=3D@var{socket},mount_tag=3D@var{mount_tag} [,w= riteout=3D@var{writeout}][,readonly] +@itemx -virtfs proxy,sock_fd=3D@var{sock_fd},mount_tag=3D@var{mount_tag} [= ,writeout=3D@var{writeout}][,readonly] +@itemx -virtfs synth,mount_tag=3D@var{mount_tag} @findex -virtfs =20 -The general form of a Virtual File system pass-through options are: +Define a new filesystem device and expose it to the guest using a virtio-9= p-device. The general form of a Virtual File system pass-through options ar= e: @table @option -@item @var{fsdriver} -This option specifies the fs driver backend to use. -Currently "local" and "proxy" file system drivers are supported. +@item local +Accesses to the filesystem are done by QEMU. +@item proxy +Accesses to the filesystem are done by virtfs-proxy-helper(1). +@item synth +Synthetic filesystem, only used by QTests. @item id=3D@var{id} -Specifies identifier for this device +Specifies identifier for the filesystem device @item path=3D@var{path} Specifies the export path for the file system device. Files under this path will be available to the 9p client on the guest. @@ -1348,17 +1385,19 @@ Enables exporting 9p share as a readonly mount for = guests. By default read-write access is given. @item socket=3D@var{socket} Enables proxy filesystem driver to use passed socket file for -communicating with virtfs-proxy-helper. Usually a helper like libvirt -will create socketpair and pass one of the fds as sock_fd +communicating with virtfs-proxy-helper(1). Usually a helper like libvirt +will create socketpair and pass one of the fds as sock_fd. @item sock_fd Enables proxy filesystem driver to use passed 'sock_fd' as the socket -descriptor for interfacing with virtfs-proxy-helper +descriptor for interfacing with virtfs-proxy-helper(1). @item fmode=3D@var{fmode} Specifies the default mode for newly created files on the host. Works only with security models "mapped-xattr" and "mapped-file". @item dmode=3D@var{dmode} Specifies the default mode for newly created directories on the host. Works only with security models "mapped-xattr" and "mapped-file". +@item mount_tag=3D@var{mount_tag} +Specifies the tag name to be used by the guest to mount this export point. @end table ETEXI =20 --=20 2.17.2