From nobody Mon Feb 9 19:05:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1558087881; cv=none; d=zoho.com; s=zohoarc; b=TchG1nLs0IhQh0J/4E1ljKwEeQ6AIHOIDHDyLNm5Au0Zya4mktRcER93+TxEUKuKnefjAcbdmgdK5fooulghFExpm6xKGPrZ3rSQoC0yOy/5/BhljYipEecQ5VbMwydb+8JHCOJS/toaFSFw+clmaGKwVxh0wKu2ZJxsTWtt4Gg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558087881; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=v+DbYtVKskGtnnRLQmsfvciqQ536xouCZ2aBchkzMY0=; b=YdUxokCkIz2veQzG5QQr6Lkago4uhQ6Gvvs4yb+EgCHNmrZbeH/s8kVK6jBNbFv51oVhZyimTK0ESKLm2cp3YqjrW++0Q33cCak7GcplQXj8I3HammDyZkTsAurUkxp99/5T7lvTXqJiLrz8no+xhKDeMOEeD4e5mKJq6t/B2F0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1558087881749464.8679451323334; Fri, 17 May 2019 03:11:21 -0700 (PDT) Received: from localhost ([127.0.0.1]:45635 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRZpa-00085u-IE for importer@patchew.org; Fri, 17 May 2019 06:11:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRZn2-00063L-1R for qemu-devel@nongnu.org; Fri, 17 May 2019 06:08:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRZbf-0005uq-FU for qemu-devel@nongnu.org; Fri, 17 May 2019 05:56:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64520) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRZbe-0005bp-8U; Fri, 17 May 2019 05:56:50 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 123367E429; Fri, 17 May 2019 09:56:39 +0000 (UTC) Received: from localhost (unknown [10.40.205.117]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 905EA348F4; Fri, 17 May 2019 09:56:37 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Date: Fri, 17 May 2019 11:56:26 +0200 Message-Id: <20190517095628.10119-3-mreitz@redhat.com> In-Reply-To: <20190517095628.10119-1-mreitz@redhat.com> References: <20190517095628.10119-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 17 May 2019 09:56:39 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/4] iotests: Prefer null-co over null-aio X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" We use null-co basically everywhere in the iotests. Unless we want to test null-aio specifically, we should use it instead (for consistency). Signed-off-by: Max Reitz --- tests/qemu-iotests/093 | 7 +++---- tests/qemu-iotests/245 | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/093 b/tests/qemu-iotests/093 index d88fbc182e..bd56c94708 100755 --- a/tests/qemu-iotests/093 +++ b/tests/qemu-iotests/093 @@ -267,13 +267,12 @@ class ThrottleTestCoroutine(ThrottleTestCase): test_img =3D "null-co://" =20 class ThrottleTestGroupNames(iotests.QMPTestCase): - test_img =3D "null-aio://" max_drives =3D 3 =20 def setUp(self): self.vm =3D iotests.VM() for i in range(0, self.max_drives): - self.vm.add_drive(self.test_img, "throttling.iops-total=3D100") + self.vm.add_drive("null-co://", "throttling.iops-total=3D100") self.vm.launch() =20 def tearDown(self): @@ -377,10 +376,10 @@ class ThrottleTestRemovableMedia(iotests.QMPTestCase): =20 def test_removable_media(self): # Add a couple of dummy nodes named cd0 and cd1 - result =3D self.vm.qmp("blockdev-add", driver=3D"null-aio", + result =3D self.vm.qmp("blockdev-add", driver=3D"null-co", node_name=3D"cd0") self.assert_qmp(result, 'return', {}) - result =3D self.vm.qmp("blockdev-add", driver=3D"null-aio", + result =3D self.vm.qmp("blockdev-add", driver=3D"null-co", node_name=3D"cd1") self.assert_qmp(result, 'return', {}) =20 diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245 index a04c6235c1..d888a1354c 100644 --- a/tests/qemu-iotests/245 +++ b/tests/qemu-iotests/245 @@ -598,7 +598,7 @@ class TestBlockdevReopen(iotests.QMPTestCase): ################## ###### null ###### ################## - opts =3D {'driver': 'null-aio', 'node-name': 'root', 'size': 1024} + opts =3D {'driver': 'null-co', 'node-name': 'root', 'size': 1024} =20 result =3D self.vm.qmp('blockdev-add', conv_keys =3D False, **opts) self.assert_qmp(result, 'return', {}) --=20 2.21.0