From nobody Fri Mar 29 13:53:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557942339; cv=none; d=zoho.com; s=zohoarc; b=ilq469sqU4gZdT5WhWEd7Kat5baFVYjCt+ApQHoPOKeplE0qRHAMeiyi6kF5vW/y+UDj3gniq05c/+N5/zHEq+JTVMii1OC94DRS5HOXwoYlgQMYDsEANWoyTpkxMXWyy8lFZJ3UxnDiNqxRyVUiDXJ90j7u+HOV1OEHo3Oj+G4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557942339; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=3JeS6342AEHjtaqrw+i1U4OFY7RPJVGj21OoIiHrPyU=; b=CnUBsQg/gk1ahNq5QByN9hgIYXCnEzCa2yGlfKWN8rWzx/0QMi/C1jptSCkZcld2+ZYayWnSaxZEXZUJNUMlvaMgZFX3RcdKr62UrgZqAq7WaplzDLZxEpGflYxDKziUj1z5I9XLZQfp3ozpF9jS1anHwIRpsmI2VaivRDKVpfI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557942339123194.91353442610455; Wed, 15 May 2019 10:45:39 -0700 (PDT) Received: from localhost ([127.0.0.1]:40443 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQxyC-0005jc-5L for importer@patchew.org; Wed, 15 May 2019 13:45:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQxwH-0004WX-4E for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQxwF-0004LA-U2 for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46646) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQxwF-0004Ku-LV for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:35 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 03289309264E for ; Wed, 15 May 2019 17:43:35 +0000 (UTC) Received: from thuth.com (ovpn-117-96.ams2.redhat.com [10.36.117.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id B0C553DED; Wed, 15 May 2019 17:43:33 +0000 (UTC) From: Thomas Huth To: Laurent Vivier , qemu-devel@nongnu.org Date: Wed, 15 May 2019 19:43:23 +0200 Message-Id: <20190515174328.16361-2-thuth@redhat.com> In-Reply-To: <20190515174328.16361-1-thuth@redhat.com> References: <20190515174328.16361-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Wed, 15 May 2019 17:43:35 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 1/6] tests/libqos: Get rid of global_qtest dependency in qvring_init() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Library functions should not depend on global_qtest functions like writew() and writeq(), so that they can also be used in tests that deal with multiple QTestStates at the same time (like migration tests). Signed-off-by: Thomas Huth --- tests/libqos/virtio-mmio.c | 2 +- tests/libqos/virtio-pci.c | 3 ++- tests/libqos/virtio.c | 18 ++++++++++-------- tests/libqos/virtio.h | 3 ++- 4 files changed, 15 insertions(+), 11 deletions(-) diff --git a/tests/libqos/virtio-mmio.c b/tests/libqos/virtio-mmio.c index 3678c07ef0..213a5f9de0 100644 --- a/tests/libqos/virtio-mmio.c +++ b/tests/libqos/virtio-mmio.c @@ -148,7 +148,7 @@ static QVirtQueue *qvirtio_mmio_virtqueue_setup(QVirtio= Device *d, g_assert_cmpint(vq->size & (vq->size - 1), =3D=3D, 0); =20 addr =3D guest_alloc(alloc, qvring_size(vq->size, dev->page_size)); - qvring_init(alloc, vq, addr); + qvring_init(dev->qts, alloc, vq, addr); qvirtio_mmio_set_queue_address(d, vq->desc / dev->page_size); =20 return vq; diff --git a/tests/libqos/virtio-pci.c b/tests/libqos/virtio-pci.c index 993d347830..a622ca26ca 100644 --- a/tests/libqos/virtio-pci.c +++ b/tests/libqos/virtio-pci.c @@ -199,6 +199,7 @@ static QVirtQueue *qvirtio_pci_virtqueue_setup(QVirtioD= evice *d, uint32_t feat; uint64_t addr; QVirtQueuePCI *vqpci; + QVirtioPCIDevice *qvpcidev =3D container_of(d, QVirtioPCIDevice, vdev); =20 vqpci =3D g_malloc0(sizeof(*vqpci)); feat =3D qvirtio_pci_get_guest_features(d); @@ -224,7 +225,7 @@ static QVirtQueue *qvirtio_pci_virtqueue_setup(QVirtioD= evice *d, =20 addr =3D guest_alloc(alloc, qvring_size(vqpci->vq.size, VIRTIO_PCI_VRING_ALIGN)); - qvring_init(alloc, &vqpci->vq, addr); + qvring_init(qvpcidev->pdev->bus->qts, alloc, &vqpci->vq, addr); qvirtio_pci_set_queue_address(d, vqpci->vq.desc / VIRTIO_PCI_VRING_ALI= GN); =20 return &vqpci->vq; diff --git a/tests/libqos/virtio.c b/tests/libqos/virtio.c index 5e8f39b4d3..b4c01dc0c1 100644 --- a/tests/libqos/virtio.c +++ b/tests/libqos/virtio.c @@ -162,7 +162,8 @@ void qvirtio_wait_config_isr(QVirtioDevice *d, gint64 t= imeout_us) } } =20 -void qvring_init(const QGuestAllocator *alloc, QVirtQueue *vq, uint64_t ad= dr) +void qvring_init(QTestState *qts, const QGuestAllocator *alloc, QVirtQueue= *vq, + uint64_t addr) { int i; =20 @@ -173,22 +174,23 @@ void qvring_init(const QGuestAllocator *alloc, QVirtQ= ueue *vq, uint64_t addr) =20 for (i =3D 0; i < vq->size - 1; i++) { /* vq->desc[i].addr */ - writeq(vq->desc + (16 * i), 0); + qtest_writeq(qts, vq->desc + (16 * i), 0); /* vq->desc[i].next */ - writew(vq->desc + (16 * i) + 14, i + 1); + qtest_writew(qts, vq->desc + (16 * i) + 14, i + 1); } =20 /* vq->avail->flags */ - writew(vq->avail, 0); + qtest_writew(qts, vq->avail, 0); /* vq->avail->idx */ - writew(vq->avail + 2, 0); + qtest_writew(qts, vq->avail + 2, 0); /* vq->avail->used_event */ - writew(vq->avail + 4 + (2 * vq->size), 0); + qtest_writew(qts, vq->avail + 4 + (2 * vq->size), 0); =20 /* vq->used->flags */ - writew(vq->used, 0); + qtest_writew(qts, vq->used, 0); /* vq->used->avail_event */ - writew(vq->used + 2 + sizeof(struct vring_used_elem) * vq->size, 0); + qtest_writew(qts, vq->used + 2 + sizeof(struct vring_used_elem) * vq->= size, + 0); } =20 QVRingIndirectDesc *qvring_indirect_desc_setup(QVirtioDevice *d, diff --git a/tests/libqos/virtio.h b/tests/libqos/virtio.h index 51d2359ace..7b97f5e567 100644 --- a/tests/libqos/virtio.h +++ b/tests/libqos/virtio.h @@ -129,7 +129,8 @@ QVirtQueue *qvirtqueue_setup(QVirtioDevice *d, void qvirtqueue_cleanup(const QVirtioBus *bus, QVirtQueue *vq, QGuestAllocator *alloc); =20 -void qvring_init(const QGuestAllocator *alloc, QVirtQueue *vq, uint64_t ad= dr); +void qvring_init(QTestState *qts, const QGuestAllocator *alloc, QVirtQueue= *vq, + uint64_t addr); QVRingIndirectDesc *qvring_indirect_desc_setup(QVirtioDevice *d, QGuestAllocator *alloc, uint16_t e= lem); void qvring_indirect_desc_add(QVRingIndirectDesc *indirect, uint64_t data, --=20 2.21.0 From nobody Fri Mar 29 13:53:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557942379; cv=none; d=zoho.com; s=zohoarc; b=gnz/7hN5GbqJ8L6aLI5eC3IDa3t8ljKZ+Vn6zv4+XVF9iogms5SUTIM8j+BPxol8icNRr3WXTzmlcIXur03QxYHcqeFtKi40/+UDTnxjQ1Whx8nQT3BKkoohQMAydbH9xzA2ukO/4+PRhotNoTNvBYS8eHXXI/Q1+Mc3a1CF7Ts= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557942379; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=vV62dUs8lBICDav613WRBEb0HzBcbhKes5EhG3cd5HE=; b=TwpSfwpdQVvxowh6l9UjIKLovzDlFi60SiOY84MSL9t3dYeJqx9tbCNBHeYLoxwf3VEeuj2Z+LtNuus8qj9pUSTZJo+NC43wVIJbyqCuIyPVLi/b5ATC/oqGUaikj+Mx/oCxJHsKWPALlkvWjIUgkFmiwAV6rCa2LNBbMjsw0Uw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557942379601926.8624131923747; Wed, 15 May 2019 10:46:19 -0700 (PDT) Received: from localhost ([127.0.0.1]:40475 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQxyo-0006MS-LS for importer@patchew.org; Wed, 15 May 2019 13:46:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQxwI-0004Xp-FO for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQxwH-0004Lt-BL for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37332) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQxwH-0004LZ-4I for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:37 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 65FBC30833A8 for ; Wed, 15 May 2019 17:43:36 +0000 (UTC) Received: from thuth.com (ovpn-117-96.ams2.redhat.com [10.36.117.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4DAB73DED; Wed, 15 May 2019 17:43:35 +0000 (UTC) From: Thomas Huth To: Laurent Vivier , qemu-devel@nongnu.org Date: Wed, 15 May 2019 19:43:24 +0200 Message-Id: <20190515174328.16361-3-thuth@redhat.com> In-Reply-To: <20190515174328.16361-1-thuth@redhat.com> References: <20190515174328.16361-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 15 May 2019 17:43:36 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/6] tests/q35-test: Make test independent of global_qtest X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Use a local QTestState variable, so that we can finally get rid of the undesired global_qtest variable in this file, too. Signed-off-by: Thomas Huth --- tests/q35-test.c | 39 ++++++++++++++++++--------------------- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/tests/q35-test.c b/tests/q35-test.c index 34b34bc2b9..a68183d513 100644 --- a/tests/q35-test.c +++ b/tests/q35-test.c @@ -84,10 +84,11 @@ static void test_smram_lock(void) QPCIBus *pcibus; QPCIDevice *pcidev; QDict *response; + QTestState *qts; =20 - qtest_start("-M q35"); + qts =3D qtest_init("-M q35"); =20 - pcibus =3D qpci_new_pc(global_qtest, NULL); + pcibus =3D qpci_new_pc(qts, NULL); g_assert(pcibus !=3D NULL); =20 pcidev =3D qpci_device_find(pcibus, 0); @@ -106,7 +107,7 @@ static void test_smram_lock(void) g_assert(smram_test_bit(pcidev, MCH_HOST_BRIDGE_SMRAM_D_OPEN) =3D=3D f= alse); =20 /* reset */ - response =3D qmp("{'execute': 'system_reset', 'arguments': {} }"); + response =3D qtest_qmp(qts, "{'execute': 'system_reset', 'arguments': = {} }"); g_assert(response); g_assert(!qdict_haskey(response, "error")); qobject_unref(response); @@ -120,33 +121,29 @@ static void test_smram_lock(void) g_free(pcidev); qpci_free_pc(pcibus); =20 - qtest_end(); + qtest_quit(qts); } =20 static void test_tseg_size(const void *data) { const TsegSizeArgs *args =3D data; - char *cmdline; QPCIBus *pcibus; QPCIDevice *pcidev; uint8_t smram_val; uint8_t esmramc_val; uint32_t ram_offs; + QTestState *qts; =20 if (args->esmramc_tseg_sz =3D=3D MCH_HOST_BRIDGE_ESMRAMC_TSEG_SZ_MASK)= { - cmdline =3D g_strdup_printf("-M q35 -m %uM " - "-global mch.extended-tseg-mbytes=3D%u", - TSEG_SIZE_TEST_GUEST_RAM_MBYTES, - args->extended_tseg_mbytes); + qts =3D qtest_initf("-M q35 -m %uM -global mch.extended-tseg-mbyte= s=3D%u", + TSEG_SIZE_TEST_GUEST_RAM_MBYTES, + args->extended_tseg_mbytes); } else { - cmdline =3D g_strdup_printf("-M q35 -m %uM", - TSEG_SIZE_TEST_GUEST_RAM_MBYTES); + qts =3D qtest_initf("-M q35 -m %uM", TSEG_SIZE_TEST_GUEST_RAM_MBYT= ES); } - qtest_start(cmdline); - g_free(cmdline); =20 /* locate the DRAM controller */ - pcibus =3D qpci_new_pc(global_qtest, NULL); + pcibus =3D qpci_new_pc(qts, NULL); g_assert(pcibus !=3D NULL); pcidev =3D qpci_device_find(pcibus, 0); g_assert(pcidev !=3D NULL); @@ -175,18 +172,18 @@ static void test_tseg_size(const void *data) */ ram_offs =3D (TSEG_SIZE_TEST_GUEST_RAM_MBYTES - args->expected_tseg_mb= ytes) * 1024 * 1024 - 1; - g_assert_cmpint(readb(ram_offs), =3D=3D, 0); - writeb(ram_offs, 1); - g_assert_cmpint(readb(ram_offs), =3D=3D, 1); + g_assert_cmpint(qtest_readb(qts, ram_offs), =3D=3D, 0); + qtest_writeb(qts, ram_offs, 1); + g_assert_cmpint(qtest_readb(qts, ram_offs), =3D=3D, 1); =20 ram_offs++; - g_assert_cmpint(readb(ram_offs), =3D=3D, 0xff); - writeb(ram_offs, 1); - g_assert_cmpint(readb(ram_offs), =3D=3D, 0xff); + g_assert_cmpint(qtest_readb(qts, ram_offs), =3D=3D, 0xff); + qtest_writeb(qts, ram_offs, 1); + g_assert_cmpint(qtest_readb(qts, ram_offs), =3D=3D, 0xff); =20 g_free(pcidev); qpci_free_pc(pcibus); - qtest_end(); + qtest_quit(qts); } =20 int main(int argc, char **argv) --=20 2.21.0 From nobody Fri Mar 29 13:53:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557942584; cv=none; d=zoho.com; s=zohoarc; b=aoqWFjaxOcEmVQn3Uw4JAXLs7DC1b91HMRPzWAdJeRoJyqHKADMnQJLP6ZWY5SQP8mt9SuTyWue/PpIG+fZZatSKsUzRQ1iJpFLNg2JLbGC8Jn77JFPUPyRtJRZ4vivwqImc8klc8Q1wfEu2w6aNfTCHdDn/mbbSP/MWegvAxiE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557942584; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=X3HLTCm4ijJ0jZXK6dzRvb40DrB1rweNY+mF3BOZH1k=; b=mIWvhPqGSfkW2YPsHLcqdEuSyVXIBEV/FY5szh9UaRWKb0294J/vYYOhErINkv5N9jyDn24ksF2Yr1sFUpDiNRhvNiTbqe00KXHhD0drpXBfbF30943IUbS5widgzGiSRpxxUCm4WT+a8hhR8LrcJE5bJN5w0A6R8FRFbCB3E4k= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557942584965252.7686737271398; Wed, 15 May 2019 10:49:44 -0700 (PDT) Received: from localhost ([127.0.0.1]:40502 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQy29-0000WT-R5 for importer@patchew.org; Wed, 15 May 2019 13:49:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQxwJ-0004ZC-QN for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQxwI-0004MU-IG for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46660) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQxwI-0004M7-B6 for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:38 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AF83F3092648 for ; Wed, 15 May 2019 17:43:37 +0000 (UTC) Received: from thuth.com (ovpn-117-96.ams2.redhat.com [10.36.117.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id A7068166A9; Wed, 15 May 2019 17:43:36 +0000 (UTC) From: Thomas Huth To: Laurent Vivier , qemu-devel@nongnu.org Date: Wed, 15 May 2019 19:43:25 +0200 Message-Id: <20190515174328.16361-4-thuth@redhat.com> In-Reply-To: <20190515174328.16361-1-thuth@redhat.com> References: <20190515174328.16361-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Wed, 15 May 2019 17:43:37 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 3/6] tests/numa-test: Use qtest_init() instead of qtest_start() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" qtest_start() + qtest_end() should be avoided, since they use the global_qtest variable that we want to get rid of in the long run. Use qtest_init() and qtest_quit() instead. Signed-off-by: Thomas Huth --- tests/numa-test.c | 53 +++++++++++++++++++++++++++-------------------- 1 file changed, 30 insertions(+), 23 deletions(-) diff --git a/tests/numa-test.c b/tests/numa-test.c index 9824fdd587..8de8581231 100644 --- a/tests/numa-test.c +++ b/tests/numa-test.c @@ -23,18 +23,19 @@ static void test_mon_explicit(const void *data) { char *s; char *cli; + QTestState *qts; =20 cli =3D make_cli(data, "-smp 8 " "-numa node,nodeid=3D0,cpus=3D0-3 " "-numa node,nodeid=3D1,cpus=3D4-7 "); - qtest_start(cli); + qts =3D qtest_init(cli); =20 - s =3D hmp("info numa"); + s =3D qtest_hmp(qts, "info numa"); g_assert(strstr(s, "node 0 cpus: 0 1 2 3")); g_assert(strstr(s, "node 1 cpus: 4 5 6 7")); g_free(s); =20 - qtest_end(); + qtest_quit(qts); g_free(cli); } =20 @@ -42,16 +43,17 @@ static void test_mon_default(const void *data) { char *s; char *cli; + QTestState *qts; =20 cli =3D make_cli(data, "-smp 8 -numa node -numa node"); - qtest_start(cli); + qts =3D qtest_init(cli); =20 - s =3D hmp("info numa"); + s =3D qtest_hmp(qts, "info numa"); g_assert(strstr(s, "node 0 cpus: 0 2 4 6")); g_assert(strstr(s, "node 1 cpus: 1 3 5 7")); g_free(s); =20 - qtest_end(); + qtest_quit(qts); g_free(cli); } =20 @@ -59,24 +61,25 @@ static void test_mon_partial(const void *data) { char *s; char *cli; + QTestState *qts; =20 cli =3D make_cli(data, "-smp 8 " "-numa node,nodeid=3D0,cpus=3D0-1 " "-numa node,nodeid=3D1,cpus=3D4-5 "); - qtest_start(cli); + qts =3D qtest_init(cli); =20 - s =3D hmp("info numa"); + s =3D qtest_hmp(qts, "info numa"); g_assert(strstr(s, "node 0 cpus: 0 1 2 3 6 7")); g_assert(strstr(s, "node 1 cpus: 4 5")); g_free(s); =20 - qtest_end(); + qtest_quit(qts); g_free(cli); } =20 -static QList *get_cpus(QDict **resp) +static QList *get_cpus(QTestState *qts, QDict **resp) { - *resp =3D qmp("{ 'execute': 'query-cpus' }"); + *resp =3D qtest_qmp(qts, "{ 'execute': 'query-cpus' }"); g_assert(*resp); g_assert(qdict_haskey(*resp, "return")); return qdict_get_qlist(*resp, "return"); @@ -88,10 +91,11 @@ static void test_query_cpus(const void *data) QDict *resp; QList *cpus; QObject *e; + QTestState *qts; =20 cli =3D make_cli(data, "-smp 8 -numa node,cpus=3D0-3 -numa node,cpus= =3D4-7"); - qtest_start(cli); - cpus =3D get_cpus(&resp); + qts =3D qtest_init(cli); + cpus =3D get_cpus(qts, &resp); g_assert(cpus); =20 while ((e =3D qlist_pop(cpus))) { @@ -115,7 +119,7 @@ static void test_query_cpus(const void *data) } =20 qobject_unref(resp); - qtest_end(); + qtest_quit(qts); g_free(cli); } =20 @@ -125,6 +129,7 @@ static void pc_numa_cpu(const void *data) QDict *resp; QList *cpus; QObject *e; + QTestState *qts; =20 cli =3D make_cli(data, "-cpu pentium -smp 8,sockets=3D2,cores=3D2,thre= ads=3D2 " "-numa node,nodeid=3D0 -numa node,nodeid=3D1 " @@ -132,8 +137,8 @@ static void pc_numa_cpu(const void *data) "-numa cpu,node-id=3D0,socket-id=3D1,core-id=3D0 " "-numa cpu,node-id=3D0,socket-id=3D1,core-id=3D1,thread-id=3D0 " "-numa cpu,node-id=3D1,socket-id=3D1,core-id=3D1,thread-id=3D1"); - qtest_start(cli); - cpus =3D get_cpus(&resp); + qts =3D qtest_init(cli); + cpus =3D get_cpus(qts, &resp); g_assert(cpus); =20 while ((e =3D qlist_pop(cpus))) { @@ -168,7 +173,7 @@ static void pc_numa_cpu(const void *data) } =20 qobject_unref(resp); - qtest_end(); + qtest_quit(qts); g_free(cli); } =20 @@ -178,6 +183,7 @@ static void spapr_numa_cpu(const void *data) QDict *resp; QList *cpus; QObject *e; + QTestState *qts; =20 cli =3D make_cli(data, "-smp 4,cores=3D4 " "-numa node,nodeid=3D0 -numa node,nodeid=3D1 " @@ -185,8 +191,8 @@ static void spapr_numa_cpu(const void *data) "-numa cpu,node-id=3D0,core-id=3D1 " "-numa cpu,node-id=3D0,core-id=3D2 " "-numa cpu,node-id=3D1,core-id=3D3"); - qtest_start(cli); - cpus =3D get_cpus(&resp); + qts =3D qtest_init(cli); + cpus =3D get_cpus(qts, &resp); g_assert(cpus); =20 while ((e =3D qlist_pop(cpus))) { @@ -213,7 +219,7 @@ static void spapr_numa_cpu(const void *data) } =20 qobject_unref(resp); - qtest_end(); + qtest_quit(qts); g_free(cli); } =20 @@ -223,13 +229,14 @@ static void aarch64_numa_cpu(const void *data) QDict *resp; QList *cpus; QObject *e; + QTestState *qts; =20 cli =3D make_cli(data, "-smp 2 " "-numa node,nodeid=3D0 -numa node,nodeid=3D1 " "-numa cpu,node-id=3D1,thread-id=3D0 " "-numa cpu,node-id=3D0,thread-id=3D1"); - qtest_start(cli); - cpus =3D get_cpus(&resp); + qts =3D qtest_init(cli); + cpus =3D get_cpus(qts, &resp); g_assert(cpus); =20 while ((e =3D qlist_pop(cpus))) { @@ -256,7 +263,7 @@ static void aarch64_numa_cpu(const void *data) } =20 qobject_unref(resp); - qtest_end(); + qtest_quit(qts); g_free(cli); } =20 --=20 2.21.0 From nobody Fri Mar 29 13:53:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557942535; cv=none; d=zoho.com; s=zohoarc; b=HBducYU9vAI8pey3fw44ekN9TkIWmlD4Zu42nIv94wjWgRt/LeFEmcJ5+19gzFJd0DgyKpQDkbx2W3YtvyQxS/m0sV1ltOxDniZlVD6F+s8gmCDKkOPttWWhpEdbvayZAuPx9cfJtWQ13Dxj5OuCnVpjp5kJh+50S2Pk4wiuWEE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557942535; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=GL9AT8KxR1KqHpSTlxxQeRNoh7Okx78UXB7bSxizKec=; b=f1l0JBdPs5ntEtMXr0r8MMRSam+bUxdlNNv5NlVNLZRjWo5W+0Rha5aHHzgKVPuO/bZdOPsQ2elp9C90P052SmsrdwfG1KUCltDHA8nTOhfP+N0DTn4CMVk1ejWGBZFT03VTOq1xQqeeNLR1HQp4maA/zPc3GZp4NRLNK7TmyJQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557942535379237.73379027627254; Wed, 15 May 2019 10:48:55 -0700 (PDT) Received: from localhost ([127.0.0.1]:40498 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQy1L-0008Ou-6Q for importer@patchew.org; Wed, 15 May 2019 13:48:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQxwK-0004aJ-Ru for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQxwJ-0004NC-TW for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43590) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQxwJ-0004Mk-MJ for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:39 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0CECE3F153 for ; Wed, 15 May 2019 17:43:39 +0000 (UTC) Received: from thuth.com (ovpn-117-96.ams2.redhat.com [10.36.117.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 056AD166AC; Wed, 15 May 2019 17:43:37 +0000 (UTC) From: Thomas Huth To: Laurent Vivier , qemu-devel@nongnu.org Date: Wed, 15 May 2019 19:43:26 +0200 Message-Id: <20190515174328.16361-5-thuth@redhat.com> In-Reply-To: <20190515174328.16361-1-thuth@redhat.com> References: <20190515174328.16361-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 15 May 2019 17:43:39 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 4/6] tests/qom-test: Use qtest_init() instead of qtest_start() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" qtest_start() + qtest_end() should be avoided, since they use the global_qtest variable that we want to get rid of in the long run. Use qtest_init() and qtest_quit() instead. Signed-off-by: Thomas Huth --- tests/qom-test.c | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/tests/qom-test.c b/tests/qom-test.c index 73c52af3bb..4f94cc678c 100644 --- a/tests/qom-test.c +++ b/tests/qom-test.c @@ -44,7 +44,7 @@ static bool is_blacklisted(const char *arch, const char *= mach) return false; } =20 -static void test_properties(const char *path, bool recurse) +static void test_properties(QTestState *qts, const char *path, bool recurs= e) { char *child_path; QDict *response, *tuple, *tmp; @@ -52,8 +52,8 @@ static void test_properties(const char *path, bool recurs= e) QListEntry *entry; =20 g_test_message("Obtaining properties of %s", path); - response =3D qmp("{ 'execute': 'qom-list'," - " 'arguments': { 'path': %s } }", path); + response =3D qtest_qmp(qts, "{ 'execute': 'qom-list'," + " 'arguments': { 'path': %s } }", path); g_assert(response); =20 if (!recurse) { @@ -71,15 +71,15 @@ static void test_properties(const char *path, bool recu= rse) if (is_child || is_link) { child_path =3D g_strdup_printf("%s/%s", path, qdict_get_str(tuple, "name"= )); - test_properties(child_path, is_child); + test_properties(qts, child_path, is_child); g_free(child_path); } else { const char *prop =3D qdict_get_str(tuple, "name"); g_test_message("Testing property %s.%s", path, prop); - tmp =3D qmp("{ 'execute': 'qom-get'," - " 'arguments': { 'path': %s," - " 'property': %s } }", - path, prop); + tmp =3D qtest_qmp(qts, + "{ 'execute': 'qom-get'," + " 'arguments': { 'path': %s, 'property': %s }= }", + path, prop); /* qom-get may fail but should not, e.g., segfault. */ g_assert(tmp); qobject_unref(tmp); @@ -91,20 +91,18 @@ static void test_properties(const char *path, bool recu= rse) static void test_machine(gconstpointer data) { const char *machine =3D data; - char *args; QDict *response; + QTestState *qts; =20 - args =3D g_strdup_printf("-machine %s", machine); - qtest_start(args); + qts =3D qtest_initf("-machine %s", machine); =20 - test_properties("/machine", true); + test_properties(qts, "/machine", true); =20 - response =3D qmp("{ 'execute': 'quit' }"); + response =3D qtest_qmp(qts, "{ 'execute': 'quit' }"); g_assert(qdict_haskey(response, "return")); qobject_unref(response); =20 - qtest_end(); - g_free(args); + qtest_quit(qts); g_free((void *)machine); } =20 --=20 2.21.0 From nobody Fri Mar 29 13:53:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557942415; cv=none; d=zoho.com; s=zohoarc; b=PkbtAm9CZ8nJw08nPxJITtZoFiBl5vW+sdu5EiJSZr7BSAXjIDndm15IVSjNmIk1LdVQ53o/8FoqwaCflLxk6534BRSog3uxigFaS0tNHsFYRFooaYyYOiWtQb94o3RHhGI0ZKxESltf3/Kj0kIgcXpccDwY8Yd8UBLG0NVMPnc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557942415; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=LGpE277xQqxO88boY8CGw9DHjT7njYyK+FJhcOlRfXg=; b=NJCjuiX1Cxoq1H1Bci7dvoZItLnVEX6FmdyblzYLtTdXsnc5W9BAvpdZhTChfFITrtIAKkmqD6KwQyzS8MgK2rWsb5usb/uKI7g+GAgfzqn/q92N3u/AXhXPQxTV3Ry13lFMFlLSLSa3PLOhzn/zWaxYVDMuUmIiDHm5xrjBt8k= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557942415204971.1124110686295; Wed, 15 May 2019 10:46:55 -0700 (PDT) Received: from localhost ([127.0.0.1]:40477 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQxzM-00071g-3r for importer@patchew.org; Wed, 15 May 2019 13:46:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQxwM-0004bz-Hk for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQxwL-0004Nr-8F for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40750) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQxwL-0004NR-0i for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:41 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 610B830BF19A for ; Wed, 15 May 2019 17:43:40 +0000 (UTC) Received: from thuth.com (ovpn-117-96.ams2.redhat.com [10.36.117.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 57B24166AC; Wed, 15 May 2019 17:43:39 +0000 (UTC) From: Thomas Huth To: Laurent Vivier , qemu-devel@nongnu.org Date: Wed, 15 May 2019 19:43:27 +0200 Message-Id: <20190515174328.16361-6-thuth@redhat.com> In-Reply-To: <20190515174328.16361-1-thuth@redhat.com> References: <20190515174328.16361-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Wed, 15 May 2019 17:43:40 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 5/6] tests/device-introspect: Use qtest_init() instead of qtest_start() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" qtest_start() + qtest_end() should be avoided, since they use the global_qtest variable that we want to get rid of in the long run. Use qtest_init() and qtest_quit() instead. Signed-off-by: Thomas Huth --- tests/device-introspect-test.c | 85 ++++++++++++++++++---------------- 1 file changed, 46 insertions(+), 39 deletions(-) diff --git a/tests/device-introspect-test.c b/tests/device-introspect-test.c index a25092dfaa..04f22903b0 100644 --- a/tests/device-introspect-test.c +++ b/tests/device-introspect-test.c @@ -26,7 +26,8 @@ =20 const char common_args[] =3D "-nodefaults -machine none"; =20 -static QList *qom_list_types(const char *implements, bool abstract) +static QList *qom_list_types(QTestState * qts, const char *implements, + bool abstract) { QDict *resp; QList *ret; @@ -36,8 +37,8 @@ static QList *qom_list_types(const char *implements, bool= abstract) if (implements) { qdict_put_str(args, "implements", implements); } - resp =3D qmp("{'execute': 'qom-list-types'," - " 'arguments': %p }", args); + resp =3D qtest_qmp(qts, "{'execute': 'qom-list-types', 'arguments': %p= }", + args); g_assert(qdict_haskey(resp, "return")); ret =3D qdict_get_qlist(resp, "return"); qobject_ref(ret); @@ -95,12 +96,12 @@ static QDict *type_list_find(QList *types, const char *= name) return NULL; } =20 -static QList *device_type_list(bool abstract) +static QList *device_type_list(QTestState *qts, bool abstract) { - return qom_list_types("device", abstract); + return qom_list_types(qts, "device", abstract); } =20 -static void test_one_device(const char *type) +static void test_one_device(QTestState *qts, const char *type) { QDict *resp; char *help; @@ -109,15 +110,15 @@ static void test_one_device(const char *type) =20 g_test_message("Testing device '%s'", type); =20 - qom_tree_start =3D hmp("info qom-tree"); - qtree_start =3D hmp("info qtree"); + qom_tree_start =3D qtest_hmp(qts, "info qom-tree"); + qtree_start =3D qtest_hmp(qts, "info qtree"); =20 - resp =3D qmp("{'execute': 'device-list-properties'," - " 'arguments': {'typename': %s}}", + resp =3D qtest_qmp(qts, "{'execute': 'device-list-properties'," + " 'arguments': {'typename': %s}}", type); qobject_unref(resp); =20 - help =3D hmp("device_add \"%s,help\"", type); + help =3D qtest_hmp(qts, "device_add \"%s,help\"", type); g_free(help); =20 /* @@ -125,12 +126,12 @@ static void test_one_device(const char *type) * "info qom-tree" or "info qtree" have a good chance at crashing then. * Also make sure that the tree did not change. */ - qom_tree_end =3D hmp("info qom-tree"); + qom_tree_end =3D qtest_hmp(qts, "info qom-tree"); g_assert_cmpstr(qom_tree_start, =3D=3D, qom_tree_end); g_free(qom_tree_start); g_free(qom_tree_end); =20 - qtree_end =3D hmp("info qtree"); + qtree_end =3D qtest_hmp(qts, "info qtree"); g_assert_cmpstr(qtree_start, =3D=3D, qtree_end); g_free(qtree_start); g_free(qtree_end); @@ -140,29 +141,30 @@ static void test_device_intro_list(void) { QList *types; char *help; + QTestState *qts; =20 - qtest_start(common_args); + qts =3D qtest_init(common_args); =20 - types =3D device_type_list(true); + types =3D device_type_list(qts, true); qobject_unref(types); =20 - help =3D hmp("device_add help"); + help =3D qtest_hmp(qts, "device_add help"); g_free(help); =20 - qtest_end(); + qtest_quit(qts); } =20 /* * Ensure all entries returned by qom-list-types implements=3D * have as a parent. */ -static void test_qom_list_parents(const char *parent) +static void test_qom_list_parents(QTestState *qts, const char *parent) { QList *types; QListEntry *e; QDict *index; =20 - types =3D qom_list_types(parent, true); + types =3D qom_list_types(qts, parent, true); index =3D qom_type_index(types); =20 QLIST_FOREACH_ENTRY(types, e) { @@ -181,11 +183,12 @@ static void test_qom_list_fields(void) QList *all_types; QList *non_abstract; QListEntry *e; + QTestState *qts; =20 - qtest_start(common_args); + qts =3D qtest_init(common_args); =20 - all_types =3D qom_list_types(NULL, true); - non_abstract =3D qom_list_types(NULL, false); + all_types =3D qom_list_types(qts, NULL, true); + non_abstract =3D qom_list_types(qts, NULL, false); =20 QLIST_FOREACH_ENTRY(all_types, e) { QDict *d =3D qobject_to(QDict, qlist_entry_obj(e)); @@ -198,27 +201,29 @@ static void test_qom_list_fields(void) g_assert(abstract =3D=3D expected_abstract); } =20 - test_qom_list_parents("object"); - test_qom_list_parents("device"); - test_qom_list_parents("sys-bus-device"); + test_qom_list_parents(qts, "object"); + test_qom_list_parents(qts, "device"); + test_qom_list_parents(qts, "sys-bus-device"); =20 qobject_unref(all_types); qobject_unref(non_abstract); - qtest_end(); + qtest_quit(qts); } =20 static void test_device_intro_none(void) { - qtest_start(common_args); - test_one_device("nonexistent"); - qtest_end(); + QTestState *qts =3D qtest_init(common_args); + + test_one_device(qts, "nonexistent"); + qtest_quit(qts); } =20 static void test_device_intro_abstract(void) { - qtest_start(common_args); - test_one_device("device"); - qtest_end(); + QTestState *qts =3D qtest_init(common_args); + + test_one_device(qts, "device"); + qtest_quit(qts); } =20 static void test_device_intro_concrete(const void *args) @@ -226,19 +231,20 @@ static void test_device_intro_concrete(const void *ar= gs) QList *types; QListEntry *entry; const char *type; + QTestState *qts; =20 - qtest_start(args); - types =3D device_type_list(false); + qts =3D qtest_init(args); + types =3D device_type_list(qts, false); =20 QLIST_FOREACH_ENTRY(types, entry) { type =3D qdict_get_try_str(qobject_to(QDict, qlist_entry_obj(entry= )), "name"); g_assert(type); - test_one_device(type); + test_one_device(qts, type); } =20 qobject_unref(types); - qtest_end(); + qtest_quit(qts); g_free((void *)args); } =20 @@ -247,10 +253,11 @@ static void test_abstract_interfaces(void) QList *all_types; QListEntry *e; QDict *index; + QTestState *qts; =20 - qtest_start(common_args); + qts =3D qtest_init(common_args); =20 - all_types =3D qom_list_types("interface", true); + all_types =3D qom_list_types(qts, "interface", true); index =3D qom_type_index(all_types); =20 QLIST_FOREACH_ENTRY(all_types, e) { @@ -273,7 +280,7 @@ static void test_abstract_interfaces(void) =20 qobject_unref(all_types); qobject_unref(index); - qtest_end(); + qtest_quit(qts); } =20 static void add_machine_test_case(const char *mname) --=20 2.21.0 From nobody Fri Mar 29 13:53:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557942755; cv=none; d=zoho.com; s=zohoarc; b=XEPZJ4NUlYKUpStM4zFF//baawPu6Myq5/5oqinhA/b3LRwf7xj/OpB6VaEqgV/Pocq+QMKeDpLf1Z5j9DxWQXeuP8VNu2m9Cqb1PCa1jnb2dPxTgg7A/hgwjLfY38gJj4NpTrKsVvdOa6pgkKRF1fBdL/X8xs/LHnZXngr6Tdo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557942755; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=wiaovHAAFwzK4vpCZh1tiNpTJKySqHf6zZw97CJ950g=; b=eh/xN112bqEBCnx9bah+4JMmfLKBEnbdyajHjAN2+Oxellb5l4v332kX+w0rqe0PkxwOS1+2tuNstv7lt4gFAr0YpzzV0YJN1ADrgfUV1h05cA++9fKazG/gK4upeXKNjoMDb/GKpBFUa7knxBn/x0kz3tvAZszxceh14ELgevg= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557942755002527.0984099873522; Wed, 15 May 2019 10:52:35 -0700 (PDT) Received: from localhost ([127.0.0.1]:40556 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQy4p-0002kz-Vm for importer@patchew.org; Wed, 15 May 2019 13:52:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQxwN-0004da-U1 for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQxwM-0004OW-JB for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5244) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQxwM-0004O5-BQ for qemu-devel@nongnu.org; Wed, 15 May 2019 13:43:42 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B306489C3F for ; Wed, 15 May 2019 17:43:41 +0000 (UTC) Received: from thuth.com (ovpn-117-96.ams2.redhat.com [10.36.117.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD9B9166AC; Wed, 15 May 2019 17:43:40 +0000 (UTC) From: Thomas Huth To: Laurent Vivier , qemu-devel@nongnu.org Date: Wed, 15 May 2019 19:43:28 +0200 Message-Id: <20190515174328.16361-7-thuth@redhat.com> In-Reply-To: <20190515174328.16361-1-thuth@redhat.com> References: <20190515174328.16361-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 15 May 2019 17:43:41 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 6/6] tests/hd-geo-test: Use qtest_init() instead of qtest_start() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" qtest_start() + qtest_end() should be avoided, since they use the global_qtest variable that we want to get rid of in the long run. Use qtest_init() and qtest_quit() instead. Signed-off-by: Thomas Huth --- tests/hd-geo-test.c | 76 ++++++++++++++++++++++++--------------------- 1 file changed, 41 insertions(+), 35 deletions(-) diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c index ce665f1f83..9e43161a3d 100644 --- a/tests/hd-geo-test.c +++ b/tests/hd-geo-test.c @@ -77,33 +77,35 @@ static bool is_hd(const CHST *expected_chst) return expected_chst && expected_chst->cyls; } =20 -static void test_cmos_byte(int reg, int expected) +static void test_cmos_byte(QTestState *qts, int reg, int expected) { enum { cmos_base =3D 0x70 }; int actual; =20 - outb(cmos_base + 0, reg); - actual =3D inb(cmos_base + 1); + qtest_outb(qts, cmos_base + 0, reg); + actual =3D qtest_inb(qts, cmos_base + 1); g_assert(actual =3D=3D expected); } =20 -static void test_cmos_bytes(int reg0, int n, uint8_t expected[]) +static void test_cmos_bytes(QTestState *qts, int reg0, int n,=20 + uint8_t expected[]) { int i; =20 for (i =3D 0; i < 9; i++) { - test_cmos_byte(reg0 + i, expected[i]); + test_cmos_byte(qts, reg0 + i, expected[i]); } } =20 -static void test_cmos_disk_data(void) +static void test_cmos_disk_data(QTestState *qts) { - test_cmos_byte(0x12, + test_cmos_byte(qts, 0x12, (is_hd(cur_ide[0]) ? 0xf0 : 0) | (is_hd(cur_ide[1]) ? 0x0f : 0)); } =20 -static void test_cmos_drive_cyl(int reg0, const CHST *expected_chst) +static void test_cmos_drive_cyl(QTestState *qts, int reg0, + const CHST *expected_chst) { if (is_hd(expected_chst)) { int c =3D expected_chst->cyls; @@ -113,29 +115,29 @@ static void test_cmos_drive_cyl(int reg0, const CHST = *expected_chst) c & 0xff, c >> 8, h, 0xff, 0xff, 0xc0 | ((h > 8) << 3), c & 0xff, c >> 8, s }; - test_cmos_bytes(reg0, 9, expected_bytes); + test_cmos_bytes(qts, reg0, 9, expected_bytes); } else { int i; =20 for (i =3D 0; i < 9; i++) { - test_cmos_byte(reg0 + i, 0); + test_cmos_byte(qts, reg0 + i, 0); } } } =20 -static void test_cmos_drive1(void) +static void test_cmos_drive1(QTestState *qts) { - test_cmos_byte(0x19, is_hd(cur_ide[0]) ? 47 : 0); - test_cmos_drive_cyl(0x1b, cur_ide[0]); + test_cmos_byte(qts, 0x19, is_hd(cur_ide[0]) ? 47 : 0); + test_cmos_drive_cyl(qts, 0x1b, cur_ide[0]); } =20 -static void test_cmos_drive2(void) +static void test_cmos_drive2(QTestState *qts) { - test_cmos_byte(0x1a, is_hd(cur_ide[1]) ? 47 : 0); - test_cmos_drive_cyl(0x24, cur_ide[1]); + test_cmos_byte(qts, 0x1a, is_hd(cur_ide[1]) ? 47 : 0); + test_cmos_drive_cyl(qts, 0x24, cur_ide[1]); } =20 -static void test_cmos_disktransflag(void) +static void test_cmos_disktransflag(QTestState *qts) { int val, i; =20 @@ -145,15 +147,15 @@ static void test_cmos_disktransflag(void) val |=3D cur_ide[i]->trans << (2 * i); } } - test_cmos_byte(0x39, val); + test_cmos_byte(qts, 0x39, val); } =20 -static void test_cmos(void) +static void test_cmos(QTestState *qts) { - test_cmos_disk_data(); - test_cmos_drive1(); - test_cmos_drive2(); - test_cmos_disktransflag(); + test_cmos_disk_data(qts); + test_cmos_drive1(qts); + test_cmos_drive2(qts); + test_cmos_disktransflag(qts); } =20 static int append_arg(int argc, char *argv[], int argv_sz, char *arg) @@ -238,14 +240,15 @@ static void test_ide_none(void) { char **argv =3D g_new0(char *, ARGV_SIZE); char *args; + QTestState *qts; =20 setup_common(argv, ARGV_SIZE); args =3D g_strjoinv(" ", argv); - qtest_start(args); + qts =3D qtest_init(args); g_strfreev(argv); g_free(args); - test_cmos(); - qtest_end(); + test_cmos(qts); + qtest_quit(qts); } =20 static void test_ide_mbr(bool use_device, MBRcontents mbr) @@ -255,6 +258,7 @@ static void test_ide_mbr(bool use_device, MBRcontents m= br) int argc; Backend i; const char *dev; + QTestState *qts; =20 argc =3D setup_common(argv, ARGV_SIZE); for (i =3D 0; i < backend_last; i++) { @@ -263,11 +267,11 @@ static void test_ide_mbr(bool use_device, MBRcontents= mbr) argc =3D setup_ide(argc, argv, ARGV_SIZE, i, dev, i, mbr); } args =3D g_strjoinv(" ", argv); - qtest_start(args); + qts =3D qtest_init(args); g_strfreev(argv); g_free(args); - test_cmos(); - qtest_end(); + test_cmos(qts); + qtest_quit(qts); } =20 /* @@ -325,6 +329,7 @@ static void test_ide_drive_user(const char *dev, bool t= rans) int argc; int secs =3D img_secs[backend_small]; const CHST expected_chst =3D { secs / (4 * 32) , 4, 32, trans }; + QTestState *qts; =20 argc =3D setup_common(argv, ARGV_SIZE); opts =3D g_strdup_printf("%s,%scyls=3D%d,heads=3D%d,secs=3D%d", @@ -335,11 +340,11 @@ static void test_ide_drive_user(const char *dev, bool= trans) argc =3D setup_ide(argc, argv, ARGV_SIZE, 0, opts, backend_small, mbr_= chs); g_free(opts); args =3D g_strjoinv(" ", argv); - qtest_start(args); + qts =3D qtest_init(args); g_strfreev(argv); g_free(args); - test_cmos(); - qtest_end(); + test_cmos(qts); + qtest_quit(qts); } =20 /* @@ -367,6 +372,7 @@ static void test_ide_drive_cd_0(void) char *args; int argc, ide_idx; Backend i; + QTestState *qts; =20 argc =3D setup_common(argv, ARGV_SIZE); for (i =3D 0; i <=3D backend_empty; i++) { @@ -375,11 +381,11 @@ static void test_ide_drive_cd_0(void) argc =3D setup_ide(argc, argv, ARGV_SIZE, ide_idx, NULL, i, mbr_bl= ank); } args =3D g_strjoinv(" ", argv); - qtest_start(args); + qts =3D qtest_init(args); g_strfreev(argv); g_free(args); - test_cmos(); - qtest_end(); + test_cmos(qts); + qtest_quit(qts); } =20 int main(int argc, char **argv) --=20 2.21.0