From nobody Thu Apr 25 14:27:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557807950; cv=none; d=zoho.com; s=zohoarc; b=DfHksq6bhL20iLFMyXzj5ONl394sBRo4uSjWzxMAIN2R9NC5KzwszHs5F4srZXCaWkkA420mT2WphZPAEYHgea29lbtP+vw4M0OeRYqe/vX2gC2BAUiBvRMnli9XcVb8RWGwEvlm7DZchf9VrQUTxD7TzTPJh67fNvQlI1PjyKY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557807950; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=lahpEtV3rL0vXJMl6CtAs/ssxHOr1UguIJcaQjRFtuc=; b=Ol1kgOi/BJTbcb69yjwiQ0DWWYDt2XsHO6d47Zwx9JPcHDMmNd/XN9Da2rRwhdpOJcW4UDx3WjZH29R9TP2h6oUN1JqKq9qyH0Qw5nEF8aiKGNpGYnKMpAEHu4xzmM+C1IQoGY+Ape9g3oapT8AaZ7DRNzBNsAjGuBe1XE7aHCI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557807950294366.05361886444757; Mon, 13 May 2019 21:25:50 -0700 (PDT) Received: from localhost ([127.0.0.1]:38887 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQP0c-0008L5-2n for importer@patchew.org; Tue, 14 May 2019 00:25:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52543) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQOzh-0007to-C6 for qemu-devel@nongnu.org; Tue, 14 May 2019 00:24:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQOzg-0006eD-Cp for qemu-devel@nongnu.org; Tue, 14 May 2019 00:24:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55654) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQOzg-0006dU-7c; Tue, 14 May 2019 00:24:48 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C35E7C057F3C; Tue, 14 May 2019 04:24:46 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-117-74.ams2.redhat.com [10.36.117.74]) by smtp.corp.redhat.com (Postfix) with ESMTP id 47BC85D71E; Tue, 14 May 2019 04:24:44 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 805EF1747D; Tue, 14 May 2019 06:24:43 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Tue, 14 May 2019 06:24:43 +0200 Message-Id: <20190514042443.10735-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 14 May 2019 04:24:46 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] kbd-state: fix autorepeat handling X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When allowing multiple down-events in a row (key autorepeat) we can't use change_bit() any more to update the state, because autorepeat events don't change the key state. We have to explicitly use set_bit() and clear_bit() instead. Cc: qemu-stable@nongnu.org Fixes: 35921860156e kbd-state: don't block auto-repeat events Buglink: https://bugs.launchpad.net/qemu/+bug/1828272 Signed-off-by: Gerd Hoffmann --- ui/kbd-state.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ui/kbd-state.c b/ui/kbd-state.c index f3ab2d7a665d..1668d17ddabc 100644 --- a/ui/kbd-state.c +++ b/ui/kbd-state.c @@ -59,7 +59,11 @@ void qkbd_state_key_event(QKbdState *kbd, QKeyCode qcode= , bool down) } =20 /* update key and modifier state */ - change_bit(qcode, kbd->keys); + if (down) { + set_bit(qcode, kbd->keys); + } else { + clear_bit(qcode, kbd->keys); + } switch (qcode) { case Q_KEY_CODE_SHIFT: case Q_KEY_CODE_SHIFT_R: --=20 2.18.1