From nobody Thu Apr 25 23:22:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1557802114; cv=none; d=zoho.com; s=zohoarc; b=MeBe+dRXOuunCkCkTeeW/FWKXxPKELNNVyXBsSMT48JhoAcu8uU8rvokgKnMaKFyq9P6nCvUtRlSVmZembsUteg2g6+ExzjWPGy/BE1KTwP98wdZMSKQKr1t2y/z/6bAPiduUoJcTDlPNyM0LjRWPY0sp4HL45j/HMSC29O+hHk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557802114; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=UNTNcU8NTc7XelmI6QIbWOMz3/5RDKMpurk3x3KqTCI=; b=m7QBsYUji8U0S/C/8C0o6D1L7NQUcn3uZSRCnnOZtyejPffqSVphYMvu+4QcnBY/wF3bqN47Bpd4GSZ2m4xgzNYsJMFjDU30F7BnPbwFCsbWcwxhhi7PLKBSHDjiq7SsaneZw058RKuBur07+GCy9pHZx6NE2xjnCUX0wcs49nI= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557802114226333.4229664383545; Mon, 13 May 2019 19:48:34 -0700 (PDT) Received: from localhost ([127.0.0.1]:38085 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQNTo-0007aT-7x for importer@patchew.org; Mon, 13 May 2019 22:47:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQNSq-0007A8-If for qemu-devel@nongnu.org; Mon, 13 May 2019 22:46:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQNSo-0003KU-K2 for qemu-devel@nongnu.org; Mon, 13 May 2019 22:46:48 -0400 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:40071) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQLzV-0005RB-Ua for qemu-devel@nongnu.org; Mon, 13 May 2019 21:12:26 -0400 Received: by mail-pl1-x643.google.com with SMTP id b3so7336778plr.7 for ; Mon, 13 May 2019 18:11:35 -0700 (PDT) Received: from localhost.localdomain (97-113-13-231.tukw.qwest.net. [97.113.13.231]) by smtp.gmail.com with ESMTPSA id b67sm20029147pfb.150.2019.05.13.18.11.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 May 2019 18:11:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UNTNcU8NTc7XelmI6QIbWOMz3/5RDKMpurk3x3KqTCI=; b=wKxpzDN5p9sW1US72yyS6VBUq0hOrHMBsdWkSAl75jp4y9t6QJy1TkdOJhPNC3VxVu SZXL+fNFxpJCoK+3PEBvJDRhsX+vhPHNUGaMg9Bu/205GdQc99u/AOOQN7kcYSfrKZ7Y Q6oNuLFhmLnPcXFjxH/UtFhMLFpQRutVbdob0J/fQ3GfYLVfGoUqPHuyccaUpkJTTewr mQv6AdIOM10nnXMDBYID5xL/rmu4gOX1JppvzRycx1ik9pu3SIEt/Zvc0GK+GVLPO4du U/iZw+18Sn3quedC2fGT6BWKtB9PRZou/AW9uM6NP0Ks7oNROeuMxcOoQuExnaicW+Ev FgfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=UNTNcU8NTc7XelmI6QIbWOMz3/5RDKMpurk3x3KqTCI=; b=OtLJpfb/8w+/gvhKU4wXry1AssqSXwRoLF7OpnJcK6BcyMEcSd8TSMOn/Fd2fMcXz7 w7fLg3Ii5qdGfrp81tD+whgIWHsvpj0AtLYPAAFnG99V1iPLCPoNLyz+JHACTMNWzl4h wXopc8k4Zs3mJvp82V3FFxLNfeD5fN1/TgyG2Jq0m6r1tYEHIrAsmfj9goqqRnOf37x4 EDrD1VUiFpFgC8NG+poIa+wy88ge4uI3oVfqvXoBqraPlONtpv66fk8i8qiPXg4HFPZz 7CHmL/ldI8/Q//9nQmme81DZl1+P/S0/cjPMWppyKqW4mFjJAlZYYihYpHmLW85KUVOh VXlQ== X-Gm-Message-State: APjAAAUzELRmUx6fL+NLUVIDrlzge9A4I6f+3WxeSKzrgKjsnCNCnJLy 8IYY2YZdNX2egySzrjkFEzIFtjBscTI= X-Google-Smtp-Source: APXvYqx+Mdr/wkp8ot7Hb7rPuxslVTZLzrcL/pBqgS8A48OgLz0cg1j1T2nJjekKJRAF3vYER6bDhg== X-Received: by 2002:a17:902:54f:: with SMTP id 73mr35148246plf.140.1557796293841; Mon, 13 May 2019 18:11:33 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 13 May 2019 18:11:28 -0700 Message-Id: <20190514011129.11330-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190514011129.11330-1-richard.henderson@linaro.org> References: <20190514011129.11330-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::643 Subject: [Qemu-devel] [PATCH 1/2] target/arm: Use extract2 for EXTR X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This is, after all, how we implement extract2 in tcg/aarch64. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 38 ++++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 9dcc5ff3a3..c4bee74ce5 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -4114,25 +4114,27 @@ static void disas_extract(DisasContext *s, uint32_t= insn) } else { tcg_gen_ext32u_i64(tcg_rd, cpu_reg(s, rm)); } - } else if (rm =3D=3D rn) { /* ROR */ - tcg_rm =3D cpu_reg(s, rm); - if (sf) { - tcg_gen_rotri_i64(tcg_rd, tcg_rm, imm); - } else { - TCGv_i32 tmp =3D tcg_temp_new_i32(); - tcg_gen_extrl_i64_i32(tmp, tcg_rm); - tcg_gen_rotri_i32(tmp, tmp, imm); - tcg_gen_extu_i32_i64(tcg_rd, tmp); - tcg_temp_free_i32(tmp); - } } else { - tcg_rm =3D read_cpu_reg(s, rm, sf); - tcg_rn =3D read_cpu_reg(s, rn, sf); - tcg_gen_shri_i64(tcg_rm, tcg_rm, imm); - tcg_gen_shli_i64(tcg_rn, tcg_rn, bitsize - imm); - tcg_gen_or_i64(tcg_rd, tcg_rm, tcg_rn); - if (!sf) { - tcg_gen_ext32u_i64(tcg_rd, tcg_rd); + tcg_rm =3D cpu_reg(s, rm); + tcg_rn =3D cpu_reg(s, rn); + + if (sf) { + /* Specialization to ROR happens in EXTRACT2. */ + tcg_gen_extract2_i64(tcg_rd, tcg_rm, tcg_rn, imm); + } else { + TCGv_i32 t0 =3D tcg_temp_new_i32(); + + tcg_gen_extrl_i64_i32(t0, tcg_rm); + if (rm =3D=3D rn) { + tcg_gen_rotri_i32(t0, t0, imm); + } else { + TCGv_i32 t1 =3D tcg_temp_new_i32(); + tcg_gen_extrl_i64_i32(t1, tcg_rn); + tcg_gen_extract2_i32(t0, t0, t1, imm); + tcg_temp_free_i32(t1); + } + tcg_gen_extu_i32_i64(tcg_rd, t0); + tcg_temp_free_i32(t0); } } } --=20 2.17.1 From nobody Thu Apr 25 23:22:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1557804572; cv=none; d=zoho.com; s=zohoarc; b=gt+b8y/q5Vlv9f2DLctUyVAZL0AA2saxzoGCHNdqwN5E4XR6TBig17vf51oXzKXsVIgChcdvFq9YjMUJ6lHzh1dIK88XGzEcxKGN/jVDwECazeJJjfHKmncIHuVxnBAvfbjFCbvZSini9k1T4ZAl/m5Y6wJuqFxFnqBHPlp3w7Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557804572; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=UDhIE0FmHFjvTg+Yc2t3Xw+YfnUzd/HuDHfr9sdMw70=; b=hYp7y+JxCUdOHxHP3wOgaAxNQ5yT4POerQWNnuQjnKC0Ap/u8qlkhPfczHUxzdL/eU5+lyAZqjmjjPjSkxFeVmMrfSTSPUiB8wq8SGgv4n6LdbfSfK6nIN9yoi4X5072axGZu0hw0bukM1qyanhwX6q/LchZUbPkN6NLFEJehB0= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557804572880181.210598821904; Mon, 13 May 2019 20:29:32 -0700 (PDT) Received: from localhost ([127.0.0.1]:38392 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQO83-0005KQ-3O for importer@patchew.org; Mon, 13 May 2019 23:29:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQO7A-00051J-Ge for qemu-devel@nongnu.org; Mon, 13 May 2019 23:28:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQLz9-0005u8-Sz for qemu-devel@nongnu.org; Mon, 13 May 2019 21:12:43 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:42740) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQLyw-0005Tw-Qf for qemu-devel@nongnu.org; Mon, 13 May 2019 21:11:53 -0400 Received: by mail-pl1-x641.google.com with SMTP id x15so7328868pln.9 for ; Mon, 13 May 2019 18:11:37 -0700 (PDT) Received: from localhost.localdomain (97-113-13-231.tukw.qwest.net. [97.113.13.231]) by smtp.gmail.com with ESMTPSA id b67sm20029147pfb.150.2019.05.13.18.11.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 May 2019 18:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UDhIE0FmHFjvTg+Yc2t3Xw+YfnUzd/HuDHfr9sdMw70=; b=XJqEkukhImvF+TMIP67St4SDlllZ5Gc2UsTtGWU+hJbow/M4b0GfG058/m4nUfF/oy Td0MXABa9a01ph2dNKp5E/6IjlZ2hFzeoSBo91QSWM2SIaMWRlsKp5VrV/5JsiVN/+Nl ATrVUqy+pmk3aTcF53hTGTFbRhhrjKX8s+9DnNoVsR0kh7sWrBBwxVg2BEbwbkDgH6Qp PlgT4OBPBwzAERJul400rlCdI7/2VPc0bamuk7xRrMahHOBlEWxPfZL/SvzR6tFMtAJl NIzqzADn2sWWxqxK2Sh6v2QNUUYoVKxFJpTYlmGhpLtwXvwMmiBtE6wtAvmeK2YttNUS KvLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UDhIE0FmHFjvTg+Yc2t3Xw+YfnUzd/HuDHfr9sdMw70=; b=EFGWJJOehLcuPri7Ngk5dQdCFmUGCuJX2jjc7ayISr/d1tIuvtErkdzLM6+45qXGDq kmJO93dWNFxIo+IGkWEDLw5+1PB+6UXv1c/fQT8gIKBJwyvwnnIzyWh3fX3LG+eJNye4 n4S+kmaifNg2p8mIJ4bz7YQ82XfTufUo27GWbEnlmtwORQ0iGUletvLpO15aqflKURQ1 qAIm4SbdRTKUBuCo9+5phgmmP084N84gc5gl+URxwD/g5goFgQF8rOXr96FvMvYkGYyF DwulkjKCMrjZB+LeyRBwEK/mPK0+o822zKz424nKIsaDElQ0ZmJ4JJ937DrwD0cLI58N BqSA== X-Gm-Message-State: APjAAAWocFXpLXVr2yqPTDD89aTSEszgwNBq2ZpQoyKTENupBke2xNVh htVXJ/n+n5Mo9aZ6tEPz/mkWymZoLHU= X-Google-Smtp-Source: APXvYqymIQHzVZS/Ybm1YN+MjvUUbUyA8FZMpXWM88QHVkge6ArYV9DgvpqSInpQoj/0i3pbedyP3A== X-Received: by 2002:a17:902:fa2:: with SMTP id 31mr35551538plz.128.1557796296078; Mon, 13 May 2019 18:11:36 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 13 May 2019 18:11:29 -0700 Message-Id: <20190514011129.11330-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190514011129.11330-1-richard.henderson@linaro.org> References: <20190514011129.11330-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::641 Subject: [Qemu-devel] [PATCH 2/2] target/arm: Simplify BFXIL expansion X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The mask implied by the extract is redundant with the one implied by the deposit. Also, fix spelling of BFXIL. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index c4bee74ce5..472d898096 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -4043,8 +4043,8 @@ static void disas_bitfield(DisasContext *s, uint32_t = insn) tcg_gen_extract_i64(tcg_rd, tcg_tmp, ri, len); return; } - /* opc =3D=3D 1, BXFIL fall through to deposit */ - tcg_gen_extract_i64(tcg_tmp, tcg_tmp, ri, len); + /* opc =3D=3D 1, BFXIL fall through to deposit */ + tcg_gen_shri_i64(tcg_tmp, tcg_tmp, ri); pos =3D 0; } else { /* Handle the ri > si case with a deposit @@ -4062,7 +4062,7 @@ static void disas_bitfield(DisasContext *s, uint32_t = insn) len =3D ri; } =20 - if (opc =3D=3D 1) { /* BFM, BXFIL */ + if (opc =3D=3D 1) { /* BFM, BFXIL */ tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, pos, len); } else { /* SBFM or UBFM: We start with zero, and we haven't modified --=20 2.17.1