From nobody Wed May 8 04:47:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557515023; cv=none; d=zoho.com; s=zohoarc; b=Ch1Fdm4EV81KTEbiBmDNf8wK1a2bameRn5DxSG2F3mCRDTVBk8P4toEebjXEhfx9ko7FORXTwtI5ZgFyqv23c43KMia2WoRF0fJA2q7pQgdyC+X8fVRjtLTpDZCcKrDnLIW9YhuAnYaWQTW3DfRSIKIx+IlRdr8GIgAdpx8Whzo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557515023; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=0t7QgtOeCQfXREcVTu7XxQfpdZoMV1qUsNgUlpVZiG8=; b=oIsCVwGMnGHlifPNWsMooiXUn1OhcOxRZ+pVphM1O6XFrFKnGodrc/08ZqvD1TZ0wZDJNLdUN67NyUwry2r98hRCw5ESwx8udDFAyWBOqB50FEDcXROr3pxSHh8rZS9t/L/pdioQmAan7yWjcuaTCFwX8+2ywvc+CG6dHwERkMU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557515023399387.802042773092; Fri, 10 May 2019 12:03:43 -0700 (PDT) Received: from localhost ([127.0.0.1]:48630 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPAnz-0007O9-8h for importer@patchew.org; Fri, 10 May 2019 15:03:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPAh2-0000nv-3N for qemu-devel@nongnu.org; Fri, 10 May 2019 14:56:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPAh0-0000VU-4R for qemu-devel@nongnu.org; Fri, 10 May 2019 14:56:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32806) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hPAgz-0000Rq-V2 for qemu-devel@nongnu.org; Fri, 10 May 2019 14:56:26 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 19ACA307DAC8 for ; Fri, 10 May 2019 18:56:22 +0000 (UTC) Received: from localhost (ovpn-116-40.gru2.redhat.com [10.97.116.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B7615ED46; Fri, 10 May 2019 18:56:21 +0000 (UTC) From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 10 May 2019 15:56:20 -0300 Message-Id: <20190510185620.15757-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 10 May 2019 18:56:22 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] monitor: Call mon_get_cpu() only once at hmp_gva2gpa() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Dr. David Alan Gilbert" , Stefan Hajnoczi , Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" hmp_gva2gpa() calls mon_get_cpu() twice, which is unnecessary. Not an actual bug, but this is reported as a defect by Coverity Scan (CID 1401346). Signed-off-by: Eduardo Habkost Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Richard Henderson --- monitor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index bb48997913..6428eb3b7e 100644 --- a/monitor.c +++ b/monitor.c @@ -1685,8 +1685,7 @@ static void hmp_gva2gpa(Monitor *mon, const QDict *qd= ict) return; } =20 - gpa =3D cpu_get_phys_page_attrs_debug(mon_get_cpu(), - addr & TARGET_PAGE_MASK, &attrs); + gpa =3D cpu_get_phys_page_attrs_debug(cs, addr & TARGET_PAGE_MASK, &a= ttrs); if (gpa =3D=3D -1) { monitor_printf(mon, "Unmapped\n"); } else { --=20 2.18.0.rc1.1.g3f1ff2140