From nobody Tue Apr 30 08:04:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557484097; cv=none; d=zoho.com; s=zohoarc; b=T4PlUJ4l8iex7x4dK5ZLgCyjSfYLsyNDCeRucDCaSJcRvlLKGHvFktS1FWIbePC9U/s1HtrnIKn3KEiNQKfc7MZOsol97FvJuaK5/kx9E+J7bQy5YR4IaxYU6B1YUOGMwGpISIMc8tPqK366xUa0elbLFDLM9SBIBB1ujLnm+/g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557484097; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=niIO6UffLHGV2YWnRac5WSP1wTld7g5fL454pStYsXc=; b=d8lgFTydsuQ5WKkFBGpJsmDZaJwnsHE9NC+Ru3xA0lQ+sC9DENL3NC39OLm66Wm0KhJfv13xdkvJtgWk7YJo/I81YZoI1h91hlA7WmhuTPRgJaccxneyaL7R8WaS8vupUNg2mK5t91R+DnaNwiYHRMJWTmtYsI8sSx+hO/KJx80= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557484097121624.1492882699303; Fri, 10 May 2019 03:28:17 -0700 (PDT) Received: from localhost ([127.0.0.1]:40736 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP2ke-0007xz-NH for importer@patchew.org; Fri, 10 May 2019 06:27:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP2jk-0007Tg-JH for qemu-devel@nongnu.org; Fri, 10 May 2019 06:26:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hP2ji-0000Mg-L1 for qemu-devel@nongnu.org; Fri, 10 May 2019 06:26:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36898) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hP2ji-0000K5-Dq for qemu-devel@nongnu.org; Fri, 10 May 2019 06:26:42 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B5B32A4D21; Fri, 10 May 2019 10:26:40 +0000 (UTC) Received: from thinkpad.redhat.com (unknown [10.40.205.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 61E1C5D70D; Fri, 10 May 2019 10:26:38 +0000 (UTC) From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 10 May 2019 12:26:37 +0200 Message-Id: <20190510102637.10209-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 10 May 2019 10:26:40 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2] rng-builtin: add an RNG backend that uses qemu_guest_getrandom() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Kashyap Chamarthy , Amit Shah , Richard Henderson , Markus Armbruster , "Richard W . M . Jones" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Add a new RNG backend using QEMU builtin getrandom function. It can be created and used with something like: ... -object rng-builtin,id=3Drng0 -device virtio-rng,rng=3Drng0 ... Reviewed-by: Richard Henderson Signed-off-by: Laurent Vivier Reviewed-by: Daniel P. Berrang=C3=A9 --- Notes: This patch applies on top of "[PATCH v5 00/24] Add qemu_getrandom and ARMv8.5-RNG etc" Based-on: 20190510012458.22706-1-richard.henderson@linaro.org =20 v2: Update qemu-options.hx describe the new backend and specify virtio-rng uses the rng-random by default (do we want to change this?) backends/Makefile.objs | 2 +- backends/rng-builtin.c | 56 ++++++++++++++++++++++++++++++++++++++++++ qemu-options.hx | 10 +++++++- 3 files changed, 66 insertions(+), 2 deletions(-) create mode 100644 backends/rng-builtin.c diff --git a/backends/Makefile.objs b/backends/Makefile.objs index ff619d31b461..8da4a508d97b 100644 --- a/backends/Makefile.objs +++ b/backends/Makefile.objs @@ -1,4 +1,4 @@ -common-obj-y +=3D rng.o rng-egd.o +common-obj-y +=3D rng.o rng-egd.o rng-builtin.o common-obj-$(CONFIG_POSIX) +=3D rng-random.o =20 common-obj-$(CONFIG_TPM) +=3D tpm.o diff --git a/backends/rng-builtin.c b/backends/rng-builtin.c new file mode 100644 index 000000000000..b1264b745407 --- /dev/null +++ b/backends/rng-builtin.c @@ -0,0 +1,56 @@ +/* + * QEMU Builtin Random Number Generator Backend + * + * This work is licensed under the terms of the GNU GPL, version 2 or late= r. + * See the COPYING file in the top-level directory. + */ + +#include "qemu/osdep.h" +#include "sysemu/rng.h" +#include "qapi/error.h" +#include "qapi/qmp/qerror.h" +#include "qemu/main-loop.h" +#include "qemu/guest-random.h" + +#define TYPE_RNG_BUILTIN "rng-builtin" +#define RNG_BUILTIN(obj) OBJECT_CHECK(RngBuiltin, (obj), TYPE_RNG_BUILTIN) + +typedef struct RngBuiltin { + RngBackend parent; +} RngBuiltin; + +static void rng_builtin_request_entropy(RngBackend *b, RngRequest *req) +{ + RngBuiltin *s =3D RNG_BUILTIN(b); + + while (!QSIMPLEQ_EMPTY(&s->parent.requests)) { + RngRequest *req =3D QSIMPLEQ_FIRST(&s->parent.requests); + + qemu_guest_getrandom_nofail(req->data, req->size); + + req->receive_entropy(req->opaque, req->data, req->size); + + rng_backend_finalize_request(&s->parent, req); + } +} + +static void rng_builtin_class_init(ObjectClass *klass, void *data) +{ + RngBackendClass *rbc =3D RNG_BACKEND_CLASS(klass); + + rbc->request_entropy =3D rng_builtin_request_entropy; +} + +static const TypeInfo rng_builtin_info =3D { + .name =3D TYPE_RNG_BUILTIN, + .parent =3D TYPE_RNG_BACKEND, + .instance_size =3D sizeof(RngBuiltin), + .class_init =3D rng_builtin_class_init, +}; + +static void register_types(void) +{ + type_register_static(&rng_builtin_info); +} + +type_init(register_types); diff --git a/qemu-options.hx b/qemu-options.hx index 0191ef8b1eb7..3e2a51c691b0 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4280,13 +4280,21 @@ other options. =20 The @option{share} boolean option is @var{on} by default with memfd. =20 +@item -object rng-builtin,id=3D@var{id} + +Creates a random number generator backend which obtains entropy from +QEMU builtin functions. The @option{id} parameter is a unique ID that +will be used to reference this entropy backend from the @option{virtio-rng} +device. + @item -object rng-random,id=3D@var{id},filename=3D@var{/dev/random} =20 Creates a random number generator backend which obtains entropy from a device on the host. The @option{id} parameter is a unique ID that will be used to reference this entropy backend from the @option{virtio-rng} device. The @option{filename} parameter specifies which file to obtain -entropy from and if omitted defaults to @option{/dev/random}. +entropy from and if omitted defaults to @option{/dev/random}. By default, +the @option{virtio-rng} device uses this RNG backend. =20 @item -object rng-egd,id=3D@var{id},chardev=3D@var{chardevid} =20 --=20 2.20.1