From nobody Mon Nov 10 14:55:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ozlabs.org ARC-Seal: i=1; a=rsa-sha256; t=1557363028; cv=none; d=zoho.com; s=zohoarc; b=lzFepa3iJ8fH7SROcmI1NkioJbFyZoI8Jbb/RtHyxCzn4FmE/EV7jRt7fBG6kMpulOyUlr/W9Gpu0ngsBuEI1Dde5nysMlsZp8ofvcqjvC83kpobaq28I8OsVJTKQ7NHdwSiDhxqkAoUrELn6ycIj7lSpU2UlBXgGSSEwd1/rtk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557363028; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Ko7BmoJIaToCLKzZIJ8hqkxHtFouh5eKBdEQW+hKC+s=; b=Xje/yzQW6nNy8LYUYgpmzCqluGZIBARNEMwNbn+VX83BbpFeTQHVjlWp/O33JtWyK9Fh/goUX9EDpWV4S1ul3Du3D2l6JO/H/PhvHQTgnpQ11v9Te5W00SOfIWhKO1GI0ETWE7oazRpWxlh3/f0GfjeBN8lUvf4bHB5gtScJo8E= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557363028644497.2189075047188; Wed, 8 May 2019 17:50:28 -0700 (PDT) Received: from localhost ([127.0.0.1]:45745 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOXGT-0004kU-Ny for importer@patchew.org; Wed, 08 May 2019 20:50:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOXFS-0004NV-4D for qemu-devel@nongnu.org; Wed, 08 May 2019 20:49:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOXFR-0003S6-1f for qemu-devel@nongnu.org; Wed, 08 May 2019 20:49:22 -0400 Received: from ozlabs.org ([203.11.71.1]:39499) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hOXFO-0003ON-Rm; Wed, 08 May 2019 20:49:19 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 44zvqY3WzCz9s9T; Thu, 9 May 2019 10:49:13 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1557362953; bh=MEd9dxcvskEBkQaRIX15D4PtNkNhpfkqi3tnAZCafUQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BpXtFMixNCabcKmFElL1FDF3Uga06txtQAxmF3ih3Ask4Tq+28ruwQomiSiFxhp71 T6WzlIbyBnOV3VpCsnU/82SIs/Y8hesuWEj83N/5Ky0DBLBkpZVURNdbeQN3b5NiCu WirhJH3xhZe6fQi85HWKTpNJRTXODT6CFhSZaAulVlwhBVEv+gupH01YxtSU7n9PDb huxG4zecLoi9QhU1NMP1gsIEsR4vnuHMQs4dYt/SqPfgbiXz+HjFN+EfSeLNK8qr7Q +QlpHAsfS90csQA/u8U2nN+9dUjlrdwbcGnxSovFxPI/7SBXeKLcPE0+in3jFut27X jGXbMh8WyJdMQ== Date: Thu, 9 May 2019 10:49:12 +1000 From: Anton Blanchard To: David Gibson Message-ID: <20190509104912.6b754dff@kryten> In-Reply-To: <20190507052243.GH7073@umbus.fritz.box> References: <20190507004811.29968-1-anton@ozlabs.org> <20190507004811.29968-5-anton@ozlabs.org> <20190507052243.GH7073@umbus.fritz.box> X-Mailer: Mutt/1.8.0 (2017-02-23) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PATCH v2] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ego@linux.vnet.ibm.com, sandipandas1990@gmail.com, mark.cave-ayland@ilande.co.uk, richard.henderson@linaro.org, qemu-devel@nongnu.org, f4bug@amsat.org, qemu-ppc@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We were using set_cpu_vsr*() when we should have used get_cpu_vsr*(). Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and set_cpu_vsr{l,h}() h= elpers for VSR register access") Signed-off-by: Anton Blanchard Reviewed-by: Mark Cave-Ayland --- target/ppc/translate/vsx-impl.inc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/ppc/translate/vsx-impl.inc.c b/target/ppc/translate/vsx= -impl.inc.c index b487136d52..4b7627f53b 100644 --- a/target/ppc/translate/vsx-impl.inc.c +++ b/target/ppc/translate/vsx-impl.inc.c @@ -859,8 +859,8 @@ static void glue(gen_, name)(DisasContext *ctx) = \ xbh =3D tcg_temp_new_i64(); \ xbl =3D tcg_temp_new_i64(); \ sgm =3D tcg_temp_new_i64(); \ - set_cpu_vsrh(xB(ctx->opcode), xbh); \ - set_cpu_vsrl(xB(ctx->opcode), xbl); \ + get_cpu_vsrh(xbh, xB(ctx->opcode)); \ + get_cpu_vsrl(xbl, xB(ctx->opcode)); \ tcg_gen_movi_i64(sgm, sgn_mask); \ switch (op) { \ case OP_ABS: { \ --=20 2.20.1