From nobody Mon Nov 10 14:23:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ozlabs.org ARC-Seal: i=1; a=rsa-sha256; t=1557346770; cv=none; d=zoho.com; s=zohoarc; b=Qflf9DGZSUHH348JZTs9i6a7bLXD1gFKOJhhN2cSaglAvxq7ZWN/AIXD9JqVetag/R3ZDPBMg8AFoH3lmZE+SGNEGJIcdzqLB74+6kQLNI6fH/yefp6afIVqBo69h3sidQjQyhi/nVZw0M3Y1Pdy6t3X041vd97Cfbw4Hw3eXJA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557346770; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=DisGqDaNY/IFopt9gYmbJYAXWHIHm9NKpBglYptf3nE=; b=h5POc8s1iHfSt4l9qznuMp2Pt3c+Nkk2W3ppKZZJv9BLy9WL1yxySbZ0YklUeFLkdJwEuNrtRq+I0/MvtEy38EXt8JsUmo+7TBHtd+S2kq0TEFjnq9gUN6lVRUjiupxaeVM6C8sBs5FbPVTkCj+dSueWMyn90Rq6y2v1ltQhMvM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557346769756361.4726435560458; Wed, 8 May 2019 13:19:29 -0700 (PDT) Received: from localhost ([127.0.0.1]:43342 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOT27-0003Sj-PV for importer@patchew.org; Wed, 08 May 2019 16:19:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOT0q-0002sF-RT for qemu-devel@nongnu.org; Wed, 08 May 2019 16:18:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOT0p-0007z5-4j for qemu-devel@nongnu.org; Wed, 08 May 2019 16:18:00 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:54875 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hOT0o-0007iJ-I9; Wed, 08 May 2019 16:17:59 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 44znp62Wxhz9s9T; Thu, 9 May 2019 06:17:34 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1557346656; bh=1ZUozj+aqczDyPmG/j2bjCpGDLuHpAdkAJnlA7qalhU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PDFacoS2X0UZL4tT67LxdOeBFcBpEZYoLmKq8wLgO5Rg9etUPBbwzqdvNsoP38hNp 9IrL0U7xhw6LjUeSGJfc0VtH5UhdTMEA+o6WFVNEhwe7ZQ6E3locAxIyh8xfLFytfx uLMSzW52JbxinJmypPxb097E9KOH3ieSTwtYrZN150YCCSljGGLADiUwoKF9/4KrN/ VKnic537XwO9wsEZmMBLgioo9n0MJQB/o3OftAwnAfYJwlSjBs+VCuqYdRrxQRmGcJ 61ATKkob7gi3e1oCJf1ABf1tqQ4fu+F6eMacVhwTNa0vSeAxd/T40b+YbTXKiRpU7B n302R/OSLbZqQ== Date: Thu, 9 May 2019 06:17:33 +1000 From: Anton Blanchard To: David Gibson Message-ID: <20190509061713.69490488@kryten> In-Reply-To: <20190507052039.GF7073@umbus.fritz.box> References: <20190507004811.29968-1-anton@ozlabs.org> <20190507004811.29968-2-anton@ozlabs.org> <20190507052039.GF7073@umbus.fritz.box> X-Mailer: Mutt/1.8.0 (2017-02-23) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PATCH v2] target/ppc: Fix xxspltib X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ego@linux.vnet.ibm.com, sandipandas1990@gmail.com, mark.cave-ayland@ilande.co.uk, richard.henderson@linaro.org, qemu-devel@nongnu.org, f4bug@amsat.org, qemu-ppc@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" xxspltib raises a VMX or a VSX exception depending on the register set it is operating on. We had a check, but it was backwards. Fixes: f113283525a4 ("target-ppc: add xxspltib instruction") Signed-off-by: Anton Blanchard --- target/ppc/translate/vsx-impl.inc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/ppc/translate/vsx-impl.inc.c b/target/ppc/translate/vsx= -impl.inc.c index 4d8ca7cf32..4812a374aa 100644 --- a/target/ppc/translate/vsx-impl.inc.c +++ b/target/ppc/translate/vsx-impl.inc.c @@ -1355,13 +1355,13 @@ static void gen_xxspltib(DisasContext *ctx) int rt =3D xT(ctx->opcode); =20 if (rt < 32) { - if (unlikely(!ctx->altivec_enabled)) { - gen_exception(ctx, POWERPC_EXCP_VPU); + if (unlikely(!ctx->vsx_enabled)) { + gen_exception(ctx, POWERPC_EXCP_VSXU); return; } } else { - if (unlikely(!ctx->vsx_enabled)) { - gen_exception(ctx, POWERPC_EXCP_VSXU); + if (unlikely(!ctx->altivec_enabled)) { + gen_exception(ctx, POWERPC_EXCP_VPU); return; } } --=20 2.20.1