From nobody Mon Feb 9 11:33:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557350464; cv=none; d=zoho.com; s=zohoarc; b=NN2qVYtKiUuXzJoUBCxl6ISxsa4Zdm1v4ER0dc5X6e6qmu9zupDYpWy05dFeR3BF2h/1ZSXtP0Kj7L6c0oe6ixpdGq7SqnLmYIfH8CU/SQ7zZWo/1d5UVcaziR9nPOp/XfIPqNSn1Fr3QDA6dIqLWCpf20TRDQrYCDVjkhvuLho= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557350464; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=pxUjtSayP8COLRQAFIFYaJf95cYQ8T4TgUi8+sb1/1M=; b=EJ0i6wVT1TGOvc9PCkSfx0ZayYpWzxZf9Gn1vU7Ex4tMDS1aYLYmfls4udJnzRWIraSbgILAu4QYuvO38VCNpIwwTeSuv0EYFFqsbqY3jSRmwu8TeZu35LajJ8gsBsjHGgU64MC/6N46Cd0/bAnpvJHxpT1RurTCFZKwhadpFWQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557350464734472.8139891205012; Wed, 8 May 2019 14:21:04 -0700 (PDT) Received: from localhost ([127.0.0.1]:43917 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOTzg-00066m-1s for importer@patchew.org; Wed, 08 May 2019 17:20:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOTxb-0004mV-CQ for qemu-devel@nongnu.org; Wed, 08 May 2019 17:18:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOTxT-0005p9-DP for qemu-devel@nongnu.org; Wed, 08 May 2019 17:18:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60918) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hOTxO-0005nQ-M4; Wed, 08 May 2019 17:18:30 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 04C5B308620F; Wed, 8 May 2019 21:18:30 +0000 (UTC) Received: from localhost (ovpn-204-96.brq.redhat.com [10.40.204.96]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 93CD7107A432; Wed, 8 May 2019 21:18:29 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Date: Wed, 8 May 2019 23:18:18 +0200 Message-Id: <20190508211820.17851-4-mreitz@redhat.com> In-Reply-To: <20190508211820.17851-1-mreitz@redhat.com> References: <20190508211820.17851-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Wed, 08 May 2019 21:18:30 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v3 3/5] qemu-nbd: Do not close stderr X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" We kept old_stderr specifically so we could keep emitting error message on stderr. However, qemu_daemon() closes stderr. Therefore, we need to dup() stderr to old_stderr before invoking qemu_daemon(). Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- qemu-nbd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index edb5195208..e4446d479c 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -1014,10 +1014,11 @@ int main(int argc, char **argv) exit(EXIT_FAILURE); } else if (pid =3D=3D 0) { close(stderr_fd[0]); + + old_stderr =3D dup(STDERR_FILENO); ret =3D qemu_daemon(1, 0); =20 /* Temporarily redirect stderr to the parent's pipe... */ - old_stderr =3D dup(STDERR_FILENO); dup2(stderr_fd[1], STDERR_FILENO); if (ret < 0) { error_report("Failed to daemonize: %s", strerror(errno)); --=20 2.21.0