From nobody Mon Feb 9 14:34:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557217361; cv=none; d=zoho.com; s=zohoarc; b=Q++/wlujsoMHYGmGqrui1U0R2W9vCEwQPzLi5iwKsKY587DoJzY7LIV42BLNtWjN+yVCuO4MyF1FOqCh7YRPnyfKFozLxvhAtDVwTlfEBvdjyHBcUDqvW22Gbv5bLxxoGzv5BzaJ/QGsWQ3r1JOas6IDnJvEobpCU8z5Vtacogw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557217361; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=TKe64jQwheMAS31A430hSQOy+ZwUNyZ3U9yJ3MEawpA=; b=WrO9HLUgPo34+spSQGvgY7ihtuXDZZARawNIFQ9K+eUGkscq510x0y+7kcwOeXwjK0nP21h6oHI5cwyb3Tm41Kbk8twCweBxpsTvTc9VG8gv8u6S95SPSFFt507hC6Cr7S5uemmR0Tqkz2LcAGCEJFkaq3rwDzrmR+1VpczIcYM= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557217361367247.0978884421272; Tue, 7 May 2019 01:22:41 -0700 (PDT) Received: from localhost ([127.0.0.1]:42059 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNvMz-00034w-5M for importer@patchew.org; Tue, 07 May 2019 04:22:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNvKL-0000dz-O2 for qemu-devel@nongnu.org; Tue, 07 May 2019 04:19:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNvKK-00088s-Ns for qemu-devel@nongnu.org; Tue, 07 May 2019 04:19:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46226) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hNvKI-00086v-Nc; Tue, 07 May 2019 04:19:50 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F3C313097025; Tue, 7 May 2019 08:19:49 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-45.ams2.redhat.com [10.36.116.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 931E6171F1; Tue, 7 May 2019 08:19:47 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 801431750B; Tue, 7 May 2019 10:19:46 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Tue, 7 May 2019 10:19:39 +0200 Message-Id: <20190507081946.19264-2-kraxel@redhat.com> In-Reply-To: <20190507081946.19264-1-kraxel@redhat.com> References: <20190507081946.19264-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Tue, 07 May 2019 08:19:50 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 1/8] qxl: check release info object X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Prasad J Pandit , Alistair Francis , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Gerd Hoffmann , "Edgar E. Iglesias" , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Prasad J Pandit When releasing spice resources in release_resource() routine, if release info object 'ext.info' is null, it leads to null pointer dereference. Add check to avoid it. Reported-by: Bugs SysSec Signed-off-by: Prasad J Pandit Message-id: 20190425063534.32747-1-ppandit@redhat.com Signed-off-by: Gerd Hoffmann --- hw/display/qxl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index c8ce5781e037..632923add239 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -777,6 +777,9 @@ static void interface_release_resource(QXLInstance *sin, QXLReleaseRing *ring; uint64_t *item, id; =20 + if (!ext.info) { + return; + } if (ext.group_id =3D=3D MEMSLOT_GROUP_HOST) { /* host group -> vga mode update request */ QXLCommandExt *cmdext =3D (void *)(intptr_t)(ext.info->id); --=20 2.18.1