From nobody Fri May 3 13:12:33 2024 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1557167523; cv=none; d=zoho.com; s=zohoarc; b=S4LARHSN1zwWAoJjSvH53U7Q35XqjH6HSTvW5IV22jdAXdzD5m6DMhxNyh4lw95Q1S4Q9eykp1hP9CFvtAdNSt5Nfu3q2EFzWtwiIuB6J72UnbkNZ8D7k4rIUfQlmb2GRxNc9zwn9viHewztWu8QRtYRQPDyFITJ2lm+0WCAAT8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557167523; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=tOB7k/2hv0qgDPmpyJIjmIejxWr898ct1NuzMnEJO5o=; b=MUSFeeILU0R9aodluj2xC8d2cdfF+DArvAkHlqOUy+ilKhXyyIYabZIBSjsYDHWNOTLUMZBVLLIoBWkQydfNfaFSoSFiqUzi7cw8wIRCVs+ew2c2Ph0yp1YOot/GzESHUNWN3nSrbuQW8ZSZwmF+42ttMoQUzlJvGyS7hjjAbvo= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557167523789125.29376612931287; Mon, 6 May 2019 11:32:03 -0700 (PDT) Received: from localhost ([127.0.0.1]:60626 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNiOy-0008EF-AK for importer@patchew.org; Mon, 06 May 2019 14:31:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNiN1-0007Ds-MJ for qemu-devel@nongnu.org; Mon, 06 May 2019 14:29:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNiN0-0000IE-Bp for qemu-devel@nongnu.org; Mon, 06 May 2019 14:29:47 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:41115) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hNiN0-0000HS-3X for qemu-devel@nongnu.org; Mon, 06 May 2019 14:29:46 -0400 Received: by mail-pl1-x629.google.com with SMTP id d9so6783276pls.8 for ; Mon, 06 May 2019 11:29:46 -0700 (PDT) Received: from localhost.localdomain (97-113-189-189.tukw.qwest.net. [97.113.189.189]) by smtp.gmail.com with ESMTPSA id j32sm12909924pgi.73.2019.05.06.11.29.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 May 2019 11:29:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tOB7k/2hv0qgDPmpyJIjmIejxWr898ct1NuzMnEJO5o=; b=x+gDCQWrb4dORd3sZG+iZE+WUrUZJGWBWhX3G2TBLHhQIlLjMK45xy54joOqsNVAhg 7TwVA4wWbI88Ys2rL+fS4SNPmyGoYrpcPZZ8OSXnR2YsdE1wecN2ui1CEP9gzXpiw3Oj 3el0ojP/U6nAFOXczberquzHpEqCRoqlJ7JN4jFYFE11vsOkxq8KY3Vown5Uiz6OrII2 pAoyeXt+jgROX6YEWSKoRNFdghasxJ3RngZ+06vSDAQ1hk5LHWLPQe+Edl5xYUzgZAlD ZYVkM8A2EQmyKqCqw6MzP7KPzJZPOsda2D4wP6iWuGBJEJsWqPi5hH/sLxG1P67XOBMW OE7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tOB7k/2hv0qgDPmpyJIjmIejxWr898ct1NuzMnEJO5o=; b=Q6PFTXFc+5691ou4Sk0CtgX9ES1gWl2yBAaQ6y91KPXURbqHnrnnSp9pQDuRHbb0kp rq4jEyAZpHWrO4ugyY9i8dTNyXGC/rutOMUXj5GDO1RW3NGkMW7/CWzAoG6wTbmpmYMc bo77w9aMFK2gb52m8p9HBgx6T3E4stUezQ/QNlH/Unfn5pcgdda4E3acTrpd6ppWpi8l RxBnjPybMI2elFDaawpdSwY/BmhPoPm6bsnx/ZHtT+vT+6RbhUJPJaU+oi7LSfn5qg8h tasVaDN146CASqEbA4/tifTAcukmXMNykaA+rQ9/bJvomkhilYwxLqk3hD55TtDvOktw ibbw== X-Gm-Message-State: APjAAAWCQoC5Yb8T31zwjzyYmlMAnT+8dNwIOVC0NUA222qs8TXA9WCT eFriABNRlAB3dw2HzRcqDkRNj7W3psw= X-Google-Smtp-Source: APXvYqyXxppT+7rZDvcpBZkYT3Uzz/KIqAmBRv9Xi4hS1K3xDb8iKmKfcCQgMz0gOXDBEtqAF2T1qA== X-Received: by 2002:a17:902:e183:: with SMTP id cd3mr34356435plb.233.1557167384669; Mon, 06 May 2019 11:29:44 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 6 May 2019 11:29:38 -0700 Message-Id: <20190506182940.2200-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190506182940.2200-1-richard.henderson@linaro.org> References: <20190506182940.2200-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::629 Subject: [Qemu-devel] [PULL 1/3] decodetree: Initial support for variable-length ISAs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Assuming that the ISA clearly describes how to determine the length of the instruction, and the ISA has a reasonable maximum instruction length, the input to the decoder can be right-justified in an appropriate insn word. This is not 100% convenient, as out-of-line %fields are numbered relative to the maximum instruction length, but this appears to still be usable. Signed-off-by: Richard Henderson --- scripts/decodetree.py | 49 ++++++++++++++++++++++++++++++++----------- 1 file changed, 37 insertions(+), 12 deletions(-) diff --git a/scripts/decodetree.py b/scripts/decodetree.py index aa790b596a..555a46522b 100755 --- a/scripts/decodetree.py +++ b/scripts/decodetree.py @@ -27,6 +27,7 @@ import getopt =20 insnwidth =3D 32 insnmask =3D 0xffffffff +variablewidth =3D False fields =3D {} arguments =3D {} formats =3D {} @@ -289,7 +290,7 @@ class Arguments: =20 class General: """Common code between instruction formats and instruction patterns""" - def __init__(self, name, lineno, base, fixb, fixm, udfm, fldm, flds): + def __init__(self, name, lineno, base, fixb, fixm, udfm, fldm, flds, w= ): self.name =3D name self.file =3D input_file self.lineno =3D lineno @@ -299,6 +300,7 @@ class General: self.undefmask =3D udfm self.fieldmask =3D fldm self.fields =3D flds + self.width =3D w =20 def __str__(self): return self.name + ' ' + str_match_bits(self.fixedbits, self.fixed= mask) @@ -352,7 +354,7 @@ class Pattern(General): class MultiPattern(General): """Class representing an overlapping set of instruction patterns""" =20 - def __init__(self, lineno, pats, fixb, fixm, udfm): + def __init__(self, lineno, pats, fixb, fixm, udfm, w): self.file =3D input_file self.lineno =3D lineno self.pats =3D pats @@ -360,6 +362,7 @@ class MultiPattern(General): self.fixedbits =3D fixb self.fixedmask =3D fixm self.undefmask =3D udfm + self.width =3D w =20 def __str__(self): r =3D "{" @@ -502,7 +505,7 @@ def infer_argument_set(flds): return arg =20 =20 -def infer_format(arg, fieldmask, flds): +def infer_format(arg, fieldmask, flds, width): global arguments global formats global decode_function @@ -521,6 +524,8 @@ def infer_format(arg, fieldmask, flds): continue if fieldmask !=3D fmt.fieldmask: continue + if width !=3D fmt.width: + continue if not eq_fields_for_fmts(flds, fmt.fields): continue return (fmt, const_flds) @@ -529,7 +534,7 @@ def infer_format(arg, fieldmask, flds): if not arg: arg =3D infer_argument_set(flds) =20 - fmt =3D Format(name, 0, arg, 0, 0, 0, fieldmask, var_flds) + fmt =3D Format(name, 0, arg, 0, 0, 0, fieldmask, var_flds, width) formats[name] =3D fmt =20 return (fmt, const_flds) @@ -546,6 +551,7 @@ def parse_generic(lineno, is_format, name, toks): global re_ident global insnwidth global insnmask + global variablewidth =20 fixedmask =3D 0 fixedbits =3D 0 @@ -633,8 +639,15 @@ def parse_generic(lineno, is_format, name, toks): error(lineno, 'invalid token "{0}"'.format(t)) width +=3D shift =20 + if variablewidth and width < insnwidth and width % 8 =3D=3D 0: + shift =3D insnwidth - width + fixedbits <<=3D shift + fixedmask <<=3D shift + undefmask <<=3D shift + undefmask |=3D (1 << shift) - 1 + # We should have filled in all of the bits of the instruction. - if not (is_format and width =3D=3D 0) and width !=3D insnwidth: + elif not (is_format and width =3D=3D 0) and width !=3D insnwidth: error(lineno, 'definition has {0} bits'.format(width)) =20 # Do not check for fields overlaping fields; one valid usage @@ -660,7 +673,7 @@ def parse_generic(lineno, is_format, name, toks): if name in formats: error(lineno, 'duplicate format name', name) fmt =3D Format(name, lineno, arg, fixedbits, fixedmask, - undefmask, fieldmask, flds) + undefmask, fieldmask, flds, width) formats[name] =3D fmt else: # Patterns can reference a format ... @@ -670,12 +683,14 @@ def parse_generic(lineno, is_format, name, toks): error(lineno, 'pattern specifies both format and argument = set') if fixedmask & fmt.fixedmask: error(lineno, 'pattern fixed bits overlap format fixed bit= s') + if width !=3D fmt.width: + error(lineno, 'pattern uses format of different width') fieldmask |=3D fmt.fieldmask fixedbits |=3D fmt.fixedbits fixedmask |=3D fmt.fixedmask undefmask |=3D fmt.undefmask else: - (fmt, flds) =3D infer_format(arg, fieldmask, flds) + (fmt, flds) =3D infer_format(arg, fieldmask, flds, width) arg =3D fmt.base for f in flds.keys(): if f not in arg.fields: @@ -687,7 +702,7 @@ def parse_generic(lineno, is_format, name, toks): if f not in flds.keys() and f not in fmt.fields.keys(): error(lineno, 'field {0} not initialized'.format(f)) pat =3D Pattern(name, lineno, fmt, fixedbits, fixedmask, - undefmask, fieldmask, flds) + undefmask, fieldmask, flds, width) patterns.append(pat) allpatterns.append(pat) =20 @@ -727,6 +742,13 @@ def build_multi_pattern(lineno, pats): if p.lineno < lineno: lineno =3D p.lineno =20 + width =3D None + for p in pats: + if width is None: + width =3D p.width + elif width !=3D p.width: + error(lineno, 'width mismatch in patterns within braces') + repeat =3D True while repeat: if fixedmask =3D=3D 0: @@ -742,7 +764,7 @@ def build_multi_pattern(lineno, pats): else: repeat =3D False =20 - mp =3D MultiPattern(lineno, pats, fixedbits, fixedmask, undefmask) + mp =3D MultiPattern(lineno, pats, fixedbits, fixedmask, undefmask, wid= th) patterns.append(mp) # end build_multi_pattern =20 @@ -979,13 +1001,14 @@ def main(): global insntype global insnmask global decode_function + global variablewidth =20 decode_scope =3D 'static ' =20 long_opts =3D ['decode=3D', 'translate=3D', 'output=3D', 'insnwidth=3D= ', - 'static-decode=3D'] + 'static-decode=3D', 'varinsnwidth=3D'] try: - (opts, args) =3D getopt.getopt(sys.argv[1:], 'o:w:', long_opts) + (opts, args) =3D getopt.getopt(sys.argv[1:], 'o:vw:', long_opts) except getopt.GetoptError as err: error(0, err) for o, a in opts: @@ -999,7 +1022,9 @@ def main(): elif o =3D=3D '--translate': translate_prefix =3D a translate_scope =3D '' - elif o in ('-w', '--insnwidth'): + elif o in ('-w', '--insnwidth', '--varinsnwidth'): + if o =3D=3D '--varinsnwidth': + variablewidth =3D True insnwidth =3D int(a) if insnwidth =3D=3D 16: insntype =3D 'uint16_t' --=20 2.17.1 From nobody Fri May 3 13:12:33 2024 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1557167524; cv=none; d=zoho.com; s=zohoarc; b=F1Iu0molQ2gF7a2EMlWon9Qsq81UOKTonkQ0VjIHSZyoYp8fPFdCl64eBhnNkUU+1MvOnp7hco+GemmCGon/pEn0/LFem8kNKT0KQrwEXc0lDxkomk+WsULy0kdOHXEusuFjfcV12mf0ALw2ruEG3Awl/d+3G8RzEuar87LDDgQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557167524; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=aOndsQdbM3kEhAR2nREOKWxj88rFf9PBZroBuJd+MwA=; b=Whx2voqKK/jhFTgpuCkT0YJXsQGGP4UsJhoFkzedOFqEKvnPYTlj5d9gHGiESl7AHZ+qO/vCx7oGNH+Yd16H+1t0l3qIs+wWNcuc5MQVlGclZOPXTfozDjNuacaaaTyMDIotIkuyzp+DjIvDY4U3k7y/bhgiu5PnRtJ7YJrNGRw= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557167524056499.7126286600942; Mon, 6 May 2019 11:32:04 -0700 (PDT) Received: from localhost ([127.0.0.1]:60628 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNiOz-0008FG-0U for importer@patchew.org; Mon, 06 May 2019 14:31:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNiN2-0007E1-SV for qemu-devel@nongnu.org; Mon, 06 May 2019 14:29:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNiN1-0000JS-KQ for qemu-devel@nongnu.org; Mon, 06 May 2019 14:29:48 -0400 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:35271) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hNiN1-0000Iq-Cu for qemu-devel@nongnu.org; Mon, 06 May 2019 14:29:47 -0400 Received: by mail-pl1-x62b.google.com with SMTP id w24so6793929plp.2 for ; Mon, 06 May 2019 11:29:47 -0700 (PDT) Received: from localhost.localdomain (97-113-189-189.tukw.qwest.net. [97.113.189.189]) by smtp.gmail.com with ESMTPSA id j32sm12909924pgi.73.2019.05.06.11.29.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 May 2019 11:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aOndsQdbM3kEhAR2nREOKWxj88rFf9PBZroBuJd+MwA=; b=up0KztIyuKg4cu1gGVw+Wxq/RuJ4ShV6LODEOlgIX8oj+gn+p4DBogoCU5OQTVml9p 7jEPjWGVUoOrYstZ1D59Yp48SfA5wQcT94OBV/Gng+Xv7g8wdbwImMcv4vx7k15vDUrm BY7xNPlnn0Bw3K8vsh06laeopbYQBduanb/Ro9ocXVY21LikqxYl+lDTHjSAAZTlqWmN E0ycI/a347k0upGt8ddI+kaixtX0hP0Yp4JE25bgJqGu9YFYkFlrLU+ej4uUDwVjt8mb yNMr0TIkQ+ZH3uHr7Bnpkh3RRB76Us6ftzGYutuW8u/e0KJVRZIJGTCRG8Vc4UebXVBi yF5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aOndsQdbM3kEhAR2nREOKWxj88rFf9PBZroBuJd+MwA=; b=AS+LoPBnN3ZZhR3S1XNiwH90wNtXqSVZHKzfXIr9mZ2cnTEZU/sBbkkstpN+Wx6HNS 1S4UmM9HQ8pJJLKAtbcNPc1rt/Aad/HgddiVYdJwM7LybMd9fiz6zpJTKqSfC/QuwgP8 dtGq6qdHsfbc88MjH+FNdOY5jW1HqBRpfC18P+aqcIb7W/QlACeKi+D0r1oplLF3J+rS SMJrpDRrey3C57pGPK5BAwEk05nWSJJLeFBuV/F0edy0Olu4s7DieP9n6Xc3gKDAIJYY kmUeXEu8dLJDgmracZmBmSVkND9zmOaeFKv6LJwipSMsVscprsVWXDzyOhfln/0tOYjo 4hFw== X-Gm-Message-State: APjAAAXjedxD762EymnoQTZ13gTBghyJDutnfpI5F9q9WpPj9MmLp3BY aBUEL/MQTSwFB23Jwm9g6uxKJumaEn4= X-Google-Smtp-Source: APXvYqz1/7f7xnCt0OShcdN0tRwwj9HWpGsbHp6mKOLQP5r3iQfpGSdTV3/tbf1lTGbusI9uuHvyFA== X-Received: by 2002:a17:902:6b8b:: with SMTP id p11mr33685759plk.225.1557167385988; Mon, 06 May 2019 11:29:45 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 6 May 2019 11:29:39 -0700 Message-Id: <20190506182940.2200-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190506182940.2200-1-richard.henderson@linaro.org> References: <20190506182940.2200-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::62b Subject: [Qemu-devel] [PULL 2/3] decodetree: Expand a decode_load function X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Read the instruction, loading no more bytes than necessary. Signed-off-by: Richard Henderson --- scripts/decodetree.py | 175 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 172 insertions(+), 3 deletions(-) diff --git a/scripts/decodetree.py b/scripts/decodetree.py index 555a46522b..4536e3a63d 100755 --- a/scripts/decodetree.py +++ b/scripts/decodetree.py @@ -965,6 +965,147 @@ def build_tree(pats, outerbits, outermask): # end build_tree =20 =20 +class SizeTree: + """Class representing a node in a size decode tree""" + + def __init__(self, m, w): + self.mask =3D m + self.subs =3D [] + self.base =3D None + self.width =3D w + + def str1(self, i): + ind =3D str_indent(i) + r =3D '{0}{1:08x}'.format(ind, self.mask) + r +=3D ' [\n' + for (b, s) in self.subs: + r +=3D '{0} {1:08x}:\n'.format(ind, b) + r +=3D s.str1(i + 4) + '\n' + r +=3D ind + ']' + return r + + def __str__(self): + return self.str1(0) + + def output_code(self, i, extracted, outerbits, outermask): + ind =3D str_indent(i) + + # If we need to load more bytes to test, do so now. + if extracted < self.width: + output(ind, 'insn =3D ', decode_function, + '_load_bytes(ctx, insn, {0}, {1});\n' + .format(extracted / 8, self.width / 8)); + extracted =3D self.width + + # Attempt to aid the compiler in producing compact switch statemen= ts. + # If the bits in the mask are contiguous, extract them. + sh =3D is_contiguous(self.mask) + if sh > 0: + # Propagate SH down into the local functions. + def str_switch(b, sh=3Dsh): + return '(insn >> {0}) & 0x{1:x}'.format(sh, b >> sh) + + def str_case(b, sh=3Dsh): + return '0x{0:x}'.format(b >> sh) + else: + def str_switch(b): + return 'insn & 0x{0:08x}'.format(b) + + def str_case(b): + return '0x{0:08x}'.format(b) + + output(ind, 'switch (', str_switch(self.mask), ') {\n') + for b, s in sorted(self.subs): + innermask =3D outermask | self.mask + innerbits =3D outerbits | b + output(ind, 'case ', str_case(b), ':\n') + output(ind, ' /* ', + str_match_bits(innerbits, innermask), ' */\n') + s.output_code(i + 4, extracted, innerbits, innermask) + output(ind, '}\n') + output(ind, 'return insn;\n') +# end SizeTree + +class SizeLeaf: + """Class representing a leaf node in a size decode tree""" + + def __init__(self, m, w): + self.mask =3D m + self.width =3D w + + def str1(self, i): + ind =3D str_indent(i) + return '{0}{1:08x}'.format(ind, self.mask) + + def __str__(self): + return self.str1(0) + + def output_code(self, i, extracted, outerbits, outermask): + global decode_function + ind =3D str_indent(i) + + # If we need to load more bytes, do so now. + if extracted < self.width: + output(ind, 'insn =3D ', decode_function, + '_load_bytes(ctx, insn, {0}, {1});\n' + .format(extracted / 8, self.width / 8)); + extracted =3D self.width + output(ind, 'return insn;\n') +# end SizeLeaf + + +def build_size_tree(pats, width, outerbits, outermask): + global insnwidth + + # Collect the mask of bits that are fixed in this width + innermask =3D 0xff << (insnwidth - width) + innermask &=3D ~outermask + minwidth =3D None + onewidth =3D True + for i in pats: + innermask &=3D i.fixedmask + if minwidth is None: + minwidth =3D i.width + elif minwidth !=3D i.width: + onewidth =3D False; + if minwidth < i.width: + minwidth =3D i.width + + if onewidth: + return SizeLeaf(innermask, minwidth) + + if innermask =3D=3D 0: + if width < minwidth: + return build_size_tree(pats, width + 8, outerbits, outermask) + + pnames =3D [] + for p in pats: + pnames.append(p.name + ':' + p.file + ':' + str(p.lineno)) + error_with_file(pats[0].file, pats[0].lineno, + 'overlapping patterns size {0}:'.format(width), pn= ames) + + bins =3D {} + for i in pats: + fb =3D i.fixedbits & innermask + if fb in bins: + bins[fb].append(i) + else: + bins[fb] =3D [i] + + fullmask =3D outermask | innermask + lens =3D sorted(bins.keys()) + if len(lens) =3D=3D 1: + b =3D lens[0] + return build_size_tree(bins[b], width + 8, b | outerbits, fullmask) + + r =3D SizeTree(innermask, width) + for b, l in bins.items(): + s =3D build_size_tree(l, width, b | outerbits, fullmask) + r.subs.append((b, s)) + return r +# end build_size_tree + + def prop_format(tree): """Propagate Format objects into the decode tree""" =20 @@ -987,6 +1128,23 @@ def prop_format(tree): # end prop_format =20 =20 +def prop_size(tree): + """Propagate minimum widths up the decode size tree""" + + if isinstance(tree, SizeTree): + min =3D None + for (b, s) in tree.subs: + width =3D prop_size(s) + if min is None or min > width: + min =3D width + assert min >=3D tree.width + tree.width =3D min + else: + min =3D tree.width + return min +# end prop_size + + def main(): global arguments global formats @@ -1042,8 +1200,12 @@ def main(): parse_file(f) f.close() =20 - t =3D build_tree(patterns, 0, 0) - prop_format(t) + if variablewidth: + stree =3D build_size_tree(patterns, 8, 0, 0) + prop_size(stree) + + dtree =3D build_tree(patterns, 0, 0) + prop_format(dtree) =20 if output_file: output_fd =3D open(output_file, 'w') @@ -1084,11 +1246,18 @@ def main(): f =3D arguments[n] output(i4, i4, f.struct_name(), ' f_', f.name, ';\n') output(i4, '} u;\n\n') - t.output_code(4, False, 0, 0) + dtree.output_code(4, False, 0, 0) =20 output(i4, 'return false;\n') output('}\n') =20 + if variablewidth: + output('\n', decode_scope, insntype, ' ', decode_function, + '_load(DisasContext *ctx)\n{\n', + ' ', insntype, ' insn =3D 0;\n\n') + stree.output_code(4, 0, 0, 0) + output('}\n') + if output_file: output_fd.close() # end main --=20 2.17.1 From nobody Fri May 3 13:12:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1557167662; cv=none; d=zoho.com; s=zohoarc; b=auFMILpu6rTm3hzPW/zxn1L+wLf6kiMsfS84mpXQsTiTdn/7/c3a9q6kC5jHewrrnsDntZW4iyvRp+Qsj+9WpcqvSu5puGfCfla4MCxqRtg+qmsalnFUVYDdrv+PGCIUIrJpiNieNpIr3d+BLfLvEMhyfCtkSqP1sx54yumxKqM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557167662; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=5O+OzCYzy78V1uswfGstaXgkM49gQkBz6dXALOrBXUQ=; b=gnFEN1yoQ4gyjVBB6UvNVQ9mwT4BXQJSBzE1Ktjb3m5lqfPFfHoE7ESjRVO9QAyZjz2A8sFMU83l8t7aJBbgAje8ydEGiVtDHPVACrIfTh/snsO9gRWagbSfLoLd+BJ82ZzF+ttjtlrsDJVml39wvIXQppZswPtsJV/nRtC/Pv8= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1557167662262625.0588451610447; Mon, 6 May 2019 11:34:22 -0700 (PDT) Received: from localhost ([127.0.0.1]:60657 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNiRP-0001OA-9K for importer@patchew.org; Mon, 06 May 2019 14:34:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNiN4-0007Fj-P2 for qemu-devel@nongnu.org; Mon, 06 May 2019 14:29:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNiN3-0000L4-5v for qemu-devel@nongnu.org; Mon, 06 May 2019 14:29:50 -0400 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]:38041) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hNiN2-0000K7-Tg for qemu-devel@nongnu.org; Mon, 06 May 2019 14:29:49 -0400 Received: by mail-pf1-x433.google.com with SMTP id 10so7214511pfo.5 for ; Mon, 06 May 2019 11:29:48 -0700 (PDT) Received: from localhost.localdomain (97-113-189-189.tukw.qwest.net. [97.113.189.189]) by smtp.gmail.com with ESMTPSA id j32sm12909924pgi.73.2019.05.06.11.29.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 May 2019 11:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5O+OzCYzy78V1uswfGstaXgkM49gQkBz6dXALOrBXUQ=; b=o9FCGohSaa3uY9gJvsV/1F1r67O1Gx5jG+5cC4IomQbKBWy+ZX8UjmHhInX8hYGYKm GX+A1HK/MoBIlWQBte1BarAdtbsoiAYbnXbk1UMil9CfldhC+V/HDoOlY6/8RcLWk/Sa sHw3PK7nW25yc6zJUKi0LUmCxnDOoxZjYE071EEKnob53ZfQpGxxc3tqN75j4EydjHy5 fWJDcFfSf29XCasK0TZFaNfa7yokv85A8hYDMoLefAhzeVrsXxe1mLQca9k9iYu6m2DO aN6BC4btjFq3ck1ujWcBuJhkalQ9vC8RqXxBYnFiHcKdmOxi+BBTZKStGds1LVumLd3A /LlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5O+OzCYzy78V1uswfGstaXgkM49gQkBz6dXALOrBXUQ=; b=fKyoW1ICiWwuEkp0LEhW/mhaFOaFa8/V34FxNUSHRXr+vk7Upal2IZl8AYIKkB9SJI nMwaqJ8jN4vvINVgRq7HprU5rj6GpzMkS6pFVue7w8FIKO9AAZd20jlkxs9+SkKEcHR4 +CFDbF5VZXZC07SFY+nCM3JwNxbz96n5WQnFiI68xGZnDVXn81w58iQr3pFmP9dB3rJ0 yU5R35ZYvjfkTv8MY3DlFkm0zrN6L42dU8huTYQl4YP73iF00wCz/6JDGKJPCXGGbpvk hZIX+t3QrpxUqvDS9DWT3YExzhJtZvIlZSgIr6jM6cujKrTDOj+9+256PJRiZz833eJF CGHQ== X-Gm-Message-State: APjAAAXi9rEHbanJVxjZcUKtw/Wxcy+J+vPjwBa35JdKC6J8p/Er02Um zJdhqXnuyighcK8EIA6PiodW0nECS4s= X-Google-Smtp-Source: APXvYqyIDU5tdKrz+kIgV6fPgzBZb1MpHEMy0TZSm8VsDPejHVBsbt/zhO34WYoy6XQgu/pnY7lzFg== X-Received: by 2002:a63:f754:: with SMTP id f20mr33240247pgk.162.1557167387307; Mon, 06 May 2019 11:29:47 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 6 May 2019 11:29:40 -0700 Message-Id: <20190506182940.2200-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190506182940.2200-1-richard.henderson@linaro.org> References: <20190506182940.2200-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::433 Subject: [Qemu-devel] [PULL 3/3] decodetree: Add DisasContext argument to !function expanders X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This does require adjusting all existing users. Signed-off-by: Richard Henderson --- target/arm/translate-sve.c | 24 ++++++++++++------------ target/hppa/translate.c | 16 ++++++++-------- target/riscv/insn_trans/trans_rvc.inc.c | 10 +++++----- target/riscv/translate.c | 4 ++-- scripts/decodetree.py | 9 +++++---- 5 files changed, 32 insertions(+), 31 deletions(-) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 245cd82621..80645db508 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -54,35 +54,35 @@ typedef void gen_helper_gvec_mem_scatter(TCGv_env, TCGv= _ptr, TCGv_ptr, /* See e.g. ASR (immediate, predicated). * Returns -1 for unallocated encoding; diagnose later. */ -static int tszimm_esz(int x) +static int tszimm_esz(DisasContext *s, int x) { x >>=3D 3; /* discard imm3 */ return 31 - clz32(x); } =20 -static int tszimm_shr(int x) +static int tszimm_shr(DisasContext *s, int x) { - return (16 << tszimm_esz(x)) - x; + return (16 << tszimm_esz(s, x)) - x; } =20 /* See e.g. LSL (immediate, predicated). */ -static int tszimm_shl(int x) +static int tszimm_shl(DisasContext *s, int x) { - return x - (8 << tszimm_esz(x)); + return x - (8 << tszimm_esz(s, x)); } =20 -static inline int plus1(int x) +static inline int plus1(DisasContext *s, int x) { return x + 1; } =20 /* The SH bit is in bit 8. Extract the low 8 and shift. */ -static inline int expand_imm_sh8s(int x) +static inline int expand_imm_sh8s(DisasContext *s, int x) { return (int8_t)x << (x & 0x100 ? 8 : 0); } =20 -static inline int expand_imm_sh8u(int x) +static inline int expand_imm_sh8u(DisasContext *s, int x) { return (uint8_t)x << (x & 0x100 ? 8 : 0); } @@ -90,7 +90,7 @@ static inline int expand_imm_sh8u(int x) /* Convert a 2-bit memory size (msz) to a 4-bit data type (dtype) * with unsigned data. C.f. SVE Memory Contiguous Load Group. */ -static inline int msz_dtype(int msz) +static inline int msz_dtype(DisasContext *s, int msz) { static const uint8_t dtype[4] =3D { 0, 5, 10, 15 }; return dtype[msz]; @@ -4834,7 +4834,7 @@ static void do_ldrq(DisasContext *s, int zt, int pg, = TCGv_i64 addr, int msz) int desc, poff; =20 /* Load the first quadword using the normal predicated load helpers. = */ - desc =3D sve_memopidx(s, msz_dtype(msz)); + desc =3D sve_memopidx(s, msz_dtype(s, msz)); desc |=3D zt << MEMOPIDX_SHIFT; desc =3D simd_desc(16, 16, desc); t_desc =3D tcg_const_i32(desc); @@ -5016,7 +5016,7 @@ static void do_st_zpa(DisasContext *s, int zt, int pg= , TCGv_i64 addr, fn =3D fn_multiple[be][nreg - 1][msz]; } assert(fn !=3D NULL); - do_mem_zpa(s, zt, pg, addr, msz_dtype(msz), fn); + do_mem_zpa(s, zt, pg, addr, msz_dtype(s, msz), fn); } =20 static bool trans_ST_zprr(DisasContext *s, arg_rprr_store *a) @@ -5065,7 +5065,7 @@ static void do_mem_zpz(DisasContext *s, int zt, int p= g, int zm, TCGv_i32 t_desc; int desc; =20 - desc =3D sve_memopidx(s, msz_dtype(msz)); + desc =3D sve_memopidx(s, msz_dtype(s, msz)); desc |=3D scale << MEMOPIDX_SHIFT; desc =3D simd_desc(vsz, vsz, desc); t_desc =3D tcg_const_i32(desc); diff --git a/target/hppa/translate.c b/target/hppa/translate.c index e1febdfea1..188fe688cb 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -279,7 +279,7 @@ typedef struct DisasContext { } DisasContext; =20 /* Note that ssm/rsm instructions number PSW_W and PSW_E differently. */ -static int expand_sm_imm(int val) +static int expand_sm_imm(DisasContext *ctx, int val) { if (val & PSW_SM_E) { val =3D (val & ~PSW_SM_E) | PSW_E; @@ -291,43 +291,43 @@ static int expand_sm_imm(int val) } =20 /* Inverted space register indicates 0 means sr0 not inferred from base. = */ -static int expand_sr3x(int val) +static int expand_sr3x(DisasContext *ctx, int val) { return ~val; } =20 /* Convert the M:A bits within a memory insn to the tri-state value we use for the final M. */ -static int ma_to_m(int val) +static int ma_to_m(DisasContext *ctx, int val) { return val & 2 ? (val & 1 ? -1 : 1) : 0; } =20 /* Convert the sign of the displacement to a pre or post-modify. */ -static int pos_to_m(int val) +static int pos_to_m(DisasContext *ctx, int val) { return val ? 1 : -1; } =20 -static int neg_to_m(int val) +static int neg_to_m(DisasContext *ctx, int val) { return val ? -1 : 1; } =20 /* Used for branch targets and fp memory ops. */ -static int expand_shl2(int val) +static int expand_shl2(DisasContext *ctx, int val) { return val << 2; } =20 /* Used for fp memory ops. */ -static int expand_shl3(int val) +static int expand_shl3(DisasContext *ctx, int val) { return val << 3; } =20 /* Used for assemble_21. */ -static int expand_shl11(int val) +static int expand_shl11(DisasContext *ctx, int val) { return val << 11; } diff --git a/target/riscv/insn_trans/trans_rvc.inc.c b/target/riscv/insn_tr= ans/trans_rvc.inc.c index ebcd977b2f..3e5d6fd5ea 100644 --- a/target/riscv/insn_trans/trans_rvc.inc.c +++ b/target/riscv/insn_trans/trans_rvc.inc.c @@ -48,13 +48,13 @@ static bool trans_c_flw_ld(DisasContext *ctx, arg_c_flw= _ld *a) REQUIRE_EXT(ctx, RVF); =20 arg_c_lw tmp; - decode_insn16_extract_cl_w(&tmp, ctx->opcode); + decode_insn16_extract_cl_w(ctx, &tmp, ctx->opcode); arg_flw arg =3D { .rd =3D tmp.rd, .rs1 =3D tmp.rs1, .imm =3D tmp.uimm = }; return trans_flw(ctx, &arg); #else /* C.LD ( RV64C/RV128C-only ) */ arg_c_fld tmp; - decode_insn16_extract_cl_d(&tmp, ctx->opcode); + decode_insn16_extract_cl_d(ctx, &tmp, ctx->opcode); arg_ld arg =3D { .rd =3D tmp.rd, .rs1 =3D tmp.rs1, .imm =3D tmp.uimm }; return trans_ld(ctx, &arg); #endif @@ -80,13 +80,13 @@ static bool trans_c_fsw_sd(DisasContext *ctx, arg_c_fsw= _sd *a) REQUIRE_EXT(ctx, RVF); =20 arg_c_sw tmp; - decode_insn16_extract_cs_w(&tmp, ctx->opcode); + decode_insn16_extract_cs_w(ctx, &tmp, ctx->opcode); arg_fsw arg =3D { .rs1 =3D tmp.rs1, .rs2 =3D tmp.rs2, .imm =3D tmp.uim= m }; return trans_fsw(ctx, &arg); #else /* C.SD ( RV64C/RV128C-only ) */ arg_c_fsd tmp; - decode_insn16_extract_cs_d(&tmp, ctx->opcode); + decode_insn16_extract_cs_d(ctx, &tmp, ctx->opcode); arg_sd arg =3D { .rs1 =3D tmp.rs1, .rs2 =3D tmp.rs2, .imm =3D tmp.uimm= }; return trans_sd(ctx, &arg); #endif @@ -107,7 +107,7 @@ static bool trans_c_jal_addiw(DisasContext *ctx, arg_c_= jal_addiw *a) #ifdef TARGET_RISCV32 /* C.JAL */ arg_c_j tmp; - decode_insn16_extract_cj(&tmp, ctx->opcode); + decode_insn16_extract_cj(ctx, &tmp, ctx->opcode); arg_jal arg =3D { .rd =3D 1, .imm =3D tmp.imm }; return trans_jal(ctx, &arg); #else diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 967eac7bc3..2ff6b49487 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -517,7 +517,7 @@ static void decode_RV32_64C(DisasContext *ctx) } =20 #define EX_SH(amount) \ - static int ex_shift_##amount(int imm) \ + static int ex_shift_##amount(DisasContext *ctx, int imm) \ { \ return imm << amount; \ } @@ -533,7 +533,7 @@ EX_SH(12) } \ } while (0) =20 -static int ex_rvc_register(int reg) +static int ex_rvc_register(DisasContext *ctx, int reg) { return 8 + reg; } diff --git a/scripts/decodetree.py b/scripts/decodetree.py index 4536e3a63d..81874e22cc 100755 --- a/scripts/decodetree.py +++ b/scripts/decodetree.py @@ -256,7 +256,7 @@ class FunctionField: return self.func + '(' + str(self.base) + ')' =20 def str_extract(self): - return self.func + '(' + self.base.str_extract() + ')' + return self.func + '(ctx, ' + self.base.str_extract() + ')' =20 def __eq__(self, other): return self.func =3D=3D other.func and self.base =3D=3D other.base @@ -318,7 +318,7 @@ class Format(General): return decode_function + '_extract_' + self.name =20 def output_extract(self): - output('static void ', self.extract_name(), '(', + output('static void ', self.extract_name(), '(DisasContext *ctx, ', self.base.struct_name(), ' *a, ', insntype, ' insn)\n{\n') for n, f in self.fields.items(): output(' a->', n, ' =3D ', f.str_extract(), ';\n') @@ -343,7 +343,8 @@ class Pattern(General): arg =3D self.base.base.name output(ind, '/* ', self.file, ':', str(self.lineno), ' */\n') if not extracted: - output(ind, self.base.extract_name(), '(&u.f_', arg, ', insn);= \n') + output(ind, self.base.extract_name(), + '(ctx, &u.f_', arg, ', insn);\n') for n, f in self.fields.items(): output(ind, 'u.f_', arg, '.', n, ' =3D ', f.str_extract(), ';\= n') output(ind, 'if (', translate_prefix, '_', self.name, @@ -894,7 +895,7 @@ class Tree: # extract the fields now. if not extracted and self.base: output(ind, self.base.extract_name(), - '(&u.f_', self.base.base.name, ', insn);\n') + '(ctx, &u.f_', self.base.base.name, ', insn);\n') extracted =3D True =20 # Attempt to aid the compiler in producing compact switch statemen= ts. --=20 2.17.1