[Qemu-devel] [PATCH] hw/display/cirrus_vga: Remove unused include

Philippe Mathieu-Daudé posted 1 patch 4 years, 10 months ago
Test asan passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190505225640.4592-1-philmd@redhat.com
Maintainers: Gerd Hoffmann <kraxel@redhat.com>
hw/display/cirrus_vga.c | 1 -
1 file changed, 1 deletion(-)
[Qemu-devel] [PATCH] hw/display/cirrus_vga: Remove unused include
Posted by Philippe Mathieu-Daudé 4 years, 10 months ago
Commit ce3cf70edaaf split the ISA device out of the PCI one,
but forgot to remove the "hw/loader.h" header inclusion (the ISA
device calls rom_add_vga()).  Remove the now unused include.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/display/cirrus_vga.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
index a0e71469f4d..f67df3c1f6f 100644
--- a/hw/display/cirrus_vga.c
+++ b/hw/display/cirrus_vga.c
@@ -33,7 +33,6 @@
 #include "hw/hw.h"
 #include "hw/pci/pci.h"
 #include "ui/pixel_ops.h"
-#include "hw/loader.h"
 #include "cirrus_vga_internal.h"
 
 /*
-- 
2.20.1


Re: [Qemu-devel] [PATCH] hw/display/cirrus_vga: Remove unused include
Posted by Gerd Hoffmann 4 years, 10 months ago
On Mon, May 06, 2019 at 12:56:40AM +0200, Philippe Mathieu-Daudé wrote:
> Commit ce3cf70edaaf split the ISA device out of the PCI one,
> but forgot to remove the "hw/loader.h" header inclusion (the ISA
> device calls rom_add_vga()).  Remove the now unused include.

Added to vga queue.

thanks,
  Gerd


Re: [Qemu-devel] [PATCH] hw/display/cirrus_vga: Remove unused include
Posted by Thomas Huth 4 years, 10 months ago
On 06/05/2019 00.56, Philippe Mathieu-Daudé wrote:
> Commit ce3cf70edaaf split the ISA device out of the PCI one,
> but forgot to remove the "hw/loader.h" header inclusion (the ISA
> device calls rom_add_vga()).  Remove the now unused include.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/display/cirrus_vga.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
> index a0e71469f4d..f67df3c1f6f 100644
> --- a/hw/display/cirrus_vga.c
> +++ b/hw/display/cirrus_vga.c
> @@ -33,7 +33,6 @@
>  #include "hw/hw.h"
>  #include "hw/pci/pci.h"
>  #include "ui/pixel_ops.h"
> -#include "hw/loader.h"
>  #include "cirrus_vga_internal.h"

Reviewed-by: Thomas Huth <thuth@redhat.com>