From nobody Mon Feb 9 04:44:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1556977112; cv=none; d=zoho.com; s=zohoarc; b=nf0YhFacxIckW0CB8Hr65os/K1BozEyXFWlmv+o7PIRHh3j3wcVdiOk5XHUx61EsxDm+af9wqWjiDrLHE7fkSk2NKRUdWS5g0v9hYYBYqnhh9CQOdhFgYq9NRc7PvEKtW2BDa2txHvV92tuMG9asS5LopLOMjwK2tDaTmpF33Dw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556977112; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=NY9qui6TB2EbUb6BaCqgZtUg7X6Q/sEeUp+LL6X+r3o=; b=D4ePlNzIeTWcI69DqjE2UmiMq8oIBgerYXvZLGQ3N54UOl8NegnG6HJMrXFiNDXDD+vv4eQxz91RN0k6wXYSY3muTpzZVaFbi98CrkaqyjfCSQx+ZhIT55PfuO+4uaYqQANH9LAANb4R8Ks176wULcvNmc8wECnqnczHTKGMkr8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556977112347953.8389444730391; Sat, 4 May 2019 06:38:32 -0700 (PDT) Received: from localhost ([127.0.0.1]:56794 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMury-00062A-8N for importer@patchew.org; Sat, 04 May 2019 09:38:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMupT-0004Uk-90 for qemu-devel@nongnu.org; Sat, 04 May 2019 09:35:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMupS-00056V-8O for qemu-devel@nongnu.org; Sat, 04 May 2019 09:35:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33122) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMupS-00054z-1V; Sat, 04 May 2019 09:35:50 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 427C98535D; Sat, 4 May 2019 13:35:49 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-35.brq.redhat.com [10.40.204.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 899CD5D71B; Sat, 4 May 2019 13:35:47 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-trivial@nongnu.org, Laszlo Ersek , qemu-devel@nongnu.org Date: Sat, 4 May 2019 15:35:39 +0200 Message-Id: <20190504133540.19758-2-philmd@redhat.com> In-Reply-To: <20190504133540.19758-1-philmd@redhat.com> References: <20190504133540.19758-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Sat, 04 May 2019 13:35:49 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 1/2] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" In commit 1cab464136b4 we incorrectly described the EDK2_BASETOOLS_OPTFLAGS can pass CPPFLAGS and CFLAGS options to the EDK2 build tools, but it only expands the CFLAGS (not to the CPPFLAGS). Update the description to be more accurate. Reported-by: Laszlo Ersek Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laszlo Ersek --- roms/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/roms/Makefile b/roms/Makefile index 0ce84a45ad5..f020102c866 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -121,8 +121,8 @@ build-efi-roms: build-pxe-roms $(patsubst %,bin-i386-efi/%.efidrv,$(pxerom_targets)) \ $(patsubst %,bin-x86_64-efi/%.efidrv,$(pxerom_targets)) =20 -# Build scripts can pass compiler/linker flags to the EDK2 build tools -# via the EDK2_BASETOOLS_OPTFLAGS (CPPFLAGS and CFLAGS) and +# Build scripts can pass compiler/linker flags to the EDK2 +# build tools via the EDK2_BASETOOLS_OPTFLAGS (CFLAGS) and # EDK2_BASETOOLS_LDFLAGS (LDFLAGS) environment variables. # # Example: --=20 2.20.1