From nobody Mon Feb 9 21:12:29 2026 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1556971673; cv=none; d=zoho.com; s=zohoarc; b=SLaknjt41cbSWwtzTJZb7MKmoS+0uGWxlQzUu0US/SOrgQunt04I5V9DQVW09OkSjhhoRsM2Gcfss6shojBFYDKa/HKTV4efs3mDrttK1vC2bzPqbFIjpAJ8W4xFgN2iZlkQuQSSlbt7EMEwM/8n7cs7aeM0dtcGWX+gHL8peDs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556971673; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=pmZJgq4sgMXP9qHYEfxrgn9xoXzv+P55K0/VCJX3rj4=; b=Yb49NH2lSdavevishZErlAtGGGAb265P6g6a8FKOWfM11z0pnmgtx+REwkuzof3PN305XEilyseiffrQ8IvYGbQcuEekiVSnkKGeuPkONuX9J+C8iXIHu2403fbJxa4Zwv29+OQEdhTMRjy90xC+C/mnCjm8hLNLaw5IP6WqiYY= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556971673020644.0401786468541; Sat, 4 May 2019 05:07:53 -0700 (PDT) Received: from localhost ([127.0.0.1]:55665 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMtS5-0008Ix-AT for importer@patchew.org; Sat, 04 May 2019 08:07:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMtQ9-000792-2H for qemu-devel@nongnu.org; Sat, 04 May 2019 08:05:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMtQ6-0001C6-Tj for qemu-devel@nongnu.org; Sat, 04 May 2019 08:05:36 -0400 Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]:41296) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMtQ6-0001BM-HE; Sat, 04 May 2019 08:05:34 -0400 Received: by mail-ot1-x330.google.com with SMTP id g8so7624690otl.8; Sat, 04 May 2019 05:05:32 -0700 (PDT) Received: from localhost.localdomain ([198.59.53.9]) by smtp.gmail.com with ESMTPSA id s26sm1844978otk.24.2019.05.04.05.05.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 May 2019 05:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pmZJgq4sgMXP9qHYEfxrgn9xoXzv+P55K0/VCJX3rj4=; b=eJF5BpXMrgWoO8/CcxRFeGVCJLQXnvspWD8+IbqaS8DA5XMPCRmxHhNeTkegwhr0d0 g0cfu2yfrx1muxQqq5aJbYa8lHeZiz416kzLBRv23fEOvIJTNMQd7B6NdXdPw1YV+ngg n2k9A4BV4bZJ9Ki3gUHQYWQdgzdNjCNX9EYF9g+7H45RDqQLG8ypWq7BSmdOM6ErSJpX uebJHdvZqd5g3dPpQ0uVpPebXFDTMhj1BPWtf9fr/sQdV+YcqHbep5KaAzZ06UlvS2Do RhEqf+C4hOR0ytCtQiL5MzV6Ya17M3KfOq9XpEZA4qBTOyQKBl4eyWMp6G9BB3zotxUO IEQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=pmZJgq4sgMXP9qHYEfxrgn9xoXzv+P55K0/VCJX3rj4=; b=HDepH0WIK3elGuNTPks+CnTvyfwtw85UFSHqmnw1h33smpZJJ9omrHHI9WKD3CqUhj nBYBJ45jq4S9mkDlFuLUQn9T4HocySinF/jjG+mbkQ/kTrOdvuEQrC6ipxnAgTL201W1 ceqNANPpo6iROUzsvmb4QdOTiVO5nrVoFswuKp6ND+9GgNjss7smNdyG+1Zifr5whx/P sKcsoQbc0PaMkK9SgHUHh6kLbrWqb4tMECxZKHwM+a8+5qlP/qlUuiDthl6Nr1vDVABd Cxox+o3Hr4B5iym4uHDzhBO81Xr8YJ76LKINmX1z8hrFcIN9VKilPD4BNkpZns2v4RbV tFvA== X-Gm-Message-State: APjAAAWry7HC1mYxbYnBbnGojneqXKhE403Qs1pC+COsceVP7VcG5fmd NKMcAd5HW1Y6c+TMDa0If8AZIuo3 X-Google-Smtp-Source: APXvYqwGdiOQa1jDHcPHGwZBGeKDoOqm6JKnguYPiYDm2NeNqwqnd9MjsZFphMkhn9LfTQahaqFVTA== X-Received: by 2002:a05:6830:2106:: with SMTP id i6mr9763319otc.146.1556971531677; Sat, 04 May 2019 05:05:31 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sat, 4 May 2019 06:05:19 -0600 Message-Id: <20190504120528.6389-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190504120528.6389-1-pbonzini@redhat.com> References: <20190504120528.6389-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::330 Subject: [Qemu-devel] [PATCH 1/9] qemugdb: allow adding support for other coroutine backends X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, cohuck@redhat.com, richard.henderson@linaro.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Split the jmpbuf access to a separate module and dispatch based on which CoroutineXYZ type is defined. Signed-off-by: Paolo Bonzini --- scripts/qemugdb/coroutine.py | 106 ++++++++------------------ scripts/qemugdb/coroutine_ucontext.py | 69 +++++++++++++++++ 2 files changed, 100 insertions(+), 75 deletions(-) create mode 100644 scripts/qemugdb/coroutine_ucontext.py diff --git a/scripts/qemugdb/coroutine.py b/scripts/qemugdb/coroutine.py index 41e079d0e2..db2753d949 100644 --- a/scripts/qemugdb/coroutine.py +++ b/scripts/qemugdb/coroutine.py @@ -1,6 +1,6 @@ #!/usr/bin/python =20 -# GDB debugging support +# GDB debugging support, coroutine dispatch # # Copyright 2012 Red Hat, Inc. and/or its affiliates # @@ -10,82 +10,25 @@ # This work is licensed under the terms of the GNU GPL, version 2 # or later. See the COPYING file in the top-level directory. =20 +from . import coroutine_ucontext import gdb =20 VOID_PTR =3D gdb.lookup_type('void').pointer() +UINTPTR_T =3D gdb.lookup_type('uintptr_t') =20 -def get_fs_base(): - '''Fetch %fs base value using arch_prctl(ARCH_GET_FS). This is - pthread_self().''' - # %rsp - 120 is scratch space according to the SystemV ABI - old =3D gdb.parse_and_eval('*(uint64_t*)($rsp - 120)') - gdb.execute('call (int)arch_prctl(0x1003, $rsp - 120)', False, True) - fs_base =3D gdb.parse_and_eval('*(uint64_t*)($rsp - 120)') - gdb.execute('set *(uint64_t*)($rsp - 120) =3D %s' % old, False, True) - return fs_base - -def pthread_self(): - '''Fetch pthread_self() from the glibc start_thread function.''' - f =3D gdb.newest_frame() - while f.name() !=3D 'start_thread': - f =3D f.older() - if f is None: - return get_fs_base() - - try: - return f.read_var("arg") - except ValueError: - return get_fs_base() - -def get_glibc_pointer_guard(): - '''Fetch glibc pointer guard value''' - fs_base =3D pthread_self() - return gdb.parse_and_eval('*(uint64_t*)((uint64_t)%s + 0x30)' % fs_bas= e) - -def glibc_ptr_demangle(val, pointer_guard): - '''Undo effect of glibc's PTR_MANGLE()''' - return gdb.parse_and_eval('(((uint64_t)%s >> 0x11) | ((uint64_t)%s << = (64 - 0x11))) ^ (uint64_t)%s' % (val, val, pointer_guard)) - -def get_jmpbuf_regs(jmpbuf): - JB_RBX =3D 0 - JB_RBP =3D 1 - JB_R12 =3D 2 - JB_R13 =3D 3 - JB_R14 =3D 4 - JB_R15 =3D 5 - JB_RSP =3D 6 - JB_PC =3D 7 - - pointer_guard =3D get_glibc_pointer_guard() - return {'rbx': jmpbuf[JB_RBX], - 'rbp': glibc_ptr_demangle(jmpbuf[JB_RBP], pointer_guard), - 'rsp': glibc_ptr_demangle(jmpbuf[JB_RSP], pointer_guard), - 'r12': jmpbuf[JB_R12], - 'r13': jmpbuf[JB_R13], - 'r14': jmpbuf[JB_R14], - 'r15': jmpbuf[JB_R15], - 'rip': glibc_ptr_demangle(jmpbuf[JB_PC], pointer_guard) } - -def bt_jmpbuf(jmpbuf): - '''Backtrace a jmpbuf''' - regs =3D get_jmpbuf_regs(jmpbuf) - old =3D dict() - - for i in regs: - old[i] =3D gdb.parse_and_eval('(uint64_t)$%s' % i) - - for i in regs: - gdb.execute('set $%s =3D %s' % (i, regs[i])) - - gdb.execute('bt') - - for i in regs: - gdb.execute('set $%s =3D %s' % (i, old[i])) - -def coroutine_to_jmpbuf(co): - coroutine_pointer =3D co.cast(gdb.lookup_type('CoroutineUContext').poi= nter()) - return coroutine_pointer['env']['__jmpbuf'] +backends =3D { + 'CoroutineUContext': coroutine_ucontext +} =20 +def coroutine_backend(): + for k, v in backends.items(): + try: + gdb.lookup_type(k) + except: + continue + return v + + raise Exception('could not find coroutine backend') =20 class CoroutineCommand(gdb.Command): '''Display coroutine backtrace''' @@ -99,18 +42,31 @@ class CoroutineCommand(gdb.Command): gdb.write('usage: qemu coroutine \n') return =20 - bt_jmpbuf(coroutine_to_jmpbuf(gdb.parse_and_eval(argv[0]))) + addr =3D gdb.parse_and_eval(argv[0]) + regs =3D coroutine_backend().get_coroutine_regs(addr) + old =3D dict() + + for i in regs: + old[i] =3D gdb.parse_and_eval('(uint64_t)$%s' % i) + + for i in regs: + gdb.execute('set $%s =3D %s' % (i, regs[i].cast(UINTPTR_T))) + + gdb.execute('bt') + + for i in regs: + gdb.execute('set $%s =3D %s' % (i, old[i].cast(UINTPTR_T))) =20 class CoroutineSPFunction(gdb.Function): def __init__(self): gdb.Function.__init__(self, 'qemu_coroutine_sp') =20 def invoke(self, addr): - return get_jmpbuf_regs(coroutine_to_jmpbuf(addr))['rsp'].cast(VOID= _PTR) + return coroutine_backend().get_coroutine_regs(addr)['rsp'].cast(VO= ID_PTR) =20 class CoroutinePCFunction(gdb.Function): def __init__(self): gdb.Function.__init__(self, 'qemu_coroutine_pc') =20 def invoke(self, addr): - return get_jmpbuf_regs(coroutine_to_jmpbuf(addr))['rip'].cast(VOID= _PTR) + return coroutine_backend().get_coroutine_regs(addr)['rip'].cast(VO= ID_PTR) diff --git a/scripts/qemugdb/coroutine_ucontext.py b/scripts/qemugdb/corout= ine_ucontext.py new file mode 100644 index 0000000000..a2f8c1dbbf --- /dev/null +++ b/scripts/qemugdb/coroutine_ucontext.py @@ -0,0 +1,69 @@ +#!/usr/bin/python + +# GDB debugging support +# +# Copyright 2012 Red Hat, Inc. and/or its affiliates +# +# Authors: +# Avi Kivity +# +# This work is licensed under the terms of the GNU GPL, version 2 or +# later. See the COPYING file in the top-level directory. + +import gdb + +def get_fs_base(): + '''Fetch %fs base value using arch_prctl(ARCH_GET_FS). This is + pthread_self().''' + # %rsp - 120 is scratch space according to the SystemV ABI + old =3D gdb.parse_and_eval('*(uint64_t*)($rsp - 120)') + gdb.execute('call (int)arch_prctl(0x1003, $rsp - 120)', False, True) + fs_base =3D gdb.parse_and_eval('*(uint64_t*)($rsp - 120)') + gdb.execute('set *(uint64_t*)($rsp - 120) =3D %s' % old, False, True) + return fs_base + +def pthread_self(): + '''Fetch pthread_self() from the glibc start_thread function.''' + f =3D gdb.newest_frame() + while f.name() !=3D 'start_thread': + f =3D f.older() + if f is None: + return get_fs_base() + + try: + return f.read_var("arg") + except ValueError: + return get_fs_base() + +def get_glibc_pointer_guard(): + '''Fetch glibc pointer guard value''' + fs_base =3D pthread_self() + return gdb.parse_and_eval('*(uint64_t*)((uint64_t)%s + 0x30)' % fs_bas= e) + +def glibc_ptr_demangle(val, pointer_guard): + '''Undo effect of glibc's PTR_MANGLE()''' + return gdb.parse_and_eval('(((uint64_t)%s >> 0x11) | ((uint64_t)%s << = (64 - 0x11))) ^ (uint64_t)%s' % (val, val, pointer_guard)) + +def get_jmpbuf_regs(jmpbuf): + JB_RBX =3D 0 + JB_RBP =3D 1 + JB_R12 =3D 2 + JB_R13 =3D 3 + JB_R14 =3D 4 + JB_R15 =3D 5 + JB_RSP =3D 6 + JB_PC =3D 7 + + pointer_guard =3D get_glibc_pointer_guard() + return {'rbx': jmpbuf[JB_RBX], + 'rbp': glibc_ptr_demangle(jmpbuf[JB_RBP], pointer_guard), + 'rsp': glibc_ptr_demangle(jmpbuf[JB_RSP], pointer_guard), + 'r12': jmpbuf[JB_R12], + 'r13': jmpbuf[JB_R13], + 'r14': jmpbuf[JB_R14], + 'r15': jmpbuf[JB_R15], + 'rip': glibc_ptr_demangle(jmpbuf[JB_PC], pointer_guard) } + +def get_coroutine_regs(addr): + co =3D addr.cast(gdb.lookup_type('CoroutineUContext').pointer()) + return get_jmpbuf_regs(co['env']['__jmpbuf']) --=20 2.21.0