[Qemu-devel] [PATCH v1 0/8] DRAFT AVR Patches

Sarah Harris posted 8 patches 4 years, 10 months ago
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test asan passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190504083638.13380-1-S.E.Harris@kent.ac.uk
Maintainers: Markus Armbruster <armbru@redhat.com>, Thomas Huth <thuth@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Eric Blake <eblake@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>
MAINTAINERS                     |    6 +
arch_init.c                     |    2 +
configure                       |    6 +
default-configs/avr-softmmu.mak |    5 +
gdbstub.c                       |    5 +
hw/Kconfig                      |    1 +
hw/avr/Kconfig                  |    4 +
hw/avr/Makefile.objs            |    1 +
hw/avr/sample.c                 |  177 ++
hw/char/Kconfig                 |    3 +
hw/char/Makefile.objs           |    1 +
hw/char/avr_usart.c             |  316 ++++
hw/timer/Kconfig                |    3 +
hw/timer/Makefile.objs          |    1 +
hw/timer/avr_timer16.c          |  587 ++++++
include/disas/dis-asm.h         |    6 +
include/exec/gdbstub.h          |    4 +
include/hw/char/avr_usart.h     |   99 +
include/hw/timer/avr_timer16.h  |   99 +
include/sysemu/arch_init.h      |    1 +
qapi/common.json                |    2 +-
target/avr/Makefile.objs        |   23 +
target/avr/cpu-qom.h            |   83 +
target/avr/cpu.c                |  570 ++++++
target/avr/cpu.h                |  238 +++
target/avr/decode.c             |  441 +++++
target/avr/decode.h             |   68 +
target/avr/gdbstub.c            |   85 +
target/avr/helper.c             |  343 ++++
target/avr/helper.h             |   28 +
target/avr/machine.c            |  122 ++
target/avr/translate-inst.h     |  695 +++++++
target/avr/translate.c          | 3013 +++++++++++++++++++++++++++++++
tests/machine-none-test.c       |    1 +
34 files changed, 7038 insertions(+), 1 deletion(-)
create mode 100644 default-configs/avr-softmmu.mak
create mode 100644 hw/avr/Kconfig
create mode 100644 hw/avr/Makefile.objs
create mode 100644 hw/avr/sample.c
create mode 100644 hw/char/avr_usart.c
create mode 100644 hw/timer/avr_timer16.c
create mode 100644 include/hw/char/avr_usart.h
create mode 100644 include/hw/timer/avr_timer16.h
create mode 100644 target/avr/Makefile.objs
create mode 100644 target/avr/cpu-qom.h
create mode 100644 target/avr/cpu.c
create mode 100644 target/avr/cpu.h
create mode 100644 target/avr/decode.c
create mode 100644 target/avr/decode.h
create mode 100644 target/avr/gdbstub.c
create mode 100644 target/avr/helper.c
create mode 100644 target/avr/helper.h
create mode 100644 target/avr/machine.c
create mode 100644 target/avr/translate-inst.h
create mode 100644 target/avr/translate.c
[Qemu-devel] [PATCH v1 0/8] DRAFT AVR Patches
Posted by Sarah Harris 4 years, 10 months ago
This series of patches adds support for 8 bit Atmel (Microchip) AVR microcontrollers.
All documented instructions except DES, SPM, and WDR are implemented.
These patches include very incomplete peripheral emulation, and only a single example board definition.

All instructions except LAC, LAS, LAT, XCH, BREAK, and SLEEP have been tested by comparing their behaviours against hardware.
The test programs used were designed specifically to exercise as many instruction variants as possible.
More details, source code, and results are available here: https://github.com/seharris/qemu-avr-tests/tree/master/instruction-tests

Additionally, it has been confirmed that this emulation can run FreeRTOS (an open source realtime operating system).
AVRs don't have memory management hardware and typically only have a few kilobytes of RAM so booting something more standard, e.g. Linux, wasn't feasible.
Two peripherals were needed (USART and 16 bit timer) for this test and are included in these patches.
The implementations are somewhat limited, mostly because QEMU doesn't seem to have much in the way of facilities to handle low-level electrical interfaces like GPIO pins.
A simple LED indicator peripheral was also used, but is not included because it isn't likely to be generally useful.
The FreeRTOS build and LED patch are available here: https://github.com/seharris/qemu-avr-tests/tree/master/free-rtos

These patches are based on work by Michael Rolnik, last discussed here in 2017: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg02290.html
This series is derived from the version found in this repository: https://github.com/michaelrolnik/qemu-avr
Changes from that version:
- rebase onto current master
- fixes for some accumulated bitrot (including a crash at startup)
- minor improvements to sample board firmware loading
- fixes for bugs in instruction translations (POP, ASR, LSR, ROR, FMUL, FMULS, FMULSU, MUL, MULS, MULSU, OR, SBC, SBCI)
- new instruction decoder to avoid some awkward dependencies
- general cleanup (style fixes, fixing unclear comments, making code easier to follow)

On a personal note, I'm unfamiliar with this style of submission so I hope I haven't broken anything!

Sarah Harris (8):
  target/avr: Add instruction decoder
  target/avr: Add mechanism to check for active debugger connection
  target/avr: Add outward facing interfaces and core CPU logic
  target/avr: Add instruction helpers
  target/avr: Add instruction translation
  target/avr: Add limited support for USART and 16 bit timer peripherals
  target/avr: Add example board configuration
  target/avr: Register AVR support with the rest of QEMU, the build
    system, and the MAINTAINERS file

 MAINTAINERS                     |    6 +
 arch_init.c                     |    2 +
 configure                       |    6 +
 default-configs/avr-softmmu.mak |    5 +
 gdbstub.c                       |    5 +
 hw/Kconfig                      |    1 +
 hw/avr/Kconfig                  |    4 +
 hw/avr/Makefile.objs            |    1 +
 hw/avr/sample.c                 |  177 ++
 hw/char/Kconfig                 |    3 +
 hw/char/Makefile.objs           |    1 +
 hw/char/avr_usart.c             |  316 ++++
 hw/timer/Kconfig                |    3 +
 hw/timer/Makefile.objs          |    1 +
 hw/timer/avr_timer16.c          |  587 ++++++
 include/disas/dis-asm.h         |    6 +
 include/exec/gdbstub.h          |    4 +
 include/hw/char/avr_usart.h     |   99 +
 include/hw/timer/avr_timer16.h  |   99 +
 include/sysemu/arch_init.h      |    1 +
 qapi/common.json                |    2 +-
 target/avr/Makefile.objs        |   23 +
 target/avr/cpu-qom.h            |   83 +
 target/avr/cpu.c                |  570 ++++++
 target/avr/cpu.h                |  238 +++
 target/avr/decode.c             |  441 +++++
 target/avr/decode.h             |   68 +
 target/avr/gdbstub.c            |   85 +
 target/avr/helper.c             |  343 ++++
 target/avr/helper.h             |   28 +
 target/avr/machine.c            |  122 ++
 target/avr/translate-inst.h     |  695 +++++++
 target/avr/translate.c          | 3013 +++++++++++++++++++++++++++++++
 tests/machine-none-test.c       |    1 +
 34 files changed, 7038 insertions(+), 1 deletion(-)
 create mode 100644 default-configs/avr-softmmu.mak
 create mode 100644 hw/avr/Kconfig
 create mode 100644 hw/avr/Makefile.objs
 create mode 100644 hw/avr/sample.c
 create mode 100644 hw/char/avr_usart.c
 create mode 100644 hw/timer/avr_timer16.c
 create mode 100644 include/hw/char/avr_usart.h
 create mode 100644 include/hw/timer/avr_timer16.h
 create mode 100644 target/avr/Makefile.objs
 create mode 100644 target/avr/cpu-qom.h
 create mode 100644 target/avr/cpu.c
 create mode 100644 target/avr/cpu.h
 create mode 100644 target/avr/decode.c
 create mode 100644 target/avr/decode.h
 create mode 100644 target/avr/gdbstub.c
 create mode 100644 target/avr/helper.c
 create mode 100644 target/avr/helper.h
 create mode 100644 target/avr/machine.c
 create mode 100644 target/avr/translate-inst.h
 create mode 100644 target/avr/translate.c

-- 
2.21.0