From nobody Tue Feb 10 07:41:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1556950273; cv=none; d=zoho.com; s=zohoarc; b=U31p3osei2nYi0n/kv0voJQWucX3wtaaH7C5GBKbI2YSnxrm+Kz061lAWNF036isT0j9QYFMB7fxAYhQ7mywONfdrcX5q3mag5ASILW5krGiga19EZCLXxDcmXlD8Vs+lkz4qVkm+J35gVE/oUUcTlkUq5FJzG+b+LNs6I/tAa0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556950273; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=aOq8R9O0JYe2vR4wE14TCH6+yK72ddx4w9niulf5glk=; b=lLW41pR23DbJyvSdWnWqDbuTm8JlY+HY/MXaPADSu0Ul03mRu8CB9Ga1Q2Ij9nlChVOd8QojoPzUPAp3WZSC4ID2PX5mK6wZkeoos7xPjMqwRMUrBiMl12eFGCwWmQUADGCAjCtPuTt2/n8wXNlEQRiHEkYCir5xHU8hOGLnMiA= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556950273700207.88195504730925; Fri, 3 May 2019 23:11:13 -0700 (PDT) Received: from localhost ([127.0.0.1]:51860 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMnt3-0005NR-Ev for importer@patchew.org; Sat, 04 May 2019 02:11:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMnc6-000845-0b for qemu-devel@nongnu.org; Sat, 04 May 2019 01:53:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMnc4-0004Yb-PK for qemu-devel@nongnu.org; Sat, 04 May 2019 01:53:33 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:45099) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMnc4-0004XD-JI for qemu-devel@nongnu.org; Sat, 04 May 2019 01:53:32 -0400 Received: by mail-pf1-x42b.google.com with SMTP id e24so3956593pfi.12 for ; Fri, 03 May 2019 22:53:32 -0700 (PDT) Received: from localhost.localdomain (97-113-189-189.tukw.qwest.net. [97.113.189.189]) by smtp.gmail.com with ESMTPSA id 15sm6680423pfo.117.2019.05.03.22.53.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 May 2019 22:53:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aOq8R9O0JYe2vR4wE14TCH6+yK72ddx4w9niulf5glk=; b=nGvOrO9oB3UkPDpmgBzSWrHM+u9KKFatM+TWLiY/+ybybRbKECJ9xSHDqN9Wo1k+HQ qK4I6mVURQ1eorIah3m4YXb6uQcr8PbsivYlPCABpvLeQAIrYAO7kkMQS8B/SNT50LBk MfdVkHXU+/nyuwrXeIpIRb2WdVVZXcQJuBKSRPinRdCOpxR+Pq6ugrryxVKKOToIFJuW b1pGCfeZ4WYVwXT/ecdrSWAkLsP0V9MObNssdN7yPhHdXTT8GALDVf/8VfkhK+Nm5lCU fsuDz2zIM8aixkdk/FmgQB/jA3gFOOeEqRZMpNaNS4rM8Rci9IW2pwZffH5/HUFW3nQy kgcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aOq8R9O0JYe2vR4wE14TCH6+yK72ddx4w9niulf5glk=; b=cPzKTp2R7GOGAiZV/9gRA07pTYqmNZy3OKh4Z8vGcCgAQ66wBeBuxSPSweIJPX4uU8 g6UfyHEVCJykQnIpvRu+iMJxAmVuSOF3usi5WcjTN19UuIIXVLcv+QnnLFg5k95jSeeZ WAJVjat/fYsWgbBDM2M810dJRoT69nUwqWy4fOiXGqKMyEEeC9Aue7KLNknC21wPOJLS u7jtzNpur/kehO8WXl/VYN9CHkISmda8lTT0e+vBRfFXM8ApMm+0Rxa47m30oMcpRaVp 4GOsywren7aqceq+iEKYcQeFvpjJrOtHh8Lubhz9EU9ca3wVATiD5e4xZ8nY+oO9AV+4 H7Ww== X-Gm-Message-State: APjAAAUtKrIP4A9kSXVkjMPaE88MupiMY1aypDV3LUDRkKbEt7DkTrTN dzUrEL9UNb+l+cM4hvw2CRgocj9oaps= X-Google-Smtp-Source: APXvYqywmXeLgRudjZUZobs48amjUNQmUD8UoxZlJi6UimIQD8kdMzYGanvgs8sPIMzddbu/CdfmWw== X-Received: by 2002:a62:2687:: with SMTP id m129mr17312979pfm.204.1556949211292; Fri, 03 May 2019 22:53:31 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 22:52:53 -0700 Message-Id: <20190504055300.18426-25-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190504055300.18426-1-richard.henderson@linaro.org> References: <20190504055300.18426-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::42b Subject: [Qemu-devel] [PATCH v3 24/31] target/arm: Use tcg_gen_abs_i64 and tcg_gen_gvec_abs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, david@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Richard Henderson --- target/arm/helper.h | 2 -- target/arm/neon_helper.c | 5 ----- target/arm/translate-a64.c | 41 +++++--------------------------------- target/arm/translate.c | 11 +++------- 4 files changed, 8 insertions(+), 51 deletions(-) diff --git a/target/arm/helper.h b/target/arm/helper.h index 50cb036378..132aa1682e 100644 --- a/target/arm/helper.h +++ b/target/arm/helper.h @@ -352,8 +352,6 @@ DEF_HELPER_2(neon_ceq_u8, i32, i32, i32) DEF_HELPER_2(neon_ceq_u16, i32, i32, i32) DEF_HELPER_2(neon_ceq_u32, i32, i32, i32) =20 -DEF_HELPER_1(neon_abs_s8, i32, i32) -DEF_HELPER_1(neon_abs_s16, i32, i32) DEF_HELPER_1(neon_clz_u8, i32, i32) DEF_HELPER_1(neon_clz_u16, i32, i32) DEF_HELPER_1(neon_cls_s8, i32, i32) diff --git a/target/arm/neon_helper.c b/target/arm/neon_helper.c index ed1c6fc41c..4259056723 100644 --- a/target/arm/neon_helper.c +++ b/target/arm/neon_helper.c @@ -1228,11 +1228,6 @@ NEON_VOP(ceq_u16, neon_u16, 2) NEON_VOP(ceq_u32, neon_u32, 1) #undef NEON_FN =20 -#define NEON_FN(dest, src, dummy) dest =3D (src < 0) ? -src : src -NEON_VOP1(abs_s8, neon_s8, 4) -NEON_VOP1(abs_s16, neon_s16, 2) -#undef NEON_FN - /* Count Leading Sign/Zero Bits. */ static inline int do_clz8(uint8_t x) { diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 9dcc5ff3a3..b7c5a928b4 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -9468,11 +9468,7 @@ static void handle_2misc_64(DisasContext *s, int opc= ode, bool u, if (u) { tcg_gen_neg_i64(tcg_rd, tcg_rn); } else { - TCGv_i64 tcg_zero =3D tcg_const_i64(0); - tcg_gen_neg_i64(tcg_rd, tcg_rn); - tcg_gen_movcond_i64(TCG_COND_GT, tcg_rd, tcg_rn, tcg_zero, - tcg_rn, tcg_rd); - tcg_temp_free_i64(tcg_zero); + tcg_gen_abs_i64(tcg_rd, tcg_rn); } break; case 0x2f: /* FABS */ @@ -12366,11 +12362,12 @@ static void disas_simd_two_reg_misc(DisasContext = *s, uint32_t insn) } break; case 0xb: - if (u) { /* NEG */ + if (u) { /* ABS, NEG */ gen_gvec_fn2(s, is_q, rd, rn, tcg_gen_gvec_neg, size); - return; + } else { + gen_gvec_fn2(s, is_q, rd, rn, tcg_gen_gvec_abs, size); } - break; + return; } =20 if (size =3D=3D 3) { @@ -12438,17 +12435,6 @@ static void disas_simd_two_reg_misc(DisasContext *= s, uint32_t insn) gen_helper_neon_qabs_s32(tcg_res, cpu_env, tcg_op); } break; - case 0xb: /* ABS, NEG */ - if (u) { - tcg_gen_neg_i32(tcg_res, tcg_op); - } else { - TCGv_i32 tcg_zero =3D tcg_const_i32(0); - tcg_gen_neg_i32(tcg_res, tcg_op); - tcg_gen_movcond_i32(TCG_COND_GT, tcg_res, tcg_op, - tcg_zero, tcg_op, tcg_res); - tcg_temp_free_i32(tcg_zero); - } - break; case 0x2f: /* FABS */ gen_helper_vfp_abss(tcg_res, tcg_op); break; @@ -12561,23 +12547,6 @@ static void disas_simd_two_reg_misc(DisasContext *= s, uint32_t insn) tcg_temp_free_i32(tcg_zero); break; } - case 0xb: /* ABS, NEG */ - if (u) { - TCGv_i32 tcg_zero =3D tcg_const_i32(0); - if (size) { - gen_helper_neon_sub_u16(tcg_res, tcg_zero, tcg= _op); - } else { - gen_helper_neon_sub_u8(tcg_res, tcg_zero, tcg_= op); - } - tcg_temp_free_i32(tcg_zero); - } else { - if (size) { - gen_helper_neon_abs_s16(tcg_res, tcg_op); - } else { - gen_helper_neon_abs_s8(tcg_res, tcg_op); - } - } - break; case 0x4: /* CLS, CLZ */ if (u) { if (size =3D=3D 0) { diff --git a/target/arm/translate.c b/target/arm/translate.c index b25781554f..dd053c80d6 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -8120,6 +8120,9 @@ static int disas_neon_data_insn(DisasContext *s, uint= 32_t insn) case NEON_2RM_VNEG: tcg_gen_gvec_neg(size, rd_ofs, rm_ofs, vec_size, vec_s= ize); break; + case NEON_2RM_VABS: + tcg_gen_gvec_abs(size, rd_ofs, rm_ofs, vec_size, vec_s= ize); + break; =20 default: elementwise: @@ -8225,14 +8228,6 @@ static int disas_neon_data_insn(DisasContext *s, uin= t32_t insn) } tcg_temp_free_i32(tmp2); break; - case NEON_2RM_VABS: - switch(size) { - case 0: gen_helper_neon_abs_s8(tmp, tmp); brea= k; - case 1: gen_helper_neon_abs_s16(tmp, tmp); bre= ak; - case 2: tcg_gen_abs_i32(tmp, tmp); break; - default: abort(); - } - break; case NEON_2RM_VCGT0_F: { TCGv_ptr fpstatus =3D get_fpstatus_ptr(1); --=20 2.17.1