From nobody Wed May 15 22:20:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1556883774; cv=none; d=zoho.com; s=zohoarc; b=SxYPnh0M/PsYME8eBbT4RU6dr4/d9kRME3Tr6uzTtHTIufPMKz4XIPdeh0P0oGI1974EAHzs7TTSOYk1IvYQH3IZatrShDjLpWY2iRc3TO6bIKCBphzKwvLpDj61hsFt0dQmWMlbP1bqnR2/U//AlABRX4X6i3MH+SE3h6d6kPk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556883774; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=9qifjDO/490KpoE1IBkw36CRMb78JqGh3xrncujuu88=; b=EJ2zjrtxn/0TjGH6PsC3B+xid6+clHgTNmOER/Fx9OKC5pqpsvm3UFE7N8Ep49v96qtyZr5ObRp0OuTX+2q24RReNQtc82sXceTFTbr9CBYxzasCNQv2uphTPg2QmdVfv88AHuKD1lOJm/cYMkujXoXYkSrPKMLN8GjALoKveMw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556883774559394.71111851983324; Fri, 3 May 2019 04:42:54 -0700 (PDT) Received: from localhost ([127.0.0.1]:38729 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWaW-0005Pv-Aj for importer@patchew.org; Fri, 03 May 2019 07:42:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWLQ-0007Tx-Qk for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWLP-0002yR-W9 for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:12 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:45443) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWLP-0002vf-O2; Fri, 03 May 2019 07:27:11 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MsJXG-1gUI620Kd8-00tilO; Fri, 03 May 2019 13:27:00 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:26:43 +0200 Message-Id: <20190503112654.4393-2-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503112654.4393-1-laurent@vivier.eu> References: <20190503112654.4393-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:FwDBsksgwr3Ro8wFHhTMgwol3cUCD/ilGRHQs4MAiGl1UtjiqFF P3XBYBVYtRXQrlY3wlVNFlUDSIMYOOKFgvqUKJWDLifVc28d1pkpgAFd2+Xx5CrOPa4zIrp jXbbP+8W/L58IVc1241l8sHMGugi/MplAaGDDgmSkSRPj4GFQHsjc0IPodDWXAd55FmJSZG n/gkGbWdbtuhMZlgq8xVw== X-UI-Out-Filterresults: notjunk:1;V03:K0:3Uc4m6XBooE=:C8mQ6489mMY17Dd/pk5DSV M/kpYAVR1WSwAQLdvhNEvtsVQuIsiquUQ8GAP6NjcY7bo08kn4S9G3MmbSlITXv+g4gFLyW8R ac5LxyOxXRsNzZ9RU1Wl0hEeZAHYHW9smt8DeI45IvzmhVm0LGMOQLskuqVmsKIOBcY2Grcc0 GTGQ8QO2kuvUV2ED/wnMVcvfdrDnhXjAr4fyTfZ2pu/387vZU0mts2h8Tv4KMBaAKKJMQ+7VL tZpBgmw/6EUr+2+tEMV5C93gyo3pzCv5jNHkMYgDFrqBVaqQj2RiMVH8zGF2JDuvIfTCYJQia D18o3NI7dl8rlj5bOTyL2RkmY9lcC5azv1blG1l2XcwPMhRSF0XHFJsavPDpIsyzk2eKpckR/ XlFJmdy2MSp6m2tOWuz9q8yjbsxy0jBolrrAkeaK1Iqy2Ln5fSa0NO4WDiu6G4Mao1m38lXg4 3HEdjzRkD55tvY0+GVzQbTiBEMLLoyZcx1owxDs0e0WOrnBRj5OcZDGR+9PrVOhuBoUnuvDgV O0mqxvPbr070Vti/LGZYrct5Jyxi1/hon2Z785dzldqIlq1uvTQaDAZ4GJWZGtXVbLSt84Bzt CBU/jSCxD87/ONr2jajbstjUVQARFZ+PbLpAml3nWpaaSNCeKhdb/S25qGr/bzbw5akYiFujj rgy0OgZkDxmSop6j/+gAxaNAK3VQcGa6ZGl5xxceB58d1v3o+TqaZubIosV/nh8OHAr8f8ayO 92qD6/APoUXk+6fqXGHD5qKRWWhZP85mHbuxlkhe9TQ6hSIsk0JBDUno2LE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.135 Subject: [Qemu-devel] [PULL v2 01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Gerd Hoffmann , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Avoid to clutter stdout until explicitly requested (with -d guest_errors): $ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta Bad SWSTYLE=3D0x04 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Message-Id: <20190311102712.8572-1-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/net/pcnet.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c index d9ba04bdfc62..16683091c939 100644 --- a/hw/net/pcnet.c +++ b/hw/net/pcnet.c @@ -36,6 +36,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/qdev.h" #include "net/net.h" #include "net/eth.h" @@ -1501,7 +1502,8 @@ static void pcnet_bcr_writew(PCNetState *s, uint32_t = rap, uint32_t val) val |=3D 0x0300; break; default: - printf("Bad SWSTYLE=3D0x%02x\n", val & 0xff); + qemu_log_mask(LOG_GUEST_ERROR, "pcnet: Bad SWSTYLE=3D0x%02x\n", + val & 0xff); val =3D 0x0200; break; } --=20 2.20.1 From nobody Wed May 15 22:20:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1556883887; cv=none; d=zoho.com; s=zohoarc; b=ELF0XIZ/5zNNWcSQnAY3VGHLpKWxVV3AedafuGi6b7I4FyjttJtTe8SP7A6Dhr/++2kZEtqCrhQfiVQfG7vmJDJBxmFb4qOiAdHtlKvpB+l8R4Qgv1HI2fHlOk8oAsFD4gsWBF8zwI0RgNmpuqz0yg3LIram9S8pPRD3gMYjoBc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556883887; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=T6+S1LdylRhcpnVt6w7n43oLE3SwQ1r7H9im40xgn7Y=; b=lK57JcjVZONg7uFP04Shlu2KNQPj0kEZDM73YhetY4V14BsFc9mrxidyBVVgJfL8HCaraCJNDkeWldL/AG7xKEq6Jb29m8OH1SlQfL75B4/nT1fj1uIe4tOWpxgLop1wplEQtoDxy7/6iioFrFa3O9HaqpJnVmh5X88LXpJ6mSs= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 155688388766523.657318213352823; Fri, 3 May 2019 04:44:47 -0700 (PDT) Received: from localhost ([127.0.0.1]:38763 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWcK-0006sa-K3 for importer@patchew.org; Fri, 03 May 2019 07:44:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWLb-0007fy-9Q for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWLa-0003Gq-Aw for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:23 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:47175) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWLX-0003CW-Ua; Fri, 03 May 2019 07:27:20 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MAchM-1hT5vZ258q-00B4K0; Fri, 03 May 2019 13:27:01 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:26:44 +0200 Message-Id: <20190503112654.4393-3-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503112654.4393-1-laurent@vivier.eu> References: <20190503112654.4393-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:8SpV5q+wuYzAk9ypmqbApsD5yPUlesepmLhhH0Wesf46hT4PjrH 63DLXxROIpeIrnMMLvoic81JGuRHJDvZlKR+5HC8M1kwZCojtpG57sTrkELWILiisw3B8OZ 0KIr81YsL10QL3OeOqFB6s+A7ZQ3VgPKdd6tHdhpJFSZrspCqG50XTccLkO5hWw85IqCsYG uNlPx6EMD0m9yp9sK44bw== X-UI-Out-Filterresults: notjunk:1;V03:K0:CNCT3k0LTiE=:mRpjnw/f8AHTlQR1hwcNBO MwCJvMSwg6eqJa2lx7mm+mwKmJgLbzq7v/rEx2NJk5sANBAUMpJ7RkEBIFW/pkCRzzRTnsN9G khOLByfBfaT2OeTsCNNZA1+mrdGEGpuuadS5dpK44VFWUrQlQTSfMfa92YwzMVzxBPTh0aF9R pYKBFjqLDhBs0sb5o3OCHamnVoslq2bxbdj055enId7ny5/Bzi4yWoGc1NgcKEP0m0Ax2hC4A cZhC9uBfNIRCf1X+wriaIn4yj46orU6hsvKXnD9RZ/3h1VfmmSnY9cbgLoVVp09XxxK7/RQWA XGClr6A1NQ2vkw5ZetMENXpoIQVFiwftVgS3TTu+qAEV/Q2LoS/sGk7/KjQvGpaetn6+Jl6fp h19Ht6f/Fa05cccuVN4PFIjxwMEmvfvrAfxt8xEHuldYyNsLV4g+CmS0qbWpydNx7MkHoSt9V vfm3ZWByn3QS8AOt5DAzGDZAJIDt8w1K20TOY7ERbRFQ1rqGiEVD1LgKGnNcx+/kj6/GaSuo+ HHQ5kKeh8fu2f2jn1gnR4v1ZDKefc+ApUwh4rnQSjehbvnc8oqHvlJ1y1jxP9QwyJ8+SmXVjh 6KlF5j2xUi/SJCAHjS2n0mHOghIpY0+UbkzeKo8l87CBeSqxk6Nj7Ag20Jw6xelmZ3qmcfFmO p72l8U+/2p6OTdg8nsyT87LTRRyTdAO9Z+xyOgtzaJjjVu8gobj/NLOUPMvxZl8VxDOr721F/ hmMMBAMbKSYEXKBa0uvwJzYnU2qQe8jYFuxNBg== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.131 Subject: [Qemu-devel] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Wei Yang , Gerd Hoffmann , Igor Mammedov , Paolo Bonzini , Stefano Garzarella , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Wei Yang We didn't specify the indent rule for multiline code here, which may mislead users. And in current code, the code use various styles. Add this rule in CODING_STYLE to make sure this is clear to every one. Signed-off-by: Wei Yang Suggested-by: Igor Mammedov Reviewed-by: Igor Mammedov Reviewed-by: Stefano Garzarella Message-Id: <20190304071631.27567-2-richardw.yang@linux.intel.com> Signed-off-by: Laurent Vivier --- CODING_STYLE | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/CODING_STYLE b/CODING_STYLE index ec075dedc4a8..90321e9c2821 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -29,6 +29,45 @@ Spaces of course are superior to tabs because: =20 Do not leave whitespace dangling off the ends of lines. =20 +1.1 Multiline Indent + +There are several places where indent is necessary: + + - if/else + - while/for + - function definition & call + +When breaking up a long line to fit within line width, we need a proper in= dent +for the following lines. + +In case of if/else, while/for, align the secondary lines just after the +opening parenthesis of the first. + +For example: + + if (a =3D=3D 1 && + b =3D=3D 2) { + + while (a =3D=3D 1 && + b =3D=3D 2) { + +In case of function, there are several variants: + + * 4 spaces indent from the beginning + * align the secondary lines just after the opening parenthesis of the + first + +For example: + + do_something(x, y, + z); + + do_something(x, y, + z); + + do_something(x, do_another(y, + z)); + 2. Line width =20 Lines should be 80 characters; try not to make them longer. --=20 2.20.1 From nobody Wed May 15 22:20:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1556883326; cv=none; d=zoho.com; s=zohoarc; b=Wln2w2gv2nF9vw/vw/pxDhklx4enF4rgxBHO+w1TmHKLkJA0O6ypob0/G8RKIHW2t3Xb3Eav1Qeyl0bbfmC8YfDekIK0YjyniUCiWt82fi96aadODrLrHM61rweYP9KffTv18bdRlH+7Na/4Tyt98Nt96G5tsbhKs3jqmtEdvYg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556883326; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=1NdZTnPHMQqyvJlrqk4KOIug3/by1q6lAvWSM6iilHA=; b=EjRj/0Jxd22HoGuXrQZ8IVcC18faqSAaRnz9p3Y0hJ4oGmRpBROl3dIx1a8uIO0rSRJ8ZnVVAGZcBbNg/DXqDfRFYy7LSqTd5nZ5qzO7eFnwE7QnPUoMQ4JzMC4HojzdEnPCjltAI4v0w2Q2oM1D35Jqt9JchvdwpNcW9v2IKpE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556883326268392.3531097618567; Fri, 3 May 2019 04:35:26 -0700 (PDT) Received: from localhost ([127.0.0.1]:38574 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWTI-0005iE-1h for importer@patchew.org; Fri, 03 May 2019 07:35:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWLf-0007kD-Op for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWLe-0003Lj-R4 for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:27 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:41031) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWLc-0003Hr-J1; Fri, 03 May 2019 07:27:24 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MXXZf-1hFhg93Xnr-00Ywj9; Fri, 03 May 2019 13:27:03 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:26:45 +0200 Message-Id: <20190503112654.4393-4-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503112654.4393-1-laurent@vivier.eu> References: <20190503112654.4393-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Vwma6Rzlj1kjDOfuerTs47edBiyFSJN5reaPmOSAYvp+eeoE27q z7EK4W3bbUHt68eLqFhPcwTWR5qMBgnVQk2GCgwd7h4KbQSfUZVMUh9YcekhNZhicQYbIta kf8MJVWBrtp/CJL5KfwNilVi+VSgI5Extlxd8CWU/oFYmZf98UUJb87WyzQIIEbkGSuUq4v C8yVoT+erKbxXgJ4En/oA== X-UI-Out-Filterresults: notjunk:1;V03:K0:IfgB+E8W+KY=:tPvxorVaOzTttZtQOwl0Vm AUBoMI6dZ0YqIRGyqLuQ01qCXYAp5k9fl+o2Uno3tnaTuRg+WhcjCeS1X1oslG0BApq+kkKsk XFeHszHpSWVMkaUKi0kTw6AFFyjh7Zf2YSVtyIgC7owhYk+uji124tIvosY2KGpDt1UMqLY1X oQlnmISEmQL7kmLU78LxWrM3KCtvS3yjtgztYZxXRlYM/4hnmz2+xCu2UTvplohpMrrEeuBVv gPjZKUcDw2kC2wo8014cYtOG/o1apYXrQVbuY2YzgktMZ1J4Ryyz3HvXaEiAclaolbcHso2hg 8/n2smotmkV551YbPb259USzGMsIivJFwfxWSrqlj+ivwPIq3jWks14MHRP1ZKijek78h9qX/ fMQm6Z5kkaiBtB4K0KtYYGxuzmOVEm3Fuivw97x49ctDM6/U0Oj8Sl4o6psM38bUochVwZiDL BuMbxitEuKDjhu1C0CxrmGrHOkQaQzvhZhEZ7QATHlI2d+6EO/tlLU8Rx7rrjpTjQRIfm5Xp8 vqYuOV9CbBnVKLY0q0yFhuYMMZxtH6HjhYSBnWdApeAe16ThHU4NzWD4iwqH2B904XQKTSkZP wFiZALze0g6EBLj1AmEKSK0Y+7VTxDzkUQdv10EbM6ge8A+ykbzwCB7CFG/iYYmU7CXb5idTJ 26WJwDc6+UHqVUuuxwtujuveJpZpW+RRnReNW6MM525R0PJGPMsiYVwIXR++hp+5ZtaeC8CAr q1Ee8Fuwd1uXO8nm5m6tdV9Krwccsv4R/qb0HeLcs4VSWWBS/YJCTLo+VcQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.134 Subject: [Qemu-devel] [PULL v2 03/12] CODING_STYLE: indent example code as all others X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Wei Yang , Gerd Hoffmann , Igor Mammedov , Paolo Bonzini , Stefano Garzarella , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Wei Yang All the example code are indented with four spaces except this one. Fix this by adding four spaces here. Signed-off-by: Wei Yang Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Igor Mammedov Reviewed-by: Stefano Garzarella Message-Id: <20190304071631.27567-3-richardw.yang@linux.intel.com> Signed-off-by: Laurent Vivier --- CODING_STYLE | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index 90321e9c2821..cb8edcbb3692 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -147,10 +147,10 @@ block to a separate function altogether. When comparing a variable for (in)equality with a constant, list the constant on the right, as in: =20 -if (a =3D=3D 1) { - /* Reads like: "If a equals 1" */ - do_something(); -} + if (a =3D=3D 1) { + /* Reads like: "If a equals 1" */ + do_something(); + } =20 Rationale: Yoda conditions (as in 'if (1 =3D=3D a)') are awkward to read. Besides, good compilers already warn users when '=3D=3D' is mis-typed as '= =3D', --=20 2.20.1 From nobody Wed May 15 22:20:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1556883730; cv=none; d=zoho.com; s=zohoarc; b=GToaP3xIIh4HmMcVgoXednRTdSW0bum4akpqDgeMFkodXhMuBkiFGDvFoCw0P9YPiQsojVMXovOGsbc+bTYyUVLryh7D127pw7/JOxBPMg8wH4SsQj/g3IjcsjPBcIpmKQlUxrVO8dBo/RV2HqJA1b/M9Zs/LH7W/UmFGE3UyOo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556883730; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=EyFxv6MktR+0J/f1CQ4qUvhledY+W+hlpGzowYF2CaQ=; b=YUX2Pgf2qNF2BBrKjnpjLS4+iylnTpahBZ9YDvIOZEWRl0TYb70mDv0gsGvlRAgpZqbJprgIQsk8E/eMQpWK9YW133bPgwIL8I5mJpRVVjULFUAPnJnaJZC3wOkEV5NPVCM4WarUyO1Asn2MzWdJ8QY/emUZbmvavUHRYuMjYZo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556883730494861.8817182563132; Fri, 3 May 2019 04:42:10 -0700 (PDT) Received: from localhost ([127.0.0.1]:38712 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWZr-0004Yq-Ef for importer@patchew.org; Fri, 03 May 2019 07:42:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWLm-0007qz-Dp for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWLl-0003UY-97 for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:34 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:48721) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWLl-0003Te-11; Fri, 03 May 2019 07:27:33 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N14xe-1gd3XG0BiM-012UBm; Fri, 03 May 2019 13:27:04 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:26:46 +0200 Message-Id: <20190503112654.4393-5-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503112654.4393-1-laurent@vivier.eu> References: <20190503112654.4393-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:/exoKr2G8amIMJOf8rY8yNH4VKXqwLNcO4mlaKtG33M69xL87BX 6G7CQnal/Hv4gaAajGW3fQTfFA3z4r1FwPuLkyeKNiixwp73yANVwUMFuF9fD9slE16QZyT 2F0fuzvvrm0P7I97AO8vvVBmJgXIxyZaL3jmE62cDIaaN5K1LV6Z/TK5ViYvmJWOcVcsDr3 EtEuVmO4ABblJP5dfXkMg== X-UI-Out-Filterresults: notjunk:1;V03:K0:cvr4RbMvxyU=:+opHoDA9oED1oZIISzlzOR Z4x9mHeowNmjzNGLvffRLYF21eq8lFnt8YJh2G0aVCCRvdKaFyWUdi171xdKqbrvkNMZwT8/R g6VkSOGIKDxlToPAX3lUNSXDHocJyxgWB3rRMTVXIF2YsAONQxlz6Xv6wNiscNGwiCEvxm6BY dZYv8pPSjrBm4p8sqDfpbR75NH7NVwLQmFoe55bCceLA33YiwdNlRurCXa7sBK2GkagSsQwHJ w1adFjod8dUqRufS3Z/7oppN4n0KJNjH8+SN9vXa1jvPzTeFM4MDlUbCKqSZ1i5xdcJtv0Jp0 HsmSkYrZkGug7GmfyPWUxJJU+CnR93t0zuuHCKZQQQdb2SKpZ/VsXqPr7zwQ3SeVDuxRMRYCB W949pJcqcg8/eWt+SWql+8sJys6ZPUGUAoutEGpBgxhwtT7PiSb9lKT8k0kaIdHpmtMKWF0JQ 5s/RxEmjR0yYm/O5F/Ni/l1lC4dAb6wKaCm5WQJTrDYJeOazlr7c8EFavS9CAjkG4s1MQR0Rn Jgy85G4HHHEP4tqGZFbZ9x2dKs2EYqLwOOJmMG2ed3T5u/yKUcJ1+yCntDokkGMsSthlBdbjc edsd/6xqCReOkNpD33JGrCK4ndOL90fi4lhN5sEENSwMC0fmghVK/QqOFuLxsW/QAzKId9vQl wC7GoRPm9g+q3jJqy88hm/8gDkpOQ6+fl/FTudEHIkDiIErvvanVHVc+7Jux+oNroiKfLjxKa l0yC6+ZGh8/6Rnt+pd4KauO6nU/GLo664L5PP3HZPLf+MYfirgJ/pASROWI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.133 Subject: [Qemu-devel] [PULL v2 04/12] doc: fix the configuration path X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Marc-Andr=C3=A9 Lureau Use a CONFDIR variable to show the configured sysconf path in the generated documentations (html, man pages etc). Related to: https://bugzilla.redhat.com/show_bug.cgi?id=3D1644985 Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20181126105125.30973-1-marcandre.lureau@redhat.com> Signed-off-by: Laurent Vivier --- qemu-ga.texi | 4 ++-- Makefile | 9 ++++++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/qemu-ga.texi b/qemu-ga.texi index 4c7a8fd16329..f00ad830f283 100644 --- a/qemu-ga.texi +++ b/qemu-ga.texi @@ -30,7 +30,7 @@ set user's password @end itemize =20 qemu-ga will read a system configuration file on startup (located at -@file{/etc/qemu/qemu-ga.conf} by default), then parse remaining +@file{@value{CONFDIR}/qemu-ga.conf} by default), then parse remaining configuration options on the command line. For the same key, the last option wins, but the lists accumulate (see below for configuration file format). @@ -58,7 +58,7 @@ file format). Enable fsfreeze hook. Accepts an optional argument that specifies script to run on freeze/thaw. Script will be called with 'freeze'/'thaw' arguments accordingly (default is - @samp{/etc/qemu/fsfreeze-hook}). If using -F with an argument, do + @samp{@value{CONFDIR}/fsfreeze-hook}). If using -F with an argument, do not follow -F with a space (for example: @samp{-F/var/run/fsfreezehook.sh}). =20 diff --git a/Makefile b/Makefile index 1211e78c91ed..43a7a047b452 100644 --- a/Makefile +++ b/Makefile @@ -899,11 +899,14 @@ ui/shader.o: $(SRC_PATH)/ui/shader.c \ MAKEINFO=3Dmakeinfo MAKEINFOINCLUDES=3D -I docs -I $( $@,"GEN","$@") +docs/version.texi: $(SRC_PATH)/VERSION config-host.mak + $(call quiet-command,(\ + echo "@set VERSION $(VERSION)" && \ + echo "@set CONFDIR $(qemu_confdir)" \ + )> $@,"GEN","$@") =20 %.html: %.texi docs/version.texi $(call quiet-command,LC_ALL=3DC $(MAKEINFO) $(MAKEINFOFLAGS) --no-headers= \ --=20 2.20.1 From nobody Wed May 15 22:20:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1556883618; cv=none; d=zoho.com; s=zohoarc; b=TwJtA2MukV9JhNPvRMOKJFpgJXlog2KrGN5K+UXGzVOy90BGYOQ8ywePj6+1b7AOGNtcJEWn+Nnoy62wTIzjlL/CJb2QaVGsXxndvJ+9CAeeFmmRCdjCS/6nGJS3UTdxr8Hi5al8EgbGdbI4TMSAhZMui3JmguTstAhj5t5PJ1I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556883618; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=KgnllEvhCWGeWdsSdEuzz7MM0PT5TDXBzevZ1LBU8iE=; b=oObzM+9WeI1R1JrObuAD9VE055glEV/IU7BsrmQHAW+epYoURlz4QDKaXF9/0BFcgGZXGUrQDS1YbBv2a5ubr0IHlhO2afVyvd+Ij4JTMmZgr/g0qtGcBk2gWfQ1chYVgyxyrIDxzA7QVWOPj0dKlqjn45QSDKV81FAiVgI/lEI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556883618916214.2719744976755; Fri, 3 May 2019 04:40:18 -0700 (PDT) Received: from localhost ([127.0.0.1]:38659 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWY2-0002Rb-5q for importer@patchew.org; Fri, 03 May 2019 07:40:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWLp-0007uK-GC for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWLo-0003Ww-I9 for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:37 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:40459) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWLo-0003Vz-AA; Fri, 03 May 2019 07:27:36 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MHEPI-1hZhdZ17PE-00DIJE; Fri, 03 May 2019 13:27:05 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:26:47 +0200 Message-Id: <20190503112654.4393-6-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503112654.4393-1-laurent@vivier.eu> References: <20190503112654.4393-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:9mJ0MGscqZRGBssB4WUsQFl3MyEohYKw0+nYDypOHB4kljMeWOr KTiOz0xelByBCjut1qimUyzh6sXudAvBob1yQWVckkkrw19qTk9bhb5WR5LlrfCRs/JQVB1 1o1Uch6d5qRKmpDRcqEe0qrOCr5NuKZUfkEviGQ2310xahDE8xPNHw0dfcsaHREWU4MqWJ2 zabRRwLY0JJZ+M6nI69Ug== X-UI-Out-Filterresults: notjunk:1;V03:K0:mYlqkDd0v18=:VbHbjz+SXh//p930qlIPaE b461DT1hqvMJ6lWXroidtbye3ZdnfVKNkdYq3sbgFD8N9PEsbcW67NwopU3w+o1RkW2XLiJiw nOCLmT7JGsUmbdHOZDx5KMu2hG8i7QMPKtphdf6t9EpK6ipuYMneBfxViNW182lbo6idKOBq/ DYIwhmf8rTGKMM0PTVZ5WVtiG2KM6xOwU0+b+ibZGY/FWiTRmGm0dMLtYEWkLQTi4IiHyvJyB ozL4+ZJfi/USWSdOqMinDSDWwULQX2j5juwqNOKNPUssVWuGzV+jDBixVpcV7u+eRLgXaDLIL jN8ZIHyD4Wi8BgdFU595Tl2G7VThb+CFWoRy65QEgWiO7YGyUCAl52n9qehABrbWOx/RurABP B+P9xxLN3KhDhC/alidAgjp2vSffotWCk+04STjixAETaEwzSWBceT4KM2RK8sbbdIHUYCyQ1 WhL/0bWuCqWFVpsvoBvWbO4S5hTxlZX7AA41HlkvtzNEMoqXBUo5QIwO3Bxtbc+MQwhVDSaSC kfBRMG4HjwUsQr31qsoLryHV3rQXwbuEcV4qKv7Kos6y1Aee2+T1Ex7MMBjB62l2Xs3Ah+zLH lZd7oSU4hofN21Uq3CHU4MvP+wcFscifUmiS7SGJt8HZsGUCFLs7RNUCNhm/3Zro53ERvsY2/ 0hNrjuUONttR3jQuBSjU3l8jPKd6h/WRk6oebPi+nuwVi7uDxHSi7oQSuPvGxFhliRJyJd040 ke4ICX5ZkecedWV02FBW1iy0S2IvGGjt1vtP5wGOeBU4gwF5YwpQ3MC++4A= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.135 Subject: [Qemu-devel] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Wei Yang , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Stefano Garzarella , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Wei Yang Function object_new_with_propv already get the Type of the object, so we could leverage object_new_with_type here. Signed-off-by: Wei Yang Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Stefano Garzarella Message-Id: <20190311083234.20841-1-richardw.yang@linux.intel.com> Signed-off-by: Laurent Vivier --- qom/object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index e3206d6799ee..d3412e7fdca6 100644 --- a/qom/object.c +++ b/qom/object.c @@ -679,7 +679,7 @@ Object *object_new_with_propv(const char *typename, error_setg(errp, "object type '%s' is abstract", typename); return NULL; } - obj =3D object_new(typename); + obj =3D object_new_with_type(klass->type); =20 if (object_set_propv(obj, &local_err, vargs) < 0) { goto error; --=20 2.20.1 From nobody Wed May 15 22:20:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1556882989; cv=none; d=zoho.com; s=zohoarc; b=jS7F/d4xJgQmjjrSL0gF6ufkGaJ3NcHmnvow8HCxsiFqZMhh1GJqDb6dIiFpuJBEAkKAcsUxyOUJNYLAFwdnAAhg0NxWI3Dg1csH9olTAH32GRGfQCYFYrtwS7ZylqMGakV+GphRBKLxifkGOR2MTJ10G+ljL+VVCpxs1OTDHQA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556882989; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=szmoouXf4/nD6CKMT99tn3JsKxnh2gMX2Az+qEWPK1U=; b=oetFBBEB7R+mq+Rm4acUz+FW0a8anPYZ6nyOYHexFLCIAqQ3LiVymAcnqZqqNnvblLZCBaPuZF+5II7RqDSI42KnViP+Ufjc6/ZyG78prb1I4FIBqiVdFYag+12cU3tRDBitrcn5eZblbCLHRhwNrnbVHTTpnHyVDLh4DuSYGyI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556882989696812.4663253797131; Fri, 3 May 2019 04:29:49 -0700 (PDT) Received: from localhost ([127.0.0.1]:38483 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWNh-0000hp-Hc for importer@patchew.org; Fri, 03 May 2019 07:29:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWLW-0007ao-6Q for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWLV-00035O-6o for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:18 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:42163) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWLU-00031r-U8; Fri, 03 May 2019 07:27:17 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MOm9H-1h6wEf1pdf-00QBIl; Fri, 03 May 2019 13:27:06 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:26:48 +0200 Message-Id: <20190503112654.4393-7-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503112654.4393-1-laurent@vivier.eu> References: <20190503112654.4393-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:G1g65eP0H0efAzs12qRn+BsXmZsM6nBMNv988fXaIK8J+tSGW82 x/mm6jEzXirjjJMyjGFnzZHomDgnhAAgsHzRik++tROZHcZIWW7WR7jab50thSRto2+UXtq y3CkIDFNe+ZWRf06/FQHv2OmXRt28Z/BekpnvyOQIP7Ll5rGoNbRaSnUqjca+7wPN+Rxr7g UrsXZSYh8Cg63JVMNa41g== X-UI-Out-Filterresults: notjunk:1;V03:K0:jBCT4kIxxXA=:dIYgJ9udYmEvgucowX0j5c 93H4TENxoYhgVxAVIkCM2/8MZ/3+ednL6QdoJZUJy6HTQBrGYvnv/zTWcF7STs3vp3UoMfAei VwnKAQ7CCbz501+FruwQgpBWQ0DQq7PsyKCweBn4GZaF7HMTYNOieIlTbOe2/YB5qZjIWQcmY VEZlOdoa99faf5VViRytZYClX6VhYllpIIFfN5a2QjNsLnPd0rioNIu6h++84+e9oSLnHaDVV eaoVEKHX44QZZXPCCSLBWR4WSCr6ozTNf1VLpYREJ+2GLQFwOOPRt2e4sYUS9JMDbZOK0aoSx NVP46EiWfomjZ4UPwQ4ZxN6kzK5xwLnMP9uEcWxB1BjsJ24B3daiqrN98I3sbQ/PA3Kyg1New N/JtZnqStUc1VIN4u7LLv+vTnlozCt9INS2OzdYzhWx6EurevjNh2awn5Fc2+35istb5s2III o/ZKSQpY622EUnALMVdKB0oo0QxzX0vLAmFJ1ZHZ1Nrv4Qdtr0bxtWt7uLsls0gd8I/+fgXeP lkqLe7EcYeMisHRdYG5/4mkmTjCrc3WlJylYH8dW8xJts1ST24q5hOxG4fdzTGhYhjSzgrxfd Xhkcbnj2HmRNHE3AUfKzWUExrg1kNgU0PTEvRF+3uZGF9aNPr23kVRQkJPgkcg1DMe8mKH8Qi AZ52J969q7IjVKg8SDFrsWtZBMPBq/eG7hwTuUF0YZ1HomV1gAxnmoshN3oyxD0SMWRFM1NAZ yraX/I+fkCxyMwv8x/VBpui4DPaOfcfgVSQXDvGOpgIO/8P+rR2kZjBeCZeo6zxj/lRz2gUVt Do2yRDyqjUCCCZzzbO7RdyRIOi6DaG3ctIveGLDnpTskjVEvhDY3NgfGUckP8gPw8aBfhKhBq J4uKGFwrxbmcoq6N5rIPz67OI7BzKh2Z2n+SfdjJQth44e53yCWDaSDB+ouSD+I1AhnPM/s/g bR/Gpab9sHw== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.135 Subject: [Qemu-devel] [PULL v2 06/12] configure: fix pam test warning X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Dr. David Alan Gilbert" , qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Gerd Hoffmann , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: "Dr. David Alan Gilbert" The pam test generates a warning on Fedora 29 with -O3 compilation because the headers declare that the pam_conversation pointer to pam_start must be non-NULL. Change it to use the same 0 initialised structure as we actually use in qauthz. Signed-off-by: Dr. David Alan Gilbert Acked-by: Daniel P. Berrang=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20190404091725.20595-1-dgilbert@redhat.com> Signed-off-by: Laurent Vivier --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 60719ddcc5b0..a2607afb3408 100755 --- a/configure +++ b/configure @@ -2940,9 +2940,9 @@ if test "$auth_pam" !=3D "no"; then int main(void) { const char *service_name =3D "qemu"; const char *user =3D "frank"; - const struct pam_conv *pam_conv =3D NULL; + const struct pam_conv pam_conv =3D { 0 }; pam_handle_t *pamh =3D NULL; - pam_start(service_name, user, pam_conv, &pamh); + pam_start(service_name, user, &pam_conv, &pamh); return 0; } EOF --=20 2.20.1 From nobody Wed May 15 22:20:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1556883150; cv=none; d=zoho.com; s=zohoarc; b=UOa3BJHMLaKk0/HsRRdg5RMNDX+oUGJL4An/DkJ4fkK3nJU7XZA4RXZ8i04GRZKIHjEpsnReeYt1Z1CLpqMz9+AJVi5AIOf1y1sWy5cT2IKPhqEEWywlU66Mlm6TeQg62paswgz9lXirdV3sURNc+BhKZTNo9GODQAdQbXb/lVw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556883150; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=gXY6wZU3DzV9GtIrK6xtMUlKwVmfR+hGO5NyTmgoclQ=; b=iWE6rfMgbQpc1hZwZnj2QmDamVHtCGPIj2tYD/H0dbuUwV+PNfdVNtsxgYFa4lr7wqAm0ZCdXYVSxy3OFDfK/X6sGtnZFTe4z/+BJ08frjVbKsDXt3M1RXt3nI0cufqw9QIXI6Kr1ZNSzCN6RgSMkIL3Y0whFEJuy0pQjjlgLkM= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15568831502801006.6222764590424; Fri, 3 May 2019 04:32:30 -0700 (PDT) Received: from localhost ([127.0.0.1]:38548 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWQV-0003B8-2I for importer@patchew.org; Fri, 03 May 2019 07:32:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWLd-0007ht-GK for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWLc-0003IG-Lb for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:25 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:53183) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWLc-0003Hh-De; Fri, 03 May 2019 07:27:24 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MSZDt-1hBq3W2v6X-00SsBl; Fri, 03 May 2019 13:27:07 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:26:49 +0200 Message-Id: <20190503112654.4393-8-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503112654.4393-1-laurent@vivier.eu> References: <20190503112654.4393-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:N07At0ZGbo5irFABpI5uyTwKRVlRPb2fUGCZ7q3zcuJYX9kZvoe /bqsmUbvIUXBMoaw8aDQCc0ffl5emnNJ0D3tPJod/VxDecIdIwcVppwvIrXXOxKlTKvDLiM x7b/be7wZpH8NLNdvp1xEQQxujLfs197lQhzR31jDAB3rb/ckSZcpsoiTgRjt6T7ty2Z6S7 Cy4rPBLDTbprizof7YTBQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:i122f+U2Nv0=:yP3Vo9C/nr9TtDjkVhL+aH dE2xW/AvZAAtQytXYtGgt3WVhzowIuZkYQHu3S283vH24Wdg3lzcLC5moQWbVgyfFe1Ui7MpF Y3oTlhK+6G96EWpIIb4PyQug2x1YB6dXbM0P1EreJ/6ShLeX5qd9k0gFBCBj1pjDOafTO3AwE NV/CEBhyH/ZiB4uLIk1/hN0e2gom/rk98Sv/FvDtSrxK+Q7SFoMAprY/Ba+kOmNQuNG/lFakE 6941oEbVq8hBwp6p5w+FNz8mAMvsAD+BqGpZIL3IjCLD6Us7eq3f2TzhVvrnT8HftHtau8oK+ maycJajnLyWzboum8+WmGbtd5lpf3MVrlid06fIULRoT29c2WuSM6Ahjgd7SITpNZkRz/xpw0 zVms/WcXc7IWk+NhS70t3y8yaEFMPoiCTcJQG7N85/gIDLORjv3iZRNJban38O4saGLnRAeth /rnAdjaD2lxMS85RYZwwqSeKl8hF2/qSN6MkSGTEUSRscBDx/oBJEgZV+m0eModLf1qtvc7xl +Ffj/SBIrFqqKpn6d22w/gEPtcu1mrHRiPpj1JHeZCMzje4+KompbG/6PtZSGN8+nOxA36GFh 2yy5Be1bLZD50CJxfq5DxF1eezqmbbyknS35XlK/vT7QWQbagcsG4ipvWJXkBqVmvUDoRJXpr hj524biWRXynZ/IEAdAEW2QYZ6FtOEfKugn6EFZV2SeXzK5oCfmCBPbokxWQ1YrWeH+I375J7 M+CQ9dMBF+UJ++ZGeZBQreZENaSeJ++XrCFr6ZVzisP5CnzXSKu5KF/yhvc= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.187 Subject: [Qemu-devel] [PULL v2 07/12] Update configure X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mammedov , qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Gerd Hoffmann , Stefan Weil , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Stefan Weil The last *.aml file was removed in commit 13b1881aacc7e5018773bd545bbaf8d54= 76699ee. Signed-off-by: Stefan Weil Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20190409053320.14612-1-sw@weilnetz.de> Signed-off-by: Laurent Vivier --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index a2607afb3408..14f02452f9d4 100755 --- a/configure +++ b/configure @@ -7880,7 +7880,6 @@ LINKS=3D"$LINKS python" for bios_file in \ $source_path/pc-bios/*.bin \ $source_path/pc-bios/*.lid \ - $source_path/pc-bios/*.aml \ $source_path/pc-bios/*.rom \ $source_path/pc-bios/*.dtb \ $source_path/pc-bios/*.img \ --=20 2.20.1 From nobody Wed May 15 22:20:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1556883430; cv=none; d=zoho.com; s=zohoarc; b=h2rDThtCnoP5A3q8F+rDji1owxZV8x4/jp+zQp2KqHBDId8kdEoO4wLxPYYW9xPOf4utLF00PCX6BnuAz1ZePHuDS2/1WxxVwV6eSuBB3YR4A3Fo9LZ1wLuOw25/FHNS1Ulk6S/NAQ9xguFo9ExBpg1HdZKjml9EbRCI8J8A1yI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556883430; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=2FjOfdWMT4t0oOFyLX61AhF3JnTwh8BmCFcRkVfnJh4=; b=adj316yx+u3+3Lsrw0d6uGGa5CPGodvDEzlbR+EUQFPceo3SuZRaZG78IdYshODY6B6iS+jjdNmg1tQzjl4WHp50PKXoDuvh/m825KlKoYpB1CJYC7SB4UJ4bgB4dhgxH5wnQZVMp/GXHWOkjJ1IRVqug7OOP5ZFZ6Ps9gMBhPI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556883430539525.5493622131264; Fri, 3 May 2019 04:37:10 -0700 (PDT) Received: from localhost ([127.0.0.1]:38622 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWV0-0007SM-GT for importer@patchew.org; Fri, 03 May 2019 07:37:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWLg-0007l9-I0 for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWLe-0003La-M3 for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:28 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:39291) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWLe-0003JV-DL; Fri, 03 May 2019 07:27:26 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MWhxY-1hFyvU3tqS-00X13A; Fri, 03 May 2019 13:27:09 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:26:50 +0200 Message-Id: <20190503112654.4393-9-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503112654.4393-1-laurent@vivier.eu> References: <20190503112654.4393-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:G2yBrV7EeKrN/+ppX66Q4YSPLjd/pin9EJ9LPnkhhk4KBEsXU0S 18qNg1leysXag1GayfOmJqH5Yu6CwlUZvOo+2WAl5aC52MbuY3KqpDcbGUnCbmwmO2+iyRU 7cMaCBrq14EQNjFnR+L0w/Eo0dcP/QBOTMrF7B4UJrnFY+ANXYlRnmM2syN7sRb5xrfjDoZ m+haxnDDdOydQMjaiapLg== X-UI-Out-Filterresults: notjunk:1;V03:K0:iuZKCtrbyDY=:7B1a4EN08eXbwEmHWnhbga J3tOIhdeKPujwgVl6T1TxJtCaw/g8aiujYZYi0kCal9zXJpI/JbdA9aHBGIPspW7uu6Y+uZSb kLraZ40mD+Cd9CqDL39ipPOFhg9hOI2T5z0o8vs6MqwP+LRDFox5jKCo7aaKfZuDOuGQB0lHt I5kLXX/ANZ8auYPeIzpx/0JCjjcCb8FrLXc+e4S1q5/ldNnK1RCRH+aNaw0PDOI8sQHCWgcUg EQpr0Tcy+YqyeIwaUEN0I3YCoNQFFoHx98cCZ2FtjkMi0ssDhE+Rs9kNIAHfK3oTSfIZuWSfD wD5nLQTgYYk4nCkn7Mbl0YtUobIvto0/9qh2evss2ySQf/1bxMmYUHTRCoEOYtlnQz5/yOoZ8 wlIBe++/u+ox1Pz0S9KwT1UkUPCFFq7kiBXspPfnFStzb0kbiu/ls16CuLpd1MY6o6tKHrBOE pce4GLsFj0AJxoH03aDKKtKuZUDNb4qwkUIoyGgEUQBszsDc1qNF7d3bqTXwsfHnMCHnQvFeN 2hbe/+AdXecPbu4kBGfw2i0Q5eJ56op2CUdmuGamTVaa8WUyUx4/k0d1Rr5vG1l9N4bsMAndF pKCHvbT5lPylBtkOE4ERaQ9v2+1eiWyy3rYk6oJKlqqRaO04uz4cWJ1bZfWx8p1Kextd53msP PlJ1/5VKkT92vS9N7C6NGd2DMraImBqKHrn91QEThtMiWAc0/iO/AZvB7KXtl1LIIH6pAKPkD wVqx0vDbS3V0LHvHm+LdrtxrBm7KY4pFOWDD4g== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.131 Subject: [Qemu-devel] [PULL v2 08/12] Header cleanups X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Gerd Hoffmann , Aruna Jayasena , Paolo Bonzini , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Aruna Jayasena Removed unwanted includes from cpu-common.h This task was under https://wiki.qemu.org/Contribute/BiteSizedTasks Signed-off-by: Aruna Jayasena Reviewed-by: Peter Maydell Reviewed-by: Thomas Huth Message-Id: <20190409155635.10276-1-aruna.15@cse.mrt.ac.lk> [lv: fix conflict on rebase] Signed-off-by: Laurent Vivier --- include/exec/cpu-common.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h index 848a4b94ab73..f7dbe75fbc38 100644 --- a/include/exec/cpu-common.h +++ b/include/exec/cpu-common.h @@ -7,9 +7,6 @@ #include "exec/hwaddr.h" #endif =20 -#include "qemu/bswap.h" -#include "qemu/queue.h" - /* The CPU list lock nests outside page_(un)lock or mmap_(un)lock */ void qemu_init_cpu_list(void); void cpu_list_lock(void); --=20 2.20.1 From nobody Wed May 15 22:20:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1556884014; cv=none; d=zoho.com; s=zohoarc; b=b5V1uEARrbgpvR2SGgzudhPRVx9XXJ9DnAaUWFhJodyG44AKFaCqzWJ+4VPttu3C9YdgK+YXEqkpHLvAgZZPZlALF58mAdGvAqtRI2Cc99gfmiBiRcTZmKD86g9BlCw453dqxJuWkK9vIX3XShOIifJ6dmxsEuxraCZ5ib9ijaw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556884014; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Hoa0DzLp5Vcz7xzfh8ltJfwT0BE/ALemN/ckTrlzMT0=; b=laWpjI4NIqUA9vgtgze0NmHivb827YGR3oGScWIvrVd1dohHTXgjFT5cXEe23WYsf0CIYjULmCAEIatlQ6rNKuxW0h3Ts449ponY/JOKTbrS+7IpdngnJps3IF7Sx5KQDxOPhgR4AOwYZCMI9FXMF2xC1uvHi6vNfPe2Z8sBtF4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556884014606930.3660032469124; Fri, 3 May 2019 04:46:54 -0700 (PDT) Received: from localhost ([127.0.0.1]:38848 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWeO-0008Ki-Je for importer@patchew.org; Fri, 03 May 2019 07:46:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWLk-0007or-4y for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWLj-0003Se-5G for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:32 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:45683) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWLi-0003Rp-SO; Fri, 03 May 2019 07:27:31 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MYtoe-1hIAms0Zai-00UpC4; Fri, 03 May 2019 13:27:10 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:26:51 +0200 Message-Id: <20190503112654.4393-10-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503112654.4393-1-laurent@vivier.eu> References: <20190503112654.4393-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:eT9HzwyNXoucdZC+9VuanHN27GG8yYzj5tbE4MzFM1Sv6nyLmeW NaUWW3SLen2u1LX28oLxarUTJTW84U5ZObiZlQ6HRr2pQYjZq1UW8InDVDfuW18vDPpI77W /rUiaaQaVro1nJFx4MgHTTET3q2WvmFhSbBc5rH6LXWi4CDY3LJZfsOncubs20/EHnVTALD fx4m4kniL8XsdBHryUScQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:aXEYOKnYNf8=:mfY8Yx0AAFMQDEZNUmXc1C D/VyT5IUHNJWJir8s+Enw4syIlWSwVOEAdj4d5KilzQf3wMCC5Cfba5jRaLtrafmNs9lfrfTO RVpmc2RI+5KQWSY6Ynxg/ERft9cL3wKabjB2eMQygReNuMZitgrewJH8W5hKhTPvOGn8kEyYn ss+1irPm2jLPJI//LfOozJUBLWgOugWtxuvsdfTUXLDcqErpG1761+tSHFJb4fBZ9EsatsSxq 4csig/0X9s+uBBYE1PDyeHkimilfh5WDIbSwzdcUJQ/0H0urgZaWrCbG20edeN5pEXIwnHOSk 5nlIH7yVaT5I9jULOC6PXEaWFRpg006ckDQyDTJ43VwuDIK7I5dtDM5QLxXczQVLCRIRvALzP LZ5MoNEHaliz59UWfUpzwPuK0Lt8XyX1l+iQY6at6NywvNOQ6AGD/J4bNQG6o7jbZ3e7YdMis 2jIpfUKsRBs9n+0HbkzXRrhfo8XiIShIvgbXtwxm0Y+j1Ao9SR+kTAL8E6uJq133tmtuqZ5rk 5cXezTdOAlR5NGeOXBiwZOI6o80BWC30sGMiWJd2tr+/ZXY//oBI0oo78TJTs3UNcBURZtS2Z 7wJ7hiTQg3flsyAd044+3r3LrgQWvF5bsyp1nYKViUrNdzoIK7N1LVFs7ok8IaYFXtvsDTEPF G4zzcNMCHfBozRS+pWdaIHHLx4oiv1vtSh3W73gMDBMalZ0W9HN4GtLrWiQueK5qqHHgZb1Lx Cz3M1mCA9tybBGCQaEyJzExV0naFsAP+CwhfDL8BOdOYn9WkHItfhflIFY8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.130 Subject: [Qemu-devel] [PULL v2 09/12] net: Print output of "-net nic, model=help" to stdout instead of stderr X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Gerd Hoffmann , Paolo Bonzini , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Thomas Huth We are printing all other help output to stdout already (e.g. "-help", "-cpu help" and "-machine help" output). So the "-net nic,model=3Dhelp" output should go to stdout instead of stderr, too. And while we're at it, also print the NICs line by line, like we do it e.g. with the "-cpu help" or "-M help" output, too. Buglink: https://bugs.launchpad.net/qemu/+bug/1574327 Signed-off-by: Thomas Huth Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20190423160608.7519-1-thuth@redhat.com> Signed-off-by: Laurent Vivier --- net/net.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/net.c b/net/net.c index f3a3c5444cc3..2cf5e7646997 100644 --- a/net/net.c +++ b/net/net.c @@ -837,9 +837,10 @@ int qemu_show_nic_models(const char *arg, const char *= const *models) return 0; } =20 - fprintf(stderr, "qemu: Supported NIC models: "); - for (i =3D 0 ; models[i]; i++) - fprintf(stderr, "%s%c", models[i], models[i+1] ? ',' : '\n'); + printf("Supported NIC models:\n"); + for (i =3D 0 ; models[i]; i++) { + printf("%s\n", models[i]); + } return 1; } =20 --=20 2.20.1 From nobody Wed May 15 22:20:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1556883493; cv=none; d=zoho.com; s=zohoarc; b=BL61lsFqvXOVHQf386Zv+egtEGh3KxEQnsNRIkfNheAs8AeXpJ7bUkDbpB8dyn6GzMAEPzsiQ/Wk/+bpj6lSD9NknnSs3YLsVbX/4VuqrIyEx4ud9oJeh94JxzHQphNFQlU8teJDTrmiqXnKLNty1aaKWxcwf9g+gimgUDM9bO8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556883493; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=yB//6bZgACplIT2o7Dez8spNLmb59OI6uomikoNp0Ts=; b=FfR4E94AqBqT3ODLRTswl90wBskv7hOUzPnTr22bqnpzoJv2mTZQ7y36MRXW8vsXbBfkM8F6du7RjsTR4tF35i4GCY1Il/9gY7iEkI/0WLuJVLnFrBdhzJC9RMef0WNYi7RBQfRQhKJM5O+AjlpIlsNeDi5MMTcNqodu1Rx4jig= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556883493460180.05630475041244; Fri, 3 May 2019 04:38:13 -0700 (PDT) Received: from localhost ([127.0.0.1]:38634 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWW0-0000CA-A7 for importer@patchew.org; Fri, 03 May 2019 07:38:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWLr-0007w7-B1 for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWLq-0003YR-BO for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:39 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:43839) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWLq-0003Xd-2g; Fri, 03 May 2019 07:27:38 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mtxxk-1gSdOt1Hps-00uGzk; Fri, 03 May 2019 13:27:11 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:26:52 +0200 Message-Id: <20190503112654.4393-11-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503112654.4393-1-laurent@vivier.eu> References: <20190503112654.4393-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:qP3adIP8oXcIdsE+hQ0KIyGDDIVh4OUeNCt5i1VwQjrqCox6CcY 3gsM6PwyJza9PLzSMPGSpBDXxmO56aj/o61VkOE/lqJiKmMBxmtr2hucOE8MIZuwdfTKHKC ic6ic/KICzhDxtb4AHxR73Chpbqy8tQUGr9NkYBoA0Hdy0SRXVuQZ6NOWo1Ev2J2m8A6tQE 610C/XiyL+ayDbH733YAA== X-UI-Out-Filterresults: notjunk:1;V03:K0:njiNo2w2ei4=:/yYLlsDIBnnpFbCiD5f051 sgsumgGjoB0Nc2oGtXH+BZJ9pzSf3YGBxT4C/LPJAIa0Sjh8AAnvomf6InLWghSrrCc2GG2n+ 10K7gWeWjHik7cxwKLVsf/k0Pmk6omn8M/m1HlNX1cT7eNGFCG4RP0EXyCebXY7FA9+1rImG9 lL/dckIAfN23Mu8qJCOHMCLPY0lE9fXZ56cAW8tPZroB6dOy6HWMjDnuOswYaAoAvJ+LJOgKM X0L3czCB2hjHKgF1b4w7oFhm4gTkrw5csqMcSzJLyXKxkPIjMNFsm3CIJpRZM+MiGwCmQpTv5 +ug6rTS2d9Vst3hE46ZYoxKemyeMWjkLhLREfpO8+rzB6bxiyS3ck6sBgznAzKw1x2W8cSJEP 6llsSGB6YuILslXoCDH3fKRFUN7Hq2u3nI651G5MkOw626JuJzPd/8SforuTYimW4QYjRCJD7 qp+W9Bv1bYivolfI8h+vYvRGMKnkjX73rbdZvMRctvstFLaycc1U72qQgAObwUsGxettb4llQ 5GkQ8Qwn222LATD2GKR0UNxqw2lXHNTf9LnluSh1sQzMJIm0mMSnIU26iedpZGIzx+WbgP5h8 SzwhPazQK128M903GrpTefKyeuu/wB9dF8iWghhoaUkb7vwIK58RNV4TV1Q1rJrrri7mEkEkU Eq4pLYrRfJAdhWhDZuPF76yCnq9oWUa07qErAxFwsLPHEkks5P93YaFaNgcphg+oZPAoObOA/ 5YQUgR9Ecy5KU/wmSo3lP0mt0oVVQ1a4qoYtHrufNkYLBtZR22sCLK7BHsY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.131 Subject: [Qemu-devel] [PULL v2 10/12] Makefile: Let the 'clean' rule remove qemu-ga.exe on Windows hosts X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Gerd Hoffmann , Stefan Weil , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Commit 48ff7a625b36 added the QEMU Guest Agent tool with the optional ".exe" suffix for Windows hosts, but forgot to use this suffix in the 'clean' rule. Calling this rule let a dangling executable in the build directory. Correct this by using the proper optional suffix. Fixes: 48ff7a625b36 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Stefan Weil Message-Id: <20190427161322.24642-1-philmd@redhat.com> Signed-off-by: Laurent Vivier --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 43a7a047b452..e223bfe2a3a1 100644 --- a/Makefile +++ b/Makefile @@ -639,7 +639,7 @@ clean: ! -path ./roms/edk2/BaseTools/Source/Python/UPT/Dll/sqlite3.dll \ -exec rm {} + rm -f $(edk2-decompressed) - rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga TAGS cscope.* *.p= od *~ */*~ + rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga$(EXESUF) TAGS csc= ope.* *.pod *~ */*~ rm -f fsdev/*.pod scsi/*.pod rm -f qemu-img-cmds.h rm -f ui/shader/*-vert.h ui/shader/*-frag.h --=20 2.20.1 From nobody Wed May 15 22:20:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1556883847; cv=none; d=zoho.com; s=zohoarc; b=IZSNAI1P0nj7Cy4V9RGYMtnaulp3I194jRrLf5VeJmZi9UDLg4EQxl/gr69u8s0Q2G3bu+bar533oQbf1eTkv5O0JMtVEYaML8R7u/YP+IcwuCsj2u8RXXDyFUJTTqKHo5tghn1OGdLACOzSrAAaNf0uXzFYjcVNGhgnpMWp7PM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556883847; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=+LQApKPYBVvGFa3Hh+JshImcp1aWl72VW20e7ebBQBw=; b=Hsovlp8iR6V+FQZqBbwDKW5XX6CrOLQ5qXLR4LK6rIWko2I1RylEx26Hn/g31N+aMZJ0sOQRibIXSYEiXrHCd2c0Em6poz9u7rh8/oa8qV+K5ZXelUeGuIVBZs6dgL3X46Ds20YAcPwMYpIhpIvYK8aRnud9zIZ5UaW/Wly/Qss= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 155688384791744.70123367394331; Fri, 3 May 2019 04:44:07 -0700 (PDT) Received: from localhost ([127.0.0.1]:38761 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWbe-0006Nu-RO for importer@patchew.org; Fri, 03 May 2019 07:43:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWLt-0007yS-8X for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWLr-0003Zy-UT for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:41 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:51901) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWLr-0003Yq-IV; Fri, 03 May 2019 07:27:39 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mmhs6-1gvfmw3Cty-00jruY; Fri, 03 May 2019 13:27:13 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:26:53 +0200 Message-Id: <20190503112654.4393-12-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503112654.4393-1-laurent@vivier.eu> References: <20190503112654.4393-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Yr6N8DVUuZAek6d2wIuyKkCulINgbzvSwJs77413ZEOeSlYO+1k DhJEgZCCHuvHdyBsNqrx1P7P+RuElo0e3mL8i15Gd1gLR73wZ9+dbABkcKjIm/y9DZbjDk6 cxlNzWYvaigJwrL5xY83Z8Kl5AZP8jQV5ezLDuZytdBFhnvgSE+YVWos1DHHCmbjLFRpkrt FKJ26tniVeGz9Q8zqWKRg== X-UI-Out-Filterresults: notjunk:1;V03:K0:ldkHbtITqlE=:CCU2hx6y84NcCvOwpyx2jG 4M188hiX8HxLd5cscIXGiAcRVb7K+pGc7NCfKl378rJJKji7i4aG5474D+MymO9llCeM8c7vT JLcLvJeHs4edYHxmiRreylmYnDQx8uqLZ9mGubxZAdWwhkpmPP00Rrd6woM/GVaq8NQ/k/fnt mYJoSvLe1h8Ftrmc4lqdCfH9TH+AcCBo8HUpvk+Qq7wCZmqu+ZNAEO37wmBj2IW21rN2RUr9S o9iF9ncZnjDPuuL0bqSlguMPJrmoyRyWNggS7CX8R6nD/r0/N4VplToVv2+VW9CvE9cj33DLX 7IQYFjQgOb6/lQsziYcfF/cxzvAKN/UAMICurHFY/tskF2mnvfYAqFU9mp8SCIYeTa1L7yeYQ wOPO13LK+y8gt8n+tppZDUCEqeokJrZAFD/lXglGzedDFhObbO9ayfnT5yTze9gunxVxOevCJ uNr6YYm8XY10y5esEVD1kB8yFT8N6KWt7Si4xQ83Qp76KrPTtCabMkQ22GHLiB2FKdTHErGfc qJpbJqSRiEwffFtvaufk9EE/CPYTF/CMS3IMLAlgHy/9U04yN5aCSMGJjWVDxta6N2SWb7/kM bV+SLp7U3MlR4RBcFALNxBpkM8pZaSes+GdYjrm6SXxUYk1az6I9BYPHFrQyOh2iA74HPKCK2 JkfFc9vI/+N9w1pOGJJjjU5G0ena3XVK16NwkLwYVynVl1SCfL5Vy7Rrbc7JU3haazOxccJLV uPp0n7d2R1HqR205EH9x/RVM4YnbYYE+No/1ANO5D4ySLcZpbR4cPtuBN8g= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.187 Subject: [Qemu-devel] [PULL v2 11/12] hw/sparc/leon3: Allow load of uImage firmwares X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , KONRAD Frederic , Gerd Hoffmann , Paolo Bonzini , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Currently the Leon3 machine doesn't allow to load legacy u-boot images: $ qemu-system-sparc -M leon3_generic -d in_asm \ -kernel HelenOS-0.6.0-sparc32-leon3.bin qemu-system-sparc: could not load kernel 'HelenOS-0.6.0-sparc32-leon3.bin' $ file HelenOS-0.6.0-sparc32-leon3.bin HelenOS-0.6.0-sparc32-leon3.bin: u-boot legacy uImage, HelenOS-0.6.0,\ Linux/ARM, OS Kernel Image (Not compressed), 2424229 bytes,\ Sun Dec 21 19:18:09 2014,\ Load Address: 0x40000000, Entry Point: 0x40000000,\ Header CRC: 0x8BCFA236, Data CRC: 0x37AD87DF Since QEMU can load uImages, add the necessary code, so the Leon3 machine can load these images: $ qemu-system-sparc -M leon3_generic -d in_asm \ -kernel HelenOS-0.6.0-sparc32-leon3.bin ---------------- IN: 0x40000000: b 0x400007a8 0x40000004: nop ---------------- IN: 0x400007a8: save %sp, -136, %sp 0x400007ac: call 0x40000020 0x400007b0: sethi %hi(0x4000b800), %i1 ... Tested with the following firmware: http://www.helenos.org/releases/HelenOS-0.6.0-sparc32-leon3.bin Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: KONRAD Frederic Tested-by: KONRAD Frederic Message-Id: <20190427162922.4207-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/sparc/leon3.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index 774639af3393..0383b17c298f 100644 --- a/hw/sparc/leon3.c +++ b/hw/sparc/leon3.c @@ -193,6 +193,10 @@ static void leon3_generic_hw_init(MachineState *machin= e) kernel_size =3D load_elf(kernel_filename, NULL, NULL, NULL, &entry, NULL, NULL, 1 /* big endian */, EM_SPARC, 0, 0); + if (kernel_size < 0) { + kernel_size =3D load_uimage(kernel_filename, NULL, &entry, + NULL, NULL, NULL); + } if (kernel_size < 0) { error_report("could not load kernel '%s'", kernel_filename); exit(1); --=20 2.20.1 From nobody Wed May 15 22:20:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1556883659; cv=none; d=zoho.com; s=zohoarc; b=bw3/uYINHGFMxb40+cFlIHswq73kDkPCQm+BTUy7LUjDDOO5YIWukIMxI9TT/s3pIsimAMMtmAK67bbz3sZWe7iytLSgScNa0va/y4v4BunGGorAQBaf/kkaOwWQgPe93Ejw/Mg/MxzYX+Qp5ns2HdwsKPwXjCIHSCVSTwMer28= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556883659; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=PryaSMjW2m2et5+XwrG31XUz91I1w7aNiotaGWKeGI4=; b=GQ/m65W3WiLcUNrkt+4qGh94KDJqnLYx6OxpeTvvayWritS1iyyuuchKxYSxjz3YtLs2d+1Ag3ioAaEdk+MsA5UIZoDXMuo84lOS+gKKM/b3OUMs/gMvuflrgY3ctWU1WYTYXaENGy/XkfVYcSpHy7DPxcj7a8tQUwvPnkyFut0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556883659867260.59874229521847; Fri, 3 May 2019 04:40:59 -0700 (PDT) Received: from localhost ([127.0.0.1]:38685 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWYf-0002zb-Np for importer@patchew.org; Fri, 03 May 2019 07:40:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWLt-0007yo-FS for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWLs-0003aI-5I for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:41 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:58167) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWLp-0003X8-FM; Fri, 03 May 2019 07:27:37 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Movrq-1gxtmB3xWg-00qTby; Fri, 03 May 2019 13:27:14 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:26:54 +0200 Message-Id: <20190503112654.4393-13-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503112654.4393-1-laurent@vivier.eu> References: <20190503112654.4393-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ttwLbHfjFvzQwfNO9cPzyHDWHibyiGxX3ChUL76EYHycmw6EnmQ kx4FPyw+19atBvv9rTvmGMzWtnRB2Nw8LpG3BT7UsJRdIGZppMUoPxmfCku0TYi4WxRrpc2 gcC4yxJY5WaFH2jsPA0++zT7nbzpXMsAr25W1rV5bf4PAkkPXiFCAytwX+5eeT1n+pRGQ46 iBYBR40gUDShIbw4z18QQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:8DdFuGzYnG0=:Cz+Bl1L/hYJ+YNd2i6eG0t 37PibROpijR6jsht4R6cKPt2uQ1t8+Ak3RII7DCZy/fUpyN/LDaEbukfbq4p3FzAdyaHyAjUH YJwWT23oTMom+/552ujZEHEv6LO8KO7qM2eQ2sghrEuJFCMPIVYdK5Df4ntxWhWTYtWX8gKfF 7pScW0UZxYQikQSVUskv62EmbLTTJGWhXXPrvOuzKGtWXM+HxEQcmFPM6JZemz/kBX0gRZuM9 ztrHpLzJ2Y44iX2A6YxzgxeHNvmH6OkLfdTIuTkfWhFDlNReG29GIQvsnswBZj9OvcvuwvtWp H3/+XJZGO3/EzJ1QTTPFyeJCnAB3972CUTfswf6s+uH5MTAW9xdLUZEHkgfb6SAiATGvhGdtZ zaD3utatdFMyB4Z6LLDaPUP0aptg2Ou/dXSQ3DbRTURc0UvGHV90NkDQOOku6FzNAFGHRRN1Y BqhCeinaag4avNPCqqdpI3WkuZRp+WEqVZspx/h+Hx3EwuKO9EEO2VnF0NbQgbwJjZkeXTrl0 qJGZUMzW598nOk6InZVcSpxAwM7OZWhKnn8h5MAPcVch0p3rBS6oyIErsl/9teeBdmKWWsnuk suOCoLu5K/I8IDVyoLDITF8dTHmhl65A7CMWLYRfTI8lsKGjnYRGmrHU+oY2XpHN2Hz3M6YMd ppLr+1DnBbL2vNimNVp/rjtvpSvWC5H0wyDbBjOskjg2Z7UDLXZa3d7W3fILc3du3UQRmZC5r jtXI7EBExZulsJsnEUV/wgnupFfnvMIn1yq7kuJ9+GTqH3cxcgL398syCVM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.187 Subject: [Qemu-devel] [PULL v2 12/12] sockets: avoid string truncation warnings when copying UNIX path X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Gerd Hoffmann , Paolo Bonzini , Stefano Garzarella , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Daniel P. Berrang=C3=A9 In file included from /usr/include/string.h:494, from include/qemu/osdep.h:101, from util/qemu-sockets.c:18: In function =E2=80=98strncpy=E2=80=99, inlined from =E2=80=98unix_connect_saddr.isra.0=E2=80=99 at util/qemu-s= ockets.c:925:5: /usr/include/bits/string_fortified.h:106:10: warning: =E2=80=98__builtin_st= rncpy=E2=80=99 specified bound 108 equals destination size [-Wstringop-trun= cation] 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__de= st)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~ In function =E2=80=98strncpy=E2=80=99, inlined from =E2=80=98unix_listen_saddr.isra.0=E2=80=99 at util/qemu-so= ckets.c:880:5: /usr/include/bits/string_fortified.h:106:10: warning: =E2=80=98__builtin_st= rncpy=E2=80=99 specified bound 108 equals destination size [-Wstringop-trun= cation] 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__de= st)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ We are already validating the UNIX socket path length earlier in the functions. If we save this string length when we first check it, then we can simply use memcpy instead of strcpy later, avoiding the gcc truncation warnings. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Eric Blake Reviewed-by: Stefano Garzarella Message-Id: <20190501145052.12579-1-berrange@redhat.com> Signed-off-by: Laurent Vivier --- util/qemu-sockets.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 970505169000..ba6335e71a95 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -830,6 +830,7 @@ static int unix_listen_saddr(UnixSocketAddress *saddr, int sock, fd; char *pathbuf =3D NULL; const char *path; + size_t pathlen; =20 sock =3D qemu_socket(PF_UNIX, SOCK_STREAM, 0); if (sock < 0) { @@ -845,7 +846,8 @@ static int unix_listen_saddr(UnixSocketAddress *saddr, path =3D pathbuf =3D g_strdup_printf("%s/qemu-socket-XXXXXX", tmpd= ir); } =20 - if (strlen(path) > sizeof(un.sun_path)) { + pathlen =3D strlen(path); + if (pathlen > sizeof(un.sun_path)) { error_setg(errp, "UNIX socket path '%s' is too long", path); error_append_hint(errp, "Path must be less than %zu bytes\n", sizeof(un.sun_path)); @@ -877,7 +879,7 @@ static int unix_listen_saddr(UnixSocketAddress *saddr, =20 memset(&un, 0, sizeof(un)); un.sun_family =3D AF_UNIX; - strncpy(un.sun_path, path, sizeof(un.sun_path)); + memcpy(un.sun_path, path, pathlen); =20 if (bind(sock, (struct sockaddr*) &un, sizeof(un)) < 0) { error_setg_errno(errp, errno, "Failed to bind socket to %s", path); @@ -901,6 +903,7 @@ static int unix_connect_saddr(UnixSocketAddress *saddr,= Error **errp) { struct sockaddr_un un; int sock, rc; + size_t pathlen; =20 if (saddr->path =3D=3D NULL) { error_setg(errp, "unix connect: no path specified"); @@ -913,7 +916,8 @@ static int unix_connect_saddr(UnixSocketAddress *saddr,= Error **errp) return -1; } =20 - if (strlen(saddr->path) > sizeof(un.sun_path)) { + pathlen =3D strlen(saddr->path); + if (pathlen > sizeof(un.sun_path)) { error_setg(errp, "UNIX socket path '%s' is too long", saddr->path); error_append_hint(errp, "Path must be less than %zu bytes\n", sizeof(un.sun_path)); @@ -922,7 +926,7 @@ static int unix_connect_saddr(UnixSocketAddress *saddr,= Error **errp) =20 memset(&un, 0, sizeof(un)); un.sun_family =3D AF_UNIX; - strncpy(un.sun_path, saddr->path, sizeof(un.sun_path)); + memcpy(un.sun_path, saddr->path, pathlen); =20 /* connect to peer */ do { --=20 2.20.1