From nobody Mon Feb 9 16:51:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=foxmail.com ARC-Seal: i=1; a=rsa-sha256; t=1556843948; cv=none; d=zoho.com; s=zohoarc; b=R81S8Yq8X37EDJRZp3QTeDBHfAUaYB8eDF2Q97Skk7lFFzn9+sA6rtRJaWQhwif8/txgHgYmbyxdkSkE/6nETfEEL6WNuS5XsWSo+IJpVWrpn6GjcxwGOBaY3AU3DL1lcf17NuXqubvB2mC/njd15sbvtsL2aqCzaYq07wSc7g4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556843948; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=fqx7px8aicw59s5wsPfWml96z0lJHa6tUbYs8uCbaaw=; b=GUlAaMllCOt1LKDhjwhokPVWrGprxTg6Zr7aUI2qiawBlfOlHIz7BKyyp/7+o/f9gp3rF713xzbWCISAMlFJ29zx6jlTmV+YtGa+bwokavR7kJmj1T11GmboKwgXqVyHhWQd5u+7VSOAqln3WymmtoQ1AIb9O7EVox1jvTk4J3M= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556843948064687.9112205603857; Thu, 2 May 2019 17:39:08 -0700 (PDT) Received: from localhost ([127.0.0.1]:60385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMMEF-0000wd-2W for importer@patchew.org; Thu, 02 May 2019 20:39:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMMCd-0008SZ-T4 for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMMCc-00030R-Vr for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:27 -0400 Received: from smtpproxy19.qq.com ([184.105.206.84]:50156) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMMCc-0002zn-Ol for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:26 -0400 Received: from localhost (unknown [183.63.119.3]) by esmtp4.qq.com (ESMTP) with id ; Fri, 03 May 2019 08:37:19 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1556843841; bh=fqx7px8aicw59s5wsPfWml96z0lJHa6tUbYs8uCbaaw=; h=From:To:Subject:Date:Message-Id; b=nwvxZV1sTGrrCUe0ikJ8Y9GfKTjFJhGZmzYLvTkNCgWihCid+LPT5kaDvtXR+FntW 4XAOM9n9g1i/dXI7aXgchzUJswvPzobmqh1jcKMJDiPGP/J4+bYLlB2vohnI8SAUYJ z+OIS6s8ZziOTBDHIWaF2A6N5KJ8KAwH7xyIdLK4= X-QQ-mid: esmtp2t1556843840tnjge6umc X-QQ-SSF: B100000000000030F7F00F00000000O X-QQ-FEAT: 0wsbT93u7eCMTn3b6RLI6G4Cws3/XlKIMI7VNta4wKG3NDZzzT0jiRgIu8x/k DAKSH8/mNV3lZptaGiI0/ua44BHTN+L5tjBKFJyjyqhw+BtHEmAHDDd7LldWSZyhCzBVc9H esAX0AnV/gKL/yfm+dXVGGJ2MgSLX1UnsjFNt/SkqOc/NEh9XQ4epcanuQf/GjQTFjdnjl0 Ey4akzTs7WHqpepl9rJc483oKw5I/xE8vFFSukbP2BsUCbMWzF/Wbe11UhMokfS2RBdODxH IwFbfAtsaKyD+9zFJyvRLRpvGTXYJI+ZYkDx0gNzbTj7Qs X-QQ-GoodBg: 0 From: Cao Jiaxi To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 08:37:19 +0800 Message-Id: <20190503003719.10233-1-driver1998@foxmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190503002206.9751-1-driver1998@foxmail.com> References: <20190503002206.9751-1-driver1998@foxmail.com> X-QQ-SENDSIZE: 520 Feedback-ID: esmtp:foxmail.com:bgforeign:bgforeign4 X-QQ-Bgrelay: 1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 184.105.206.84 Subject: [Qemu-devel] [PATCH v3 4/4] osdep: Fix mingw compilation regarding stdio formats X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cao Jiaxi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" I encountered the following compilation error on mingw: /mnt/d/qemu/include/qemu/osdep.h:97:9: error: '__USE_MINGW_ANSI_STDIO' macr= o redefined [-Werror,-Wmacro-redefined] #define __USE_MINGW_ANSI_STDIO 1 ^ /mnt/d/llvm-mingw/aarch64-w64-mingw32/include/_mingw.h:433:9: note: previou= s definition is here #define __USE_MINGW_ANSI_STDIO 0 /* was not defined so it should be 0= */ It turns out that __USE_MINGW_ANSI_STDIO must be set before any system headers are included, not just before stdio.h. Signed-off-by: Cao Jiaxi Reviewed-by: Stefan Weil Reviewed-by: Thomas Huth --- include/qemu/osdep.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 303d315c5d..af2b91f0b8 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -85,17 +85,17 @@ extern int daemon(int, int); #endif #endif =20 +/* enable C99/POSIX format strings (needs mingw32-runtime 3.15 or later) */ +#ifdef __MINGW32__ +#define __USE_MINGW_ANSI_STDIO 1 +#endif + #include #include #include #include #include #include - -/* enable C99/POSIX format strings (needs mingw32-runtime 3.15 or later) */ -#ifdef __MINGW32__ -#define __USE_MINGW_ANSI_STDIO 1 -#endif #include =20 #include --=20 2.17.1