From nobody Wed May 15 22:57:48 2024 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=foxmail.com ARC-Seal: i=1; a=rsa-sha256; t=1556843911; cv=none; d=zoho.com; s=zohoarc; b=TKZk/YBcpoLo0LkAG587+NDluX/y3gwEgdeJB/yXPFBm2Akxi3SLTrBqRCH2iqW84dRRE8kPTbwZNgPkCPQd9xarpDNezTOjsQt/v8OqPuIn0qCbsX6lgQkxlmL4Jwy2h6BpEUwH4/Hi0ThPR5Al7flb70bBdMTQHGLwYooZyWY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556843911; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=qZ9rLgsGWHtP85ggUAkc/jYOZeYPylxBMw1r5H65aLQ=; b=B0TmTvXaNpKeEqYlAJ6KRE/6ktWbOZCrkBeKW9Z9RVWy8W7uMf2VHFDdPNWhk6AXmlBXymBnAGKe5f9ystYMdIyg/ZQAzmkpVoZhf+JECpGLZ2LbelNJg+qdMoAoT4BpW8nhq076O01CPrTi8ATa76WLCy3XLwyb4EJ1QewtWXQ= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556843911190853.9960467211395; Thu, 2 May 2019 17:38:31 -0700 (PDT) Received: from localhost ([127.0.0.1]:60381 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMMDP-0000Fz-M5 for importer@patchew.org; Thu, 02 May 2019 20:38:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMMC4-000873-HZ for qemu-devel@nongnu.org; Thu, 02 May 2019 20:36:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMMC3-0002Wv-6R for qemu-devel@nongnu.org; Thu, 02 May 2019 20:36:52 -0400 Received: from smtpbgeu2.qq.com ([18.194.254.142]:60675) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMMC2-0002Q3-U6 for qemu-devel@nongnu.org; Thu, 02 May 2019 20:36:51 -0400 Received: from localhost (unknown [183.63.119.3]) by esmtp4.qq.com (ESMTP) with id ; Fri, 03 May 2019 08:36:26 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1556843787; bh=qZ9rLgsGWHtP85ggUAkc/jYOZeYPylxBMw1r5H65aLQ=; h=From:To:Subject:Date:Message-Id; b=mLT5neEgxNXy5bL7+owHX7eQph2kcesPg67FvbOwAi5QlbH3ONuDaPY/b0zSV06xz jKeG/gKtqc5T3iPXl1IHklrnXIzW4QGJuw//zd+HRGZcGbz4rud2dSSgA8PzfqrRBp 70PHmICnnQ/soaUax5bISPGfWLZszDz1pUyoFpeI= X-QQ-mid: esmtp6t1556843786tlr38r47j X-QQ-SSF: B100000000000030F7F00F00000000O X-QQ-FEAT: LukZvA942xAbObHUXEBsi4QgLypUm5Ew7V52rRmRu8wQXwgMNPpXXhaEvmZQ6 6mQfK5XXkz3T4M0Dtnm3f0yM+6zdIMBEd6oxUFpYyJN4DeW85dY3jBY891/g110/8cNHCsa NOUY2lS1i4eF7mfBYRJeJBAuEXVbGC3RNWv5O+iD1/bm8/Z19/zVxhpwzBmwNCQXAA+DaRn QYthcCFNj2/IRZyrWjGgreepDamGuEa3/SJ9Rr0gUT7Zi9hAbbMwzBXSlQhXny9rC7kv/VG hbJN+CTgdyS7REz9CQFcenOj5jraeFBRUNtCGWXk41PlZ1 X-QQ-GoodBg: 0 From: Cao Jiaxi To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 08:36:18 +0800 Message-Id: <20190503003618.10089-1-driver1998@foxmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190503002206.9751-1-driver1998@foxmail.com> References: <20190503002206.9751-1-driver1998@foxmail.com> X-QQ-SENDSIZE: 520 Feedback-ID: esmtp:foxmail.com:bgforeign:bgforeign2 X-QQ-Bgrelay: 1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 18.194.254.142 Subject: [Qemu-devel] [PATCH v3 1/4] QEMU_PACKED: Remove gcc_struct attribute in Windows non x86 targets X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cao Jiaxi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" gcc_struct is for x86 only, and it generates an warning on ARM64 Clang/MinG= W targets. Signed-off-by: Cao Jiaxi Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Suggested-by: Eric Blake Tested-by: Philippe Mathieu-Daud=C3=A9 --- contrib/libvhost-user/libvhost-user.h | 2 +- include/qemu/compiler.h | 2 +- scripts/cocci-macro-file.h | 7 ++++++- slirp/src/util.h | 2 +- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/contrib/libvhost-user/libvhost-user.h b/contrib/libvhost-user/= libvhost-user.h index 414ceb0a2f..78b33306e8 100644 --- a/contrib/libvhost-user/libvhost-user.h +++ b/contrib/libvhost-user/libvhost-user.h @@ -148,7 +148,7 @@ typedef struct VhostUserInflight { uint16_t queue_size; } VhostUserInflight; =20 -#if defined(_WIN32) +#if defined(_WIN32) && (defined(__x86_64__) || defined(__i386__)) # define VU_PACKED __attribute__((gcc_struct, packed)) #else # define VU_PACKED __attribute__((packed)) diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index 296b2fd572..09fc44cca4 100644 --- a/include/qemu/compiler.h +++ b/include/qemu/compiler.h @@ -28,7 +28,7 @@ =20 #define QEMU_SENTINEL __attribute__((sentinel)) =20 -#if defined(_WIN32) +#if defined(_WIN32) && (defined(__x86_64__) || defined(__i386__)) # define QEMU_PACKED __attribute__((gcc_struct, packed)) #else # define QEMU_PACKED __attribute__((packed)) diff --git a/scripts/cocci-macro-file.h b/scripts/cocci-macro-file.h index e485cdccae..c6bbc05ba3 100644 --- a/scripts/cocci-macro-file.h +++ b/scripts/cocci-macro-file.h @@ -23,7 +23,12 @@ #define QEMU_NORETURN __attribute__ ((__noreturn__)) #define QEMU_WARN_UNUSED_RESULT __attribute__((warn_unused_result)) #define QEMU_SENTINEL __attribute__((sentinel)) -#define QEMU_PACKED __attribute__((gcc_struct, packed)) + +#if defined(_WIN32) && (defined(__x86_64__) || defined(__i386__)) +# define QEMU_PACKED __attribute__((gcc_struct, packed)) +#else +# define QEMU_PACKED __attribute__((packed)) +#endif =20 #define cat(x,y) x ## y #define cat2(x,y) cat(x,y) diff --git a/slirp/src/util.h b/slirp/src/util.h index 01f1e0e068..278828fe3f 100644 --- a/slirp/src/util.h +++ b/slirp/src/util.h @@ -43,7 +43,7 @@ #include #endif =20 -#if defined(_WIN32) +#if defined(_WIN32) && (defined(__x86_64__) || defined(__i386__)) # define SLIRP_PACKED __attribute__((gcc_struct, packed)) #else # define SLIRP_PACKED __attribute__((packed)) --=20 2.17.1 From nobody Wed May 15 22:57:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=foxmail.com ARC-Seal: i=1; a=rsa-sha256; t=1556843919; cv=none; d=zoho.com; s=zohoarc; b=cneDl96s3AkG/AKOTmV7A1cHOxgjWThBmG1uOB8Cm8PwGoR6m64bEq1+0s0oSXtPGiO9mnkOQkJ2pmFNSGQa6DQKFpttxLw/8t36OFaxCJr85S36cqnCOvLKBGhuwPtkEE6nOv6Dwv2fG6AXB1+EMZoi+Pxg8hSMxrB0j0A0H50= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556843919; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=rNrdiz1Sy8K1ZYQLRYYtYLz7q52e7xr8Xcc2h9May4E=; b=JQ4eZ9qYal5eEWB2Rep/SDmGjGBQDh2y4NA93omiiC685zUB8YBQHgKqQ1hSYAm1t8qScdT2KYB/kHRGfgDAvGxU42gmdcV8mWa1Bwg7a1c4ulScsrGF23Hmt7s4bX32gZuImPFK3TlBTuPlStVCC3Zh+YQOJeDl8EhjNZj8SlE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556843919960118.5677959293123; Thu, 2 May 2019 17:38:39 -0700 (PDT) Received: from localhost ([127.0.0.1]:60383 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMMDh-0000Ub-R1 for importer@patchew.org; Thu, 02 May 2019 20:38:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMMCC-0008As-Ng for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMMCB-0002n2-RH for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:00 -0400 Received: from smtpbgbr2.qq.com ([54.207.22.56]:45504) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMMCB-0002kg-Fr for qemu-devel@nongnu.org; Thu, 02 May 2019 20:36:59 -0400 Received: from localhost (unknown [183.63.119.3]) by esmtp4.qq.com (ESMTP) with id ; Fri, 03 May 2019 08:36:51 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1556843812; bh=rNrdiz1Sy8K1ZYQLRYYtYLz7q52e7xr8Xcc2h9May4E=; h=From:To:Subject:Date:Message-Id; b=uc6WKjHVErtv3Kv/AHtFrPjckiXKICvhhTGlsjzE8t0fKJ6o3CLdKoCDxVnRx7cm6 hQ5kqm8fMTErFY3qM7gWgdRHtyBYtWdspCHaQsoTGah+iciwDgM2LoEaginlDIvTiT fL0uOyOA25Mh9N0umXisIuNkXMO34aPUrOo61lXI= X-QQ-mid: esmtp4t1556843811tezymyy2b X-QQ-SSF: B100000000000030F7F00F00000000O X-QQ-FEAT: 5GknEzJPEhvCyQ1/jMaBdgfgTWksQ/7cZqDu1hIg+4LFrE5hIXVo3ecfkFFZ1 QbOu7+dDmGzfqSH3cUuEFkS4frOOFshPSY6ZZ+rk985bOa/Mn/+Ocr8S6hlvarkz2tfTnlU mT2/atjidIX1JoijMo4LONa/SippJKnvat+DOYdpVJh0Q3CjOTq4WsnNtIx4LXz4fK2DW6j OmVbIXt8p2bCK3yKjSHWf5XSXTXXMcCY324sue3cehA2islYcPJPezuvg9XN+fyogZpupn9 HPsfWQINVRPXYefBNYkIevxtNawQXarKZBfaerFjn2RN5Y X-QQ-GoodBg: 0 From: Cao Jiaxi To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 08:36:50 +0800 Message-Id: <20190503003650.10137-1-driver1998@foxmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190503002206.9751-1-driver1998@foxmail.com> References: <20190503002206.9751-1-driver1998@foxmail.com> X-QQ-SENDSIZE: 520 Feedback-ID: esmtp:foxmail.com:bgforeign:bgforeign2 X-QQ-Bgrelay: 1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 54.207.22.56 Subject: [Qemu-devel] [PATCH v3 2/4] qga: Fix mingw compilation warnings on enum conversion X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cao Jiaxi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The win2qemu[] is supposed to be the conversion table to convert between STORAGE_BUS_TYPE in Windows SDK and GuestDiskBusType in qga. But it was incorrectly written that it forces to set a GuestDiskBusType value to STORAGE_BUS_TYPE, which generates an enum conversion warning in cl= ang. Signed-off-by: Cao Jiaxi Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Suggested-by: Eric Blake Tested-by: Philippe Mathieu-Daud=C3=A9 --- qga/commands-win32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index d40d61f605..6b67f16faf 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -457,7 +457,7 @@ void qmp_guest_file_flush(int64_t handle, Error **errp) =20 #ifdef CONFIG_QGA_NTDDSCSI =20 -static STORAGE_BUS_TYPE win2qemu[] =3D { +static GuestDiskBusType win2qemu[] =3D { [BusTypeUnknown] =3D GUEST_DISK_BUS_TYPE_UNKNOWN, [BusTypeScsi] =3D GUEST_DISK_BUS_TYPE_SCSI, [BusTypeAtapi] =3D GUEST_DISK_BUS_TYPE_IDE, --=20 2.17.1 From nobody Wed May 15 22:57:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=foxmail.com ARC-Seal: i=1; a=rsa-sha256; t=1556844024; cv=none; d=zoho.com; s=zohoarc; b=Ws67WzXqDw4PRaPueJcrU17wl1LNcPadIap3jXSTWx4rwYnIjr/ZPxcwNOhSRSfp+Z17qEfy5fEilq3fJrpFCe6UfBoEQkdwYCruQSXVWrynGtwyvZmm9gQrKLp9vAmOQprmtGwbXEFVkjfR6jS0nF2dwTelNplW3L9PPZ5luWA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556844024; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=5pl5oYHhrQHhrz2dqdwsgLGsyUpjkYXkRCk4kQ9nGqk=; b=lJg9s6H3bOAT8ODxAyeZG8cSNIIdbpKAE9Qybfz+61o4iTarcflS7AmV6GqcfwXX1u8By/neo8Ll0sj87TgwJl3HY89a2OozeYOcmSlTIz7OQ1lgjS6N1LVOsxidpbMWsgDSxDW6wKxvqkCJnnwW5lUG5xOdbxYq7DdKR8OzmNE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556844024349864.1736765186334; Thu, 2 May 2019 17:40:24 -0700 (PDT) Received: from localhost ([127.0.0.1]:60397 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMMFP-0001tw-BS for importer@patchew.org; Thu, 02 May 2019 20:40:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMMCS-0008Hw-3s for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMMCR-0002uP-9m for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:16 -0400 Received: from smtpbg299.qq.com ([184.105.67.99]:55364) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMMCR-0002tZ-2Q for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:15 -0400 Received: from localhost (unknown [183.63.119.3]) by esmtp4.qq.com (ESMTP) with id ; Fri, 03 May 2019 08:37:07 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1556843831; bh=5pl5oYHhrQHhrz2dqdwsgLGsyUpjkYXkRCk4kQ9nGqk=; h=From:To:Subject:Date:Message-Id; b=TsCpfXPVsmmxgPoxoQ0MbJEsPG7RM8yy91/ZceoU5bc5fnnYoUOd9zDCLPbrbylgR QGvYXPI2a1fDV8ETMvwxoUBF88GfQhGUCnDqNWEo+5MOgMoUfFAudD0rIXuqi2zMVS HkIyp/dd+KmRXD1r+8MrgkJ/8f6gS4o3wkKl2iBY= X-QQ-mid: esmtp4t1556843828t1vs5fkh7 X-QQ-SSF: B100000000000030F7F00F00000000O X-QQ-FEAT: kCBpokdLy2DzowniVSWhOW+BVcq4spYJpNB4uD4gkKS3oBA1bE0d4g6tAs1I/ +NslEM/oP8qlQ0ysz84gfyDhxCSINkHWPxRqDXwgutRGBUU9uqWLKgh+je4k9hOOu/nebqj zWgL7Qi5PsQM8xtEIuWqhKfR00TFNp2DdM6T4/XGwp+12GPkuBebrpJYPjuUtkycHSzwebk 13VM2TmJmjRqJqG2exXH6Jzz8O6ZqfxmRgW+qArE8bQFmrZ6Auf/dzcTOmODWRdQqbrDMRm 1fhwVLOCwtr20jOStGH/P1fDomEbQHwiPmaw== X-QQ-GoodBg: 0 From: Cao Jiaxi To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 08:37:07 +0800 Message-Id: <20190503003707.10185-1-driver1998@foxmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190503002206.9751-1-driver1998@foxmail.com> References: <20190503002206.9751-1-driver1998@foxmail.com> X-QQ-SENDSIZE: 520 X-QQ-FName: 722D390903854009AD3FEF5654262B8C X-QQ-LocalIP: 10.208.130.95 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 184.105.67.99 Subject: [Qemu-devel] [PATCH v3 3/4] util/cacheinfo: Use uint64_t on LLP64 model to satisfy Windows ARM64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cao Jiaxi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Windows ARM64 uses LLP64 model, which breaks current assumptions. Signed-off-by: Cao Jiaxi Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Suggested-by: Eric Blake Tested-by: Philippe Mathieu-Daud=C3=A9 --- util/cacheinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/cacheinfo.c b/util/cacheinfo.c index 3cd080b83d..eebe1ce9c5 100644 --- a/util/cacheinfo.c +++ b/util/cacheinfo.c @@ -107,7 +107,7 @@ static void sys_cache_info(int *isize, int *dsize) static void arch_cache_info(int *isize, int *dsize) { if (*isize =3D=3D 0 || *dsize =3D=3D 0) { - unsigned long ctr; + uint64_t ctr; =20 /* The real cache geometry is in CCSIDR_EL1/CLIDR_EL1/CSSELR_EL1, but (at least under Linux) these are marked protected by the --=20 2.17.1 From nobody Wed May 15 22:57:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=foxmail.com ARC-Seal: i=1; a=rsa-sha256; t=1556843948; cv=none; d=zoho.com; s=zohoarc; b=R81S8Yq8X37EDJRZp3QTeDBHfAUaYB8eDF2Q97Skk7lFFzn9+sA6rtRJaWQhwif8/txgHgYmbyxdkSkE/6nETfEEL6WNuS5XsWSo+IJpVWrpn6GjcxwGOBaY3AU3DL1lcf17NuXqubvB2mC/njd15sbvtsL2aqCzaYq07wSc7g4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556843948; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=fqx7px8aicw59s5wsPfWml96z0lJHa6tUbYs8uCbaaw=; b=GUlAaMllCOt1LKDhjwhokPVWrGprxTg6Zr7aUI2qiawBlfOlHIz7BKyyp/7+o/f9gp3rF713xzbWCISAMlFJ29zx6jlTmV+YtGa+bwokavR7kJmj1T11GmboKwgXqVyHhWQd5u+7VSOAqln3WymmtoQ1AIb9O7EVox1jvTk4J3M= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556843948064687.9112205603857; Thu, 2 May 2019 17:39:08 -0700 (PDT) Received: from localhost ([127.0.0.1]:60385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMMEF-0000wd-2W for importer@patchew.org; Thu, 02 May 2019 20:39:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMMCd-0008SZ-T4 for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMMCc-00030R-Vr for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:27 -0400 Received: from smtpproxy19.qq.com ([184.105.206.84]:50156) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMMCc-0002zn-Ol for qemu-devel@nongnu.org; Thu, 02 May 2019 20:37:26 -0400 Received: from localhost (unknown [183.63.119.3]) by esmtp4.qq.com (ESMTP) with id ; Fri, 03 May 2019 08:37:19 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1556843841; bh=fqx7px8aicw59s5wsPfWml96z0lJHa6tUbYs8uCbaaw=; h=From:To:Subject:Date:Message-Id; b=nwvxZV1sTGrrCUe0ikJ8Y9GfKTjFJhGZmzYLvTkNCgWihCid+LPT5kaDvtXR+FntW 4XAOM9n9g1i/dXI7aXgchzUJswvPzobmqh1jcKMJDiPGP/J4+bYLlB2vohnI8SAUYJ z+OIS6s8ZziOTBDHIWaF2A6N5KJ8KAwH7xyIdLK4= X-QQ-mid: esmtp2t1556843840tnjge6umc X-QQ-SSF: B100000000000030F7F00F00000000O X-QQ-FEAT: 0wsbT93u7eCMTn3b6RLI6G4Cws3/XlKIMI7VNta4wKG3NDZzzT0jiRgIu8x/k DAKSH8/mNV3lZptaGiI0/ua44BHTN+L5tjBKFJyjyqhw+BtHEmAHDDd7LldWSZyhCzBVc9H esAX0AnV/gKL/yfm+dXVGGJ2MgSLX1UnsjFNt/SkqOc/NEh9XQ4epcanuQf/GjQTFjdnjl0 Ey4akzTs7WHqpepl9rJc483oKw5I/xE8vFFSukbP2BsUCbMWzF/Wbe11UhMokfS2RBdODxH IwFbfAtsaKyD+9zFJyvRLRpvGTXYJI+ZYkDx0gNzbTj7Qs X-QQ-GoodBg: 0 From: Cao Jiaxi To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 08:37:19 +0800 Message-Id: <20190503003719.10233-1-driver1998@foxmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190503002206.9751-1-driver1998@foxmail.com> References: <20190503002206.9751-1-driver1998@foxmail.com> X-QQ-SENDSIZE: 520 Feedback-ID: esmtp:foxmail.com:bgforeign:bgforeign4 X-QQ-Bgrelay: 1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 184.105.206.84 Subject: [Qemu-devel] [PATCH v3 4/4] osdep: Fix mingw compilation regarding stdio formats X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cao Jiaxi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" I encountered the following compilation error on mingw: /mnt/d/qemu/include/qemu/osdep.h:97:9: error: '__USE_MINGW_ANSI_STDIO' macr= o redefined [-Werror,-Wmacro-redefined] #define __USE_MINGW_ANSI_STDIO 1 ^ /mnt/d/llvm-mingw/aarch64-w64-mingw32/include/_mingw.h:433:9: note: previou= s definition is here #define __USE_MINGW_ANSI_STDIO 0 /* was not defined so it should be 0= */ It turns out that __USE_MINGW_ANSI_STDIO must be set before any system headers are included, not just before stdio.h. Signed-off-by: Cao Jiaxi Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Stefan Weil Reviewed-by: Thomas Huth Suggested-by: Eric Blake Tested-by: Philippe Mathieu-Daud=C3=A9 --- include/qemu/osdep.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 303d315c5d..af2b91f0b8 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -85,17 +85,17 @@ extern int daemon(int, int); #endif #endif =20 +/* enable C99/POSIX format strings (needs mingw32-runtime 3.15 or later) */ +#ifdef __MINGW32__ +#define __USE_MINGW_ANSI_STDIO 1 +#endif + #include #include #include #include #include #include - -/* enable C99/POSIX format strings (needs mingw32-runtime 3.15 or later) */ -#ifdef __MINGW32__ -#define __USE_MINGW_ANSI_STDIO 1 -#endif #include =20 #include --=20 2.17.1