From nobody Mon Feb 9 09:16:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1556783746; cv=none; d=zoho.com; s=zohoarc; b=exapwFXXY+yfsu80cjXeArNFPU17GuHAs4tXqofWt9vnlnCJ+z23yZlpt2n246P3L7tga5T2PRCK6sZKJMggVfbk+NPLfn9MhBInsC8ORB4S9Q688QEQhN8qM06UIWoZrZfxOncPgEWEH/yOLYKO7mW8j8UYuCutDA16E7gxcC4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556783746; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=V5o5m8O5n769YkTgmSgA69ECVqSjdswFCVUb/2HOfe0=; b=JDW1KLKPr1DOrF0aJGcwE3uRxsp1bE8OyOy1jYLpVjLUHNIJuDIvy0W2ibULX9Y0ZyMi2lToKyzCREOxXVAl/Ce4C0FCizZLpDgk9c37Z7KdMNPGxBeRknHTaALW+69Wp8ajDHEAQMUgnsnIAdX1xTMsURDkGsnvHlDPdlvF7EM= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556783746159516.7676259395851; Thu, 2 May 2019 00:55:46 -0700 (PDT) Received: from localhost ([127.0.0.1]:46916 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hM6ZD-0002cJ-5K for importer@patchew.org; Thu, 02 May 2019 03:55:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hM6GS-0002FA-A8 for qemu-devel@nongnu.org; Thu, 02 May 2019 03:36:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hM6GO-00016W-UT for qemu-devel@nongnu.org; Thu, 02 May 2019 03:36:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60544) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hM6GN-0000mF-64 for qemu-devel@nongnu.org; Thu, 02 May 2019 03:36:15 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1F0812D800; Thu, 2 May 2019 07:35:52 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-45.ams2.redhat.com [10.36.116.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id B01221001DEF; Thu, 2 May 2019 07:35:44 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 91AEE17535; Thu, 2 May 2019 09:35:43 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Thu, 2 May 2019 09:35:39 +0200 Message-Id: <20190502073543.4391-4-kraxel@redhat.com> In-Reply-To: <20190502073543.4391-1-kraxel@redhat.com> References: <20190502073543.4391-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 02 May 2019 07:35:52 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 3/7] usb-mtp: change default to success for usb_mtp_update_object X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bandan Das , Gerd Hoffmann , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Bandan Das Commit c5ead51f90cf (usb-mtp: return incomplete transfer on a lstat failure) checks if lstat succeeded when updating attributes of a file. However, it also changed behavior to return an error by default. This is incorrect because for smaller file sizes, Qemu will attempt to write the file in one go and there won't be an object for it. Fixes: c5ead51f90cf Signed-off-by: Bandan Das Message-id: jpgwojv9pwv.fsf@linux.bootlegged.copy Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 963449ec7de8..d90b336d53f4 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1587,7 +1587,7 @@ done: =20 static int usb_mtp_update_object(MTPObject *parent, char *name) { - int ret =3D -1; + int ret =3D 0; =20 MTPObject *o =3D usb_mtp_object_lookup_name(parent, name, strlen(name)); --=20 2.18.1