From nobody Mon Feb 9 14:03:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1556783637; cv=none; d=zoho.com; s=zohoarc; b=XyAnU0uFGlA9yHdtsH8pqcYbJnM5mrsJj3l64vA9EFFqrNdLEGpyEHD32lKd+e9SyOUnf6+iP2AGIuGtC5mpY2qJjhvuQkKGlp+2PHziSwhTusluP+GXGju7HK0UGq+TPcmwlFr77BBB/A+zQ7tCQd6d8LVf1rdjkMyL1ZQrSoY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556783637; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=1mmsY6AvBgNPfREd35t94zsPLPYDZzlNj60UyghtFVQ=; b=ZaiqKBtYIh6FsqkABRfLME1snbb+J568dlzkhv19+GYs3VN/MB2nSHYYh6QFFixJ8QiK4LJ3G2dIP0vy7uR0LqQwU1FRH0bYEGGhMz/sO6lbU8hI8iMCrR0dniag42vj9L4ryWo7KfssF0osPaHDTE+ahBNsmfumVSipuahjTtY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556783637486204.82885861632076; Thu, 2 May 2019 00:53:57 -0700 (PDT) Received: from localhost ([127.0.0.1]:46870 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hM6XP-00017n-Ed for importer@patchew.org; Thu, 02 May 2019 03:53:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hM6GE-00020g-2f for qemu-devel@nongnu.org; Thu, 02 May 2019 03:36:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hM6G8-0000uF-42 for qemu-devel@nongnu.org; Thu, 02 May 2019 03:36:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53612) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hM6Fz-0000hY-5a for qemu-devel@nongnu.org; Thu, 02 May 2019 03:35:53 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 38C33C057F2C; Thu, 2 May 2019 07:35:47 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-45.ams2.redhat.com [10.36.116.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id AFF5F18224; Thu, 2 May 2019 07:35:44 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 7F1021751C; Thu, 2 May 2019 09:35:43 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Thu, 2 May 2019 09:35:37 +0200 Message-Id: <20190502073543.4391-2-kraxel@redhat.com> In-Reply-To: <20190502073543.4391-1-kraxel@redhat.com> References: <20190502073543.4391-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 02 May 2019 07:35:47 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 1/7] usb-mtp: fix string length for filename when writing metadata X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Daniel P. Berrang=C3=A9 The ObjectInfo 'length' field provides the length of the wide character string filename. This is then converted to a multi-byte character string. This may have a different byte count to the wide character string. We should use the C string length of the multi-byte string instead. Signed-off-by: Daniel P. Berrang=C3=A9 Message-id: 20190415154503.6758-2-berrange@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 99548b012d1f..6b7d1296e430 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1721,7 +1721,7 @@ static void usb_mtp_write_metadata(MTPState *s, uint6= 4_t dlen) return; } =20 - o =3D usb_mtp_object_lookup_name(p, filename, dataset->length); + o =3D usb_mtp_object_lookup_name(p, filename, -1); if (o !=3D NULL) { next_handle =3D o->handle; } --=20 2.18.1