From nobody Sat Sep 28 22:10:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1556782578; cv=none; d=zoho.com; s=zohoarc; b=M0kwvO3w1+NIEVV0htt+LLZwFcG5U0BTUMYGFFcieQDlrxxTq8lI5bU0k9Jyl2RqHtSyrKPNVOaPwgaXFB2O5LN7MBxVxfS6VD/DY2TRBQDE8gvUnX+5I2o6CJ3xNTehTK9HLlf5eJdJss5L6bXdSHTT8sTo0nbnVRobLNydiys= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556782578; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=ezPihTnFxff66taoqz5itPBhvGaSIP4LZ9QfcTyLtvg=; b=lsfwhNmRfK74Z8W6+ViHZOzqxmpKosjodh1tgOBBxoC6vKuaSJlEly5xzcjDQK7AAguJi6MR287Mug4Xk0c0r9kVwYm9x+MKdFMlkudVDLrFNd0h9K0GlaQrEtSPwUggXQgOXajdgSAUOmdtZFFgW3q7s/cRC1PJSQ4V0jkT568= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556782578590451.7190141175304; Thu, 2 May 2019 00:36:18 -0700 (PDT) Received: from localhost ([127.0.0.1]:46604 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hM6GG-0001Ze-AQ for importer@patchew.org; Thu, 02 May 2019 03:36:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hM69i-0004an-Av for qemu-devel@nongnu.org; Thu, 02 May 2019 03:29:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hM69Z-0002Z6-62 for qemu-devel@nongnu.org; Thu, 02 May 2019 03:29:19 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:54407) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hM69X-0000jx-D6 for qemu-devel@nongnu.org; Thu, 02 May 2019 03:29:12 -0400 Received: by mail-wm1-x341.google.com with SMTP id b10so1276248wmj.4 for ; Thu, 02 May 2019 00:27:34 -0700 (PDT) Received: from localhost.localdomain ([176.230.64.186]) by smtp.gmail.com with ESMTPSA id z5sm8769289wre.70.2019.05.02.00.27.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 May 2019 00:27:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ezPihTnFxff66taoqz5itPBhvGaSIP4LZ9QfcTyLtvg=; b=i5RvU9tbgk1ad967z9+q7Ij40js3XRgLQW+Tgd18FnpFpEDAJpqo23qz0gS8Dhog0A 5RccKZ5ajlJstJ6aOH3Cyy0UatIFZm8ZWN0E4A4CzwfrRb+G6sm5cKrhGLR4d9aGzqjp 6Z7SnOtX9KeZ3HNSsdBRJDr+R2ex6+K3jc2R5p/HRh8Ro5vuOpzr4mAT6jRaYoqoEK+X Dmy66I0Wpo7wJw1hP3Rd8c/FTbwjExqyd71OwD/Tb1K0lalOlJr3RC2JeaYm6REV8NYt +f+OFBxy7dTtmHgV4cikTLS8s6xwb0gifyZzKef/Qqrr85tyqn7Qyrc7lD7qkO+ALLiw qxpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ezPihTnFxff66taoqz5itPBhvGaSIP4LZ9QfcTyLtvg=; b=h21UC04U0uyTQo8vqL/W3CSDn+nrWRrnGtYU/e0UWuTMhZdgRlp18Nnh+NNXnDF7fp iaQztzzWjOLWSXyOv6i2S3miir5kg8P4m3qTpg5wHD0kP+qQaTLdB+wK4vylEvj/qxXQ BHs9u4GDOYWC/gGwB+SjgcIdKKrjS8jPeq4Fmu1/qkJMEh2bfFdjaGvt3GzhIE8JkgK/ QlmrBF7fJG3bQfPrZWXzUYzS6jwv9u/aPmggsblqRBmzD0+IUagWkm4Xu/WeyUflqc2T JcXfC/oBvcT+1oJpQAZtqTliZRfwOpTyKOK6BabizblNE2ryayPZUHoh5sVg0HZeLsU4 45Kw== X-Gm-Message-State: APjAAAVONEqVrqtCff/FsULE5AAoCWGqLReHJ1Rat8x23hb9/p1jw9S+ 2a8sZ0FBYK2vgmJRjYHBXXlVM3H0 X-Google-Smtp-Source: APXvYqxgNu0Payw2IlQOkySP0YPSh4gItlN1MIi8W8P+uIJ3WwJxabmCJ62fZ6temkrx0N/mRPhchg== X-Received: by 2002:a1c:1a90:: with SMTP id a138mr1173501wma.81.1556782053057; Thu, 02 May 2019 00:27:33 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Thu, 2 May 2019 10:26:37 +0300 Message-Id: <20190502072641.4667-24-arilou@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190502072641.4667-1-arilou@gmail.com> References: <20190502072641.4667-1-arilou@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PATCH v8 23/27] gdbstub: Implement qemu physical memory mode X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: liran.alon@oracle.com, alex.bennee@linaro.org, Jon Doron Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Add a new query/set which changes the memory GDB sees to physical memory only. gdb> maint packet qqemu.PhyMemMode will reply the current phy_mem_mode state (1 for enabled, 0 for disabled) gdb> maint packet Qqemu.PhyMemMode:1 Will make GDB read/write only to physical memory, set to 0 to disable Signed-off-by: Jon Doron --- gdbstub.c | 58 ++++++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 55 insertions(+), 3 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 00c07d6ec0..6daf779af4 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -46,11 +46,23 @@ #define GDB_ATTACHED "1" #endif =20 +static int phy_memory_mode =3D 0; + static inline int target_memory_rw_debug(CPUState *cpu, target_ulong addr, uint8_t *buf, int len, bool is_wr= ite) { - CPUClass *cc =3D CPU_GET_CLASS(cpu); + CPUClass *cc; =20 + if (phy_memory_mode) { + if (is_write) { + cpu_physical_memory_write(addr, buf, len); + } else { + cpu_physical_memory_read(addr, buf, len); + } + return 0; + } + + cc =3D CPU_GET_CLASS(cpu); if (cc->memory_rw_debug) { return cc->memory_rw_debug(cpu, addr, buf, len, is_write); } @@ -2129,7 +2141,29 @@ static void handle_query_attached(GdbCmdContext *gdb= _ctx, void *user_ctx) =20 static void handle_query_qemu_supported(GdbCmdContext *gdb_ctx, void *user= _ctx) { - put_packet(gdb_ctx->s, "sstepbits;sstep"); + put_packet(gdb_ctx->s, "sstepbits;sstep;PhyMemMode"); +} + +static void handle_query_qemu_phy_mem_mode(GdbCmdContext *gdb_ctx, + void *user_ctx) +{ + snprintf(gdb_ctx->str_buf, sizeof(gdb_ctx->str_buf), "%d", phy_memory_= mode); + put_packet(gdb_ctx->s, gdb_ctx->str_buf); +} + +static void handle_set_qemu_phy_mem_mode(GdbCmdContext *gdb_ctx, void *use= r_ctx) +{ + if (!gdb_ctx->num_params) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + if (!gdb_ctx->params[0].val_ul) { + phy_memory_mode =3D 0; + } else { + phy_memory_mode =3D 1; + } + put_packet(gdb_ctx->s, "OK"); } =20 static GdbCmdParseEntry gdb_gen_query_set_common_table[] =3D { @@ -2212,6 +2246,20 @@ static GdbCmdParseEntry gdb_gen_query_table[] =3D { .handler =3D handle_query_qemu_supported, .cmd =3D "qemu.Supported", }, + { + .handler =3D handle_query_qemu_phy_mem_mode, + .cmd =3D "qemu.PhyMemMode", + }, +}; + +static GdbCmdParseEntry gdb_gen_set_table[] =3D { + /* Order is important if has same prefix */ + { + .handler =3D handle_set_qemu_phy_mem_mode, + .cmd =3D "qemu.PhyMemMode:", + .cmd_startswith =3D 1, + .schema =3D "l0" + }, }; =20 static void handle_gen_query(GdbCmdContext *gdb_ctx, void *user_ctx) @@ -2245,7 +2293,11 @@ static void handle_gen_set(GdbCmdContext *gdb_ctx, v= oid *user_ctx) return; } =20 - put_packet(gdb_ctx->s, ""); + if (process_string_cmd(gdb_ctx->s, NULL, gdb_ctx->params[0].data, + gdb_gen_set_table, + ARRAY_SIZE(gdb_gen_set_table))) { + put_packet(gdb_ctx->s, ""); + } } =20 static void handle_target_halt(GdbCmdContext *gdb_ctx, void *user_ctx) --=20 2.20.1