From nobody Mon Nov 10 11:22:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1556630516; cv=none; d=zoho.com; s=zohoarc; b=ky8Vj/9wOd22KrearHiUc/YKhzRBggNgjGPtlgldBIZiqc9fAjq9ZvaNcQlw+MMVRddQrCRoOYT8AJN/bTTUw48ogDzJIIVFi0I+IcRvvzZLlYUK0c60uGUJ84VaR6KZJujWZZW/kUuK3nBf5cK+/7iyfXpQY8yRZjLZFI8RVeE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556630516; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=H1YB7w5o/D/DXUwpu0w3cBAnaKMuGUL1XrwztrJhRCE=; b=dI51lq7EbiTLpxcLgCdmxw8/4vrcEgqtt0295a3Ta9prOih8A80iKr+mrOFXfiSIGFPAtSCNrsg1M18WpvgOJfW+Tw0blqYxKVR3jTAov8283nxlL+EU4dNuDBFnQT0vb1XylQ0TzGhDNsXdXhptaT8I3o/36s9BASeGU2Ctsus= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556630516250467.4975080808143; Tue, 30 Apr 2019 06:21:56 -0700 (PDT) Received: from localhost ([127.0.0.1]:47224 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLShl-0006JJ-6a for importer@patchew.org; Tue, 30 Apr 2019 09:21:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLSfw-0004z9-Pm for qemu-devel@nongnu.org; Tue, 30 Apr 2019 09:20:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLSfw-00054x-1M for qemu-devel@nongnu.org; Tue, 30 Apr 2019 09:20:00 -0400 Received: from inet-orm.provo.novell.com ([137.65.248.124]:49033 helo=mail.novell.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLSfv-00053e-OO for qemu-devel@nongnu.org; Tue, 30 Apr 2019 09:19:59 -0400 Received: from brogers1.provo.novell.com ([137.65.223.116]) by mail.novell.com with ESMTP (NOT encrypted); Tue, 30 Apr 2019 07:19:52 -0600 From: Bruce Rogers To: qemu-devel@nongnu.org Date: Tue, 30 Apr 2019 07:19:46 -0600 Message-Id: <20190430131946.26628-1-brogers@suse.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 137.65.248.124 Subject: [Qemu-devel] [PATCH v2] scsi-disk: handle invalid cdb length X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, pbonzini@redhat.com, Bruce Rogers Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" While investigating link-time-optimization, the compiler flagged this case of not handling the error return from scsi_cdb_length(). Handle this error case with a trace report. Signed-off-by: Bruce Rogers --- hw/scsi/scsi-disk.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index e7e865ab3b..8fbf7512e5 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -2520,6 +2520,10 @@ static void scsi_disk_new_request_dump(uint32_t lun,= uint32_t tag, uint8_t *buf) int len =3D scsi_cdb_length(buf); char *line_buffer, *p; =20 + if (len < 0) { + trace_scsi_disk_new_request(lun, tag, "bad cdb length"); + return; + } line_buffer =3D g_malloc(len * 5 + 1); =20 for (i =3D 0, p =3D line_buffer; i < len; i++) { --=20 2.21.0