From nobody Tue Feb 10 02:01:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1556450358; cv=none; d=zoho.com; s=zohoarc; b=hdzwn6VeA1V1Z5vYP/LC0Zi/erPXWC/uf0IaaySYkZbM33AF8F+aY9C9xVgosX3IUJAU3QGVQPidTwChxYZNp+pPaUkrNMNY4SJRzu2uclr0aga+LxPjDHeD8eUenkcQD1w/uRy06lIvOtgPWMbeinSySnPO9uOb+E4zgVjFBbI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556450358; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=AMRBSKPedQ/vao53wTQts4yAXAMhd5iduqdqKtH2vi0=; b=F6tbCiKdXYGLsJFmo1Y3NmLMwu2HwSp7qr/EhE40XDlaEQxv8Buj4HovlnShoLs3MzuIM98rTRPdM5WSUixrCJJDqIXkh4Mm1q0nEFcAv7np28jnNvN4ntBe7iMY0uuHjmtJRtyU5biWzsnYk4Wwo0IRkGsNT0mMBaoFXZfjp+U= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556450358398904.6834422399282; Sun, 28 Apr 2019 04:19:18 -0700 (PDT) Received: from localhost ([127.0.0.1]:42788 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKhps-0003dK-0P for importer@patchew.org; Sun, 28 Apr 2019 07:19:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKhp0-0003AA-Ok for qemu-devel@nongnu.org; Sun, 28 Apr 2019 07:18:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKhc1-00021B-CY for qemu-devel@nongnu.org; Sun, 28 Apr 2019 07:04:50 -0400 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:33662) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hKhc0-0001yN-Ra for qemu-devel@nongnu.org; Sun, 28 Apr 2019 07:04:49 -0400 Received: by mail-pl1-x644.google.com with SMTP id y3so2873739plp.0 for ; Sun, 28 Apr 2019 04:04:47 -0700 (PDT) Received: from MBP.local.hk ([202.189.108.96]) by smtp.gmail.com with ESMTPSA id s198sm18386461pfs.34.2019.04.28.04.04.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 28 Apr 2019 04:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connect-hku-hk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=AMRBSKPedQ/vao53wTQts4yAXAMhd5iduqdqKtH2vi0=; b=tY7SWKCGI4nvwv6XBmywg/wziBked8W6bZJgiVPY7BcbwdXPIXlunxLbAR6Rgeg2Hu /g5lwBZ5LuJMeDriIG5KDDxVzcMKl5y7q5kpb2+bmbP/w51fj3T4Tdzz+yLkBuqJ0Uv7 IEO48cTIa+j2GcztWsmGtoYShuGK4nKSrEMkTTlhfXfc5xvoJ4moW0DTP0tvuH0JZXzn gW5JXLmuqDL9iQJ7w61NnmU3UF3+a51+BzQA0bnXLDVtTOQ56S8n/rqYFIYD2SCiqXAY J1WdgSaiQMmtdeoL00WcyoLrd1by+99azT+BtUYS3RANdAmhhBQUgJWwipxiiH/EXFbY n1xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AMRBSKPedQ/vao53wTQts4yAXAMhd5iduqdqKtH2vi0=; b=OuK1UyKqSQl2yffy6LvzEP9SYXFG6u20iUb5VY7hig1GQ9KIv+dKJj8GY7+AGakusA yEES/235je5vWO3SB/4m22clkEGu1ZCfQGS/LOyRq7CeVxhZMAMY/7ydh69TfEXw+L7y ukzYuWeQQwCdn8zFlpDpwRoUeq1UX5mU1sASheosm24dp1PnmQ1BLeosEyBpHkhV9dDv i7dTwH0OWbZijA/Ot1kBFtkqbwTwdHYQYwWCrYeE6hIUCC4AoKjqewWmGSKzbNk1W68r 5SX9vIA1/xAfbCiQdtgcdD/uxfKlqnKZen2Ijrm5Lwtl3KId9rKPZsWrpjJZiofY/OEY /vJw== X-Gm-Message-State: APjAAAXYF4ePs6njp0mjvr/pWz3mjxajs1OOQPFDuH4nE7fvZoQrDkJH j6x6oalvUxvHMLTGWcSViyqS4uwhEZA= X-Google-Smtp-Source: APXvYqw4nsWImWPBjHXMzmzoyQbEjYkogFsZ8Z5CltAI6PYZmzgwB+NEgg5vTx555ohOmb8+VWUeXA== X-Received: by 2002:a17:902:e793:: with SMTP id cp19mr50673035plb.65.1556449485991; Sun, 28 Apr 2019 04:04:45 -0700 (PDT) From: Boxuan Li To: qemu-devel@nongnu.org Date: Sun, 28 Apr 2019 19:02:58 +0800 Message-Id: <20190428110258.86681-1-liboxuan@connect.hku.hk> X-Mailer: git-send-email 2.13.2 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::644 Subject: [Qemu-devel] [PATCH] virtio-mmio: Always compile debug prints X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Boxuan Li Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Wrap printf calls inside debug macros (DPRINTF) in `if` statement, and change output to stderr as well. This will ensure that printf function will always compile and prevent bitrot of the format strings. Signed-off-by: Boxuan Li --- hw/virtio/virtio-mmio.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index 5807aa87fe..693b3c9eb4 100644 --- a/hw/virtio/virtio-mmio.c +++ b/hw/virtio/virtio-mmio.c @@ -28,15 +28,14 @@ #include "hw/virtio/virtio-bus.h" #include "qemu/error-report.h" =20 -/* #define DEBUG_VIRTIO_MMIO */ - -#ifdef DEBUG_VIRTIO_MMIO - -#define DPRINTF(fmt, ...) \ -do { printf("virtio_mmio: " fmt , ## __VA_ARGS__); } while (0) -#else -#define DPRINTF(fmt, ...) do {} while (0) -#endif +#define DEBUG_VIRTIO_MMIO 0 + +#define DPRINTF(fmt, ...) \ + do { \ + if (DEBUG_VIRTIO_MMIO) { \ + fprintf(stderr, "virtio_mmio: " fmt , ## __VA_ARGS__); \ + } \ + } while (0) =20 /* QOM macros */ /* virtio-mmio-bus */ --=20 2.13.2