From nobody Mon Feb 9 04:45:22 2026 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1556380028; cv=none; d=zoho.com; s=zohoarc; b=jS8ohgq3LDNzfuisQ7cm1dgR9I3/jqwexkNyUqezXg7inQCNg6jl8SKnGck4x/EpHfXgaK6XgKjOq+oHaeMlSUsSAzd5YWBO75FOqiatnrNQ2SHwHtnpdRodpyRhdM4bRsb9ydcH58uWUshethmeKIGbhgp1+H4rm/sEjag3Z7g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556380028; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=7YHv/V04KLrRGmgFE0WruUJKM3Li2z6x1SOsjH9eqC8=; b=GFXf2Rkkrft7SrzPKaFeyf9YF25UZZVvaiX6dzWPeeb3cGr+Fw+3E/g+At69Vl+DQK6CovM9wqxFywH5Qj0fk2MXR1YdsaSmvV+5hfGmoHmWnjOyK7j94LWYMAh66wYOHfYn+4BZrpghR/uSQIpVf+zF6IRyZBiWF2PCah1yF7A= ARC-Authentication-Results: i=1; mx.zoho.com; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556380028354750.1079721616966; Sat, 27 Apr 2019 08:47:08 -0700 (PDT) Received: from localhost ([127.0.0.1]:33437 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKPXO-0003wc-03 for importer@patchew.org; Sat, 27 Apr 2019 11:46:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKPWN-0003ZZ-6U for qemu-devel@nongnu.org; Sat, 27 Apr 2019 11:45:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKPWL-0002QL-VQ for qemu-devel@nongnu.org; Sat, 27 Apr 2019 11:45:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44838) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hKPWL-0002PN-QV; Sat, 27 Apr 2019 11:45:45 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4B31C368E3; Sat, 27 Apr 2019 15:45:44 +0000 (UTC) Received: from thuth.com (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id CE3B04BC; Sat, 27 Apr 2019 15:45:42 +0000 (UTC) From: Thomas Huth To: Richard Henderson , qemu-devel@nongnu.org, Paolo Bonzini Date: Sat, 27 Apr 2019 17:45:39 +0200 Message-Id: <20190427154539.11336-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Sat, 27 Apr 2019 15:45:44 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] configure: Add -Wno-typedef-redefinition to CFLAGS (for Clang) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Without the -Wno-typedef-redefinition option, clang complains if a typedef gets redefined in gnu99 mode (since this is officially a C11 feature). This used to also happen with older versions of GCC, but since we've bumped our minimum GCC version to 4.8, all versions of GCC that we support do not seem to issue this warning in gnu99 mode anymore. So this has become a common problem for people who only test their code with GCC - they do not notice the issue until they submit their patches and suddenly patchew or a maintainer complains. Now that we do not urgently need to keep the code clean from typedef redefintions anymore with recent versions of GCC, we can ease the situation with clang, too, and simply shut these warnings off for good. Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 2cc365be51..8e15dc9870 100755 --- a/configure +++ b/configure @@ -1917,7 +1917,7 @@ gcc_flags=3D"-Wformat-security -Wformat-y2k -Winit-se= lf -Wignored-qualifiers $gcc_ gcc_flags=3D"-Wno-missing-include-dirs -Wempty-body -Wnested-externs $gcc_= flags" gcc_flags=3D"-Wendif-labels -Wno-shift-negative-value $gcc_flags" gcc_flags=3D"-Wno-initializer-overrides -Wexpansion-to-defined $gcc_flags" -gcc_flags=3D"-Wno-string-plus-int $gcc_flags" +gcc_flags=3D"-Wno-string-plus-int -Wno-typedef-redefinition $gcc_flags" # Note that we do not add -Werror to gcc_flags here, because that would # enable it for all configure tests. If a configure test failed due # to -Werror this would just silently disable some features, --=20 2.21.0