From nobody Mon Feb 9 07:24:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1556374816; cv=none; d=zoho.com; s=zohoarc; b=Kfcio8J3nGTGk12MpgHOw8f01NpbPUUfuL8aYQagVDOszo1ZeDNrjHobEueGXeF0fGSm57KQZcoJBKp+MgonEVFG6pBz04IUjT6gLy87TjpZkj0Ut2AxKD4x6udAbUvbZesusdavjDaBZ0xtSNcLaAllW/YzuJHRnFqA91tGhsQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556374816; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=3f/l4YBKpr5jmqfTt6hq+nbMh2EJ1Y2J/UQhtS6KHOA=; b=hR3ovdgxCwh3K5+PCUhY/1Gtkp0sl7EIq4dsgJXSaVmBQmPynPos8VIqXeda0ga39CodgswSH84kdoozmkmrRmnxXdqBbGw3IiqeeGLfikJaEh22aOn5WKymcGQJNB60KvhsaXaboHibHuGgJnG4TSqmEJAkANh4sBzXj6mEeNI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556374816211320.78219174835465; Sat, 27 Apr 2019 07:20:16 -0700 (PDT) Received: from localhost ([127.0.0.1]:60891 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKOBZ-0001Lb-C9 for importer@patchew.org; Sat, 27 Apr 2019 10:20:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKOAh-0000o3-Rb for qemu-devel@nongnu.org; Sat, 27 Apr 2019 10:19:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKOAg-0004vC-Si for qemu-devel@nongnu.org; Sat, 27 Apr 2019 10:19:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59828) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hKOAg-0004uS-NE for qemu-devel@nongnu.org; Sat, 27 Apr 2019 10:19:18 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 02335308AA12; Sat, 27 Apr 2019 14:19:18 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-83.brq.redhat.com [10.40.204.83]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 17B875D70A; Sat, 27 Apr 2019 14:19:06 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Date: Sat, 27 Apr 2019 16:19:04 +0200 Message-Id: <20190427141905.20393-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Sat, 27 Apr 2019 14:19:18 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] hw/i386: The i440fx is not a machine, remove it from the machine list X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Eduardo Habkost , "Michael S. Tsirkin" , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" When building with CONFIG_ISAPC=3Dn and CONFIG_I440FX=3Dy we get: $ make subdir-x86_64-softmmu [...] /usr/bin/ld: hw/i386/pc_piix.o: in function `pc_init1': /source/qemu/hw/i386/pc_piix.c:261: undefined reference to `isa_ide_init' /usr/bin/ld: /source/qemu/hw/i386/pc_piix.c:261: undefined reference to `= isa_ide_init' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:204: qemu-system-x86_64] Error 1 This is because the I440FX device is a North Bridge, not a machine. It is however used by the ISAPC machine. Correct the dependency in the ISAPC Kconfig. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- default-configs/i386-softmmu.mak | 1 - hw/i386/Kconfig | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmm= u.mak index ba3fb3ff50a..b33f5952128 100644 --- a/default-configs/i386-softmmu.mak +++ b/default-configs/i386-softmmu.mak @@ -23,5 +23,4 @@ # Boards: # CONFIG_ISAPC=3Dy -CONFIG_I440FX=3Dy CONFIG_Q35=3Dy diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index a6aed7c1313..9211adf2bb3 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -69,7 +69,7 @@ config ISAPC select VGA_ISA # FIXME: it is in the same file as i440fx, and does not compile # if separated - depends on I440FX + select I440FX =20 config Q35 bool --=20 2.20.1