From nobody Mon Feb 9 15:09:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1556270094; cv=none; d=zoho.com; s=zohoarc; b=H67PyzvO4mDuidSF/yOI7wQ4wCNT/pl+/OUX4IUaLtXD6LJ1z8PjXhMW/z5JtGgfo72Fd0JJ8lU92b1+DKNfA1kq8X93vpzTQtVtf6tsEvAp1sjKN8SGg1aTAEz+J60n835gFgykHW3oJHvhspvkg5XwuM/b56vfZMfcjMWST0M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556270094; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=+Qfp49mDhYrt6Co1Gs1EZHLEm+TRV4hplNx3z4WZxe8=; b=BLeVkzHKB2PbLchNr9WvKNTus8wby2ajtxemoMWFB+wlnhPLd4lyZ9xaTf1sZSf0fVvQKvt04niZSjxnbjjOIA1YI+r1T5DUyOydMp+8A7GOT8Uz+VB+fWW2X9WyAqi/Fjq1mfM22dFmrxXKcyXc3ZKRmr09mAyK0eS72WIlATc= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556270094201982.5993761051811; Fri, 26 Apr 2019 02:14:54 -0700 (PDT) Received: from localhost ([127.0.0.1]:43642 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJwwV-0007H0-9N for importer@patchew.org; Fri, 26 Apr 2019 05:14:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJwtM-0005E2-Sv for qemu-devel@nongnu.org; Fri, 26 Apr 2019 05:11:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJwtL-0003Pn-V0 for qemu-devel@nongnu.org; Fri, 26 Apr 2019 05:11:36 -0400 Received: from mga04.intel.com ([192.55.52.120]:13455) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJwtL-0003Ob-Me for qemu-devel@nongnu.org; Fri, 26 Apr 2019 05:11:35 -0400 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2019 02:11:35 -0700 Received: from unknown (HELO localhost.localdomain) ([10.239.13.19]) by fmsmga005.fm.intel.com with ESMTP; 26 Apr 2019 02:11:33 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,397,1549958400"; d="scan'208";a="340969586" From: Zhang Chen To: Laurent Vivier , "Dr. David Alan Gilbert" , Juan Quintela , zhanghailiang , Markus Armbruster , qemu-dev Date: Fri, 26 Apr 2019 17:07:30 +0800 Message-Id: <20190426090730.2691-4-chen.zhang@intel.com> X-Mailer: git-send-email 2.17.GIT In-Reply-To: <20190426090730.2691-1-chen.zhang@intel.com> References: <20190426090730.2691-1-chen.zhang@intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.120 Subject: [Qemu-devel] [PATCH 3/3] qemu-option.hx: Update missed parameter for colo-compare X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Zhang Chen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Zhang Chen We missed the iothread related args in this file. This patch is used to fix this issue. Signed-off-by: Zhang Chen Reviewed-by: Dr. David Alan Gilbert --- qemu-options.hx | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 08749a3391..a4500c99ef 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4420,13 +4420,15 @@ Dump the network traffic on netdev @var{dev} to the= file specified by The file format is libpcap, so it can be analyzed with tools such as tcpdu= mp or Wireshark. =20 -@item -object colo-compare,id=3D@var{id},primary_in=3D@var{chardevid},seco= ndary_in=3D@var{chardevid},outdev=3D@var{chardevid}[,vnet_hdr_support] +@item -object colo-compare,id=3D@var{id},primary_in=3D@var{chardevid},seco= ndary_in=3D@var{chardevid},outdev=3D@var{chardevid},iothread=3D@var{id}[,vn= et_hdr_support] =20 Colo-compare gets packet from primary_in@var{chardevid} and secondary_in@v= ar{chardevid}, than compare primary packet with secondary packet. If the packets are same, we will output primary packet to outdev@var{chardevid}, else we will notify colo-frame do checkpoint and send primary packet to outdev@var{chardevid}. -if it has the vnet_hdr_support flag, colo compare will send/recv packet wi= th vnet_hdr_len. +In order to improve efficiency, we need to put the task of comparison +in another thread. If it has the vnet_hdr_support flag, colo compare +will send/recv packet with vnet_hdr_len. =20 we must use it with the help of filter-mirror and filter-redirector. =20 @@ -4441,10 +4443,11 @@ primary: -chardev socket,id=3Dcompare0-0,host=3D3.3.3.3,port=3D9001 -chardev socket,id=3Dcompare_out,host=3D3.3.3.3,port=3D9005,server,nowait -chardev socket,id=3Dcompare_out0,host=3D3.3.3.3,port=3D9005 +-object iothread,id=3Diothread1 -object filter-mirror,id=3Dm0,netdev=3Dhn0,queue=3Dtx,outdev=3Dmirror0 -object filter-redirector,netdev=3Dhn0,id=3Dredire0,queue=3Drx,indev=3Dcom= pare_out -object filter-redirector,netdev=3Dhn0,id=3Dredire1,queue=3Drx,outdev=3Dco= mpare0 --object colo-compare,id=3Dcomp0,primary_in=3Dcompare0-0,secondary_in=3Dcom= pare1,outdev=3Dcompare_out0 +-object colo-compare,id=3Dcomp0,primary_in=3Dcompare0-0,secondary_in=3Dcom= pare1,outdev=3Dcompare_out0,iothread=3Diothread1 =20 secondary: -netdev tap,id=3Dhn0,vhost=3Doff,script=3D/etc/qemu-ifup,down script=3D/et= c/qemu-ifdown --=20 2.17.GIT