From nobody Sun Feb 8 18:43:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1556254382; cv=none; d=zoho.com; s=zohoarc; b=MaQXxZwc6dUWHDNIdgpwBnfs0qDdisUIhyB8+S3cB3OVsLJZ3EiZx8wI4DEDCh6wtUPGGuhbwAtdvbNaK0Njgr2ZU9SkyFRkq6ZPOtlVSwtLAbM3W0DlsogiORu3fIQ06sCaW1lRca6vwQWv0vUqO95jtpM9CVwnSjswgNXmd3Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556254382; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=8aM/3zkgxng0ie4nC212YmQwcdv5GpIX/biWiirdyy8=; b=L9yvh7GThC+Lc6lIC1AmPIrER9FoTtdjvt0vfqOZHPdX9boQoSRH+aRnckmMqrSK9RIskeX/qDQ9/45niNQF/HmBkuVLQx3aPnzKptTpfbqwSyuFT/0AEVgjab+hw8ln6OJ7P73SWce9+HvaBYjCWdQ1Tny0Wn8y6iS4og9/XGk= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556254382084483.76341030823346; Thu, 25 Apr 2019 21:53:02 -0700 (PDT) Received: from localhost ([127.0.0.1]:39171 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJsr7-0005Lk-3Z for importer@patchew.org; Fri, 26 Apr 2019 00:53:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJsmh-0000dE-D7 for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:48:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJsb0-0004Ob-U1 for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:36:24 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:33956) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJsay-0004Lu-Ut for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:36:21 -0400 Received: by mail-wr1-x441.google.com with SMTP id v16so47489wrp.1 for ; Thu, 25 Apr 2019 21:36:19 -0700 (PDT) Received: from localhost.localdomain (bzq-79-178-247-46.red.bezeqint.net. [79.178.247.46]) by smtp.gmail.com with ESMTPSA id h5sm3467088wmf.38.2019.04.25.21.36.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Apr 2019 21:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8aM/3zkgxng0ie4nC212YmQwcdv5GpIX/biWiirdyy8=; b=KGbEXiLPfQg4s5jB4sqLPP82dDGcNOvJV+RW0BP++zjdqT4OB1t3qIx6lWcP5Uis6g Dy9yKW8dICYrklUt41pPMTNCuU+zeMtLcCzUcz0e5rkUd4CgonUy/fW3t/zG2dQ3Cu3s zTJADuOocE7RC1983PVOCsnD7BuE3nMt2TCS8OgLkI+SKiSzD5nOIfEmQEYFgdQNF0Qj tLw5WVXA9tzD5ZAOvsqAWBIJ6DFTb7c1fplz3fVutbtSvfOxttBHxo6LBRXkEC7wSmj9 yG2vNRJ8RJPXk3GVpe2Fg4FY9g+ZQSJusvb3xFUYES3JaptCwZ3DsTL3H+v7zqPPZGE+ 018g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8aM/3zkgxng0ie4nC212YmQwcdv5GpIX/biWiirdyy8=; b=TRgA7pqm2gkUN6kigsgUeggSaoOv4YovdVBb7tR7R8pbA2phrlOd3orgv4K2xZucHH g5Nfjzxg74ntZm4TM35yr3DnxGTH80ZjVz54eM2yp6X+x7Gpjj1zoqBu5KmrzGWD+zSM DTCwFSC1pCEao/7ZWaDDZb7AdNiwqU9m9eoOcHDNi9v4nRQ4+r/fL8X8JoupEbMq5zsE wFPetZyZKBWzKZAQbL7XJKJTPdv9quz60c4/oExbfW4R+3JWRZh4yaChkLDTs0l5l6M3 KgUqEw63GE5FlWe6htq8fn2QJ8rwvd3ejkeWpvtd5vPrSfSwKerIChQ3cAJv7BNxEIjX tlOQ== X-Gm-Message-State: APjAAAU1oq2j6dTCenWTUnJVp0PYUj+Xdc9J7SkdEsguNjP4DkAgBbag y5lUA59O9HfReFqmXBKlUML1wED8 X-Google-Smtp-Source: APXvYqydeYydcqyuKzHlwa6rxkw4O1ZsYKyfstn6LejLsHAd24ZnMma8MUBOSF24nbMglKH0RdXquQ== X-Received: by 2002:a5d:6352:: with SMTP id b18mr13745445wrw.24.1556253377723; Thu, 25 Apr 2019 21:36:17 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Fri, 26 Apr 2019 07:35:43 +0300 Message-Id: <20190426043558.6888-7-arilou@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190426043558.6888-1-arilou@gmail.com> References: <20190426043558.6888-1-arilou@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH v7 06/21] gdbstub: Implement set_thread (H pkt) with new infra X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, Jon Doron Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Jon Doron --- gdbstub.c | 79 ++++++++++++++++++++++++++++++++++--------------------- 1 file changed, 49 insertions(+), 30 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 469aaeb875..21cdaf4678 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1547,6 +1547,47 @@ static void handle_cont_with_sig(GdbCmdContext *gdb_= ctx, void *user_ctx) gdb_continue(gdb_ctx->s); } =20 +static void handle_set_thread(GdbCmdContext *gdb_ctx, void *user_ctx) +{ + CPUState *cpu; + + if (gdb_ctx->num_params < 2) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + if (gdb_ctx->params[1].thread_id.kind =3D=3D GDB_READ_THREAD_ERR) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + if (gdb_ctx->params[1].thread_id.kind !=3D GDB_ONE_THREAD) { + put_packet(gdb_ctx->s, "OK"); + return; + } + + cpu =3D gdb_get_cpu(gdb_ctx->s, gdb_ctx->params[1].thread_id.pid, + gdb_ctx->params[1].thread_id.tid); + if (!cpu) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + switch (gdb_ctx->params[0].opcode) { + case 'c': + gdb_ctx->s->c_cpu =3D cpu; + put_packet(gdb_ctx->s, "OK"); + break; + case 'g': + gdb_ctx->s->g_cpu =3D cpu; + put_packet(gdb_ctx->s, "OK"); + break; + default: + put_packet(gdb_ctx->s, "E22"); + break; + } +} + static int gdb_handle_packet(GDBState *s, const char *line_buf) { CPUState *cpu; @@ -1560,7 +1601,6 @@ static int gdb_handle_packet(GDBState *s, const char = *line_buf) char thread_id[16]; uint8_t *registers; target_ulong addr, len; - GDBThreadIdKind thread_kind; const GdbCmdParseEntry *cmd_parser =3D NULL; =20 trace_gdbstub_io_command(line_buf); @@ -1823,35 +1863,14 @@ static int gdb_handle_packet(GDBState *s, const cha= r *line_buf) put_packet(s, "E22"); break; case 'H': - type =3D *p++; - - thread_kind =3D read_thread_id(p, &p, &pid, &tid); - if (thread_kind =3D=3D GDB_READ_THREAD_ERR) { - put_packet(s, "E22"); - break; - } - - if (thread_kind !=3D GDB_ONE_THREAD) { - put_packet(s, "OK"); - break; - } - cpu =3D gdb_get_cpu(s, pid, tid); - if (cpu =3D=3D NULL) { - put_packet(s, "E22"); - break; - } - switch (type) { - case 'c': - s->c_cpu =3D cpu; - put_packet(s, "OK"); - break; - case 'g': - s->g_cpu =3D cpu; - put_packet(s, "OK"); - break; - default: - put_packet(s, "E22"); - break; + { + static const GdbCmdParseEntry set_thread_cmd_desc =3D { + .handler =3D handle_set_thread, + .cmd =3D "H", + .cmd_startswith =3D 1, + .schema =3D "o.t0" + }; + cmd_parser =3D &set_thread_cmd_desc; } break; case 'T': --=20 2.20.1