From nobody Mon Feb 9 11:28:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1556254365; cv=none; d=zoho.com; s=zohoarc; b=Oc+GsWxIKuOcfGKqQsOOfnMjauFZIGd/SMfh/PA6sl1Jxq1XMy9MJWn03tCjkoU/0zRLohJJCWulnHiZtjqFrPffGH/eA/+Y7L3dx4WaPaeaYqmtQmXuPL89l295rvKoolJzvA0QY/EOINyekgX0JkLcaPMxYV127kMWVVNnceE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556254365; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=brvpFyYDw1Z1o2sLMNd/sMXNZo4TYemLFYCJt79OgBg=; b=iKaUCh6LKVEyQyb2cAPdtqWg2o46KvHdG7dggPbAC6VocxdSh036IQY6OupepCtWrIGaLpOmGLTGCiB0WSNcBx14jrNRdDEAGdO9P7ljXprPeo+hOMZQv5vI1S/1YSzmRQbly67bt6v5ASmHjIPTcRgPSRydM+vMzjEWFaLR1pc= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556254365458160.26120254050488; Thu, 25 Apr 2019 21:52:45 -0700 (PDT) Received: from localhost ([127.0.0.1]:39165 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJsqn-00053F-EF for importer@patchew.org; Fri, 26 Apr 2019 00:52:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJsmc-0000dE-Bq for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:48:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJsbG-0004hO-6t for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:36:39 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:39838) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJsbG-0004ff-0X for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:36:38 -0400 Received: by mail-wr1-x444.google.com with SMTP id a9so2450912wrp.6 for ; Thu, 25 Apr 2019 21:36:37 -0700 (PDT) Received: from localhost.localdomain (bzq-79-178-247-46.red.bezeqint.net. [79.178.247.46]) by smtp.gmail.com with ESMTPSA id h5sm3467088wmf.38.2019.04.25.21.36.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Apr 2019 21:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=brvpFyYDw1Z1o2sLMNd/sMXNZo4TYemLFYCJt79OgBg=; b=FXTZ8XPVS8D4pT7Cl+s3Qv6byaZMDwBpVhPZgTsGh72pNVfM+xxTBxYu9c/o0gGG6b rpoyn2liujoAXU5N+9jRcCz0YkHKWprYwYt0+VS7BvykmyEoRkU5bsYy28vxMuRrHBx5 7c6mRui8gUJRRwDnLBG7WqxKD0NY9w7C/0bPL55o9aMdBDXMZv2d+sKtEKnjPhp2pz57 ow3DC1hCMN7BCBM8aJQ5aQbmZV299OJ1JVJGp4yhLDCCDXv3c/AirwajsRZ2q1D4yEGj JX0Lgc9796msTOf7VyLADLRaajQdbGPa/L5KUbJjinCIBTWTIhpXjTdvsTqO4rgQ7/H3 C0nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=brvpFyYDw1Z1o2sLMNd/sMXNZo4TYemLFYCJt79OgBg=; b=kX+ODuAvCyCN5lL7kJnO08q/0nfQifyOvUVLTAKvQbeU3vWjPIeWiuuY1iOaH5PguL hueBLqDVvAiPuiddR7bmByxjMnFiZpdDah4rJ2f9Pqkz/oV4CmAb370S6yAOaedgYxLr IyMCiO0RI11uV29cEwpvengrIe9SQVplKNYj3GF90kYBsQvBQ/td6Semzid97w7/SrCR ElWu6nj8szY/Umx5I3kG6vbgiFo3y0CydlMKAiw7fv7OY5CH+v0we7/uLzWvMqgZKrgM zJNR8/3QkxVYdE+xd4+ZHtTUziUOlloj89OlvY2tE4UvDHF8FaGejmXq2TRPqK7lWlED /AMw== X-Gm-Message-State: APjAAAUak/1kGt3XcoUsfMm32W8O1ny58Gd3okQjkMqIyRdTCTe3Y7xW 4WtYXAedqkOQxKmmaf0rkC+xUOJi X-Google-Smtp-Source: APXvYqypD/bXasoSh60qqJm5uUQRcOsU0iDBc6IOBVQYCDPCSdNt/12J9JMDUfLi8MTU+t/FfbEHXA== X-Received: by 2002:adf:e591:: with SMTP id l17mr2252727wrm.238.1556253396328; Thu, 25 Apr 2019 21:36:36 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Fri, 26 Apr 2019 07:35:50 +0300 Message-Id: <20190426043558.6888-14-arilou@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190426043558.6888-1-arilou@gmail.com> References: <20190426043558.6888-1-arilou@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH v7 13/21] gdbstub: Implement write all registers (G pkt) with new infra X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, Jon Doron Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Jon Doron --- gdbstub.c | 41 +++++++++++++++++++++++++++++++---------- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index daa602edc3..adfe39b3a3 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1734,6 +1734,29 @@ static void handle_read_mem(GdbCmdContext *gdb_ctx, = void *user_ctx) put_packet(gdb_ctx->s, gdb_ctx->str_buf); } =20 +static void handle_write_all_regs(GdbCmdContext *gdb_ctx, void *user_ctx) +{ + target_ulong addr, len; + uint8_t *registers; + int reg_size; + + if (!gdb_ctx->num_params) { + return; + } + + cpu_synchronize_state(gdb_ctx->s->g_cpu); + registers =3D gdb_ctx->mem_buf; + len =3D strlen(gdb_ctx->params[0].data) / 2; + hextomem(registers, gdb_ctx->params[0].data, len); + for (addr =3D 0; addr < gdb_ctx->s->g_cpu->gdb_num_g_regs && len > 0; + addr++) { + reg_size =3D gdb_write_register(gdb_ctx->s->g_cpu, registers, addr= ); + len -=3D reg_size; + registers +=3D reg_size; + } + put_packet(gdb_ctx->s, "OK"); +} + static int gdb_handle_packet(GDBState *s, const char *line_buf) { CPUState *cpu; @@ -1745,7 +1768,6 @@ static int gdb_handle_packet(GDBState *s, const char = *line_buf) uint8_t mem_buf[MAX_PACKET_LENGTH]; char buf[sizeof(mem_buf) + 1 /* trailing NUL */]; char thread_id[16]; - uint8_t *registers; target_ulong addr, len; const GdbCmdParseEntry *cmd_parser =3D NULL; =20 @@ -1911,16 +1933,15 @@ static int gdb_handle_packet(GDBState *s, const cha= r *line_buf) put_packet(s, buf); break; case 'G': - cpu_synchronize_state(s->g_cpu); - registers =3D mem_buf; - len =3D strlen(p) / 2; - hextomem((uint8_t *)registers, p, len); - for (addr =3D 0; addr < s->g_cpu->gdb_num_g_regs && len > 0; addr+= +) { - reg_size =3D gdb_write_register(s->g_cpu, registers, addr); - len -=3D reg_size; - registers +=3D reg_size; + { + static const GdbCmdParseEntry write_all_regs_cmd_desc =3D { + .handler =3D handle_write_all_regs, + .cmd =3D "G", + .cmd_startswith =3D 1, + .schema =3D "s0" + }; + cmd_parser =3D &write_all_regs_cmd_desc; } - put_packet(s, "OK"); break; case 'm': { --=20 2.20.1