From nobody Mon Nov 10 11:20:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1556163041; cv=none; d=zoho.com; s=zohoarc; b=Z1flmBwLAC8y3qZKBoYh3tEoHwjkd/jhWol1zdgAnuiNU+UoMWwc6kOtmSCfm4wal+WcrecApsGOTqw0WvCiW/RcMoZ7JXpJvCIkGWsFUVIaCcQxeArT7QI3mfkPa1wv44tsfyGROsPTyj9zoJMKbjZ+PpxCF1TBP55KHKweS20= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556163041; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=k9bRr+vndwWxltuwMGj1uOQNv50SedE6wEWcnkBaCzM=; b=Xb5/khE/ttRohWw178hpGXrTDn6yxnET4i6rdrJtvm017tta0aHKfwEhrVbWSnr960IbEPojhfjG+zyx6ppsW7X+5uMRrG9GpLlrhM6+hejPaoL1J8dV3/+dp06BQYkAOL6lVVzqywXszHBHhMQM7zJLRmHEokwHNi+/6OlfRIo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556163041039356.9178476785863; Wed, 24 Apr 2019 20:30:41 -0700 (PDT) Received: from localhost ([127.0.0.1]:50578 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJV5s-0002hc-3e for importer@patchew.org; Wed, 24 Apr 2019 23:30:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJV4N-0001u8-U5 for qemu-devel@nongnu.org; Wed, 24 Apr 2019 23:29:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJV4K-0006c0-4h for qemu-devel@nongnu.org; Wed, 24 Apr 2019 23:29:06 -0400 Received: from mga06.intel.com ([134.134.136.31]:62410) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJV4J-0006ZL-Rd for qemu-devel@nongnu.org; Wed, 24 Apr 2019 23:29:04 -0400 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 20:29:00 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga003.jf.intel.com with ESMTP; 24 Apr 2019 20:28:59 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,392,1549958400"; d="scan'208";a="145518825" From: Wei Yang To: qemu-devel@nongnu.org Date: Thu, 25 Apr 2019 11:28:31 +0800 Message-Id: <20190425032831.22551-1-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.31 Subject: [Qemu-devel] [PATCH] bitmap: get last word mask from nr directly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: corentincj@iksaif.net, pl@kamp.de, Wei Yang , quintela@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The value left in nr is the number of bits for the last word, which could be calculate the last word mask directly. Remove the unnecessary size. Signed-off-by: Wei Yang --- util/bitmap.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/util/bitmap.c b/util/bitmap.c index cb618c65a5..5aa60b8717 100644 --- a/util/bitmap.c +++ b/util/bitmap.c @@ -160,7 +160,6 @@ int slow_bitmap_andnot(unsigned long *dst, const unsign= ed long *bitmap1, void bitmap_set(unsigned long *map, long start, long nr) { unsigned long *p =3D map + BIT_WORD(start); - const long size =3D start + nr; int bits_to_set =3D BITS_PER_LONG - (start % BITS_PER_LONG); unsigned long mask_to_set =3D BITMAP_FIRST_WORD_MASK(start); =20 @@ -174,7 +173,7 @@ void bitmap_set(unsigned long *map, long start, long nr) p++; } if (nr) { - mask_to_set &=3D BITMAP_LAST_WORD_MASK(size); + mask_to_set &=3D BITMAP_LAST_WORD_MASK(nr); *p |=3D mask_to_set; } } @@ -221,7 +220,6 @@ void bitmap_set_atomic(unsigned long *map, long start, = long nr) void bitmap_clear(unsigned long *map, long start, long nr) { unsigned long *p =3D map + BIT_WORD(start); - const long size =3D start + nr; int bits_to_clear =3D BITS_PER_LONG - (start % BITS_PER_LONG); unsigned long mask_to_clear =3D BITMAP_FIRST_WORD_MASK(start); =20 @@ -235,7 +233,7 @@ void bitmap_clear(unsigned long *map, long start, long = nr) p++; } if (nr) { - mask_to_clear &=3D BITMAP_LAST_WORD_MASK(size); + mask_to_clear &=3D BITMAP_LAST_WORD_MASK(nr); *p &=3D ~mask_to_clear; } } --=20 2.19.1