From nobody Tue May 7 04:40:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1556035668; cv=none; d=zoho.com; s=zohoarc; b=jXvwa4WmvV7HvgBjJtoEkughAD0i2zn17jNzYHlD9Ojm7TFxGHKl+I/b+J2tUHu39H9DsZNh8ZKP6RSDk3HUqgV97xWYtmgj0614sapFknMtSd6p4OrjqbgHZNbNggi+fTEYOwz4hB4AzTVJ7+wU1Qh9rcFutQUbQ5c56MhPPo4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556035668; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=4/1nbDyr84VQZbLxTmZah5YH1SSZvtRqy0t+D8YRLlo=; b=QWFqDSuFqhkx+INLZhuozArLKgz/WpE9Tx5Icc0Vsw5rCdvYXGE6aSXlRB3dJzdnCnQen1oe6GrYmniJwwFm1hILb/7gF3IaDamug/sUJeYKhXYQWt0hq5D+DHwZowSbJi1OAnCuQDc6no/mwEMFXMZUoEo4XD5RjgrstmalmPk= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1556035668742563.5293669849751; Tue, 23 Apr 2019 09:07:48 -0700 (PDT) Received: from localhost ([127.0.0.1]:56216 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIxxM-0000Wg-O4 for importer@patchew.org; Tue, 23 Apr 2019 12:07:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIxw0-00083M-BA for qemu-devel@nongnu.org; Tue, 23 Apr 2019 12:06:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIxvy-0007ac-Dw for qemu-devel@nongnu.org; Tue, 23 Apr 2019 12:06:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50122) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hIxvy-0007Zu-7Y; Tue, 23 Apr 2019 12:06:14 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5C0D88008A; Tue, 23 Apr 2019 16:06:13 +0000 (UTC) Received: from thuth.com (ovpn-116-87.ams2.redhat.com [10.36.116.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id 578845C296; Tue, 23 Apr 2019 16:06:12 +0000 (UTC) From: Thomas Huth To: Jason Wang , qemu-devel@nongnu.org Date: Tue, 23 Apr 2019 18:06:08 +0200 Message-Id: <20190423160608.7519-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 23 Apr 2019 16:06:13 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] net: Print output of "-net nic, model=help" to stdout instead of stderr X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" We are printing all other help output to stdout already (e.g. "-help", "-cpu help" and "-machine help" output). So the "-net nic,model=3Dhelp" output should go to stdout instead of stderr, too. And while we're at it, also print the NICs line by line, like we do it e.g. with the "-cpu help" or "-M help" output, too. Buglink: https://bugs.launchpad.net/qemu/+bug/1574327 Signed-off-by: Thomas Huth Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- net/net.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/net.c b/net/net.c index f3a3c5444c..2cf5e76469 100644 --- a/net/net.c +++ b/net/net.c @@ -837,9 +837,10 @@ int qemu_show_nic_models(const char *arg, const char *= const *models) return 0; } =20 - fprintf(stderr, "qemu: Supported NIC models: "); - for (i =3D 0 ; models[i]; i++) - fprintf(stderr, "%s%c", models[i], models[i+1] ? ',' : '\n'); + printf("Supported NIC models:\n"); + for (i =3D 0 ; models[i]; i++) { + printf("%s\n", models[i]); + } return 1; } =20 --=20 2.21.0